- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Ctrl+W in tabbed windows (GT inspector, browser/Calypso)

by Esteban A. Maringolo

2018-03-19 7:08 GMT-03:00 Ben Coman <btc(a)openinworld.com>: > On 19 March 2018 at 17:07, Petr Fischer <petr.fischer(a)me.com> wrote: >> Is everyone in comfort with the idea that Ctrl+W should close the actual >> tab, and if there is no tab in the window (or actual tab is the last tab), >> then close the window? > > > Actually I never knew that shortcut, but I will now. > I see it works that way in both Chrome and InternetExplorer and web browsers > are a good benchmark. It's the sibling of Ctrl+Tab and Ctrl+Shift+Tab to move forward or backward in a list of tabs. I use it a lot. Esteban A. Maringolo

March 19, 2018

Re: [Pharo-dev] pharo bootstrap is in inconsistent state

by Guillermo Polito

On Mon, Mar 19, 2018 at 2:13 PM, Alistair Grant <akgrant0710(a)gmail.com> wrote: > Hi Guille, > > On 19 March 2018 at 13:59, Guillermo Polito <guillermopolito(a)gmail.com> > wrote: > > Hi! > > > > On Mon, Mar 19, 2018 at 9:17 AM, Alistair Grant <akgrant0710(a)gmail.com> > > wrote: > > > > [SNIP] > >> > >> > >> > >> https://pharo.fogbugz.com/f/cases/21615/Separate- > bootstrap-process-in-to-distinct-stages > >> > >> https://github.com/pharo-project/pharo/pull/1127 > >> > >> This does the first step of breaking the bootstrap process in to > >> distinct phases and moving all the downloads to the start (e.g. > >> allowing a test VM to be substituted for the build stage). > > > > > > Nice! thanks! > > > >> > >> > >> Once this is integrated I can submit a PR that modifies Jenkinsfile to > >> use the new shell scripts, removing code duplication. > > > > > > Question: Why not in this same PR? > > Because I'm not at all familiar with Jenkins, so am a bit nervous > about changing it. Smaller changes will be easier to work on if > something goes wrong. :-) > > Ah, but if you do something wrong the build will fail. In any case, as soon as you want to dive into changing the JenkinsFile, send me a private mail. I probably have to give you permissions in Jenkins (otherwise jenkins ignores changes in the JenkinsFile for security reasons). > Cheers, > Alistair > > > > >> On 16 March 2018 at 14:38, tesonep(a)gmail.com <tesonep(a)gmail.com> wrote: > >> > Hi, > >> > sorry my mistake when updating the scripts. As the bootstrap.sh > is > >> > not > >> > executed during the Jenkins process it has not been validated (locally > >> > I'm > >> > not using that script, because is trying to download each time the VM > >> > and > >> > the bootstraping process image) > >> > >> There are also scripts to snapshot and restore the bootstrap state, > >> avoiding the need to do the multiple downloads. > >> > >> Just to be clear again: This is intended to complement and help with > >> the goal of moving the bootstrap process to pure Pharo code. Each of > >> the shell scripts can eventually be replaced by a call to the > >> equivalent Pharo code. > >> > > > > :) > > > >> > >> > >> Thanks! > >> Alistair > >> > > > > > > > > -- > > > > > > > > Guille Polito > > > > Research Engineer > > > > Centre de Recherche en Informatique, Signal et Automatique de Lille > > > > CRIStAL - UMR 9189 > > > > French National Center for Scientific Research - http://www.cnrs.fr > > > > > > Web: http://guillep.github.io > > > > Phone: +33 06 52 70 66 13 > > -- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

March 19, 2018

Re: [Pharo-dev] Ctrl+W in tabbed windows (GT inspector, browser/Calypso)

by Petr Fischer

> Ok. I see. > > It is not scenario which I used. > Now I fixed it in dev version Wow that's fast! Next time I will use github issues for it (probably the preferred way). Thanks. > 2018-03-19 13:32 GMT+01:00 Petr Fischer <petr.fischer(a)me.com>: > > > It's completely weird: > > > > 1) first Ctrl+W closes the "content" of the tab > > 2) second Ctrl+W closes whole tabbed window > > > > Look at thos video: https://youtu.be/MUcYNGnDAR8 > > > > pf > > > > > Hi. > > > > > > Are you sure that Calypso closes full window instead of single tab? > > > Because I use it all the time and it works for me in the way you > > described. > > > > > > 2018-03-19 10:07 GMT+01:00 Petr Fischer <petr.fischer(a)me.com>: > > > > > > > Hello! > > > > > > > > I assume that Ctrl+W is a widely used keyboard shortcut for closing > > > > windows or a tab, if the window is "tabbed" (it works in web browsers, > > some > > > > desktops, Linux, IE, Mac OS X...). > > > > > > > > But when I start up some exploration session in GT inspector, I have > > > > several tabs opened in a second - then, after Ctrl+W, not the actual > > tab, > > > > but the whole window is immediately closed, gosh... > > > > Same situation in "window groups" (when you created tabbed window group > > > > from browser/Calypso) - Ctrl+W behaves weird. > > > > > > > > Is everyone in comfort with the idea that Ctrl+W should close the > > actual > > > > tab, and if there is no tab in the window (or actual tab is the last > > tab), > > > > then close the window? > > > > > > > > Tested in Pharo 5, 6 and 6.1. > > > > > > > > pf > > > > > > > > > > > >

March 19, 2018

Re: [Pharo-dev] pharo bootstrap is in inconsistent state

by Alistair Grant

Hi Guille, On 19 March 2018 at 13:59, Guillermo Polito <guillermopolito(a)gmail.com> wrote: > Hi! > > On Mon, Mar 19, 2018 at 9:17 AM, Alistair Grant <akgrant0710(a)gmail.com> > wrote: > > [SNIP] >> >> >> >> https://pharo.fogbugz.com/f/cases/21615/Separate-bootstrap-process-in-to-di… >> >> https://github.com/pharo-project/pharo/pull/1127 >> >> This does the first step of breaking the bootstrap process in to >> distinct phases and moving all the downloads to the start (e.g. >> allowing a test VM to be substituted for the build stage). > > > Nice! thanks! > >> >> >> Once this is integrated I can submit a PR that modifies Jenkinsfile to >> use the new shell scripts, removing code duplication. > > > Question: Why not in this same PR? Because I'm not at all familiar with Jenkins, so am a bit nervous about changing it. Smaller changes will be easier to work on if something goes wrong. :-) Cheers, Alistair >> On 16 March 2018 at 14:38, tesonep(a)gmail.com <tesonep(a)gmail.com> wrote: >> > Hi, >> > sorry my mistake when updating the scripts. As the bootstrap.sh is >> > not >> > executed during the Jenkins process it has not been validated (locally >> > I'm >> > not using that script, because is trying to download each time the VM >> > and >> > the bootstraping process image) >> >> There are also scripts to snapshot and restore the bootstrap state, >> avoiding the need to do the multiple downloads. >> >> Just to be clear again: This is intended to complement and help with >> the goal of moving the bootstrap process to pure Pharo code. Each of >> the shell scripts can eventually be replaced by a call to the >> equivalent Pharo code. >> > > :) > >> >> >> Thanks! >> Alistair >> > > > > -- > > > > Guille Polito > > Research Engineer > > Centre de Recherche en Informatique, Signal et Automatique de Lille > > CRIStAL - UMR 9189 > > French National Center for Scientific Research - http://www.cnrs.fr > > > Web: http://guillep.github.io > > Phone: +33 06 52 70 66 13

March 19, 2018

Re: [Pharo-dev] pharo bootstrap is in inconsistent state

by Guillermo Polito

Hi! On Mon, Mar 19, 2018 at 9:17 AM, Alistair Grant <akgrant0710(a)gmail.com> wrote: [SNIP] > > https://pharo.fogbugz.com/f/cases/21615/Separate-bootstrap-process-in-to- > distinct-stages > > https://github.com/pharo-project/pharo/pull/1127 > > This does the first step of breaking the bootstrap process in to > distinct phases and moving all the downloads to the start (e.g. > allowing a test VM to be substituted for the build stage). Nice! thanks! > > Once this is integrated I can submit a PR that modifies Jenkinsfile to > use the new shell scripts, removing code duplication. > Question: Why not in this same PR? > > > On 16 March 2018 at 14:38, tesonep(a)gmail.com <tesonep(a)gmail.com> wrote: > > Hi, > > sorry my mistake when updating the scripts. As the bootstrap.sh is > not > > executed during the Jenkins process it has not been validated (locally > I'm > > not using that script, because is trying to download each time the VM and > > the bootstraping process image) > > There are also scripts to snapshot and restore the bootstrap state, > avoiding the need to do the multiple downloads. > > Just to be clear again: This is intended to complement and help with > the goal of moving the bootstrap process to pure Pharo code. Each of > the shell scripts can eventually be replaced by a call to the > equivalent Pharo code. > > :) > > Thanks! > Alistair > > -- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

March 19, 2018

Re: [Pharo-dev] Ctrl+W in tabbed windows (GT inspector, browser/Calypso)

by Denis Kudriashov

Ok. I see. It is not scenario which I used. Now I fixed it in dev version 2018-03-19 13:32 GMT+01:00 Petr Fischer <petr.fischer(a)me.com>: > It's completely weird: > > 1) first Ctrl+W closes the "content" of the tab > 2) second Ctrl+W closes whole tabbed window > > Look at thos video: https://youtu.be/MUcYNGnDAR8 > > pf > > > Hi. > > > > Are you sure that Calypso closes full window instead of single tab? > > Because I use it all the time and it works for me in the way you > described. > > > > 2018-03-19 10:07 GMT+01:00 Petr Fischer <petr.fischer(a)me.com>: > > > > > Hello! > > > > > > I assume that Ctrl+W is a widely used keyboard shortcut for closing > > > windows or a tab, if the window is "tabbed" (it works in web browsers, > some > > > desktops, Linux, IE, Mac OS X...). > > > > > > But when I start up some exploration session in GT inspector, I have > > > several tabs opened in a second - then, after Ctrl+W, not the actual > tab, > > > but the whole window is immediately closed, gosh... > > > Same situation in "window groups" (when you created tabbed window group > > > from browser/Calypso) - Ctrl+W behaves weird. > > > > > > Is everyone in comfort with the idea that Ctrl+W should close the > actual > > > tab, and if there is no tab in the window (or actual tab is the last > tab), > > > then close the window? > > > > > > Tested in Pharo 5, 6 and 6.1. > > > > > > pf > > > > > > > >

March 19, 2018

Re: [Pharo-dev] Ctrl+W in tabbed windows (GT inspector, browser/Calypso)

by Petr Fischer

> On 19 March 2018 at 17:07, Petr Fischer <petr.fischer(a)me.com> wrote: > > > Hello! > > > > I assume that Ctrl+W is a widely used keyboard shortcut for closing > > windows or a tab, if the window is "tabbed" (it works in web browsers, some > > desktops, Linux, IE, Mac OS X...). > > > > But when I start up some exploration session in GT inspector, I have > > several tabs opened in a second - then, after Ctrl+W, not the actual tab, > > but the whole window is immediately closed, gosh... > > Same situation in "window groups" (when you created tabbed window group > > from browser/Calypso) - Ctrl+W behaves weird. > > > > Is everyone in comfort with the idea that Ctrl+W should close the actual > > tab, and if there is no tab in the window (or actual tab is the last tab), > > then close the window? > > > > Actually I never knew that shortcut, but I will now. > I see it works that way in both Chrome and InternetExplorer and web > browsers are a good benchmark. > But its not "critical" so I think it will be tough convincing someone to > work on it for 5.0, 6.0, 6.1. > For 7 it sounds like a good idea. Should I enter the issue to the Fogbuz (for Pharo 7)? pf > > cheers -ben > > > > > > Tested in Pharo 5, 6 and 6.1. > > > > pf > > > >

March 19, 2018

Re: [Pharo-dev] Ctrl+W in tabbed windows (GT inspector, browser/Calypso)

by Petr Fischer

It's completely weird: 1) first Ctrl+W closes the "content" of the tab 2) second Ctrl+W closes whole tabbed window Look at thos video: https://youtu.be/MUcYNGnDAR8 pf > Hi. > > Are you sure that Calypso closes full window instead of single tab? > Because I use it all the time and it works for me in the way you described. > > 2018-03-19 10:07 GMT+01:00 Petr Fischer <petr.fischer(a)me.com>: > > > Hello! > > > > I assume that Ctrl+W is a widely used keyboard shortcut for closing > > windows or a tab, if the window is "tabbed" (it works in web browsers, some > > desktops, Linux, IE, Mac OS X...). > > > > But when I start up some exploration session in GT inspector, I have > > several tabs opened in a second - then, after Ctrl+W, not the actual tab, > > but the whole window is immediately closed, gosh... > > Same situation in "window groups" (when you created tabbed window group > > from browser/Calypso) - Ctrl+W behaves weird. > > > > Is everyone in comfort with the idea that Ctrl+W should close the actual > > tab, and if there is no tab in the window (or actual tab is the last tab), > > then close the window? > > > > Tested in Pharo 5, 6 and 6.1. > > > > pf > > > >

March 19, 2018

Re: [Pharo-dev] Ctrl+W in tabbed windows (GT inspector, browser/Calypso)

by Ben Coman

On 19 March 2018 at 17:07, Petr Fischer <petr.fischer(a)me.com> wrote: > Hello! > > I assume that Ctrl+W is a widely used keyboard shortcut for closing > windows or a tab, if the window is "tabbed" (it works in web browsers, some > desktops, Linux, IE, Mac OS X...). > > But when I start up some exploration session in GT inspector, I have > several tabs opened in a second - then, after Ctrl+W, not the actual tab, > but the whole window is immediately closed, gosh... > Same situation in "window groups" (when you created tabbed window group > from browser/Calypso) - Ctrl+W behaves weird. > > Is everyone in comfort with the idea that Ctrl+W should close the actual > tab, and if there is no tab in the window (or actual tab is the last tab), > then close the window? > Actually I never knew that shortcut, but I will now. I see it works that way in both Chrome and InternetExplorer and web browsers are a good benchmark. But its not "critical" so I think it will be tough convincing someone to work on it for 5.0, 6.0, 6.1. For 7 it sounds like a good idea. cheers -ben > > Tested in Pharo 5, 6 and 6.1. > > pf > >

March 19, 2018

Re: [Pharo-dev] Idea to manager package comment in better way

by Denis Kudriashov

I created issue 21617 <https://pharo.fogbugz.com/f/cases/21617/Better-implementation-of-package-co…> 2018-03-16 16:54 GMT+01:00 Stephane Ducasse <stepharo.self(a)gmail.com>: > Hi denis > > Both solutions are ok for me. > > STef > > On Fri, Mar 16, 2018 at 2:38 PM, Denis Kudriashov <dionisiydk(a)gmail.com> > wrote: > > And at the end I found that #packageComment: is not really work because > it > > expects already formatted string suitable for source code insertion. > > So you can't just call: > > > > aPackage packageComment: 'my comment'. > > > > Instead all users (only Nautilus exists) should write > > > > aPackage packageComment: 'my comment' printString > > > > I will create pull request with all this changes > > > > 2018-03-14 16:51 GMT+01:00 Denis Kudriashov <dionisiydk(a)gmail.com>: > >> > >> And I found that manifest classes are already commented as package > >> comment. > >> > >> 2018-03-14 16:40 GMT+01:00 Denis Kudriashov <dionisiydk(a)gmail.com>: > >>> > >>> Hi. > >>> > >>> I look at hierarchy of PackageManifest and I was wondering that all > these > >>> classes are commented but most of packages which they describe are not. > >>> > >>> Also interesting that most of manifest comments are same. > >>> > >>> Then I found that package comment is managed as special class side > method > >>> #description which is generated when you call "aPackage packageComment: > >>> 'test'". > >>> > >>> Now the idea: will not it be better to manage package comment as > manifest > >>> class comment? > >>> > >>> Manifest is already responsible to describe the package. So it looks > >>> logical to have "manifest comment = package comment". > >>> Also it will simplify code and remove duplication of texts. > >>> In addition it will add extra place indicating that package needs to be > >>> commented because uncommented classes are marked in the browser. > >>> > >>> What you think? > >>> > >> > > > >

March 19, 2018