- Pharo-dev - lists.pharo.org

Re: [Pharo-project] Stubbing class-side methods

by Sean P. DeNigris

Igor Stasenko wrote: > > you doing something really complex. > on your place i would just implement #dateAndTimeClass > I'm playing :) And, working on ideas for our testing frameworks. Partially stubbing class-side methods is something I miss from rspec in Ruby (although in this case adding one #dateAndTimeClass method is not a huge deal) Sean -- View this message in context: http://forum.world.st/Stubbing-class-side-methods-tp3674065p3676800.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

July 18, 2011

Re: [Pharo-project] Stubbing class-side methods

by Igor Stasenko

On 19 July 2011 01:02, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > Ah, so the lookups are done once when the method is compiled and then stored > in the CompiledMethod... > > My vision is to write something like: > Â Â Â Â cannedNow := DateAndTime stub: #now; andReturn: [ DateAndTime year: 2011 > month: 12 day: 24 hour: 12 minute: 34 second: 55 ]. > Â Â Â Â testableClass := MyClass usingDouble: cannedNow. > > The first line seems easy, and for the second line, I have so far (very > rough, but working): > > Â Â Â Â | class copy | > Â Â Â Â class := MyClass. > Â Â Â Â copy := MyClass copy. > > Â Â Â Â copy methods do: [ :m | | classRef | > Â Â Â Â Â Â Â Â (m hasLiteralSuchThat: [ :l | ((l isKindOf: Association) and: [ l key = > #DateAndTime])]) > Â Â Â Â Â Â Â Â Â Â Â Â ifTrue: [ | newMeth refIndex | > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â newMeth := copy methodDictionary at: m selector put: m copy. > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â refIndex := newMeth indexOfLiteralSuchThat: [ :l | ((l isKindOf: > Association) and: [ l key = #DateAndTime])]. > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â newMeth literalAt: refIndex put: #DateAndTime->MockedClass ] ]. > Â Â Â Â ^ copy. > > Where CompiledMethod>>indexOfLiteralSuchThat: aBlock > Â Â Â Â "Answer the literal index of the argument, literal, or zero if none." > Â Â Â Â 2 to: self numLiterals - 1 "exclude superclass + selector/properties" > Â Â Â Â Â do: > Â Â Â Â Â Â Â Â [:index | > Â Â Â Â Â Â Â Â (aBlock value: (self objectAt: index)) ifTrue: [^index - 1]]. > Â Â Â Â ^0 > you doing something really complex. on your place i would just implement #dateAndTimeClass so, you can just write self dateAndTimeClass new and depending on implementor it would answer one or another class. > Thanks again. > Sean > > > -- > View this message in context: http://forum.world.st/Stubbing-class-side-methods-tp3674065p3676637.html > Sent from the Pharo Smalltalk mailing list archive at Nabble.com. > > -- Best regards, Igor Stasenko AKA sig.

July 18, 2011

Re: [Pharo-project] Stubbing class-side methods

by Sean P. DeNigris

Ah, so the lookups are done once when the method is compiled and then stored in the CompiledMethod... My vision is to write something like: cannedNow := DateAndTime stub: #now; andReturn: [ DateAndTime year: 2011 month: 12 day: 24 hour: 12 minute: 34 second: 55 ]. testableClass := MyClass usingDouble: cannedNow. The first line seems easy, and for the second line, I have so far (very rough, but working): | class copy | class := MyClass. copy := MyClass copy. copy methods do: [ :m | | classRef | (m hasLiteralSuchThat: [ :l | ((l isKindOf: Association) and: [ l key = #DateAndTime])]) ifTrue: [ | newMeth refIndex | newMeth := copy methodDictionary at: m selector put: m copy. refIndex := newMeth indexOfLiteralSuchThat: [ :l | ((l isKindOf: Association) and: [ l key = #DateAndTime])]. newMeth literalAt: refIndex put: #DateAndTime->MockedClass ] ]. ^ copy. Where CompiledMethod>>indexOfLiteralSuchThat: aBlock "Answer the literal index of the argument, literal, or zero if none." 2 to: self numLiterals - 1 "exclude superclass + selector/properties" do: [:index | (aBlock value: (self objectAt: index)) ifTrue: [^index - 1]]. ^0 Thanks again. Sean -- View this message in context: http://forum.world.st/Stubbing-class-side-methods-tp3674065p3676637.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

July 18, 2011

[Pharo-project] Why does CompiledMethod>>hasLiteral: use ==

by Sean P. DeNigris

I tried: aMethod hasLiteral: #DateAndTime->DateAndTime and got false, even though an "=" literal is indeed there. Why doesn't #hasLiteral: use #=? Thanks. Sean -- View this message in context: http://forum.world.st/Why-does-CompiledMethod-hasLiteral-use-tp3676573p3676… Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

July 18, 2011

Re: [Pharo-project] fun bug: fileouting method with a $!, produces $!!

by StÃ©phane Ducasse

But I cannot recompile the method I fileout. Can you? May be this is because I did not use the filelist and I copied and pasted from the file veronica sent me. > this is not because people were not using a decent syntax to fileout and that after they hacked the system that this is not a bug. > Yes, it is by no way meant to be human written and does not decently meet the requirements for scripting. > For exchanging code, the chunk format is a bit poor too, but it is manageable with a good change list tool (not the squeak one). > And remember, it was (and is still) used for logging system changes in the change log. > And it is very efficient for that. > With chunk format, you don't need quoting the code (except exclamation mark itself of course), and that's an important feature > IMO, this format served its purpose very decently. > Well, you can tell me the Squeak hacks to identify authors and timestamp are awfully implemented, I can only agree, but the basis are very simple. TSTTCPW. I think that it would deserve a new pass. Because "very simple" is not true when you look at the complexity = invoking the scanner to get some information and then poking around to know if this is a comment or a class definition. > But you can. > You can browse the code, can't you ? go and see in .sources or .changes, you'll see a doubled ! > You can fileOut, then fileIn, no problem. I spent some days a couple of year ago in the filein fileout because I wanted to load all the code of squeak starting from sq10 -> 3.9 and I can tell you that the allButLast first .... kind of expressions to skip over ' or ! to me indicate a problem because saving a element of program should not be like that and this is why the format of the fileout is not good. Of course it works but it does not mean that this is good. Stef

July 18, 2011

Re: [Pharo-project] [update 1.3] #13287

by StÃ©phane Ducasse

I'm happy. I think that we found a good solution. On Jul 18, 2011, at 9:44 PM, Tudor Girba wrote: > Thanks a lot! > > Glamour works on Seaside out of the box again :) > > Cheers, > Doru > > > On 18 Jul 2011, at 20:44, Lukas Renggli wrote: > >> Great, thank you for the quick fix. >> >> On Monday, 18 July 2011, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: >>> >>> 13287 >>> ----- >>> >>> - Issue 4528: Exception on:fork: enhancement. Thanks Igor Stasenko and Lukas Renggli for the idea. >>> >>> - Issue 4529: Announcement delivery breaks if last subscriber is curtailed. Thanks Henrik Johanssen. >>> >> >> -- >> Lukas Renggli >> www.lukas-renggli.ch >> > > -- > www.tudorgirba.com > > "Some battles are better lost than fought." > > > >

July 18, 2011

Re: [Pharo-project] Stubbing class-side methods

by Eliot Miranda

On Mon, Jul 18, 2011 at 12:11 PM, Sean P. DeNigris <sean(a)clipperadams.com>wrote: > Where is the code where class names actually get looked up? > In the compiler. What gets added to the method is the association for the variable. The push/store/pop literal variable bytecodes then indirect through the association to get and set its value inst var. > I put halts in Class>>bindingOf:, Class>>environment, and the > SmalltalkImage>>at: methods, but nothing hit. Also, how would I have found > this info for myself without asking on the list, since stepping into a > debugger doesn't help? > > Thanks. > Sean > > -- > View this message in context: > http://forum.world.st/Stubbing-class-side-methods-tp3674065p3676163.html > Sent from the Pharo Smalltalk mailing list archive at Nabble.com. > > -- best, Eliot

July 18, 2011

Re: [Pharo-project] [update 1.3] #13287

by Tudor Girba

Thanks a lot! Glamour works on Seaside out of the box again :) Cheers, Doru On 18 Jul 2011, at 20:44, Lukas Renggli wrote: > Great, thank you for the quick fix. > > On Monday, 18 July 2011, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: >> >> 13287 >> ----- >> >> - Issue 4528: Exception on:fork: enhancement. Thanks Igor Stasenko and Lukas Renggli for the idea. >> >> - Issue 4529: Announcement delivery breaks if last subscriber is curtailed. Thanks Henrik Johanssen. >> > > -- > Lukas Renggli > www.lukas-renggli.ch > -- www.tudorgirba.com "Some battles are better lost than fought."

July 18, 2011

Re: [Pharo-project] Stubbing class-side methods

by Sean P. DeNigris

Where is the code where class names actually get looked up? I put halts in Class>>bindingOf:, Class>>environment, and the SmalltalkImage>>at: methods, but nothing hit. Also, how would I have found this info for myself without asking on the list, since stepping into a debugger doesn't help? Thanks. Sean -- View this message in context: http://forum.world.st/Stubbing-class-side-methods-tp3674065p3676163.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

July 18, 2011

Re: [Pharo-project] fun bug: fileouting method with a $!, produces $!!

by Nicolas Cellier

2011/7/18 StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> > > > > Why do you say so ? > > I can fileOut, then fileIn without a problem. > > To me, this is not a bug. This is a feature. > > Source ! are doubled so as not to be confused with chunk separators, it's > an escaping sequence like doubles quotes in String > > > > 'here''s another example which is not a bug' > > this is not because people were not using a decent syntax to fileout and > that after they hacked the system that this is not a bug. > Yes, it is by no way meant to be human written and does not decently meet the requirements for scripting. For exchanging code, the chunk format is a bit poor too, but it is manageable with a good change list tool (not the squeak one). And remember, it was (and is still) used for logging system changes in the change log. And it is very efficient for that. With chunk format, you don't need quoting the code (except exclamation mark itself of course), and that's an important feature IMO, this format served its purpose very decently. Well, you can tell me the Squeak hacks to identify authors and timestamp are awfully implemented, I can only agree, but the basis are very simple. TSTTCPW. If you save a method and once it is saved you cannot load it back then what > is the point to save it. > > But you can. You can browse the code, can't you ? go and see in .sources or .changes, you'll see a doubled ! You can fileOut, then fileIn, no problem. > Seriously this is not the same than with double quote. > > I don't agree > Else it means that you cannot/should not use $! in Smalltalk method. And I > read most of the spec and books on smalltalk > and nobody ever mentioned that. Here this is just that this is doing the > wrong behavior. > > Right, they don't mention a problem because there is no problem. There is no problem because the ! is handled by doubling so as to not confuse it with an end of chunk mark. Nicolas > Imagine that we save the code using the coral syntax then what we would not > use [] anymore in method? > > Stef > > > > > Nicolas > > > > 2011/7/18 StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> > > Yes I know. > > To me, saving a method should make sure that we can reload it and this is > not the case. > > So to me this is a bug. > > > > try to fileout > > > > getPreambleFrom: aFileStream at: position > > | writeStream | > > writeStream := String new writeStream. > > position to: 0 by: -1 do: [ :p | > > | c | > > aFileStream position: p. > > c := aFileStream basicNext. > > c == $! > > ifTrue: [^ writeStream contents reversed] > > ifFalse: [writeStream nextPut: c]] > > > > > > :) > > > > I do not see why the system should not save it correctly even if !! is > used as a chunk separator. > > > > Stef > > > > > > On Jul 18, 2011, at 4:55 PM, Lukas Renggli wrote: > > > > > !! Is the escaping of a single ! (like '' is the escaping of ' in a > > > string), because the ! Is used to separate junks. > > > > > > Lukas > > > > > > On Monday, 18 July 2011, stephane ducasse <stephane.ducasse(a)free.fr> > wrote: > > >> Hi > > >> > > >> with veronica we found a fun bug. > > >> If you have a method with a $! and you file it out. you get $!! in the > fileouted file. > > >> > > >> http://code.google.com/p/pharo/issues/detail?id=4531 > > >> > > >> Stef > > >> > > > > > > -- > > > Lukas Renggli > > > www.lukas-renggli.ch > > > > > > > > > > > >

July 18, 2011