- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] File path encoding

by Ben Coman

>> On 16 Apr 2018, at 13:05, Ben Coman <btc(a)openinworld.com> wrote: >> >> On 16 April 2018 at 18:52, Ben Coman <btc(a)openinworld.com> wrote: >>> On 16 April 2018 at 17:51, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >>>> Hi, >>>> >>>> Some people raise issues with file path encoding with non-ASCII characters. >>>> >>>> The following works fine for me (macOS, Pharo 7, using new File class): >>>> >>>> "works" >>>> >>>> (FileLocator temp / 'foo' , 'txt') writeStreamDo: [ :out | out << 'Les Ã©lÃ¨ves FranÃ§ais' ; crlf ]. >>>> >>>> (FileLocator temp / 'foo' , 'txt') readStreamDo: [ :in | in upToEnd ]. >>>> >>>> "works" >>>> >>>> (FileLocator temp / 'benoÃ®t' , 'txt') writeStreamDo: [ :out | out << 'Les Ã©lÃ¨ves FranÃ§ais' ; crlf ]. >>>> >>>> (FileLocator temp / 'benoÃ®t' , 'txt') readStreamDo: [ :in | in upToEnd ]. >>>> >>>> "works" >>>> >>>> (FileLocator temp / 'benoÃ®t') ensureCreateDirectory. >>>> >>>> (FileLocator temp / 'benoÃ®t' / 'benoÃ®t' , 'txt') writeStreamDo: [ :out | out << 'Les Ã©lÃ¨ves FranÃ§ais' ; crlf ]. >>>> >>>> (FileLocator temp / 'benoÃ®t' / 'benoÃ®t' , 'txt') readStreamDo: [ :in | in upToEnd ]. >>>> >>>> >>>> Can Linux/Windows users confirm that it works on their platform ? >>> >>> Thanks for attacking this. All three work on Windows 10 English locale. >>> I'd hope it wasn't different with French locale, but wait for a report on that. >>> >>> cheers -ben >> >> I unzipped a fresh download of http://files.pharo.org/platform/Pharo6.1-win.zip >> * into C:\Temp\Pharo6.1 >> and immediately copied that directory >> * into C:\Temp\Pharo6.1.benoÃ®t >> >> Double-clicking on Pharo.exe >> * in the former, opens Pharo an expected. >> * in the latter, does nothing. On 16 April 2018 at 19:57, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > Ben, > > On my machine, macOS 10.13.4, > > $ pwd > /tmp/benoÃ®t > > $ curl get.pharo.org/70+vm | bash > % Total % Received % Xferd Average Speed Time Time Time Current > Dload Upload Total Spent Left Speed > 100 3036 100 3036 0 0 38694 0 --:--:-- --:--:-- --:--:-- 38923 > Downloading the latest 70 Image: > http://files.pharo.org/get-files/70/pharo.zip > Pharo.image > Downloading the latest pharoVM: > http://files.pharo.org/get-files/70/pharo-mac-stable.zip > pharo-vm/Pharo.app/Contents/MacOS/Pharo > Creating starter scripts pharo and pharo-ui > > $ ./pharo Pharo.image printVersion > [version] 'Pharo7.0' 'Pharo-7.0+alpha.build.769.sha.244850d3ffc1b49ab716c8093f4bcd9af3917be6 (32 Bit)' > > $ ./pharo Pharo.image eval 'FileLocator image resolve' > File @ /private/tmp/benoÃ®t/Pharo.image > > And the UI version works too. > > So we're back at 'it is a Windows problem' (but maybe it is only visible on Windows). > > Can you see what is going on ? > > Technically, at the File (FilePlugin) level we seem to be able to handle paths with strange characters, even on Windows, but somehow, somewhere a bogus call is made during image startup. I tried logging the startup like this... WorkingSession >> runStartup: isImageStarting 'C:\Temp\StartupLog.txt' asFileReference writeStreamDo: [ :log | log nextPutAll: log className; flush. self runList: manager startupList do: [ :each | log nextPutAll: each printString; nextPutAll: String crlf; flush. each startup: isImageStarting ]. self executeDeferredStartupActions: isImageStarting ] which worked in the former and with the latter(benoÃ®t) nothing. But poking around I bumped into an interesting symptom. The following does nothing.... C:\Temp\Pharo6.1.benoÃ®t> pharo but the following successfully opens the Image... C:\Temp\Pharo6.1.benoÃ®t> pharo Pharo6.1.image Not sure where to go from there. Maybe needs a Windows Debug-VM, but I'm out of time for now. cheers -ben

April 16, 2018

Re: [Pharo-dev] File path encoding

by Sven Van Caekenberghe

> On 16 Apr 2018, at 14:51, Alistair Grant <akgrant0710(a)gmail.com> wrote: > > Hi Sven, > > On 16 April 2018 at 13:57, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >> >> Technically, at the File (FilePlugin) level we seem to be able to handle paths with strange characters, even on Windows, but somehow, somewhere a bogus call is made during image startup. > > I'm not going to have time to look at this in the next few days, sorry. > > But I have a vague memory that some of the other primitives outside > FilePlugin don't add the "\\?\" prefix, so they possibly also don't do > wide character conversion. Then I hope some other Windows user/developer can have a look. Hell, I believe we got a few French people working on Pharo, n'est pas ? > Cheers, > Alistair >

April 16, 2018

Re: [Pharo-dev] File path encoding

by Alistair Grant

Hi Sven, On 16 April 2018 at 13:57, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > Technically, at the File (FilePlugin) level we seem to be able to handle paths with strange characters, even on Windows, but somehow, somewhere a bogus call is made during image startup. I'm not going to have time to look at this in the next few days, sorry. But I have a vague memory that some of the other primitives outside FilePlugin don't add the "\\?\" prefix, so they possibly also don't do wide character conversion. Cheers, Alistair

April 16, 2018

Re: [Pharo-dev] Critiques - Temporaries read before written.

by John Brant

On 04/15/2018 05:02 PM, Ben Coman wrote: > On 16 April 2018 at 03:07, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: >> >> >> >> 2018-04-15 20:40 GMT+02:00 Martin McClure <martin(a)hand2mouse.com>: >>> >>> On 04/15/2018 07:42 AM, Ben Coman wrote: >>> >>> The greater prominence of Critiques in Calypso >>> encourages me to try to clean them out. >>> >>> I bumped into a false positive "Temporaries read before written." >>> that I've condensed to the following example. >>> >>> test >>> |x| >>> [ x := nil ] whileNil: [ x ifNil: [ x := 1] ] >>> >>> Now before I log an Issue, is it feasible to be able to recognise this? >>> Perhaps only for common looping idioms? >>> >>> >>> In this example, the first runtime reference to x is to send it #ifNil:. So technically, x *is* being read before being written, at least if you count sending it a message as "reading" (which seems a reasonable interpretation to me). >> >> >> Maybe critique can be a bit smarter and check that sent message is known by nil. > > That sounds like a nice approach. Browsing the messages of Undefined, > maybe its worthwhile to restrict this to messages containing the the > string "nil", because this shows explicit intent and would cover the > most common//useful cases. > https://pharo.manuscript.com/f/cases/21704/Critiques-Temporaries-read-befor… You may break extract method if you change this. I haven't tried, but I think something like this would break -- extract the last line of this method: method | x | x := self someValue. x isNil ifTrue: [Transcript show: 'nil'] You should get something like this: method | x | x := self someValue. self extractedMethod: x extractedMethod: x x isNil ifTrue: [Transcript show: 'nil'] However, if you change what is considered read before written, then you would get something like this: method | x | x := self someValue. self extractedMethod extractedMethod | x | x isNil ifTrue: [Transcript show: 'nil'] John Brant

April 16, 2018

[Pharo 7.0-dev] Build #770: 21710-evaluate-should-use-compile-

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #770 was: SUCCESS. The Pull Request #1201 was integrated: "21710-evaluate-should-use-compile-" Pull request url: https://github.com/pharo-project/pharo/pull/1201 Issue Url: https://pharo.fogbugz.com/f/cases/21710 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

April 16, 2018

Re: [Pharo-dev] File path encoding

by Sven Van Caekenberghe

Ben, On my machine, macOS 10.13.4, $ pwd /tmp/benoÃ®t $ curl get.pharo.org/70+vm | bash % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 3036 100 3036 0 0 38694 0 --:--:-- --:--:-- --:--:-- 38923 Downloading the latest 70 Image: http://files.pharo.org/get-files/70/pharo.zip Pharo.image Downloading the latest pharoVM: http://files.pharo.org/get-files/70/pharo-mac-stable.zip pharo-vm/Pharo.app/Contents/MacOS/Pharo Creating starter scripts pharo and pharo-ui $ ./pharo Pharo.image printVersion [version] 'Pharo7.0' 'Pharo-7.0+alpha.build.769.sha.244850d3ffc1b49ab716c8093f4bcd9af3917be6 (32 Bit)' $ ./pharo Pharo.image eval 'FileLocator image resolve' File @ /private/tmp/benoÃ®t/Pharo.image And the UI version works too. So we're back at 'it is a Windows problem' (but maybe it is only visible on Windows). Can you see what is going on ? Technically, at the File (FilePlugin) level we seem to be able to handle paths with strange characters, even on Windows, but somehow, somewhere a bogus call is made during image startup. > On 16 Apr 2018, at 13:05, Ben Coman <btc(a)openinworld.com> wrote: > > On 16 April 2018 at 18:52, Ben Coman <btc(a)openinworld.com> wrote: >> On 16 April 2018 at 17:51, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >>> Hi, >>> >>> Some people raise issues with file path encoding with non-ASCII characters. >>> >>> The following works fine for me (macOS, Pharo 7, using new File class): >>> >>> "works" >>> >>> (FileLocator temp / 'foo' , 'txt') writeStreamDo: [ :out | out << 'Les Ã©lÃ¨ves FranÃ§ais' ; crlf ]. >>> >>> (FileLocator temp / 'foo' , 'txt') readStreamDo: [ :in | in upToEnd ]. >>> >>> "works" >>> >>> (FileLocator temp / 'benoÃ®t' , 'txt') writeStreamDo: [ :out | out << 'Les Ã©lÃ¨ves FranÃ§ais' ; crlf ]. >>> >>> (FileLocator temp / 'benoÃ®t' , 'txt') readStreamDo: [ :in | in upToEnd ]. >>> >>> "works" >>> >>> (FileLocator temp / 'benoÃ®t') ensureCreateDirectory. >>> >>> (FileLocator temp / 'benoÃ®t' / 'benoÃ®t' , 'txt') writeStreamDo: [ :out | out << 'Les Ã©lÃ¨ves FranÃ§ais' ; crlf ]. >>> >>> (FileLocator temp / 'benoÃ®t' / 'benoÃ®t' , 'txt') readStreamDo: [ :in | in upToEnd ]. >>> >>> >>> Can Linux/Windows users confirm that it works on their platform ? >> >> Thanks for attacking this. All three work on Windows 10 English locale. >> I'd hope it wasn't different with French locale, but wait for a report on that. >> >> cheers -ben > > I unzipped a fresh download of http://files.pharo.org/platform/Pharo6.1-win.zip > * into C:\Temp\Pharo6.1 > and immediately copied that directory > * into C:\Temp\Pharo6.1.benoÃ®t > > Double-clicking on Pharo.exe > * in the former, opens Pharo an expected. > * in the latter, does nothing. > > cheers -ben >

April 16, 2018

[Pharo 7.0-dev] Build #769: 21709-add-compiler-option-embedded-source

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #769 was: SUCCESS. The Pull Request #1200 was integrated: "21709-add-compiler-option-embedded-source" Pull request url: https://github.com/pharo-project/pharo/pull/1200 Issue Url: https://pharo.fogbugz.com/f/cases/21709 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

April 16, 2018

[Pharo 7.0-dev] Build #768: 21698-ClassDefinitionShouldHideSlots

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #768 was: SUCCESS. The Pull Request #1196 was integrated: "21698-ClassDefinitionShouldHideSlots" Pull request url: https://github.com/pharo-project/pharo/pull/1196 Issue Url: https://pharo.fogbugz.com/f/cases/21698 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

April 16, 2018

Re: [Pharo-dev] File path encoding

by Ben Coman

On 16 April 2018 at 18:52, Ben Coman <btc(a)openinworld.com> wrote: > On 16 April 2018 at 17:51, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >> Hi, >> >> Some people raise issues with file path encoding with non-ASCII characters. >> >> The following works fine for me (macOS, Pharo 7, using new File class): >> >> "works" >> >> (FileLocator temp / 'foo' , 'txt') writeStreamDo: [ :out | out << 'Les Ã©lÃ¨ves FranÃ§ais' ; crlf ]. >> >> (FileLocator temp / 'foo' , 'txt') readStreamDo: [ :in | in upToEnd ]. >> >> "works" >> >> (FileLocator temp / 'benoÃ®t' , 'txt') writeStreamDo: [ :out | out << 'Les Ã©lÃ¨ves FranÃ§ais' ; crlf ]. >> >> (FileLocator temp / 'benoÃ®t' , 'txt') readStreamDo: [ :in | in upToEnd ]. >> >> "works" >> >> (FileLocator temp / 'benoÃ®t') ensureCreateDirectory. >> >> (FileLocator temp / 'benoÃ®t' / 'benoÃ®t' , 'txt') writeStreamDo: [ :out | out << 'Les Ã©lÃ¨ves FranÃ§ais' ; crlf ]. >> >> (FileLocator temp / 'benoÃ®t' / 'benoÃ®t' , 'txt') readStreamDo: [ :in | in upToEnd ]. >> >> >> Can Linux/Windows users confirm that it works on their platform ? > > Thanks for attacking this. All three work on Windows 10 English locale. > I'd hope it wasn't different with French locale, but wait for a report on that. > > cheers -ben I unzipped a fresh download of http://files.pharo.org/platform/Pharo6.1-win.zip * into C:\Temp\Pharo6.1 and immediately copied that directory * into C:\Temp\Pharo6.1.benoÃ®t Double-clicking on Pharo.exe * in the former, opens Pharo an expected. * in the latter, does nothing. cheers -ben

April 16, 2018

Re: [Pharo-dev] File path encoding

by Ben Coman

On 16 April 2018 at 17:51, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > Hi, > > Some people raise issues with file path encoding with non-ASCII characters. > > The following works fine for me (macOS, Pharo 7, using new File class): > > "works" > > (FileLocator temp / 'foo' , 'txt') writeStreamDo: [ :out | out << 'Les Ã©lÃ¨ves FranÃ§ais' ; crlf ]. > > (FileLocator temp / 'foo' , 'txt') readStreamDo: [ :in | in upToEnd ]. > > "works" > > (FileLocator temp / 'benoÃ®t' , 'txt') writeStreamDo: [ :out | out << 'Les Ã©lÃ¨ves FranÃ§ais' ; crlf ]. > > (FileLocator temp / 'benoÃ®t' , 'txt') readStreamDo: [ :in | in upToEnd ]. > > "works" > > (FileLocator temp / 'benoÃ®t') ensureCreateDirectory. > > (FileLocator temp / 'benoÃ®t' / 'benoÃ®t' , 'txt') writeStreamDo: [ :out | out << 'Les Ã©lÃ¨ves FranÃ§ais' ; crlf ]. > > (FileLocator temp / 'benoÃ®t' / 'benoÃ®t' , 'txt') readStreamDo: [ :in | in upToEnd ]. > > > Can Linux/Windows users confirm that it works on their platform ? Thanks for attacking this. All three work on Windows 10 English locale. I'd hope it wasn't different with French locale, but wait for a report on that. cheers -ben

April 16, 2018