- Pharo-dev - lists.pharo.org

Re: About ReToDoRule

by Marcus Denker

Nobody seems to have an immediate reason that it is good to keep, I propose to just remove that rule: https://github.com/pharo-project/pharo/pull/11164 <https://github.com/pharo-project/pharo/pull/11164> (PR in need of a review!) > On 9 May 2022, at 15:12, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > I have never seen ReToDoRule to suggest a change that I wanted to do. > > I think it tries to detect if there is #at: send to the collection inside the block and suggests to use more high-level iterators. > > But the suggestions are odd and it seems to be too naive with just detecting the #at: message send to the iterated value. > > "Checks for use of to:do: when a do:, with:do: or timesRepeat: when should be used.â > > â¢ #timesRepeat: does not take an argument for the block with the running index, so it is not a replacement > â¢ with:do: is not a replacement for to:do: ? it would mean creating first a collection and then iterating > â¢ using do: on an interval is bad, we even have a rule against that: ReUnoptimizedToDoRule > > > Maybe I am missing something? > > > The rule ReToDoCollectRule seems to be working nicely, though. > > Issue tracker entry: https://github.com/pharo-project/pharo/issues/11162 > > >

May 10, 2022

Dictionary newFrom: and duplicated keys

by Marcus Denker

Hi, Dictionary class>>#newFrom: right now raises an error if it sees duplicated keys. newFrom: aDictionaryOrCollectionOfAssociations "Answer an instance of me containing the same associations as the argument. Error if any key appears twice." | newDictionary | newDictionary := self new: aDictionaryOrCollectionOfAssociations size. aDictionaryOrCollectionOfAssociations associationsDo: [:x | (newDictionary includesKey: x key) ifTrue: [self error: 'Duplicate key: ', x key printString] ifFalse: [newDictionary add: x]]. ^ newDictionary this leads to an error for: {#a->1. #a->2} asDictionary While just creating it with new and putting the data of course has no problem with duplicated keys: Dictionary new at: #a put: 1; at: #a put: 2; yourself We have a suggestion to remove the error. PR is here: https://github.com/pharo-project/pharo/pull/11176 <https://github.com/pharo-project/pharo/pull/11176> (as a side-effect, this speed up asDictionary a little, too) Marcus

May 10, 2022

About ReToDoRule

by Marcus Denker

I have never seen ReToDoRule to suggest a change that I wanted to do. I think it tries to detect if there is #at: send to the collection inside the block and suggests to use more high-level iterators. But the suggestions are odd and it seems to be too naive with just detecting the #at: message send to the iterated value. "Checks for use of to:do: when a do:, with:do: or timesRepeat: when should be used.â â¢ #timesRepeat: does not take an argument for the block with the running index, so it is not a replacement â¢ with:do: is not a replacement for to:do: ? it would mean creating first a collection and then iterating â¢ using do: on an interval is bad, we even have a rule against that: ReUnoptimizedToDoRule Maybe I am missing something? The rule ReToDoCollectRule seems to be working nicely, though. Issue tracker entry: https://github.com/pharo-project/pharo/issues/11162

May 9, 2022

Re: This week (18/2022) on the Pharo Issue Tracker

by Guillermo Polito

Thanks Marcus! > El 6 may 2022, a las 8:15, Marcus Denker <marcus.denker(a)inria.fr> escribiÃ³: > > We merged 8 PRs and fixed 9 Issue tracker entries. > > There are more PRs ready to be reviewed! https://github.com/pharo-project/pharo/pulls > > Even a reviews for trivial changes (like improvements in comments, removal of dead codeâ¦) > are very helpful. > > > Memory/Image Size > ================= > > Size is down to 56.5 MB for the bootstrapped full image after this. > > - 11172-ClassclassPool-empty-dictionary-for-all-classes-but-not-many-define-class-vars #11175 > https://github.com/pharo-project/pharo/pull/11175 > > > Features > ======== > - Reflectivity-AddPragmaSupport #10436 > https://github.com/pharo-project/pharo/pull/10436 > > - Added shortcut method to show the formatting key bindings. #11181 > https://github.com/pharo-project/pharo/pull/11181 > > - Added Array2D inspector extension #365 > https://github.com/pharo-spec/NewTools/pull/365 > > Bugs > === > - Fixes issue #11143: MiniDrTests raise error #11180 > https://github.com/pharo-project/pharo/pull/11180 > > > Cleanup > ======= > > - Rename BlockClosure startpc to compiledBlock #11188 > https://github.com/pharo-project/pharo/pull/11188 > > - Start to remove code from Deprecated10 package. #11192 > https://github.com/pharo-project/pharo/pull/11192 > > - [ci skip] [cleanup] improve comment of directories and files methods #11174 > https://github.com/pharo-project/pharo/pull/11174

May 6, 2022

This week (18/2022) on the Pharo Issue Tracker

by Marcus Denker

We merged 8 PRs and fixed 9 Issue tracker entries. There are more PRs ready to be reviewed! https://github.com/pharo-project/pharo/pulls Even a reviews for trivial changes (like improvements in comments, removal of dead codeâ¦) are very helpful. Memory/Image Size ================= Size is down to 56.5 MB for the bootstrapped full image after this. - 11172-ClassclassPool-empty-dictionary-for-all-classes-but-not-many-define-class-vars #11175 https://github.com/pharo-project/pharo/pull/11175 Features ======== - Reflectivity-AddPragmaSupport #10436 https://github.com/pharo-project/pharo/pull/10436 - Added shortcut method to show the formatting key bindings. #11181 https://github.com/pharo-project/pharo/pull/11181 - Added Array2D inspector extension #365 https://github.com/pharo-spec/NewTools/pull/365 Bugs === - Fixes issue #11143: MiniDrTests raise error #11180 https://github.com/pharo-project/pharo/pull/11180 Cleanup ======= - Rename BlockClosure startpc to compiledBlock #11188 https://github.com/pharo-project/pharo/pull/11188 - Start to remove code from Deprecated10 package. #11192 https://github.com/pharo-project/pharo/pull/11192 - [ci skip] [cleanup] improve comment of directories and files methods #11174 https://github.com/pharo-project/pharo/pull/11174

May 6, 2022

Re: [ANN] Pharo Launcher 3.0.1 released!

by Shaping

From: Shaping <shaping(a)uurda.org> Sent: Wednesday, 4 May, 2022 02:46 To: 'Pharo Development List' <pharo-dev(a)lists.pharo.org> Cc: 'Pharo-users' <pharo-users(a)lists.pharo.org> Subject: [Pharo-dev] Re: [ANN] Pharo Launcher 3.0.1 released! On May 3, 2022, at 6:03 PM, Shaping < <mailto:shaping@uurda.org> shaping(a)uurda.org> wrote: > > This is strange. I tested PharoLauncher 3.0.1 on Windows 10 and had no problems. > Did you try to uninstall the previous launcher first? > > Yes, I did the uninstall. And I just did the uninstall and reinstall again. > > Do you have more information that could help finding the problem? > > No, just an ordinary event log: > > Windows Installer installed the product. Product Name: PharoLauncher. Product Version: 3.0.1. Product Language: 1033. Manufacturer: Pharo project. Installation success or error status: 0. > > > Is everyone else able to open PL 3.0.1 on Windows? I installed it on two machines. On one it worked, and on the other it didnât. On the one where it didnât work, the SDL2.dll file didnât get installed. After adding the file, it opened. Iâm guessing that the virus scanner may be getting in the way. Interesting. I don't have any special antivirus app running, just the default Windows Defender. â¦ I do have SDL2.dll in â¦\AppData\Local\PharoLauncher. Still the GUI doesnât open Hi Christophe. Do we understand why the PL 3.0.1 GUI doesnât open sometimes even when SDL2.dll is present? I have in my PharoLauncher folder 74 items. One of those is the images folder. Is that as it should be? Shaping

May 5, 2022

Re: [ANN] Pharo Launcher 3.0.1 released!

by Shaping

From: Shaping <shaping(a)uurda.org> Sent: Wednesday, 4 May, 2022 02:46 To: 'Pharo Development List' <pharo-dev(a)lists.pharo.org> Cc: 'Pharo-users' <pharo-users(a)lists.pharo.org> Subject: [Pharo-dev] Re: [ANN] Pharo Launcher 3.0.1 released! On May 3, 2022, at 6:03 PM, Shaping < <mailto:shaping@uurda.org> shaping(a)uurda.org> wrote: > > This is strange. I tested PharoLauncher 3.0.1 on Windows 10 and had no problems. > Did you try to uninstall the previous launcher first? > > Yes, I did the uninstall. And I just did the uninstall and reinstall again. > > Do you have more information that could help finding the problem? > > No, just an ordinary event log: > > Windows Installer installed the product. Product Name: PharoLauncher. Product Version: 3.0.1. Product Language: 1033. Manufacturer: Pharo project. Installation success or error status: 0. > > > Is everyone else able to open PL 3.0.1 on Windows? I installed it on two machines. On one it worked, and on the other it didnât. On the one where it didnât work, the SDL2.dll file didnât get installed. After adding the file, it opened. Iâm guessing that the virus scanner may be getting in the way. Interesting. I don't have any special antivirus app running, just the default Windows Defender. â¦ I do have SDL2.dll in â¦\AppData\Local\PharoLauncher. Still the GUI doesnât open Shaping

May 4, 2022

Re: [ANN] Pharo Launcher 3.0.1 released!

by Shaping

On May 3, 2022, at 6:03 PM, Shaping < <mailto:shaping@uurda.org> shaping(a)uurda.org> wrote: > > This is strange. I tested PharoLauncher 3.0.1 on Windows 10 and had no problems. > Did you try to uninstall the previous launcher first? > > Yes, I did the uninstall. And I just did the uninstall and reinstall again. > > Do you have more information that could help finding the problem? > > No, just an ordinary event log: > > Windows Installer installed the product. Product Name: PharoLauncher. Product Version: 3.0.1. Product Language: 1033. Manufacturer: Pharo project. Installation success or error status: 0. > > > Is everyone else able to open PL 3.0.1 on Windows? I installed it on two machines. On one it worked, and on the other it didnât. On the one where it didnât work, the SDL2.dll file didnât get installed. After adding the file, it opened. Iâm guessing that the virus scanner may be getting in the way. Interesting. I don't have any special antivirus app running, just the default Windows Defender. Shaping

May 4, 2022

Re: [ANN] Pharo Launcher 3.0.1 released!

by John Brant

On May 3, 2022, at 6:03 PM, Shaping <shaping(a)uurda.org> wrote: > > This is strange. I tested PharoLauncher 3.0.1 on Windows 10 and had no problems. > Did you try to uninstall the previous launcher first? > > Yes, I did the uninstall. And I just did the uninstall and reinstall again. > > Do you have more information that could help finding the problem? > > No, just an ordinary event log: > > Windows Installer installed the product. Product Name: PharoLauncher. Product Version: 3.0.1. Product Language: 1033. Manufacturer: Pharo project. Installation success or error status: 0. > > > Is everyone else able to open PL 3.0.1 on Windows? I installed it on two machines. On one it worked, and on the other it didnât. On the one where it didnât work, the SDL2.dll file didnât get installed. After adding the file, it opened. Iâm guessing that the virus scanner may be getting in the way. John Brant

May 3, 2022

Re: [ANN] Pharo Launcher 3.0.1 released!

by Shaping

This is strange. I tested PharoLauncher 3.0.1 on Windows 10 and had no problems. Did you try to uninstall the previous launcher first? Yes, I did the uninstall. And I just did the uninstall and reinstall again. Do you have more information that could help finding the problem? No, just an ordinary event log: Windows Installer installed the product. Product Name: PharoLauncher. Product Version: 3.0.1. Product Language: 1033. Manufacturer: Pharo project. Installation success or error status: 0. Is everyone else able to open PL 3.0.1 on Windows? Shaping Le 3 mai 2022 Ã 10:06, Shaping <shaping(a)uurda.org <mailto:shaping@uurda.org> > a Ã©crit : Hi Christophe. Is PL still broken? The PL download page still shows version 3.0.1, which does not open for me on Windows. Did you test the latest build successfully on Windows? Shaping --- PL 3.0.1 is still failing to open on Windows. The VM instance appears in TaskMan. Shaping From: Christophe Demarey <christophe.demarey(a)inria.fr <mailto:christophe.demarey@inria.fr> > Sent: Friday, 29 April, 2022 03:50 To: Pharo Development List <pharo-dev(a)lists.pharo.org <mailto:pharo-dev@lists.pharo.org> >; Pharo-users <pharo-users(a)lists.pharo.org <mailto:pharo-users@lists.pharo.org> > Subject: [Pharo-dev] [ANN] Pharo Launcher 3.0.1 released! Hi all, Pharo Launcher 3.0.1 has just been released! It is available from http://pharo.org/download. It fixes some issues reported on Pharo Launcher 3.0. Here is the changelog: Pharo Launcher v3.0.1 Bug fixes: * #554 <https://github.com/pharo-project/pharo-launcher/issues/554> UI does not show up on Windows * #551 <https://github.com/pharo-project/pharo-launcher/issues/551> Show folder button is broken in Windows 10 * #550 <https://github.com/pharo-project/pharo-launcher/issues/550> About Box shows "untitled Window" * #549 <https://github.com/pharo-project/pharo-launcher/issues/549> Better display of download error messages. * #358 <https://github.com/pharo-project/pharo-launcher/issues/358> Restore proxy authentication settings. Regards, The Pharo team.

May 3, 2022