- Pharo-dev - lists.pharo.org

[Review Needed] Resolves #11184: printStringLimitedTo:Using: will fail to actually respect limit

by Marcus Denker

Review Needed: Resolves #11184: printStringLimitedTo:Using: will fail to actually respect limit https://github.com/pharo-project/pharo/pull/11185 "Changes Object >> printStringLimitedTo:Using so that it actually properly respects the limit, and that it doesn't add '...etc...' when exactly at the limit and thus not needed."

May 13, 2022

This week (19/2022) on the Pharo Issue Tracker

by Marcus Denker

We merged 14 Pull Requests and fixed 17 Issues. There are always more issues ready to be reviewed https://github.com/pharo-project/pharo/pulls Feature ======= - 6720-Dictionary--newFrom-logic-can-be-improved- #11176 https://github.com/pharo-project/pharo/pull/11176 - Fixes #11165 begins with and ends with should return true on empty string #11173 https://github.com/pharo-project/pharo/pull/11173 Clean Blocks ============ - Fix-messagetally-tests-Cleanblocks #11209 https://github.com/pharo-project/pharo/pull/11209 Bugs ==== - 6323-RubSmalltalkEditor-meta-j-shortcut-not-working #11205 https://github.com/pharo-project/pharo/pull/11205 - FIX issue #10933: Scaled decimals comparison result depends on the number creation method #10951 https://github.com/pharo-project/pharo/pull/10951 - Implement EpInverseVisitor>>#visitTraitModification: #11208 https://github.com/pharo-project/pharo/pull/11208 - 11198-Pharo11-Reflectivity-do-not-add-temp-for-value-if-not-generating-the-primtive-Wrapper #11199 https://github.com/pharo-project/pharo/pull/11199 Cleanup ======= - 11216-categorize-ZnStaticFileDecoratorDelegate-classdecorateservingFilesFrom #11224 https://github.com/pharo-project/pharo/pull/11224 - 11162-Check-ReToDoRule #11164 https://github.com/pharo-project/pharo/pull/11164 - Fix for the issue #11115: Feature Envy clipRect on AthensCairoCanvas #11117 https://github.com/pharo-project/pharo/pull/11117 - 11144-LocaleAnnouncementTest-seems-to-be-unused #11189 https://github.com/pharo-project/pharo/pull/11189 Pharo10 ======= - Remembering scroll position when collapsing and expanding tree table items #11202 https://github.com/pharo-project/pharo/pull/11202 - Making completion support $_ in class and method names #11197 https://github.com/pharo-project/pharo/pull/11197 - 11198-Pharo10-Reflectivity-do-not-add-temp-for-value-if-not-generating-the-primtive-Wrapper #11200 https://github.com/pharo-project/pharo/pull/11200

May 13, 2022

Re: Question about MethodDictionary in TraitedClass (methodDict/localMethodDict)

by Marcus Denker

> On 12 May 2022, at 11:27, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: > > Hi, > > We were profiling the loading of code that uses many Traits. We saw something like this (this is a tally for `TraitedMetaclass>>#addAndClassifySelector:withMethod:inProtocol:`): > <Screenshot 2022-05-11 at 17.17.37.png> > > From what we saw in `TraitedMetaclass>>#addAndClassifySelector:withMethod:inProtocol:` a method is first added to `localMethodDict` and then it calls the super method that adds the selector to the `methodDict` of the actual class in `Behaviour>>addSelectorSilently:withMethod: `. Because of this we basically get an overhead as a method is added to two method dictionaries and adding a method to a MethodDictionary is slower, as it does operations like `flushCache` and `cachePragmas`. > > Should the `localMethodDict` also be an instance of MethodDictionary or could it be a simple dictionary? > I think it can be normal Dictionary: MethodDictionary we just meed where there VM executes code (for flushCache) and for lookup. The only downside is that it then uses a little bit more memory (MethodDictionary does not use associations), but that should be no problem. Marcus

May 12, 2022

Question about MethodDictionary in TraitedClass (methodDict/localMethodDict)

by Andrei Chis

Hi, We were profiling the loading of code that uses many Traits. We saw something like this (this is a tally for `TraitedMetaclass>>#addAndClassifySelector:withMethod:inProtocol:`): [image: Screenshot 2022-05-11 at 17.17.37.png] >From what we saw in `TraitedMetaclass>>#addAndClassifySelector:withMethod:inProtocol:` a method is first added to `localMethodDict` and then it calls the super method that adds the selector to the `methodDict` of the actual class in `Behaviour>>addSelectorSilently:withMethod: `. Because of this we basically get an overhead as a method is added to two method dictionaries and adding a method to a MethodDictionary is slower, as it does operations like `flushCache` and `cachePragmas`. Should the `localMethodDict` also be an instance of MethodDictionary or could it be a simple dictionary? Cheers, Andrei

May 12, 2022

About Pull Request Reviews: Multiple Reviews are best!

by Marcus Denker

Hi, If you see that a PR that you wanted to review already has a positive review, do not think âah, nothing to be done for meâ. Because imagine if the PR would be bad: you would add a comment how to improve in addition to the one already positive review. You should do the same even if you just add another âYes, looks goodâ. The reason is that *you* know that you looked at the PR and did not find a problem, but nobody else has a way to see that. Second (or even third, 4thâ¦) positive reviews are very valuable, they validate the first review *and* they are vote for getting that PR merged fast. You can find the PRs in need of a review here: https://github.com/pharo-project/pharo/pulls Marcus

May 12, 2022

Pharo Launcher 3.0.1: no GUI

by Shaping

From: Shaping <shaping(a)uurda.org> Sent: Wednesday, 4 May, 2022 02:46 To: 'Pharo Development List' <pharo-dev(a)lists.pharo.org> Cc: 'Pharo-users' <pharo-users(a)lists.pharo.org> Subject: [Pharo-dev] Re: [ANN] Pharo Launcher 3.0.1 released! On May 3, 2022, at 6:03 PM, Shaping < <mailto:shaping@uurda.org> shaping(a)uurda.org> wrote: > > This is strange. I tested PharoLauncher 3.0.1 on Windows 10 and had no problems. > Did you try to uninstall the previous launcher first? > > Yes, I did the uninstall. And I just did the uninstall and reinstall again. > > Do you have more information that could help finding the problem? > > No, just an ordinary event log: > > Windows Installer installed the product. Product Name: PharoLauncher. Product Version: 3.0.1. Product Language: 1033. Manufacturer: Pharo project. Installation success or error status: 0. > > > Is everyone else able to open PL 3.0.1 on Windows? I installed it on two machines. On one it worked, and on the other it didnât. On the one where it didnât work, the SDL2.dll file didnât get installed. After adding the file, it opened. Iâm guessing that the virus scanner may be getting in the way. Interesting. I don't have any special antivirus app running, just the default Windows Defender. â¦ I do have SDL2.dll in â¦\AppData\Local\PharoLauncher. Still the GUI doesnât open Hi Christophe. Do we understand why the PL 3.0.1 GUI doesnât open sometimes even when SDL2.dll is present? I have in my PharoLauncher folder 74 items. One of those is the images folder. Is that as it should be? â¦ Should the PL 3.0.1 installer produce a \PharoLancher install folder containing 74 items, of which one is the \images folder? If there is a file/folder list discrepancy, we can start the debugging there. â¦ I rebooted the PC, uninstalled PL 3.0.1, and then reinstalled it. The GUI still doesnât appear, but I have 70 files/folders now (not 74), one of which is \images. The difference seems to be caused by the change in OS state after the reboot. Strange. Any ideas? I still have an SDL2.dll. So, although the absence of this file in Johnâs install explains his missing GUI, it doesnât explain mine. Is anyone besides John and me seeing no PL 3.0.1 GUI on Windows? Shaping

May 12, 2022

Re: About Image Size Pharo9->Pharo11

by Norbert Hartl

This is gold. This is the work nobody usually likes to do but is THE apsect for sustainability of a system. Like it!!! thanks, Norbert > Am 11.05.2022 um 09:00 schrieb Marcus Denker <marcus.denker(a)inria.fr>: > > Pharo9: 65,8 MB > Pharo10: 57,4 MB > Pharo11: 56,5 MB > > The space saving come from three things: > > 1) Code cleanup Pharo9-Pharo10 > ========================= > > e.g. removal of support in Kernel and Compiler of old style blocks and bytecodes, > to mention one smaller (in term of image size) but deep cleanup. > > Of course, we can do more here. There is still a lot of dead code (and duplicated > things) in the image! > > > 2) Global Literal Sharing > =================== > > Literals are now, when the method is compiled, set to be read-only, recursively in the case of arrays. > > This allows us to unify (share one instance) not only in the same method, but globally over all methods. > > As the compiler can not do a global literal table when compiling a single method (too slow), this is implemented > as an additional pass, called as part of the build process. > > If you load a lot of code, it might be an idea to do that as part of your build again: > > ImageCleaner shareLiterals > > > 3) Improvement of code structure objects > =============================== > > e.g, in Pharo10 we found two empty OrderedCollections per class that where not needed. > > Further work on this idea is where the improvement in Pharo11 comes from, we merged these three changes: > > - Class>>#classPool: empty dictionary for all classes, but not many define class vars #11172 > https://github.com/pharo-project/pharo/issues/11172 > > - [Memory] sharedPools OrderedCollections waste memory #10957 > https://github.com/pharo-project/pharo/issues/10957 > > - [Memory] AllProtocol uses a lot of memory #10963 > https://github.com/pharo-project/pharo/issues/10963 > > > The classPools/sharedPool improves the size of the bootstrapped image not to0 much as the boostrap creates > classes with nil there, but for newly loaded code this will be more visible. > > This direction has some more fairly simple next steps: > > - [Memory] commentSourcePointer is not needed for MetaClasses > https://github.com/pharo-project/pharo/issues/10958 > > - [Memory] Every class and meta class has both a ProtocolOrganizer and a ClassOrganization #10959 > https://github.com/pharo-project/pharo/issues/10959 > > > ... and of course there are many more things to find with just looking a bit. > > (And it is interesting starting point to think about better language support for making long living but rarely changed > data structures more memory efficient) > > If you want to get an impression of which classes use image space, "SpaceTally printSpaceAnalysis" > prints a per-class analysis. > > Marcus

May 11, 2022

Re: About Image Size Pharo9->Pharo11

by Sven Van Caekenberghe

Great work, Marcus. > On 11 May 2022, at 09:00, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > Pharo9: 65,8 MB > Pharo10: 57,4 MB > Pharo11: 56,5 MB > > The space saving come from three things: > > 1) Code cleanup Pharo9-Pharo10 > ========================= > > e.g. removal of support in Kernel and Compiler of old style blocks and bytecodes, > to mention one smaller (in term of image size) but deep cleanup. > > Of course, we can do more here. There is still a lot of dead code (and duplicated > things) in the image! > > > 2) Global Literal Sharing > =================== > > Literals are now, when the method is compiled, set to be read-only, recursively in the case of arrays. > > This allows us to unify (share one instance) not only in the same method, but globally over all methods. > > As the compiler can not do a global literal table when compiling a single method (too slow), this is implemented > as an additional pass, called as part of the build process. > > If you load a lot of code, it might be an idea to do that as part of your build again: > > ImageCleaner shareLiterals > > > 3) Improvement of code structure objects > =============================== > > e.g, in Pharo10 we found two empty OrderedCollections per class that where not needed. > > Further work on this idea is where the improvement in Pharo11 comes from, we merged these three changes: > > - Class>>#classPool: empty dictionary for all classes, but not many define class vars #11172 > https://github.com/pharo-project/pharo/issues/11172 > > - [Memory] sharedPools OrderedCollections waste memory #10957 > https://github.com/pharo-project/pharo/issues/10957 > > - [Memory] AllProtocol uses a lot of memory #10963 > https://github.com/pharo-project/pharo/issues/10963 > > > The classPools/sharedPool improves the size of the bootstrapped image not to0 much as the boostrap creates > classes with nil there, but for newly loaded code this will be more visible. > > This direction has some more fairly simple next steps: > > - [Memory] commentSourcePointer is not needed for MetaClasses > https://github.com/pharo-project/pharo/issues/10958 > > - [Memory] Every class and meta class has both a ProtocolOrganizer and a ClassOrganization #10959 > https://github.com/pharo-project/pharo/issues/10959 > > > ... and of course there are many more things to find with just looking a bit. > > (And it is interesting starting point to think about better language support for making long living but rarely changed > data structures more memory efficient) > > If you want to get an impression of which classes use image space, "SpaceTally printSpaceAnalysis" > prints a per-class analysis. > > Marcus

May 11, 2022

About Image Size Pharo9->Pharo11

by Marcus Denker

Pharo9: 65,8 MB Pharo10: 57,4 MB Pharo11: 56,5 MB The space saving come from three things: 1) Code cleanup Pharo9-Pharo10 ========================= e.g. removal of support in Kernel and Compiler of old style blocks and bytecodes, to mention one smaller (in term of image size) but deep cleanup. Of course, we can do more here. There is still a lot of dead code (and duplicated things) in the image! 2) Global Literal Sharing =================== Literals are now, when the method is compiled, set to be read-only, recursively in the case of arrays. This allows us to unify (share one instance) not only in the same method, but globally over all methods. As the compiler can not do a global literal table when compiling a single method (too slow), this is implemented as an additional pass, called as part of the build process. If you load a lot of code, it might be an idea to do that as part of your build again: ImageCleaner shareLiterals 3) Improvement of code structure objects =============================== e.g, in Pharo10 we found two empty OrderedCollections per class that where not needed. Further work on this idea is where the improvement in Pharo11 comes from, we merged these three changes: - Class>>#classPool: empty dictionary for all classes, but not many define class vars #11172 https://github.com/pharo-project/pharo/issues/11172 - [Memory] sharedPools OrderedCollections waste memory #10957 https://github.com/pharo-project/pharo/issues/10957 - [Memory] AllProtocol uses a lot of memory #10963 https://github.com/pharo-project/pharo/issues/10963 The classPools/sharedPool improves the size of the bootstrapped image not to0 much as the boostrap creates classes with nil there, but for newly loaded code this will be more visible. This direction has some more fairly simple next steps: - [Memory] commentSourcePointer is not needed for MetaClasses https://github.com/pharo-project/pharo/issues/10958 - [Memory] Every class and meta class has both a ProtocolOrganizer and a ClassOrganization #10959 https://github.com/pharo-project/pharo/issues/10959 ... and of course there are many more things to find with just looking a bit. (And it is interesting starting point to think about better language support for making long living but rarely changed data structures more memory efficient) If you want to get an impression of which classes use image space, "SpaceTally printSpaceAnalysis" prints a per-class analysis. Marcus

May 11, 2022

Re: [ANN] Pharo Launcher 3.0.1 released!

by Shaping

From: Shaping <shaping(a)uurda.org> Sent: Wednesday, 4 May, 2022 02:46 To: 'Pharo Development List' <pharo-dev(a)lists.pharo.org> Cc: 'Pharo-users' <pharo-users(a)lists.pharo.org> Subject: [Pharo-dev] Re: [ANN] Pharo Launcher 3.0.1 released! On May 3, 2022, at 6:03 PM, Shaping < <mailto:shaping@uurda.org> shaping(a)uurda.org> wrote: > > This is strange. I tested PharoLauncher 3.0.1 on Windows 10 and had no problems. > Did you try to uninstall the previous launcher first? > > Yes, I did the uninstall. And I just did the uninstall and reinstall again. > > Do you have more information that could help finding the problem? > > No, just an ordinary event log: > > Windows Installer installed the product. Product Name: PharoLauncher. Product Version: 3.0.1. Product Language: 1033. Manufacturer: Pharo project. Installation success or error status: 0. > > > Is everyone else able to open PL 3.0.1 on Windows? I installed it on two machines. On one it worked, and on the other it didnât. On the one where it didnât work, the SDL2.dll file didnât get installed. After adding the file, it opened. Iâm guessing that the virus scanner may be getting in the way. Interesting. I don't have any special antivirus app running, just the default Windows Defender. â¦ I do have SDL2.dll in â¦\AppData\Local\PharoLauncher. Still the GUI doesnât open Hi Christophe. Do we understand why the PL 3.0.1 GUI doesnât open sometimes even when SDL2.dll is present? I have in my PharoLauncher folder 74 items. One of those is the images folder. Is that as it should be? â¦ Hi. Christophe. Should the PL 3.0.1 installer produce a \PharoLancher install folder containing 74 items, of which one is the \images folder? If there is a file/folder list discrepancy, we can start the debugging there. Shaping

May 10, 2022