- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] GT Playground Print It Popup unreadeable

by phil＠highoctane.be

Hi All, On Wed, May 9, 2018 at 9:02 AM, Torsten Bergmann <astares(a)gmx.de> wrote: > H Sven > > > Sven Van Caekenberghe wrote: > >In the very latest Pharo 7 using the Dark Theme (with the recent changed > Tooltip), the intermediate Popup shown when doing Print It in a GT > Playground is unreadable: > > see my reply in http://lists.pharo.org/pipermail/pharo-dev_lists. > pharo.org/2018-May/271654.html > which also will fix this issue. > Can't we all agree to introduce a proper palette system so that tools can be based on them? There are all kind of weird tricks to darken/lighten/whatever on the colors of the theme but there is no single place one can go to switch to another palette without having to spend hours in getting things right. I worked on the Sublimish theme to align GTSpotter with it and it was quite full of interesting surprises. Check https://terminal.sexy/ for example. We have a live environment and we have to fiddle so much? Come on! ThemePalette would be a great addition. Color entries should be separated from the semantic meaning (e.g. background, tooltip, ...). There is some semantic meaning in the Theme but it is not backed by a ThemePalette which makes us create additional ThemeClasses for what is basically the same thing, only the palette changing. What do you think? Also, is there anything like this foreseen in Brick/Block? Phil > > Thx > T. > > > >

May 9, 2018

[Pharo 7.0-dev] Build #847: 21849-add-isReferenced-for-Class

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #847 was: SUCCESS. The Pull Request #1315 was integrated: "21849-add-isReferenced-for-Class" Pull request url: https://github.com/pharo-project/pharo/pull/1315 Issue Url: https://pharo.fogbugz.com/f/cases/21849 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

May 9, 2018

Re: [Pharo-dev] GT Playground Print It Popup unreadeable

by Torsten Bergmann

H Sven Sven Van Caekenberghe wrote: >In the very latest Pharo 7 using the Dark Theme (with the recent changed Tooltip), the intermediate Popup shown when doing Print It in a GT Playground is unreadable: see my reply in http://lists.pharo.org/pipermail/pharo-dev_lists.pharo.org/2018-May/271654.… which also will fix this issue. Thx T. Â Â

May 9, 2018

Re: [Pharo-dev] who redefined the #balloonBackgroundColor for dark theme?

by Torsten Bergmann

Peter wrote: >Finally, consider the following test: In a dark room, only monitor with pharo and dark theme is producing light. Now a large popup with yellow background appears... did your eyes squint? can you suddenly see >the other side of the room? :) Instead of hypothetical tests I tend to code in a light room and rather use the practical approach of fixing an issue when it appears or when I get blamed for it :P All details and a proposed solution are summarized in new issue: https://pharo.fogbugz.com/f/cases/21856/ which - will not hardcode the balloon background color (as it was before the introduction of #21809) by using a lighter version of the darkBaseColor for balloonBackgroundColor in DarkTheme - nonetheless exactly restores the actual color values of the dark theme as before the introduction of issue #21809 - still allows to define a tooltips text color on the graphics theme as it was the goal in #21809 Also a new PR is awaiting a review: https://github.com/pharo-project/pharo/pull/1320 Thx T.

May 9, 2018

Re: [Pharo-dev] who redefined the #balloonBackgroundColor for dark theme?

by Peter UhnÃ¡k

> For me it is showing yellow with black (not white) text which seems OK. Dark theme is always light text on dark background, not the other way around. Also, the color itself feels out of place... how does it relate to the other colors? What other UI element uses yellow? It has to make sense in the entire color scheme. Finally, consider the following test: In a dark room, only monitor with pharo and dark theme is producing light. Now a large popup with yellow background appears... did your eyes squint? can you suddenly see the other side of the room? :) Peter On Tue, May 8, 2018 at 9:16 PM, Torsten Bergmann <astares(a)gmx.de> wrote: > This came from https://pharo.fogbugz.com/f/cases/21809 > > - the original changeset came from Hilaire > - Stef wanted to do prepare the PR > - I actually did the PR using the CS from Hilaire > - it was reviewed and merged by Marcus > - now Sven likes it too ;) > > So you have to blame half of the community :P > > For me it is showing yellow with black (not white) text which seems OK. > But I usually work with the light theme and might be biased. > > No problem from my side to have a look at other tools with a dark theme > (like VisualStudio, IntelliJ, Eclipse or other) to find a better color > combination. > > Bye > T. > > > Gesendet: Dienstag, 08. Mai 2018 um 15:30 Uhr > > Von: "Esteban Lorenzano" <estebanlm(a)gmail.com> > > An: "Pharo Development List" <pharo-dev(a)lists.pharo.org> > > Betreff: [Pharo-dev] who redefined the #balloonBackgroundColor for dark > theme? > > > > really? > > > > > > > > git says guilty was Torsten :P > > anywayâ¦ thatâs an awful color for background on dark. > > Why nobody realised it before? Iâm using a variant of the dark theme > myself and I just realised nowâ¦ what changed? > > > > Esteban > >

May 8, 2018

Re: [Pharo-dev] who redefined the #balloonBackgroundColor for dark theme?

by Torsten Bergmann

This came from https://pharo.fogbugz.com/f/cases/21809 - the original changeset came from Hilaire - Stef wanted to do prepare the PR - I actually did the PR using the CS from Hilaire - it was reviewed and merged by Marcus - now Sven likes it too ;) So you have to blame half of the community :P For me it is showing yellow with black (not white) text which seems OK. But I usually work with the light theme and might be biased. No problem from my side to have a look at other tools with a dark theme (like VisualStudio, IntelliJ, Eclipse or other) to find a better color combination. Bye T. > Gesendet: Dienstag, 08. Mai 2018 um 15:30 Uhr > Von: "Esteban Lorenzano" <estebanlm(a)gmail.com> > An: "Pharo Development List" <pharo-dev(a)lists.pharo.org> > Betreff: [Pharo-dev] who redefined the #balloonBackgroundColor for dark theme? > > really? > > > > git says guilty was Torsten :P > anywayâ¦ thatâs an awful color for background on dark. > Why nobody realised it before? Iâm using a variant of the dark theme myself and I just realised nowâ¦ what changed? > > Esteban

May 8, 2018

[Pharo 7.0-dev] Build #846: 20557-Update-Zinc-and-Zodiac

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #846 was: FAILURE. The Pull Request #1318 was integrated: "20557-Update-Zinc-and-Zodiac" Pull request url: https://github.com/pharo-project/pharo/pull/1318 Issue Url: https://pharo.fogbugz.com/f/cases/20557 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

May 8, 2018

Re: [Pharo-dev] fun with announcers

by Henrik-Nergaard

Hi, >Announcer allInstances size. â7124" Remember that GT implements a lot of Announcer subclasses so to gain a better picture you should use: Announcer allSubInstances size. >clearly, thatâs not good. >a symptom there is something leaking badly in our current development version. There has been leaking Announcements back from Pharo 5. Most of them is tangled into Rubric, and some GT tools. In the past many of the leaks has been from mixing weak and non weak subscriptions in the same announcer, IIRC. Here is a script you can run. =========================================================== | bag dct | bag := Bag new. dct := IdentityDictionary new. Smalltalk garbageCollect. Announcer allSubInstancesDo: [ :instance | | subs | subs := instance subscriptions subscriptions. subs do: [ :each | | cls | cls := each announcementClass. bag add: cls. dct at: cls ifPresent: [ :set | set add: each class ] ifAbsentPut: [ IdentitySet with: each class ] ] ]. "{ bag . dct } inspect." "String streamContents: [ :ss | bag sortedCounts do: [ :assoc | ss << (assoc key asString padRightTo: 7); << assoc value printString; cr ] ]" dct associations select: [ :assoc | assoc value size > 1 ] =========================================================== Best regards, Henrik -- Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html

May 8, 2018

GT Playground Print It Popup unreadeable

by Sven Van Caekenberghe

In the very latest Pharo 7 using the Dark Theme (with the recent changed Tooltip), the intermediate Popup shown when doing Print It in a GT Playground is unreadable: It seems like it is white on yellow ... Sven

May 8, 2018

Re: [Pharo-dev] who redefined the #balloonBackgroundColor for dark theme?

by Sven Van Caekenberghe

> On 8 May 2018, at 15:53, Cyril Ferlicot <cyril.ferlicot(a)gmail.com> wrote: > > > On mar. 8 mai 2018 at 15:37, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > Yes, it was changed. > > But for me (latest 7) it is black text on yellow background which is OK. > > Black and Yellow for a dark theme is readable but I do not think it is ok because it is really aggressive for the eyes. :( It is a pale yellow, only used for tooltip balloons, so for me it is acceptable. > Usually in dark themes I see light gray for backgrounds and white or black font depending on the luminescence of the font. (Depending if it's > or < to 0.5) > > > > However, Print It in Playground is unreadable now ... > > -- > Cyril Ferlicot > https://ferlicot.fr

May 8, 2018