- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] who redefined the #balloonBackgroundColor for dark theme?

by Hilaire

well... For me the hight contrast makes it very visible, as should be a tooltip, and helpfull to discover feature in drgeo. Le 09/05/2018 Ã 13:41, Esteban Lorenzano a Ã©critÂ : > thanks Hilaire, > > in any case yellow background for dark theme was bad:) > > cheers, > Esteban -- Dr. Geo http://drgeo.eu

May 9, 2018

Re: [Pharo-dev] ASK FOR TEST: latest vm

by Pavel Krivanek

Tested on 32-bit and 64-bit Linux. Everything seems to work well. -- Pavel 2018-05-09 13:36 GMT+02:00 Esteban Lorenzano <estebanlm(a)gmail.com>: > hi, > > I will try to promote new stables. > Can you people try the latest vm and report issues? (linux32 libgit2 > problem should be fixed) > > thanks! > Esteban >

May 9, 2018

Re: [Pharo-dev] [ Umbrella Issue ] Cleanup remaining DeprecatedFileSystem users

by Sven Van Caekenberghe

> On 9 May 2018, at 13:41, Thierry Goubier <thierry.goubier(a)gmail.com> wrote: > > 2018-05-09 13:14 GMT+02:00 Sven Van Caekenberghe <sven(a)stfx.eu>: >> You mean you made a subclass of StandardFilestream yourself ? > > There are a few subclasses of StandardFileStream in OSProcess: > AttachableFileStream, AsyncFileReadStream and > BufferedAsyncFileReadStream. They will need to be ported. > >> If yes, can you describe briefly why you did so ? > > As far as my analysis go, AttachableFileStream refers to and > manipulates the underlying ioHandle of a unix pipe stream, > AsyncFileReadStream interacts with the asynchronous io extensions of > the vm to observe that io handle, and a BufferedAsyncFileReadStream > add a thread-safe, buffered, blocking API for smalltalk processe on > top. Yes, they will have to be ported. If it were me (but I haven't looked at the code) I would not inherit from those classes, but from a simpler Stream class, possibly even none. The stream API is actually quite small (or it should be). Inheritance is an implementation technique, inheriting from a complex class can be hard, unless the superclass was really designed with that purpose. All this, IMHO. > Regards, > > Thierry > >>> On 9 May 2018, at 13:12, Thierry Goubier <thierry.goubier(a)gmail.com> wrote: >>> >>> Hi Sven, >>> >>> in that process, how does one rewrite StandardFilestream subclasses? >>> >>> Regards, >>> >>> Thierry >>> >>> 2018-05-09 11:51 GMT+02:00 Sven Van Caekenberghe <sven(a)stfx.eu>: >>>> Hi, >>>> >>>> I created the following: >>>> >>>> >>>> https://pharo.manuscript.com/f/cases/21858/Cleanup-remaining-DeprecatedFile… >>>> >>>> This is an umbrella issue, please create sub issues for each set of changes. It is better to work step by step. >>>> >>>> The package DeprecatedFileSystem contains classes that should no longer be used, the most important being >>>> >>>> FileStream, StandardFileStream and MultiByteFileStream >>>> MultiByteBinaryOrTextStream and RWBinaryOrTextStream >>>> >>>> Alternatives exist by using FileSystem's FileReference as well as File and various new (Zn) streams. >>>> >>>> >>>> Let's all work together to make this real. It is important that the image itself makes correct use of ongoing refactoring efforts. We already took great steps, but there is more work to do. Note that in many cases, using code can and should be simplified, removing ugly hacks where possible. >>>> >>>> Feel free to discuss any issues on the ML. >>>> >>>> Sven >>> >> >> >

May 9, 2018

Re: [Pharo-dev] [ Umbrella Issue ] Cleanup remaining DeprecatedFileSystem users

by Thierry Goubier

2018-05-09 13:14 GMT+02:00 Sven Van Caekenberghe <sven(a)stfx.eu>: > You mean you made a subclass of StandardFilestream yourself ? There are a few subclasses of StandardFileStream in OSProcess: AttachableFileStream, AsyncFileReadStream and BufferedAsyncFileReadStream. They will need to be ported. > If yes, can you describe briefly why you did so ? As far as my analysis go, AttachableFileStream refers to and manipulates the underlying ioHandle of a unix pipe stream, AsyncFileReadStream interacts with the asynchronous io extensions of the vm to observe that io handle, and a BufferedAsyncFileReadStream add a thread-safe, buffered, blocking API for smalltalk processe on top. Regards, Thierry >> On 9 May 2018, at 13:12, Thierry Goubier <thierry.goubier(a)gmail.com> wrote: >> >> Hi Sven, >> >> in that process, how does one rewrite StandardFilestream subclasses? >> >> Regards, >> >> Thierry >> >> 2018-05-09 11:51 GMT+02:00 Sven Van Caekenberghe <sven(a)stfx.eu>: >>> Hi, >>> >>> I created the following: >>> >>> >>> https://pharo.manuscript.com/f/cases/21858/Cleanup-remaining-DeprecatedFile… >>> >>> This is an umbrella issue, please create sub issues for each set of changes. It is better to work step by step. >>> >>> The package DeprecatedFileSystem contains classes that should no longer be used, the most important being >>> >>> FileStream, StandardFileStream and MultiByteFileStream >>> MultiByteBinaryOrTextStream and RWBinaryOrTextStream >>> >>> Alternatives exist by using FileSystem's FileReference as well as File and various new (Zn) streams. >>> >>> >>> Let's all work together to make this real. It is important that the image itself makes correct use of ongoing refactoring efforts. We already took great steps, but there is more work to do. Note that in many cases, using code can and should be simplified, removing ugly hacks where possible. >>> >>> Feel free to discuss any issues on the ML. >>> >>> Sven >> > >

May 9, 2018

Re: [Pharo-dev] who redefined the #balloonBackgroundColor for dark theme?

by Esteban Lorenzano

thanks Hilaire, in any case yellow background for dark theme was bad :) cheers, Esteban > On 9 May 2018, at 13:17, Hilaire <hilaire(a)drgeo.eu> wrote: > > What changed is the UITheme receive a balloonTextColor method (the fix I proposed), BUT some morphs in Pharo use the theme balloonBackgroundColor BUT NOT the assorted balloonTextColor (obviously as this method was just introduced). > > The right fix will be to makes these morphs using balloonBackgroundColor to use > balloonTextColor too. I took a look but get lost again in morph classes. Someone with the appropriate knowledge could fix it in a breeze. > > Hilaire > > Le 08/05/2018 Ã 15:30, Esteban Lorenzano a Ã©crit : >> git says guilty was Torsten :P >> anywayâ¦ thatâs an awful color for background on dark. >> Why nobody realised it before? Iâm using a variant of the dark theme myself and I just realised nowâ¦ what changed? >> > > -- > Dr. Geo > http://drgeo.eu > > >

May 9, 2018

ASK FOR TEST: latest vm

by Esteban Lorenzano

hi, I will try to promote new stables. Can you people try the latest vm and report issues? (linux32 libgit2 problem should be fixed) thanks! Esteban

May 9, 2018

[Pharo 7.0-dev] Build #850: 21816-use--for-become-and-becomeForward

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #850 was: FAILURE. The Pull Request #1313 was integrated: "21816-use--for-become-and-becomeForward" Pull request url: https://github.com/pharo-project/pharo/pull/1313 Issue Url: https://pharo.fogbugz.com/f/cases/21816 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

May 9, 2018

Re: [Pharo-dev] GT Playground Print It Popup unreadeable

by Hilaire

Indeed. The use of colors seems to be a mess. Le 09/05/2018 Ã 09:41, phil(a)highoctane.be a Ã©critÂ : > ThemePalette would be a great addition. Color entries should be > separated from the semantic meaning (e.g. background, tooltip, ...). > There is some semantic meaning in the Theme but it is not backed by a > ThemePalette which makes us create additional ThemeClasses for what is > basically the same thing, only the palette changing. > -- Dr. Geo http://drgeo.eu

May 9, 2018

Re: [Pharo-dev] who redefined the #balloonBackgroundColor for dark theme?

by Hilaire

What changed is the UITheme receive a balloonTextColor method (the fix I proposed), BUT some morphs in Pharo use the theme balloonBackgroundColor BUT NOT the assorted balloonTextColor (obviously as this method was just introduced). The right fix will be to makes these morphs using balloonBackgroundColor to use balloonTextColor too. I took a look but get lost again in morph classes. Someone with the appropriate knowledge could fix it in a breeze. Hilaire Le 08/05/2018 Ã 15:30, Esteban Lorenzano a Ã©critÂ : > git says guilty was Torsten :P > anywayâ¦ thatâs an awful color for background on dark. > Why nobody realised it before? Iâm using a variant of the dark theme > myself and I just realised nowâ¦ what changed? > -- Dr. Geo http://drgeo.eu

May 9, 2018

Re: [Pharo-dev] [ Umbrella Issue ] Cleanup remaining DeprecatedFileSystem users

by Sven Van Caekenberghe

You mean you made a subclass of StandardFilestream yourself ? If yes, can you describe briefly why you did so ? > On 9 May 2018, at 13:12, Thierry Goubier <thierry.goubier(a)gmail.com> wrote: > > Hi Sven, > > in that process, how does one rewrite StandardFilestream subclasses? > > Regards, > > Thierry > > 2018-05-09 11:51 GMT+02:00 Sven Van Caekenberghe <sven(a)stfx.eu>: >> Hi, >> >> I created the following: >> >> >> https://pharo.manuscript.com/f/cases/21858/Cleanup-remaining-DeprecatedFile… >> >> This is an umbrella issue, please create sub issues for each set of changes. It is better to work step by step. >> >> The package DeprecatedFileSystem contains classes that should no longer be used, the most important being >> >> FileStream, StandardFileStream and MultiByteFileStream >> MultiByteBinaryOrTextStream and RWBinaryOrTextStream >> >> Alternatives exist by using FileSystem's FileReference as well as File and various new (Zn) streams. >> >> >> Let's all work together to make this real. It is important that the image itself makes correct use of ongoing refactoring efforts. We already took great steps, but there is more work to do. Note that in many cases, using code can and should be simplified, removing ugly hacks where possible. >> >> Feel free to discuss any issues on the ML. >> >> Sven >

May 9, 2018