- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Commenting test classes?

by Gabriel Cotelli

Hi, I think that for TestCase subclasses 90% of the time the comment end up in "Unit test of blablabl". Maybe a really complex test case justifies a comment, but it's not the common case. If we can disable the missing comment feedback on TestCase subclasses I will certainly disable it. On Tue, Jul 3, 2018 at 3:48 PM Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > Hi. > > I noticed pull requests which add comments to test cases (class comments). > I guess the reason is that in Calypso uncommented classes are marked > differently than in Nautilus and the exclamation does not disappear when > class provides special icon like status of tests. > > So the question is do we really want people comment test cases? > I did not notice any meaningful comment from those PRs. It's like "Unit > tests for mirror primitives" for MirrorPrimitiveTests (case 22207 > <https://github.com/pharo-project/pharo/pull/1598>). > Personally I don't like such approach to put class name with spaces in the > comment. It is useless and duplicated. > > Alternatively I can change uncommented mark to be like in Nautilus. > But I like Calypso approach because #systemIcon is not overridden by > exclamation. If we want to keep it we need to introduce some > #requiresComment to Class which will be overridden by TestCase. > > So what you think? > > > > >

July 3, 2018

Commenting test classes?

by Denis Kudriashov

Hi. I noticed pull requests which add comments to test cases (class comments). I guess the reason is that in Calypso uncommented classes are marked differently than in Nautilus and the exclamation does not disappear when class provides special icon like status of tests. So the question is do we really want people comment test cases? I did not notice any meaningful comment from those PRs. It's like "Unit tests for mirror primitives" for MirrorPrimitiveTests (case 22207 <https://github.com/pharo-project/pharo/pull/1598>). Personally I don't like such approach to put class name with spaces in the comment. It is useless and duplicated. Alternatively I can change uncommented mark to be like in Nautilus. But I like Calypso approach because #systemIcon is not overridden by exclamation. If we want to keep it we need to introduce some #requiresComment to Class which will be overridden by TestCase. So what you think?

July 3, 2018

[Pharo 7.0-dev] Build #1110: 22225 Lint and formatting improvements in Compression package

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #1110 was: FAILURE. The Pull Request #1610 was integrated: "22225 Lint and formatting improvements in Compression package" Pull request url: https://github.com/pharo-project/pharo/pull/1610 Issue Url: https://pharo.fogbugz.com/f/cases/22225 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

July 3, 2018

Re: [Pharo-dev] About the infinite debugger

by Marcus Denker

> On 30 Jun 2018, at 02:56, Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > > Hi Guille, > > On Jun 29, 2018, at 7:48 AM, Guillermo Polito <guillermopolito(a)gmail.com <mailto:guillermopolito@gmail.com>> wrote: > >> Hi all, >> >> during today's sprint we have been working with lots of people on the infinite debugger problem (https://pharo.fogbugz.com/f/cases/22085/ <https://pharo.fogbugz.com/f/cases/22085/>). We have checked the emails sent in the latest month. Then, together with Quentin, Pablo, Pavel, Yoan we have been discussing and testing hypothesis all day. We have been also comparing the debuggers code between pharo 3/4 (where the bug was is present) and pharo 7, but this was not necessarily straight forward as the code is not the same and there is no easy diff... > > This is frustrating. I canât see the issue cuz I canât login to fogbugz. Having to login to read an issue is a major flaw. I can see it makes sense for submitting, but fir merely browsing it should be unacceptable. That said... > > The pragma <primitive: 199> actually sets the primitive number in the method, so it it not merely a pragma; it alters bits in the method that the VM uses to search for handler contexts. So why one would do that for evaluateSignal: makes no sense to me. The primitive should be set only in on:do: or something very similar (for example one could imagine adding on:or:do: instead of using , to construct an ExceptionSet). So I think removing it from evaluateSignal: is definitely the right thing to do. > > As far as tests for findNextHandlerFrom:, this is tested implicitly by any nested exception test so I expect you have several tests affected. ClÃ©ment points to a test that fails when not including <primitive: 199> in evaluateSignal: so more investigation is necessary. Difficult to do while bugs are hidden in fogbugz. When are they going to migrate the github where they belong? Yes, the idea was to move the issue tracker to GitHubâ¦ but after the release is done (as it requires changing again some things). The closed-ness of fugbugz is really annoying. Marcus

July 3, 2018

Re: [Pharo-dev] Promote new Pharo 7 VM?

by Alistair Grant

Hi Esteban, On Mon, 18 Jun 2018 at 23:15, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > > yes, why not :) > but, remember the cycle: > > 1. two weeks in latest (that starts today) Just a friendly reminder that the two weeks is done... :-) Thanks, Alistair > 2. one month in stable 7.0 > 3. promote to stable 6.1 > > yes, is annoying, but is the scheme has worked the better to avoid problems. > > cheers, > Esteban > > > On 18 Jun 2018, at 14:20, Alistair Grant <akgrant0710(a)gmail.com> wrote: > > > > Hi Esteban, > > > > Would you consider promoting a new Pharo 7 VM? > > > > 140ff02 should finally solve an issue I've had with time zones and DST > > on Windows in the FileAttributesPlugin. > > > > Testing I've done on this VM: > > > > - Loaded up and used my normal dev environment. > > - Run the full automated test suite on: > > -- Linux 64 bit > > -- Linux 32 bit > > -- Win 32 bit > > > > In each case the set of failures in my environment roughly aligns with > > the current stable VM and the proposed one. > > > > I guess if anyone else has any objections they'll reply to this. :-) > > > > Of course, if you've got any questions or concerns, please let me know. > > > > In case it is useful for anyone, download links are: > > > > Linux 64 bit: http://files.pharo.org/vm/pharo-spur64/linux/pharo-linux-x86_64threaded-201… > > Linux 32 bit: http://files.pharo.org/vm/pharo-spur32/linux/pharo-linux-i386threaded-20180… > > Mac 64 bit: > > - http://files.pharo.org/vm/pharo-spur64/mac/pharo-mac-x86_64-201806171702-14… > > - http://files.pharo.org/vm/pharo-spur64/mac/pharo-mac-x86_64-201806171702-14… > > Mac 32 bit: > > - http://files.pharo.org/vm/pharo-spur32/mac/pharo-mac-i386-201806171702-140f… > > - http://files.pharo.org/vm/pharo-spur32/mac/pharo-mac-i386-201806171702-140f… > > Win 32 bit: http://files.pharo.org/vm/pharo-spur32/win/pharo-win-i386-201806171702-140f… > > > > > > Thanks! > > Alistair > > > >

July 3, 2018

[Pharo 7.0-dev] Build #1109: 21671 - MemoryStore returns nil for file modificationTime (regression)

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #1109 was: FAILURE. The Pull Request #1584 was integrated: "21671 - MemoryStore returns nil for file modificationTime (regression)" Pull request url: https://github.com/pharo-project/pharo/pull/1584 Issue Url: https://pharo.fogbugz.com/f/cases/21671 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

July 2, 2018

Re: [Pharo-dev] [Moose-dev] Re: [Pharo-users] [ann] gt documenter

by Sven Van Caekenberghe

> On 17 Jun 2018, at 15:09, Denis Kudriashov <dionisiydk(a)gmail.com> wrote: > > Hi Tudor. > > This is super impressive. +10 > What's next? Do you plan to implement IDE for writing documents, navigation, refactorings? (senders, renames should find all places in documents) > > 2018-06-13 21:57 GMT+01:00 Tudor Girba <tudor(a)tudorgirba.com>: > Hi, > > We are happy to announce a new leap of GToolkit Documenter, the tool for manipulating live documents directly in the development environment: > https://github.com/feenkcom/gtoolkit-documenter > > Documenter is part of the second generation GToolkit project, it is based on Bloc and works with the latest Pillar. It is mainly developed by Juraj Kubelka. > > Attached you can see a preview of how documents look like: > > <gt-documenter.png> > > At its core it offers a live editor for manipulating Pillar documents. The interaction happens seamlessly directly in the text editor, and it can be combined with different types of previews to serve several classes of use cases: > â¢ code documentation > â¢ tutorials > â¢ interactive data notebook > > > Code documentation > ---- > Documenter complements the GToolkit Examples engine to redefine code documentation. When practicing example-driven development, examples get written as part of the typical development. Once examples exist, they can be quickly put together in a document to form documentation. For example, the linked picture shows the comment of a class containing a visual explanation: > https://twitter.com/feenkcom/status/973899862482866176 > > You can see a live example of documentation by inspecting the following snippet: > GtDocumenter editorForText: BrToggleExamples comment. > > > Tutorials: > ---- > Documenter offers a new experience of writing tutorials for Pharo by enabling the creation and embedding of Epicea change sessions directly in the document. For example, take a look at the following animation: > https://twitter.com/feenkcom/status/999975333972541440 > > The document shows a method on top, and a change preview at the bottom showing both the code and the associated diff to the state from the image. Applying the change updates both the change view (no more diff), and method preview. This speeds up significantly the process of going through a tutorial. Furthermore, given that now the document shows the diff to the current image, the reader can safely explore alternative scenario and come back to the tutorial at any time without losing the overview. > > The size of the preview can also be adjusted live: > https://twitter.com/feenkcom/status/1001152789874167808 > https://twitter.com/feenkcom/status/1001407762285375490 > > You can see a live tutorial by inspecting: > IceRepository repositoriesLocation / 'feenkcom'/ 'gtoolkit-examples' / 'doc' / 'tutorial' / 'examples-tutorial.pillarâ. > > > Interactive data notebook: > ---- > A Documenter document can also be used as an interactive notebook. Internally it essentially acts as a playground: > â¢ it supports defining variables in code snippets, and > â¢ the execution of code shows an embedded inspector. > > For example: > https://twitter.com/feenkcom/status/996310432225820672 > https://twitter.com/feenkcom/status/1002851190475026432 > > An example, can be seen by inspecting: > IceRepository repositoriesLocation / 'feenkcom'/ 'gtoolkit' / 'doc' / 'gtoolkit' / 'gtoolkit.pillar'. > > > As always, please do let us know what you think. > > Enjoy, > The feenk team > > > -- > www.tudorgirba.com > www.feenk.com > > "If you can't say why something is relevant, > it probably isn't." > > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)list.inf.unibe.ch > https://www.list.inf.unibe.ch/listinfo/moose-dev

July 2, 2018

[Pharo 7.0-dev] Build #1108: Small improvement of DateAndTimeTest

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #1108 was: SUCCESS. The Pull Request #1625 was integrated: "Small improvement of DateAndTimeTest" Pull request url: https://github.com/pharo-project/pharo/pull/1625 Issue Url: https://pharo.fogbugz.com/f/cases/22240 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

July 2, 2018

[Pharo 7.0-dev] Build #1107: 22235-unsafe-TextMorphForFieldViewminimumExtent

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #1107 was: SUCCESS. The Pull Request #1620 was integrated: "22235-unsafe-TextMorphForFieldViewminimumExtent" Pull request url: https://github.com/pharo-project/pharo/pull/1620 Issue Url: https://pharo.fogbugz.com/f/cases/22235 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

July 2, 2018

Esteban's ChangeLog week of 25 June 2018

by estebanlm＠gmail.com

Hello! This is my weekly ChangeLog, from 25 June 2018 to 1 July 2018. You can see it in a better format by going here: http://log.smallworks.eu/web/search?from=25/6/2018&to=1/7/2018 ChangeLog ========= 27 June 2018: ------------- * I made a [small PR](https://github.com/pharo-project/pharo/pull/1590) to ensure pharo will load correct freetype library when using windows 64bit platform. * I finally was able to build a windows 64bit VM with all dependencies: [https://ci.appveyor.com/project/OpenSmalltalk/vm/build/job/5q50v90myxu4bxxi… This is an important milestone in our Path to have Pharo running in 64bit in all platforms, but sadly this is not finish. While most of the 64bit things I tested are working properly, the cairo plugin (hence Athens) is still not. So I need to spend some more time here, looking at the possible problems :( 25 June 2018: ------------- * I spent some time digging on some issues of Pharo catalog. At the end, it was not very problematic, but at least I took the oportunity to add the repository for Pharo 7.0 :) cheers! Esteban

July 2, 2018