- Pharo-dev - lists.pharo.org

Re: [Pharo-project] wrong FileSystem paths resolving

by Camillo Bruni

I tried to fix the script AFAIK it work locally. can you retry the stuff on the server? best cami On 2012-11-01, at 22:56, Camillo Bruni <camillobruni(a)gmail.com> wrote: > maybe we should change vm.sh? > I'll have a look at it. > > > On 2012-11-01, at 17:15, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: > >> Hi, >> >> in a Jenkins job configuration I have this bash line for Pharo start: >> >> ./vm.sh "images/$IMAGE_NAME.image" "$WORKSPACE/support/pharo.tank" >> "$WORKSPACE/support/pharo.tankst" >> >> In the console I got this error >> >> + ./vm.sh images/PharoKernelTanker-2.0.image >> '/builds/jenkins/workspace/Pharo Kernel 2.0 Reload by >> Fuel/support/pharo.tank' '/builds/jenkins/workspace/Pharo Kernel 2.0 >> Reload by Fuel/support/pharo.tankst' >> ==== Startup Error: FileDoesNotExist: >> file:///builds/jenkins/workspace/Pharo Kernel 2.0 Reload by >> Fuel/images/Fuel/support/pharo.tank >> >> As you may see, the image argument is passed by full path but it is >> interpreted wrongly. Tanker uses simply 'xxx' asFileReference on >> argument. >> The problem is clearly in the spaces in the path (see >> "Fuel/support/pharo.tank" at the end of path). On my localmachine id >> fails too if I use "$PWD/pharo.tank" "$PWD/pharo.tankst" as argument >> and the path does contain spaces. When I have this files in the image >> directory (even when the image path contains spaces) and I use only >> names of this files without full path, they are loaded well. >> >> Cheers, >> -- Pavel >> >

Nov. 1, 2012

Re: [Pharo-project] wrong FileSystem paths resolving

by Camillo Bruni

maybe we should change vm.sh? I'll have a look at it. On 2012-11-01, at 17:15, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: > Hi, > > in a Jenkins job configuration I have this bash line for Pharo start: > > ./vm.sh "images/$IMAGE_NAME.image" "$WORKSPACE/support/pharo.tank" > "$WORKSPACE/support/pharo.tankst" > > In the console I got this error > > + ./vm.sh images/PharoKernelTanker-2.0.image > '/builds/jenkins/workspace/Pharo Kernel 2.0 Reload by > Fuel/support/pharo.tank' '/builds/jenkins/workspace/Pharo Kernel 2.0 > Reload by Fuel/support/pharo.tankst' > ==== Startup Error: FileDoesNotExist: > file:///builds/jenkins/workspace/Pharo Kernel 2.0 Reload by > Fuel/images/Fuel/support/pharo.tank > > As you may see, the image argument is passed by full path but it is > interpreted wrongly. Tanker uses simply 'xxx' asFileReference on > argument. > The problem is clearly in the spaces in the path (see > "Fuel/support/pharo.tank" at the end of path). On my localmachine id > fails too if I use "$PWD/pharo.tank" "$PWD/pharo.tankst" as argument > and the path does contain spaces. When I have this files in the image > directory (even when the image path contains spaces) and I use only > names of this files without full path, they are loaded well. > > Cheers, > -- Pavel >

Nov. 1, 2012

Re: [Pharo-project] differently organized method categories in the Debugger dnu: create process

by Marcus Denker

On Nov 1, 2012, at 10:44 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > + 1 > and it will avoid that we do work in parallel. > Marcus I will close my entry. :-) I merged in into yours as a duplicate. Marcus -- Marcus Denker -- http://marcusdenker.de

Nov. 1, 2012

Re: [Pharo-project] FileSystem class>>separator?

by Camillo Bruni

On 2012-11-01, at 22:45, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > > On Nov 1, 2012, at 10:42 PM, Camillo Bruni wrote: > >> the separator depends on the current platform... so one or the other way >> you'll have to go via an instance (repeating your statement :P). >> >> what did you have in mind? > > I was thinking aloud :) > >> besides with FileReference you rarely have to use separator, unlike with >> FileDirectory where you had to do tons of operations on path strings. > > I was fixing my web generator and I do a lot of string concatenation :) if you do filesystem stuff you don't need the separator... 'foo' asFileReference / 'bar' / 'goo' and '/foo/bar/' asFileReference will work regardless of the underlying filesystem unix/win/mac

Nov. 1, 2012

Re: [Pharo-project] FileSystem class>>separator?

by StÃ©phane Ducasse

On Nov 1, 2012, at 10:42 PM, Camillo Bruni wrote: > the separator depends on the current platform... so one or the other way > you'll have to go via an instance (repeating your statement :P). > > what did you have in mind? I was thinking aloud :) > besides with FileReference you rarely have to use separator, unlike with > FileDirectory where you had to do tons of operations on path strings. I was fixing my web generator and I do a lot of string concatenation :) Stef > > > On 2012-11-01, at 22:07, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > >> Hi >> >> Right now if I want to get the separator I have to get the FileSystem instance >> >> FileSystem disk separator >> >> I was thinking that it would be good to be able to access separator without going to the instance. >> Does it make sense? >> Probably not since the separator depends on the store used and so separator would have to delegate anyway. >> >> Stef > >

Nov. 1, 2012

Re: [Pharo-project] differently organized method categories in the Debugger dnu: create process

by StÃ©phane Ducasse

+ 1 and it will avoid that we do work in parallel. Marcus I will close my entry. Stef On Nov 1, 2012, at 10:14 PM, Marcus Denker wrote: > Hello, > > To make this easy to review and integrate, what is the best is the following > > 1) add an issue to the issue tracker. > > http://code.google.com/p/pharo/issues/list > > I did it for this already for your report (to not forget it): > > http://code.google.com/p/pharo/issues/detail?id=6896 > > 2) to take advantage of an automatic test robot, attach a Slice to the bug report > > After having added the report, this is easy. In a fresh image: > -> do the change (e.g. load the .cs or .st) > -> open Monticello > -> Press the +Slice button > -> put the issue number 6896 into the field and press "grab" > -> select the slice and save it to the inbox > -> put status to "FixReviewNeeded" or wait until someone else does it > -> The famous monkey will load your slice and run all tests to see if you managed to break something essential. > > Integration (or rejection) will happen quite fast after this (within 24 hours often, within some days for sure). > > Marcus > > > > On Nov 1, 2012, at 9:32 PM, Paul DeBruicker <pdebruic(a)gmail.com> wrote: > >> Hi- >> >> When I create methods using the Debugger's 'Create' button I am never sure which categories are used in the class I'm adding the method to versus those in its super classes. In an effort to not have to think about that any more I've adapted the ClassDescription>>#allMethodCategoriesIntegratedThrough: to put the method categories that are used in the target class first, then those in the super classes after that. >> >> >> I think this should work in Pharo and Squeak but I've only tested it in Pharo 1.4. I've attached a changeset and also pasted the method below >> >> >> Paul >> >> >> allMethodCategoriesIntegratedThrough: mostGenericClass >> "Answer a list of all the method categories of the receiver and all its superclasses, up through mostGenericClass" >> >> | otherClassCategories thisClassCategories combinedClassCategories | >> otherClassCategories := OrderedCollection new. >> self allSuperclasses >> do: [ :aClass | >> (aClass includesBehavior: mostGenericClass) >> ifTrue: [ otherClassCategories addAll: aClass organization categories ] ]. >> otherClassCategories remove: 'no messages' asSymbol ifAbsent: [ ]. >> thisClassCategories := self organization categories asSortedCollection: [ :a :b | a asLowercase > ^ Array >> streamContents: [ :stream | >> stream >> nextPutAll: thisClassCategories; >> nextPutAll: >> ((otherClassCategories asSet removeAllSuchThat: [ :each | thisClassCategories includes: each ]) >> asSortedCollection: [ :a :b | a asLowercase > <ClassDescription-allMethodCategoriesIntegratedThrough.st> > > -- > Marcus Denker -- http://marcusdenker.de > >

Nov. 1, 2012

Re: [Pharo-project] FileSystem class>>separator?

by Camillo Bruni

the separator depends on the current platform... so one or the other way you'll have to go via an instance (repeating your statement :P). what did you have in mind? besides with FileReference you rarely have to use separator, unlike with FileDirectory where you had to do tons of operations on path strings. On 2012-11-01, at 22:07, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Hi > > Right now if I want to get the separator I have to get the FileSystem instance > > FileSystem disk separator > > I was thinking that it would be good to be able to access separator without going to the instance. > Does it make sense? > Probably not since the separator depends on the store used and so separator would have to delegate anyway. > > Stef

Nov. 1, 2012

Re: [Pharo-project] Network-MIME extensions

by StÃ©phane Ducasse

Thanks Pavel.! An easy bug for the sprint of tomorrow. Stef On Nov 1, 2012, at 9:44 PM, Pavel Krivanek wrote: > Hi, > > the package Network-MIME contains extension methods for classes > FileDirectory and MacFileDirectory that are not present in the system: > > http://code.google.com/p/pharo/issues/detail?id=6895 > > -- Pavel >

Nov. 1, 2012

Re: [Pharo-project] differently organized method categories in the Debugger dnu: create process

by StÃ©phane Ducasse

Thanks paul I created http://code.google.com/p/pharo/issues/detail?id=6897 BTW: Did you sign the license agreement? Stef On Nov 1, 2012, at 9:32 PM, Paul DeBruicker wrote: > Hi- > > When I create methods using the Debugger's 'Create' button I am never sure which categories are used in the class I'm adding the method to versus those in its super classes. In an effort to not have to think about that any more I've adapted the ClassDescription>>#allMethodCategoriesIntegratedThrough: to put the method categories that are used in the target class first, then those in the super classes after that. > > > I think this should work in Pharo and Squeak but I've only tested it in Pharo 1.4. I've attached a changeset and also pasted the method below > > > Paul > > > allMethodCategoriesIntegratedThrough: mostGenericClass > "Answer a list of all the method categories of the receiver and all its superclasses, up through mostGenericClass" > > | otherClassCategories thisClassCategories combinedClassCategories | > otherClassCategories := OrderedCollection new. > self allSuperclasses > do: [ :aClass | > (aClass includesBehavior: mostGenericClass) > ifTrue: [ otherClassCategories addAll: aClass organization categories ] ]. > otherClassCategories remove: 'no messages' asSymbol ifAbsent: [ ]. > thisClassCategories := self organization categories asSortedCollection: [ :a :b | a asLowercase ^ Array > streamContents: [ :stream | > stream > nextPutAll: thisClassCategories; > nextPutAll: > ((otherClassCategories asSet removeAllSuchThat: [ :each | thisClassCategories includes: each ]) > asSortedCollection: [ :a :b | a asLowercase <ClassDescription-allMethodCategoriesIntegratedThrough.st>

Nov. 1, 2012

Re: [Pharo-project] differently organized method categories in the Debugger dnu: create process

by Marcus Denker

Hello, To make this easy to review and integrate, what is the best is the following 1) add an issue to the issue tracker. http://code.google.com/p/pharo/issues/list I did it for this already for your report (to not forget it): http://code.google.com/p/pharo/issues/detail?id=6896 2) to take advantage of an automatic test robot, attach a Slice to the bug report After having added the report, this is easy. In a fresh image: -> do the change (e.g. load the .cs or .st) -> open Monticello -> Press the +Slice button -> put the issue number 6896 into the field and press "grab" -> select the slice and save it to the inbox -> put status to "FixReviewNeeded" or wait until someone else does it -> The famous monkey will load your slice and run all tests to see if you managed to break something essential. Integration (or rejection) will happen quite fast after this (within 24 hours often, within some days for sure). Marcus On Nov 1, 2012, at 9:32 PM, Paul DeBruicker <pdebruic(a)gmail.com> wrote: > Hi- > > When I create methods using the Debugger's 'Create' button I am never sure which categories are used in the class I'm adding the method to versus those in its super classes. In an effort to not have to think about that any more I've adapted the ClassDescription>>#allMethodCategoriesIntegratedThrough: to put the method categories that are used in the target class first, then those in the super classes after that. > > > I think this should work in Pharo and Squeak but I've only tested it in Pharo 1.4. I've attached a changeset and also pasted the method below > > > Paul > > > allMethodCategoriesIntegratedThrough: mostGenericClass > "Answer a list of all the method categories of the receiver and all its superclasses, up through mostGenericClass" > > | otherClassCategories thisClassCategories combinedClassCategories | > otherClassCategories := OrderedCollection new. > self allSuperclasses > do: [ :aClass | > (aClass includesBehavior: mostGenericClass) > ifTrue: [ otherClassCategories addAll: aClass organization categories ] ]. > otherClassCategories remove: 'no messages' asSymbol ifAbsent: [ ]. > thisClassCategories := self organization categories asSortedCollection: [ :a :b | a asLowercase ^ Array > streamContents: [ :stream | > stream > nextPutAll: thisClassCategories; > nextPutAll: > ((otherClassCategories asSet removeAllSuchThat: [ :each | thisClassCategories includes: each ]) > asSortedCollection: [ :a :b | a asLowercase <ClassDescription-allMethodCategoriesIntegratedThrough.st> -- Marcus Denker -- http://marcusdenker.de

Nov. 1, 2012