- Pharo-dev - lists.pharo.org

Re: [Pharo-project] Vim Keys?

by Goubier Thierry

Le 03/12/2012 13:31, Camillo Bruni a Ã©crit : >> Well, it's allmost there. The only thing that I didn't manage to push was the removal of the global, class-linked maps (it was rejected)... This is the only step missing for your vim shortcuts to work. > > Maybe I can revive the discussion here, sadly it died on the tracker :/. > I would really love to see your changes in the image! > However it slightly (changes/breaks depending on the viewer :P) some focus-cycling in certain tools. There is two different issues : vim-like shortcuts and focus. First, vim-like (and emacs, and whatever); this requires cutting off matching of the default shortcuts (since those often conflicts). These defaults being non configurable, Sean (for vim) and I (for my dynamically loaded / matched to current menu shortcuts), had to disconnect from matching the default class-based keymaps by on-the-fly patching of a target Morph KMDispatcher :() Hugly hack, this one. Second, keyboard focus navigation. First, what I did is the following : correct a bug or two in the Morphic based focus navigation code. And, second, move the focus navigation shortcuts to Keymapping. Nothing else. However, this exposed one fact about Morphic: that the way to add submorphs is LIGT (Last In Goes to Top i.e: in front of the previous submorphs). This is great for a drawing editor, and bad for an UI design tool, such as Spec. So Spec loads in an apparent reverse order (at least relative to the focus order), and this is what you see. > Is there a way to come up with a more or less compatible things as the focus list? > Aka a nice and simple interface on top of your changes to achieve the same thing? Yes. Just have Spec use on:do: (or load the right keymap) for focus change, instead of using eventHandler. I do believe this change is just around the corner... Once this is done, any focus order you set in Spec will apply first when focus tabbing. However, you may then see design faults : if you forget one element in your focus ordering in Spec, you will never manage to focus it by the keyboard. Whereas the Morphic one will always tab through all elements whatever way you build the GUI. IMO, the best would be Spec being able to order submorphs correctly and to then rely on the Morphic focus code. But there must be a good reason for Spec not doing it. I just don't know why? I tried changing a bit Spec for that (changing the default ordering where I could see it, then changing a few Specs here and there to make sure the GUI would build and tab right) and couldn't find anything wrong with it, but I just checked on a few GUI samples. (This is also because the focus switch code in Morphic is a lot shorter than the Spec one, and I tend to believe the shorter the better (and no duplication). But that's just me:)). > We desperately need this refactoring, and if we don't use it, just because of the focus list, I think it will take another year until they make it into the image :( I thought it was integrated. I'll check. It is integrated; what I guess is missing is the Spec override. Thierry -- Thierry Goubier CEA list Laboratoire des Fondations des SystÃ¨mes Temps RÃ©el EmbarquÃ©s 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95

Dec. 3, 2012

Re: [Pharo-project] Vim Keys?

by Camillo Bruni

> Well, it's allmost there. The only thing that I didn't manage to push was the removal of the global, class-linked maps (it was rejected)... This is the only step missing for your vim shortcuts to work. Maybe I can revive the discussion here, sadly it died on the tracker :/. I would really love to see your changes in the image! However it slightly (changes/breaks depending on the viewer :P) some focus-cycling in certain tools. Is there a way to come up with a more or less compatible things as the focus list? Aka a nice and simple interface on top of your changes to achieve the same thing? We desperately need this refactoring, and if we don't use it, just because of the focus list, I think it will take another year until they make it into the image :(

Dec. 3, 2012

Re: [Pharo-project] Performance Tip: Using buffered streams

by Sven Van Caekenberghe

On 03 Dec 2012, at 12:22, Henrik Sperre Johansen <henrik.s.johansen(a)veloxit.no> wrote: > In other words, to get comparable runtimes, you'd have to include a ZnEncodedStream doing UTF-8 decoding on top of the stack used by the STON-reader. There are ZnCharacterReadStream and ZnCharacterWriteStream that add decoding/encoding to binary streams. They could indeed be used as an alternative. But that was not my point. > (At which point you're well on the way to reimplementing the modular streams of Xtreams, but with a more traditional API :) ) Many people, including myself are interested in Xtreams - many fun things will happen in the future ;-) -- Sven Van Caekenberghe http://stfx.eu Smalltalk is the Red Pill

Dec. 3, 2012

Re: [Pharo-project] Performance Tip: Using buffered streams

by Sven Van Caekenberghe

Hendrik, Thanks for entering this discussion, it is important territory, for many users. We should get the basics right. On 03 Dec 2012, at 12:10, Henrik Sperre Johansen <henrik.s.johansen(a)veloxit.no> wrote: > The reduced read times you are seeing, is lack of decoding, not lack of buffering. I should have been more clear: it is a combination of buffering & decoding (see further). > BufferedReadStream uses readInto:startingAt:count:, which isn't reimplemented for MultiByteFileStream to do proper decoding, and thus inherits the one from StandardFileStream. If that is so (and it seems to be the case), then that is an important bug, wouldn't you agree ? > The filestreams already do read buffering (albeit with a smaller buffer size), so when Fuel uses binary mode (which skips decoding), the performance is pretty much the same. Yeah, in binary mode, MultiByteFilestream does not do encoding. Still, IMO that is not the only reason for the difference. However, even when I go straight to MultiByteFilestream's superclass, StandardFileStream, which does not do decoding, the additional buffering helps a lot: [ StandardFileStream fileNamed: '/tmp/numbers.json' do: [ :stream | (NeoJSONReader on: stream) next ] ] timeToRun 2869 [ StandardFileStream fileNamed: '/tmp/numbers.json' do: [ :fstream | ZnBufferedReadStream on: fstream do: [ :stream | (NeoJSONReader on: stream) next ] ] ] timeToRun 1280 I said from the start that the access pattern matters: parser code is a sweet spot here. Sven -- Sven Van Caekenberghe http://stfx.eu Smalltalk is the Red Pill

Dec. 3, 2012

Re: [Pharo-project] Performance Tip: Using buffered streams

by Henrik Sperre Johansen

On 03.12.2012 12:10, Henrik Sperre Johansen wrote: > On 03.12.2012 09:30, Sven Van Caekenberghe wrote: >> On 03 Dec 2012, at 07:25, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >> >>> Hi Mariano, >>> >>> On 02 Dec 2012, at 23:43, Mariano Martinez Peck >>> <marianopeck(a)gmail.com> wrote: >>> >>>> This is really really interesting, because it means a speed up of >>>> 2x when reading :) >>>> Where can I get the last version of ZnBufferedReadStream? >>> I knew you would be interested: it is in the latest Zn, either >>> http://mc.stfx.eu or squeaksource (not in the metacello yet). >>> It should work on binary streams too, I don't know whether it would >>> make a lot of difference, I would guess so. >>> Maybe Fuel uses lots of 'deterministic reading' (size prefixed) >>> instead of parsing. >> Well, I just tried. The good news is, it works, the bad news is, it >> does not make a difference, either way: >> >> | data | >> data := STONTestMap classTreeExtended. >> [ FLSerializer serialize: data toFileNamed: '/tmp/all.fuel' ] >> timeToRun. 4967 >> >> [ FLMaterializer materializeFromFileNamed: '/tmp/all.fuel' ] >> timeToRun. 1095 >> >> [ '/tmp/all.fuel' asFileReference readStreamDo: [ :fstream | >> ZnBufferedReadStream on: fstream binary do: [ :stream | >> FLMaterializer newDefault materializeFrom: stream ] ] ] >> timeToRun. 1043 >> >> So I guess Fuel is already pretty optimised, especially for reading ;-) >> >> I think ZnBufferedReadStream only makes a difference for parsers that >> are sending lots of little #next, #peek and #atEnd messages in loops. >> Binary protocols are typically more deterministic, they know ahead >> what they have to read and don't have to do #peek or #atEnd tests all >> the time. >> >> Sven >> >> -- >> Sven Van Caekenberghe >> http://stfx.eu >> Smalltalk is the Red Pill > The reduced read times you are seeing, is lack of decoding, not lack > of buffering. > > BufferedReadStream uses readInto:startingAt:count:, which isn't > reimplemented for MultiByteFileStream to do proper decoding, and thus > inherits the one from StandardFileStream. > > The filestreams already do read buffering (albeit with a smaller > buffer size), so when Fuel uses binary mode (which skips decoding), > the performance is pretty much the same. > > Cheers, > Henry In other words, to get comparable runtimes, you'd have to include a ZnEncodedStream doing UTF-8 decoding on top of the stack used by the STON-reader. (At which point you're well on the way to reimplementing the modular streams of Xtreams, but with a more traditional API :) ) Cheers, Henry

Dec. 3, 2012

Re: [Pharo-project] Performance Tip: Using buffered streams

by Henrik Sperre Johansen

On 03.12.2012 09:30, Sven Van Caekenberghe wrote: > On 03 Dec 2012, at 07:25, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > >> Hi Mariano, >> >> On 02 Dec 2012, at 23:43, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: >> >>> This is really really interesting, because it means a speed up of 2x when reading :) >>> Where can I get the last version of ZnBufferedReadStream? >> I knew you would be interested: it is in the latest Zn, either http://mc.stfx.eu or squeaksource (not in the metacello yet). >> It should work on binary streams too, I don't know whether it would make a lot of difference, I would guess so. >> Maybe Fuel uses lots of 'deterministic reading' (size prefixed) instead of parsing. > Well, I just tried. The good news is, it works, the bad news is, it does not make a difference, either way: > > | data | > data := STONTestMap classTreeExtended. > [ FLSerializer serialize: data toFileNamed: '/tmp/all.fuel' ] timeToRun. 4967 > > [ FLMaterializer materializeFromFileNamed: '/tmp/all.fuel' ] timeToRun. 1095 > > [ '/tmp/all.fuel' asFileReference readStreamDo: [ :fstream | > ZnBufferedReadStream on: fstream binary do: [ :stream | > FLMaterializer newDefault materializeFrom: stream ] ] ] timeToRun. 1043 > > So I guess Fuel is already pretty optimised, especially for reading ;-) > > I think ZnBufferedReadStream only makes a difference for parsers that are sending lots of little #next, #peek and #atEnd messages in loops. Binary protocols are typically more deterministic, they know ahead what they have to read and don't have to do #peek or #atEnd tests all the time. > > Sven > > -- > Sven Van Caekenberghe > http://stfx.eu > Smalltalk is the Red Pill The reduced read times you are seeing, is lack of decoding, not lack of buffering. BufferedReadStream uses readInto:startingAt:count:, which isn't reimplemented for MultiByteFileStream to do proper decoding, and thus inherits the one from StandardFileStream. The filestreams already do read buffering (albeit with a smaller buffer size), so when Fuel uses binary mode (which skips decoding), the performance is pretty much the same. Cheers, Henry

Dec. 3, 2012

Re: [Pharo-project] Vim Keys?

by Goubier Thierry

Le 01/12/2012 18:10, Sean P. DeNigris a Ã©crit : > Igor Stasenko wrote >> Pharo is open-source project. If you need it so >> badly, then do it > > +100. This is really all there is to say. I *really* want vi bindings, > because I am far more productive with them, so I started coding them > (http://ss3.gemstone.com/ss/VimPharo.html) Yes, and I looked at that and my own shortcuts code, and I tried to push compatible changes. > <rant> > Of course, the instant I touched Paragraph/XxxEditor, and friends I got lost > down the rabbit hole of incomprehensibility... like Paragraph, which draws > the cursor and keeps track of the selection, obviously... not! wtf ?! > > Quick definition... > paragraph |ËparÉËgraf| > noun > a distinct section of a piece of writing, usually dealing with a single > theme and indicated by a new line, indentation, or numbering. > > Where, tell me, does it say anything about cursors and selections?? > </rant> > > But Pharo is: > - a gift > - infinitely better than anything else I've ever worked with > - and I've been told that the editor objects have been cleaned and were > originally way more confusing > So it is what it is. > > I'm taking a break, and will get back to it eventually. Any help is welcome > and appreciated. Well, it's allmost there. The only thing that I didn't manage to push was the removal of the global, class-linked maps (it was rejected)... This is the only step missing for your vim shortcuts to work. (there is a question about doing global shortcuts without those global maps... I described how to define them as shortcuts on the world morph instead, but I'm not sure my design is sound). Thierry -- Thierry Goubier CEA list Laboratoire des Fondations des SystÃ¨mes Temps RÃ©el EmbarquÃ©s 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95

Dec. 3, 2012

Re: [Pharo-project] Performance Tip: Using buffered streams

by Sven Van Caekenberghe

On 03 Dec 2012, at 07:25, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > Hi Mariano, > > On 02 Dec 2012, at 23:43, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: > >> This is really really interesting, because it means a speed up of 2x when reading :) >> Where can I get the last version of ZnBufferedReadStream? > > I knew you would be interested: it is in the latest Zn, either http://mc.stfx.eu or squeaksource (not in the metacello yet). > It should work on binary streams too, I don't know whether it would make a lot of difference, I would guess so. > Maybe Fuel uses lots of 'deterministic reading' (size prefixed) instead of parsing. Well, I just tried. The good news is, it works, the bad news is, it does not make a difference, either way: | data | data := STONTestMap classTreeExtended. [ FLSerializer serialize: data toFileNamed: '/tmp/all.fuel' ] timeToRun. 4967 [ FLMaterializer materializeFromFileNamed: '/tmp/all.fuel' ] timeToRun. 1095 [ '/tmp/all.fuel' asFileReference readStreamDo: [ :fstream | ZnBufferedReadStream on: fstream binary do: [ :stream | FLMaterializer newDefault materializeFrom: stream ] ] ] timeToRun. 1043 So I guess Fuel is already pretty optimised, especially for reading ;-) I think ZnBufferedReadStream only makes a difference for parsers that are sending lots of little #next, #peek and #atEnd messages in loops. Binary protocols are typically more deterministic, they know ahead what they have to read and don't have to do #peek or #atEnd tests all the time. Sven -- Sven Van Caekenberghe http://stfx.eu Smalltalk is the Red Pill

Dec. 3, 2012

Re: [Pharo-project] Vim Keys?

by Goubier Thierry

Le 01/12/2012 18:59, StÃ©phane Ducasse a Ã©crit : > What we want is to clean all the hardcoded short cut and rethink all the them using key mapper > Then people can define some maps and install them at wish. TextMorph apart, this is not that difficult and it can be done Morph by Morph without disrupting the system... Volunteers, please! (I did it for SimpleHierarchicalListMorph and that has been integrated, but I now noticed I haven't finished removing the old, hardcoded shortcuts code :( ). > For example I miss end of line start of line (emacs like :)). > I would like to have esc esc to select an expression > so that I can do esc esc + cmd D and get done :) > > Stef Any suggestions on a global scheme for user-configurable keymaps ? Thierry -- Thierry Goubier CEA list Laboratoire des Fondations des SystÃ¨mes Temps RÃ©el EmbarquÃ©s 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95

Dec. 3, 2012

Re: [Pharo-project] Performance Tip: Using buffered streams

by drush66

Sven Van Caekenberghe-2 wrote > Hi Mariano, > > On 02 Dec 2012, at 23:43, Mariano Martinez Peck < > marianopeck@ > > wrote: > >> This is really really interesting, because it means a speed up of 2x when >> reading :) >> Where can I get the last version of ZnBufferedReadStream? > > I knew you would be interested: it is in the latest Zn, either > http://mc.stfx.eu or squeaksource (not in the metacello yet). > It should work on binary streams too, I don't know whether it would make a > lot of difference, I would guess so. > Maybe Fuel uses lots of 'deterministic reading' (size prefixed) instead of > parsing. > > Sven > > -- > Sven Van Caekenberghe > http://stfx.eu > Smalltalk is the Red Pill Did you (or anybody else for that matter) tried to use persistent arrays as base for in memory streeams? They are basically shallow tree that provides array like access. Their claim to fame is that one can avoid copy operation when array gets resized. So it _might_ be usable when one handles large write streams and does not know in advance how large they will get. ----- http://www.cloud208.com/ -- View this message in context: http://forum.world.st/Performance-Tip-Using-buffered-streams-tp4657739p4657… Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Dec. 3, 2012