- Pharo-dev - lists.pharo.org

Re: [Pharo-project] [Jenkins] Old Jenkins has been turned off

by StÃ©phane Ducasse

Thanks a lot for all the efforts. I'm convinced that it will really pay off. Stef On Jan 31, 2013, at 8:55 AM, Marcus Denker wrote: > Hi, > > The migration is done! > > The old jenkins now is officially turned off, and we are running on the new one: > > https://ci.inria.fr/pharo/ > > Of course, like all move, there are some collaterals to fix, but the first milestone has > been passed. > > TODO: > -> Get the broken builds running > -> fix VM builds > -> use staging for the image and the vm later... > > Things we will seeâ¦ > > -> Virtualized Mac Slaves > -> A second Jenkins for community projects > -> More slaves to speed up builds > > and much more. > > Marcus

Jan. 31, 2013

Re: [Pharo-project] OrderedIdentityDictionary in a more general package

by Tudor Girba

Does anyone know the difference between: - OrderedIdentityDictionary from Spec and - OrderPreservingDictionary from http://www.squeaksource.com/OrderPreservingDict ? we use the latter in XMLSupport and I think we could probably consolidate. Doru On Thu, Jan 31, 2013 at 9:38 AM, Esteban Lorenzano <estebanlm(a)gmail.com>wrote: > ... and we need Spec as a project under team Pharo, in sthub :) > > On Jan 31, 2013, at 8:28 AM, "Torsten Bergmann" <astares(a)gmx.de> wrote: > > > Stef wrote: > >> good idea. > >> Do you know the test coverage of the class? > >> Because it would be nice to run hapao on it and write some tests if > there are none. > > > > Actually there are no tests - at least not in the Pharo image. > > Maybe Benjamin can comment if there are some tests in the Spec universe > for it. > > > > I opened an issue: http://code.google.com/p/pharo/issues/detail?id=7374 > > > > @Benjamin: can you move "OrderedIdentityDictionary" it out of Spec up to > a > > more general "Collection-Ordered" category/package for Pharo? > > I dont want to interfere with current Spec development and > > have no rights to commit to http://ss3.gemstone.com/ss/Spec > > > > BTW: Is it really necessary to have an mzc per "Collection-***" > category? Dont > > know about the dependencies - but for Kernel we have only one package > (and one > > for the tests). > > > > Thx > > T. > > > > > > > > > -- www.tudorgirba.com "Every thing has its own flow"

Jan. 31, 2013

Re: [Pharo-project] help needed

by StÃ©phane Ducasse

Usman did you check with 1.3 to know if the method was there? Stef On Jan 31, 2013, at 7:03 AM, Usman Bhatti wrote: > > > > On Thu, Jan 31, 2013 at 2:30 AM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Morbid fascination > It is late so I may completely off but > how many isKindOf: are executed in this method? > > > ((aSymbol isKindOf: Array) > > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > > aSymbol second == #openPath]]]) > > when [aSymbol second == #openPath] is not openPath > then we go to the next (not mentioning duplicated code inside the method ---- I will vomit) > and we restart to execute isKindOf: > > ((aSymbol isKindOf: Array) > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > aSymbol second == #expandAllFromNode:]]]) > > Am'I right? > It looks so terrible. > > Yes. And more so for someone not frequently working with Morphs. > So, can someone at least see if the problem can be fixed without a large refactoring that should surely happen, but the glamour bug needs a quick fix. Or at least point to why the missing method on the receiver is abundantly found in the code? > > usman > > > Stef > > > > > update: aSymbol > > aSymbol == #selection ifTrue: [^ self listManager updateSelectionFromModel]. > > ((aSymbol isKindOf: Array) and: [aSymbol size > 1 and: [aSymbol first == #selectItems and: [aSymbol second isCollection]]]) > > ifTrue: [^ self selectedItems: aSymbol second]. > > aSymbol == self nodeListSelector ifTrue: [^ self updateList]. > > aSymbol == #selectAll ifTrue: [^ self listManager selectAll]. > > aSymbol == #deselectAll ifTrue: [^ self listManager deselectAll]. > > ((aSymbol isKindOf: Array) > > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > > aSymbol second == #openPath]]]) "allow directed path opening where multiple trees exist" > > ifTrue: > > [^(self allNodeMorphs at: 1 ifAbsent: [^self]) > > openPath: (aSymbol allButFirst: 2)]. > > ((aSymbol isKindOf: Array) > > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > > aSymbol second == #openItemPath]]]) "allow directed path opening where multiple trees exist" > > ifTrue: > > [^ (self allNodeMorphs at: 1 ifAbsent: [^self]) > > openItemPath: (aSymbol allButFirst: 2)]. > > ((aSymbol isKindOf: Array) > > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > > aSymbol second == #expandAllFromNode:]]]) > > ifTrue: > > [^ self expandAllFromNode: aSymbol third]. > > ((aSymbol isKindOf: Array) > > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > > aSymbol second == #closeItemPath]]]) "allow directed path closing where multiple trees exist" > > ifTrue: > > [^ (self allNodeMorphs at: 1 ifAbsent: [^self]) > > closeItemPath: (aSymbol allButFirst: 2)]. > > ((aSymbol isKindOf: Array) > > and: [aSymbol notEmpty and: [aSymbol first == #openPath]]) > > ifTrue: > > [^(self allNodeMorphs at: 1 ifAbsent: [^self]) > > openPath: aSymbol allButFirst]. > > ((aSymbol isKindOf: Array) > > and: [aSymbol size = 2 and: [aSymbol first = self nodeListSelector and: [ > > aSymbol second == #expandRoots]]]) > > ifTrue: > > [^self expandRoots]. > > ((aSymbol isKindOf: Array) > > and: [aSymbol size = 2 and: [aSymbol first = self nodeListSelector]]) > > ifTrue: [aSymbol second = #expandAll ifTrue: [^ self expandAll]. > > aSymbol second = #collapseAll ifTrue: [^ self collapseAll]] > > >

Jan. 31, 2013

Re: [Pharo-project] OrderedIdentityDictionary in a more general package

by StÃ©phane Ducasse

Ok so it would be good to address the issue. We should get better and larger collection choice. Since you already add a look could you check it again. Stef On Jan 31, 2013, at 5:49 AM, ClÃ©ment Bera wrote: > Actually this was in the bug tracker > > http://code.google.com/p/pharo/issues/detail?id=2759&can=1&q=orderedDiction… > > error 2759 > > This OrderedIdentityDictionary is only used for user interface that is why it is on Spec-Core for now. See the bug report for more details. > > 2013/1/31 StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> > > On Jan 30, 2013, at 4:44 PM, Torsten Bergmann wrote: > > > The class "OrderedIdentityDictionary" is currently defined in package "Spec-Core". > > > > Since it is useful also in other scenarios and I do not want a dependency > > on spec: wouldnt it make sense to move it to a more common "Collections-..." > > package. > > good idea. > Do you know the test coverage of the class? > Because it would be nice to run hapao on it and write some tests if there are none. > > > > > Since there is already "Collections-Unordered" I would suggest to put it > > into "Collections-Ordered". > > Mmmhh ... but then class OrderedCollection would have to move from "Collections-Sequenceable" > > to "Collections-Ordered" as well (at least from the name). > > > > Any comments on that... > > > > Thx > > T. > > > > >

Jan. 31, 2013

Re: [Pharo-project] [Jenkins] Old Jenkins has been turned off

by Sven Van Caekenberghe

On 31 Jan 2013, at 12:55, Marcus Denker <marcus.denker(a)inria.fr> wrote: > Hi, > > The migration is done! > > The old jenkins now is officially turned off, and we are running on the new one: > > https://ci.inria.fr/pharo/ > > Of course, like all move, there are some collaterals to fix, but the first milestone has > been passed. > > TODO: > -> Get the broken builds running > -> fix VM builds > -> use staging for the image and the vm later... > > Things we will seeâ¦ > > -> Virtualized Mac Slaves > -> A second Jenkins for community projects Cool! > -> More slaves to speed up builds > > and much more. > > Marcus Yes, thanks a lot for taking care: these things take a *lot* of effort. Sven -- Sven Van Caekenberghe http://stfx.eu Smalltalk is the Red Pill

Jan. 31, 2013

Re: [Pharo-project] [Jenkins] Old Jenkins has been turned off

by Tudor Girba

Much more?! Impressive. Thank you for all the effort. Cheers, Doru On Thu, Jan 31, 2013 at 12:55 PM, Marcus Denker <marcus.denker(a)inria.fr>wrote: > Hi, > > The migration is done! > > The old jenkins now is officially turned off, and we are running on the > new one: > > https://ci.inria.fr/pharo/ > > Of course, like all move, there are some collaterals to fix, but the first > milestone has > been passed. > > TODO: > -> Get the broken builds running > -> fix VM builds > -> use staging for the image and the vm later... > > Things we will seeâ¦ > > -> Virtualized Mac Slaves > -> A second Jenkins for community projects > -> More slaves to speed up builds > > and much more. > > Marcus > -- www.tudorgirba.com "Every thing has its own flow"

Jan. 31, 2013

[Pharo-project] [Jenkins] Old Jenkins has been turned off

by Marcus Denker

Hi, The migration is done! The old jenkins now is officially turned off, and we are running on the new one: https://ci.inria.fr/pharo/ Of course, like all move, there are some collaterals to fix, but the first milestone has been passed. TODO: -> Get the broken builds running -> fix VM builds -> use staging for the image and the vm later... Things we will seeâ¦ -> Virtualized Mac Slaves -> A second Jenkins for community projects -> More slaves to speed up builds and much more. Marcus

Jan. 31, 2013

Re: [Pharo-project] I hate 'as yet unclassified'

by S Krish

Auto categorization in the old browser: " Categorize all uncategorized " had simple rules especially overridden methods / known methods in their known categories.. That would help greatly for most developers, more so the beginners to get a good feel of recommended categorization. But can auto categorization cause wrong labeling may need to weighed, better to leave it uncategorized in that case. **************** PS: At work on a VAGE code, I was pointing to the exact same issue of missing categorization over last many years..!.. The lack of categorization limits comprehension of the codebase... especially of code built over 20 yrs. On Thursday, January 31, 2013, Camillo Bruni wrote: > > On 2013-01-31, at 03:53, Ben Coman <btc(a)openInWorld.com> wrote: > > > > > Camillo Bruni wrote: > >> I was just waiting for the google issue tracker to come back to life... > >> > >> https://code.google.com/p/pharo/issues/detail?id=7373 > >> > >> => Slice in Inbox > >> > >> the major problem I have now, is that wrong categorizations might > easily spread :P, the sepll-fleu and the space - vi rus, are very common... > >> > >> > > > > Can the auto-categorization mark such methods as "auto-categorized" ? > So that later if it doesn't seem quite right, a human can make a better > judgment rather than assuming someone else had already made such a judgment > for some-good-reason. In reality perhaps such re-categorization wouldn't > happen a lot, but "being at least able to" make such judgment increases > confidence in the system, which can be subtly undermined by automated tools > (and anyway I hate throwing away information that is easily available at > the time). This wouldn't need any tool support straight away, but at least > the data is captured for later use. > > the categorization will happen only upon user interaction. > hence I think such a control is not needed directly. > Feel free to extend the current classifier to support it, the code is > fairly simple.. >

Jan. 31, 2013

Re: [Pharo-project] [update 2.0] #20500

by Sven Van Caekenberghe

On 31 Jan 2013, at 10:24, Marcus Denker <marcus.denker(a)inria.fr> wrote: > 20500 > ----- Lovely version number ;-) This calls for a little virtual celebration ! Thanks everybody for all the hard work. > Issue 7360: Tests for FillStyle > http://code.google.com/p/pharo/issues/detail?id=7360 > > Issue 7197: Not running RBSpellCheckerTest? > http://code.google.com/p/pharo/issues/detail?id=7197 > > Issue 7340: Failing test: ClassHierarchyTest>>testSubclasses > http://code.google.com/p/pharo/issues/detail?id=7340 > > Issue 7126: RBParser can not parse the whole image... > http://code.google.com/p/pharo/issues/detail?id=7126 > > > Diff information: > http://ss3.gemstone.com/ss/Pharo20/KernelTests-MarcusDenker.468.diff > http://ss3.gemstone.com/ss/Pharo20/Balloon-MarcusDenker.89.diff > http://ss3.gemstone.com/ss/Pharo20/AST-Tests-Core-MarcusDenker.19.diff > http://ss3.gemstone.com/ss/Pharo20/AST-Core-MarcusDenker.113.diff

Jan. 31, 2013

Re: [Pharo-project] zn url with passwords

by Camillo Bruni

On 2013-01-31, at 10:58, Damien Cassou <damien.cassou(a)gmail.com> wrote: > On Wed, Jan 30, 2013 at 7:50 PM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >> >> I added this (in bleedingEdge) so that >> >> 'git://user@foo.com/bar' asZnUrl >> >> works as expected. > > > thank you so much Sven! nice ;)

Jan. 31, 2013