- Pharo-dev - lists.pharo.org

Re: [Pharo-project] daylight savings issues

by Frank Shearar

On 1 February 2013 09:39, Camillo Bruni <camillobruni(a)gmail.com> wrote: > > On 2013-02-01, at 10:33, Otto Behrens <otto(a)finworks.biz> wrote: > >>>> We're not on 2.0 yet and are running on GemStone. Our dates are in a >>>> local time zone currently, how do we "work" with UTC dates and make >>>> sure the outside world see the correct date / time? >>> >>> Most probably you will get away with it, by only displaying dates/times in >>> local time zones, but make sure everything internally uses UTC (without daylight >>> saving times). >>> >>> So you only have to be careful with when inputting data and when displaying. >>> Everything that is relative (like your example) will work out of the box. >> >> This feels painful. I suppose we'll have to hunt for Dates in the >> system and migrate them. And then change our subclass of >> MADateDescription (we use a date picker) to convert to & from the >> local time zone. And then we have a few timestamps, which is indeed >> time zone sensitive. > > Basically everything will work fine until the point your image crosses time-zones. > Just be careful ;) I burnt my fingers more than once while fixing this mess :P > > >> I feel the need for a timezone agnostic Date. But I suppose working >> with time and duration may complicate things. > > yeah, we reached that conclusion at the point we tried to fully grasp the scale > of the problem. So now we have everything internally in UTC, which simplifies a lot. Sticking with UTC everywhere internally, converting local time -> UTC on input, and only displaying local time, is the one true way. All else is madness. frank >> Thanks for the help. >> >>>> How do I write a test for this? >>> >>> I presume to properly reproduce the problem you would have to change the os system-timezone >>> during a test. Which you could achieve with OSProcess :/ >> >> Eeeuw, ok >> > >

Feb. 1, 2013

Re: [Pharo-project] daylight savings issues

by Camillo Bruni

On 2013-02-01, at 10:33, Otto Behrens <otto(a)finworks.biz> wrote: >>> We're not on 2.0 yet and are running on GemStone. Our dates are in a >>> local time zone currently, how do we "work" with UTC dates and make >>> sure the outside world see the correct date / time? >> >> Most probably you will get away with it, by only displaying dates/times in >> local time zones, but make sure everything internally uses UTC (without daylight >> saving times). >> >> So you only have to be careful with when inputting data and when displaying. >> Everything that is relative (like your example) will work out of the box. > > This feels painful. I suppose we'll have to hunt for Dates in the > system and migrate them. And then change our subclass of > MADateDescription (we use a date picker) to convert to & from the > local time zone. And then we have a few timestamps, which is indeed > time zone sensitive. Basically everything will work fine until the point your image crosses time-zones. Just be careful ;) I burnt my fingers more than once while fixing this mess :P > I feel the need for a timezone agnostic Date. But I suppose working > with time and duration may complicate things. yeah, we reached that conclusion at the point we tried to fully grasp the scale of the problem. So now we have everything internally in UTC, which simplifies a lot. > Thanks for the help. > >>> How do I write a test for this? >> >> I presume to properly reproduce the problem you would have to change the os system-timezone >> during a test. Which you could achieve with OSProcess :/ > > Eeeuw, ok >

Feb. 1, 2013

Re: [Pharo-project] daylight savings issues

by Otto Behrens

>> We're not on 2.0 yet and are running on GemStone. Our dates are in a >> local time zone currently, how do we "work" with UTC dates and make >> sure the outside world see the correct date / time? > > Most probably you will get away with it, by only displaying dates/times in > local time zones, but make sure everything internally uses UTC (without daylight > saving times). > > So you only have to be careful with when inputting data and when displaying. > Everything that is relative (like your example) will work out of the box. This feels painful. I suppose we'll have to hunt for Dates in the system and migrate them. And then change our subclass of MADateDescription (we use a date picker) to convert to & from the local time zone. And then we have a few timestamps, which is indeed time zone sensitive. I feel the need for a timezone agnostic Date. But I suppose working with time and duration may complicate things. Thanks for the help. >> How do I write a test for this? > > I presume to properly reproduce the problem you would have to change the os system-timezone > during a test. Which you could achieve with OSProcess :/ Eeeuw, ok

Feb. 1, 2013

Re: [Pharo-project] daylight savings issues

by Camillo Bruni

On 2013-02-01, at 09:17, Otto Behrens <otto(a)finworks.biz> wrote: > Hi, > > We do some calculations based on the number of days elapsed between > two dates, by doing (date1 - date2) days * something. If these dates > span over a daylight savings switch over, we get one day less, because > the duration (result from date1 - date2) has 23 hours (+a number of > days). > > So, do we solve this kind of thing by working with UTC dates only? I > read on the mailing list some changes in Pharo 2.0 made by Camiillo > and http://forum.world.st/Should-Dates-be-Timezone-specific-td3647678.html. > We're not on 2.0 yet and are running on GemStone. Our dates are in a > local time zone currently, how do we "work" with UTC dates and make > sure the outside world see the correct date / time? Most probably you will get away with it, by only displaying dates/times in local time zones, but make sure everything internally uses UTC (without daylight saving times). So you only have to be careful with when inputting data and when displaying. Everything that is relative (like your example) will work out of the box. > How do I write a test for this? I presume to properly reproduce the problem you would have to change the os system-timezone during a test. Which you could achieve with OSProcess :/ > Here's an example of such a calculation: > > returnFromPrice: fromPrice toPrice: toPrice > | days | > days := (toPrice date - fromPrice date) days. > ^ (toPrice value / fromPrice value raisedTo: 365.25 / days) - 1 > > My issue is that the tests run in an environment without daylight > savings. The customer is in a timezone with daylight savings. > > Thanks > Otto >

Feb. 1, 2013

[Pharo-project] daylight savings issues

by Otto Behrens

Hi, We do some calculations based on the number of days elapsed between two dates, by doing (date1 - date2) days * something. If these dates span over a daylight savings switch over, we get one day less, because the duration (result from date1 - date2) has 23 hours (+a number of days). So, do we solve this kind of thing by working with UTC dates only? I read on the mailing list some changes in Pharo 2.0 made by Camiillo and http://forum.world.st/Should-Dates-be-Timezone-specific-td3647678.html. We're not on 2.0 yet and are running on GemStone. Our dates are in a local time zone currently, how do we "work" with UTC dates and make sure the outside world see the correct date / time? How do I write a test for this? Here's an example of such a calculation: returnFromPrice: fromPrice toPrice: toPrice | days | days := (toPrice date - fromPrice date) days. ^ (toPrice value / fromPrice value raisedTo: 365.25 / days) - 1 My issue is that the tests run in an environment without daylight savings. The customer is in a timezone with daylight savings. Thanks Otto

Feb. 1, 2013

Re: [Pharo-project] OrderedIdentityDictionary in a more general package

by Tudor Girba

Ok, I created a bug entry: http://code.google.com/p/pharo/issues/detail?id=7384 Cheers, Doru On Jan 31, 2013, at 10:18 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > I do not know > but indeed it would be good to have one good one instead of three half > > Stef > > On Jan 31, 2013, at 9:40 AM, Tudor Girba wrote: > >> Does anyone know the difference between: >> - OrderedIdentityDictionary from Spec and >> - OrderPreservingDictionary from http://www.squeaksource.com/OrderPreservingDict >> >> ? >> >> we use the latter in XMLSupport and I think we could probably consolidate. >> >> Doru >> >> >> On Thu, Jan 31, 2013 at 9:38 AM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: >> ... and we need Spec as a project under team Pharo, in sthub :) >> >> On Jan 31, 2013, at 8:28 AM, "Torsten Bergmann" <astares(a)gmx.de> wrote: >> >>> Stef wrote: >>>> good idea. >>>> Do you know the test coverage of the class? >>>> Because it would be nice to run hapao on it and write some tests if there are none. >>> >>> Actually there are no tests - at least not in the Pharo image. >>> Maybe Benjamin can comment if there are some tests in the Spec universe for it. >>> >>> I opened an issue: http://code.google.com/p/pharo/issues/detail?id=7374 >>> >>> @Benjamin: can you move "OrderedIdentityDictionary" it out of Spec up to a >>> more general "Collection-Ordered" category/package for Pharo? >>> I dont want to interfere with current Spec development and >>> have no rights to commit to http://ss3.gemstone.com/ss/Spec >>> >>> BTW: Is it really necessary to have an mzc per "Collection-***" category? Dont >>> know about the dependencies - but for Kernel we have only one package (and one >>> for the tests). >>> >>> Thx >>> T. >>> >>> >>> >> >> >> >> >> >> -- >> www.tudorgirba.com >> >> "Every thing has its own flow" > > -- www.tudorgirba.com "No matter how many recipes we know, we still value a chef."

Feb. 1, 2013

Re: [Pharo-project] [update 2.0] #20502

by Sean P. DeNigris

stephane ducasse wrote > - Issue 7348: Enhancing SmallLintRules Were the correct packages integrated for this? Name: SLICE-Issue-7348-Enhancing-SmallLintRules--StephaneDucasse.2 Dependencies: - Refactoring-Critics-StephaneDucasse.30 - Refactoring-Tests-Core-StephaneDucasse.61 - Manifest-Core-StephaneDucasse.101 But 20502 (from the static file server) has: - Refactoring-Critics-StephaneDucasse.28 - Refactoring-Tests-Core-StephaneDucasse.63 - Manifest-Core-StephaneDucasse.99 -- View this message in context: http://forum.world.st/update-2-0-20502-tp4666904p4666969.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Feb. 1, 2013

Re: [Pharo-project] Zinc-SSO OAuth2 Google offline access

by Yanni Chiu

On 31/01/13 2:55 PM, Jan van de Sandt wrote: > ... Instead of making a separate class for offline > access I think it's a better idea to change the current class so you can > configure it for either online or offline access. Okay, I take that approach.

Feb. 1, 2013

Re: [Pharo-project] help needed

by StÃ©phane Ducasse

On Jan 31, 2013, at 7:35 PM, Usman Bhatti wrote: > > > > On Thu, Jan 31, 2013 at 10:09 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Usman > > I also try just returning the container but do not know the expected result. > It "works" > > It kinda "works" because DNU has disappeared. > > Scenario > I have a list, when I select an element from the list, its properties, visu and metrics are shown by glamour. > > Ideal Situation: > I trigger the selection of a random node (from another visu) and its not part of the shown elements in the list (but is still part of model), it should be selected/gets focus in the list. I do not understand how a container setSelectedMorph: nil can select a node :) > > what this "Fix" does > With the "fix", I can see the properties and visu of the selected node in my browser and DNU is gone. But selection of the node does not happen. For me, sufficient to show a problem-free UI but its not the ideal behavior. > > Should this "fix" be a part of pharo? But this code needs a thorough inspection. > > usman > > > > Stef > > > > On Jan 31, 2013, at 12:48 PM, Usman Bhatti wrote: > > > > > > > > > On Thu, Jan 31, 2013 at 1:20 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > > Usman did you check with 1.3 to know if the method was there? > > > > I looked in 1.3. The method is defined on MorphTreeMorph (see sceenshot) but absent from this class in 1.4. Copying and pasting the method from 1.3 to 1.4 in the class does not work, there are some missing instance variables in the code. > > The number of implementing classes for setSelectedMorph: does not change between 1.3 and 1.4. To me it seems that the method was moved to MorphTreeListManager in 1.4. It tried to change the receiver to invoke the method on MorphTreeListManager but there are some other problems then. > > > > <image.png> > > > > > > Stef > > > > On Jan 31, 2013, at 7:03 AM, Usman Bhatti wrote: > > > > > > > > > > > > > > On Thu, Jan 31, 2013 at 2:30 AM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > > > Morbid fascination > > > It is late so I may completely off but > > > how many isKindOf: are executed in this method? > > > > > > > ((aSymbol isKindOf: Array) > > > > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > > > > aSymbol second == #openPath]]]) > > > > > > when [aSymbol second == #openPath] is not openPath > > > then we go to the next (not mentioning duplicated code inside the method ---- I will vomit) > > > and we restart to execute isKindOf: > > > > > > ((aSymbol isKindOf: Array) > > > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > > > aSymbol second == #expandAllFromNode:]]]) > > > > > > Am'I right? > > > It looks so terrible. > > > > > > Yes. And more so for someone not frequently working with Morphs. > > > So, can someone at least see if the problem can be fixed without a large refactoring that should surely happen, but the glamour bug needs a quick fix. Or at least point to why the missing method on the receiver is abundantly found in the code? > > > > > > usman > > > > > > > > > Stef > > > > > > > > > > > > > update: aSymbol > > > > aSymbol == #selection ifTrue: [^ self listManager updateSelectionFromModel]. > > > > ((aSymbol isKindOf: Array) and: [aSymbol size > 1 and: [aSymbol first == #selectItems and: [aSymbol second isCollection]]]) > > > > ifTrue: [^ self selectedItems: aSymbol second]. > > > > aSymbol == self nodeListSelector ifTrue: [^ self updateList]. > > > > aSymbol == #selectAll ifTrue: [^ self listManager selectAll]. > > > > aSymbol == #deselectAll ifTrue: [^ self listManager deselectAll]. > > > > ((aSymbol isKindOf: Array) > > > > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > > > > aSymbol second == #openPath]]]) "allow directed path opening where multiple trees exist" > > > > ifTrue: > > > > [^(self allNodeMorphs at: 1 ifAbsent: [^self]) > > > > openPath: (aSymbol allButFirst: 2)]. > > > > ((aSymbol isKindOf: Array) > > > > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > > > > aSymbol second == #openItemPath]]]) "allow directed path opening where multiple trees exist" > > > > ifTrue: > > > > [^ (self allNodeMorphs at: 1 ifAbsent: [^self]) > > > > openItemPath: (aSymbol allButFirst: 2)]. > > > > ((aSymbol isKindOf: Array) > > > > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > > > > aSymbol second == #expandAllFromNode:]]]) > > > > ifTrue: > > > > [^ self expandAllFromNode: aSymbol third]. > > > > ((aSymbol isKindOf: Array) > > > > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > > > > aSymbol second == #closeItemPath]]]) "allow directed path closing where multiple trees exist" > > > > ifTrue: > > > > [^ (self allNodeMorphs at: 1 ifAbsent: [^self]) > > > > closeItemPath: (aSymbol allButFirst: 2)]. > > > > ((aSymbol isKindOf: Array) > > > > and: [aSymbol notEmpty and: [aSymbol first == #openPath]]) > > > > ifTrue: > > > > [^(self allNodeMorphs at: 1 ifAbsent: [^self]) > > > > openPath: aSymbol allButFirst]. > > > > ((aSymbol isKindOf: Array) > > > > and: [aSymbol size = 2 and: [aSymbol first = self nodeListSelector and: [ > > > > aSymbol second == #expandRoots]]]) > > > > ifTrue: > > > > [^self expandRoots]. > > > > ((aSymbol isKindOf: Array) > > > > and: [aSymbol size = 2 and: [aSymbol first = self nodeListSelector]]) > > > > ifTrue: [aSymbol second = #expandAll ifTrue: [^ self expandAll]. > > > > aSymbol second = #collapseAll ifTrue: [^ self collapseAll]] > > > > > > > > > > > > > > > > > >

Jan. 31, 2013

Re: [Pharo-project] help needed

by StÃ©phane Ducasse

On Jan 31, 2013, at 7:35 PM, Usman Bhatti wrote: > > > > On Thu, Jan 31, 2013 at 10:09 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Usman > > I also try just returning the container but do not know the expected result. > It "works" > > It kinda "works" because DNU has disappeared. > > Scenario > I have a list, when I select an element from the list, its properties, visu and metrics are shown by glamour. > > Ideal Situation: > I trigger the selection of a random node (from another visu) and its not part of the shown elements in the list (but is still part of model), it should be selected/gets focus in the list. Ok I will try to see :) > what this "Fix" does > With the "fix", I can see the properties and visu of the selected node in my browser and DNU is gone. But selection of the node does not happen. For me, sufficient to show a problem-free UI but its not the ideal behavior. > > Should this "fix" be a part of pharo? But this code needs a thorough inspection. I'm trying to fix it for real but I'm discovering this class and its superclass. > > usman > > > > Stef > > > > On Jan 31, 2013, at 12:48 PM, Usman Bhatti wrote: > > > > > > > > > On Thu, Jan 31, 2013 at 1:20 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > > Usman did you check with 1.3 to know if the method was there? > > > > I looked in 1.3. The method is defined on MorphTreeMorph (see sceenshot) but absent from this class in 1.4. Copying and pasting the method from 1.3 to 1.4 in the class does not work, there are some missing instance variables in the code. > > The number of implementing classes for setSelectedMorph: does not change between 1.3 and 1.4. To me it seems that the method was moved to MorphTreeListManager in 1.4. It tried to change the receiver to invoke the method on MorphTreeListManager but there are some other problems then. > > > > <image.png> > > > > > > Stef > > > > On Jan 31, 2013, at 7:03 AM, Usman Bhatti wrote: > > > > > > > > > > > > > > On Thu, Jan 31, 2013 at 2:30 AM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > > > Morbid fascination > > > It is late so I may completely off but > > > how many isKindOf: are executed in this method? > > > > > > > ((aSymbol isKindOf: Array) > > > > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > > > > aSymbol second == #openPath]]]) > > > > > > when [aSymbol second == #openPath] is not openPath > > > then we go to the next (not mentioning duplicated code inside the method ---- I will vomit) > > > and we restart to execute isKindOf: > > > > > > ((aSymbol isKindOf: Array) > > > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > > > aSymbol second == #expandAllFromNode:]]]) > > > > > > Am'I right? > > > It looks so terrible. > > > > > > Yes. And more so for someone not frequently working with Morphs. > > > So, can someone at least see if the problem can be fixed without a large refactoring that should surely happen, but the glamour bug needs a quick fix. Or at least point to why the missing method on the receiver is abundantly found in the code? > > > > > > usman > > > > > > > > > Stef > > > > > > > > > > > > > update: aSymbol > > > > aSymbol == #selection ifTrue: [^ self listManager updateSelectionFromModel]. > > > > ((aSymbol isKindOf: Array) and: [aSymbol size > 1 and: [aSymbol first == #selectItems and: [aSymbol second isCollection]]]) > > > > ifTrue: [^ self selectedItems: aSymbol second]. > > > > aSymbol == self nodeListSelector ifTrue: [^ self updateList]. > > > > aSymbol == #selectAll ifTrue: [^ self listManager selectAll]. > > > > aSymbol == #deselectAll ifTrue: [^ self listManager deselectAll]. > > > > ((aSymbol isKindOf: Array) > > > > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > > > > aSymbol second == #openPath]]]) "allow directed path opening where multiple trees exist" > > > > ifTrue: > > > > [^(self allNodeMorphs at: 1 ifAbsent: [^self]) > > > > openPath: (aSymbol allButFirst: 2)]. > > > > ((aSymbol isKindOf: Array) > > > > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > > > > aSymbol second == #openItemPath]]]) "allow directed path opening where multiple trees exist" > > > > ifTrue: > > > > [^ (self allNodeMorphs at: 1 ifAbsent: [^self]) > > > > openItemPath: (aSymbol allButFirst: 2)]. > > > > ((aSymbol isKindOf: Array) > > > > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > > > > aSymbol second == #expandAllFromNode:]]]) > > > > ifTrue: > > > > [^ self expandAllFromNode: aSymbol third]. > > > > ((aSymbol isKindOf: Array) > > > > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > > > > aSymbol second == #closeItemPath]]]) "allow directed path closing where multiple trees exist" > > > > ifTrue: > > > > [^ (self allNodeMorphs at: 1 ifAbsent: [^self]) > > > > closeItemPath: (aSymbol allButFirst: 2)]. > > > > ((aSymbol isKindOf: Array) > > > > and: [aSymbol notEmpty and: [aSymbol first == #openPath]]) > > > > ifTrue: > > > > [^(self allNodeMorphs at: 1 ifAbsent: [^self]) > > > > openPath: aSymbol allButFirst]. > > > > ((aSymbol isKindOf: Array) > > > > and: [aSymbol size = 2 and: [aSymbol first = self nodeListSelector and: [ > > > > aSymbol second == #expandRoots]]]) > > > > ifTrue: > > > > [^self expandRoots]. > > > > ((aSymbol isKindOf: Array) > > > > and: [aSymbol size = 2 and: [aSymbol first = self nodeListSelector]]) > > > > ifTrue: [aSymbol second = #expandAll ifTrue: [^ self expandAll]. > > > > aSymbol second = #collapseAll ifTrue: [^ self collapseAll]] > > > > > > > > > > > > > > > > > >

Jan. 31, 2013