- Pharo-dev - lists.pharo.org

Re: [Pharo-project] TextModel review and discussion

by Sean P. DeNigris

Benjamin Van Ryseghem-2 wrote > We really need to kill this ugly monster, and make it turn into a nice > butterfly for 3.0 :) YES!!! -- View this message in context: http://forum.world.st/TextModel-review-and-discussion-tp4668021p4668025.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Feb. 6, 2013

Re: [Pharo-project] TextModel review and discussion

by Benjamin

Cool :) We really need to kill this ugly monster, and make it turn into a nice butterfly for 3.0 :) Just a tiny question: Shouldn't the code belong to RMoD team instead of Igor on SmalltalkHub ? Ben On Feb 6, 2013, at 3:56 PM, Igor Stasenko <siguctua(a)gmail.com> wrote: > Hi, today, me, Tristan and Camillo took some overview on existing > code and discussed further steps. > > TxAttributes > 'contents' should be private (no getter/setter) > > because if you can directly manipulate the underlying collection, then > what is the point of having separate class? > > Text Attributes in general: > > - we discussed and decided that it would be better that model will > keep abstract attributes for text , like > - bold > - italic > - font family name > > the view then can compute the real font to use, but model don't have > to deal with real font(s). > > This will imply having more complex attribute(s): you will be forced > to visit them all to determine all of the font properties > of a final font to use. > > The attributes in span should behave like a set (you cannot apply same > attribute once), > and hence implement #= and #hash properly. > > Also, i think, since neither bold, nor italic attributes don't need to > be represented by multiple instances of same class, > we could use convenience methods (by introducing them) in TxAttribute > class to get a singletons for those ones, e.g.: > > selection applyAttribute: TxAttribute bold > > Layout: > - right now, when you do layout it will split spans of txmodel. Which > should not happen. > > We discussed about it and agreed that layouts(views) should not modify > anything in text model. > Instead the information about where line has to be split (like when > you need to wrap a text) should be kept > separately by a view. > > We thought that it would be nicer to implement a new span type > (layoutspan), which will hold > an text-interval (pos1, pos2) and probably any additional information > (like caching the width/height) > to not recalculate this stuff if nothing changed in model. > > > We did some cosmetic changes to configuration.. to merge Tristan's > code into it and load most recent packages: > > Gofer it > smalltalkhubUser: 'sig' project: 'TxText'; > package: 'ConfigurationOfTxText'; > load. > > (ConfigurationOfTxText project version: '0.3') load: 'Tests' > > -- > Best regards, > Igor Stasenko. >

Feb. 6, 2013

[Pharo-project] TextModel review and discussion

by Igor Stasenko

Hi, today, me, Tristan and Camillo took some overview on existing code and discussed further steps. TxAttributes 'contents' should be private (no getter/setter) because if you can directly manipulate the underlying collection, then what is the point of having separate class? Text Attributes in general: - we discussed and decided that it would be better that model will keep abstract attributes for text , like - bold - italic - font family name the view then can compute the real font to use, but model don't have to deal with real font(s). This will imply having more complex attribute(s): you will be forced to visit them all to determine all of the font properties of a final font to use. The attributes in span should behave like a set (you cannot apply same attribute once), and hence implement #= and #hash properly. Also, i think, since neither bold, nor italic attributes don't need to be represented by multiple instances of same class, we could use convenience methods (by introducing them) in TxAttribute class to get a singletons for those ones, e.g.: selection applyAttribute: TxAttribute bold Layout: - right now, when you do layout it will split spans of txmodel. Which should not happen. We discussed about it and agreed that layouts(views) should not modify anything in text model. Instead the information about where line has to be split (like when you need to wrap a text) should be kept separately by a view. We thought that it would be nicer to implement a new span type (layoutspan), which will hold an text-interval (pos1, pos2) and probably any additional information (like caching the width/height) to not recalculate this stuff if nothing changed in model. We did some cosmetic changes to configuration.. to merge Tristan's code into it and load most recent packages: Gofer it smalltalkhubUser: 'sig' project: 'TxText'; package: 'ConfigurationOfTxText'; load. (ConfigurationOfTxText project version: '0.3') load: 'Tests' -- Best regards, Igor Stasenko.

Feb. 6, 2013

Re: [Pharo-project] Less than 50 issues!

by Sean P. DeNigris

Current stats: 41 Open 2.0 Issues (down from 45) 15 Ready to Review (down from 16) 00 Ready to Integrate (down from 2) ______ = 26 Outstanding 7 issues dealt with in the last hour :) Keep it going!! -- View this message in context: http://forum.world.st/Less-than-50-issues-tp4667961p4668013.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Feb. 6, 2013

Re: [Pharo-project] [update 2.0] #20517

by Sean P. DeNigris

Marcus Denker-4 wrote > 20517 > <snip> > many integrations > </snip> Thanks, Marcus! And the sprint's not even until Friday ;) -- View this message in context: http://forum.world.st/update-2-0-20517-tp4668008p4668011.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Feb. 6, 2013

[Pharo-project] [update 2.0] #20517

by Marcus Denker

20517 ----- Issue 7426: Failing tests in ZnFileUrlTest on Windows http://code.google.com/p/pharo/issues/detail?id=7426 Issue 7371: Archive>>addTree: removingFirstCharacters: match: do not work http://code.google.com/p/pharo/issues/detail?id=7371 Issue 7338: Failing test: RPackageReleaseTest>>#testRPackageOrganizer http://code.google.com/p/pharo/issues/detail?id=7338 Issue 7292: Autocomplete partial matches http://code.google.com/p/pharo/issues/detail?id=7292 Issue 6885: Image cant starts and hangs when cant find required free type font files http://code.google.com/p/pharo/issues/detail?id=6885 Diff information: http://ss3.gemstone.com/ss/Pharo20/Zinc-Resource-Meta-FileSystem-MarcusDenk… http://ss3.gemstone.com/ss/Pharo20/RPackage-Tests-MarcusDenker.109.diff http://ss3.gemstone.com/ss/Pharo20/NECompletion-MarcusDenker.87.diff http://ss3.gemstone.com/ss/Pharo20/FreeType-MarcusDenker.612.diff http://ss3.gemstone.com/ss/Pharo20/Compression-MarcusDenker.122.diff

Feb. 6, 2013

Re: [Pharo-project] Less than 50 issues!

by Nicolas Petton

Cool! Nico Esteban Lorenzano <estebanlm(a)gmail.com> writes: > http://code.google.com/p/pharo/issues/list?can=2&q=Milestone%3D2.0 > > this is starting to look like a release :) > > Esteban

Feb. 6, 2013

Re: [Pharo-project] Less than 50 issues!

by Sean P. DeNigris

Awesome work Pharo community!! Current stats: 45 Open 2.0 Issues 16 Ready to Review 02 Ready to Integrate ______ = 27 Outstanding We're /so/ close :) Let's finish strong!! Cheers, Sean -- View this message in context: http://forum.world.st/Less-than-50-issues-tp4667961p4667986.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Feb. 6, 2013

Re: [Pharo-project] Less than 50 issues!

by Marcus Denker

On Feb 6, 2013, at 11:05 AM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > http://code.google.com/p/pharo/issues/list?can=2&q=Milestone%3D2.0 > > this is starting to look like a release :) > Yes! and 10 out of those just need to be reviewedâ¦ so we are at just 35 issues. Very nice! Marcus

Feb. 6, 2013

[Pharo-project] QualityControl Bug: Line breaks withing words in all Pharo tools

by Helene Bilbo

Please consider this bug about "line breaks within words" in all Pharo tools that i reported in April 2012 and that was commented on, but never even accepted. It is still here in the latest 2.0. http://code.google.com/p/pharo/issues/detail?id=5638 Would you accept the Pharo website look like this: "I do enjoy Pharo" Ke nt Beck Pharo is a clean, innov ative, open-source S malltalk-inspired envir onment - pure object-oriented language - runs on all major plat forms - stable core with larg e test suite - a clean look and feel - good developer tool s - low memory footprin t I am sorry that i do not know enough about the Pharo text system myself to provide a solution. -- View this message in context: http://forum.world.st/QualityControl-Bug-Line-breaks-withing-words-in-all-P… Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Feb. 6, 2013