- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] the return of the strange methods

by Esteban Lorenzano

Even more important, IMHO: allowing those methods to exists is to validate an anti-pattern: if you have an specific error to throw, you should create a specific descendant of Error, not just throw Error with an explanation. So, +A LOT to remove them. Esteban On Jul 9, 2013, at 5:42 PM, ClÃ©ment Bera <bera.clement(a)gmail.com> wrote: > They may be useful. Imagine you are too lazy to create a subclass of Error, but not lazy enough to create a test and copy paste a String. > Then you write in your method: > self error: 'some strange error happened' > And you can test it: > self shouldnt: [ "some strange code" ] raise: Error whoseDescriptionIncludes: 'some strange error happened' description: 'the strange error did not happen ! That's strange' > > Seriously, as you saw these methods are used only in their tests. I guess you can remove them. Open fogz bug ? > > > 2013/7/9 Frank Shearar <frank.shearar(a)gmail.com> > On 9 July 2013 16:24, Camillo Bruni <camillobruni(a)gmail.com> wrote: > > Survey: who uses the following methods? and if yes why? > > > > - shouldnt: aBlock raise: anExceptionalEvent whoseDescriptionDoesNotInclude: subString description: aString > > - shouldnt: aBlock raise: anExceptionalEvent whoseDescriptionIncludes: subString description: aString > > > > I honestly cannot wrap my head around these two methods. > > They show that the code in the block raises an _informative_ > exception. So you get a FileNotFound exception... but what was the > missing file? I don't know! Noone bothered to mention it! > > frank > >

July 9, 2013

Re: [Pharo-dev] the return of the strange methods

by Frank Shearar

On 9 July 2013 16:42, ClÃ©ment Bera <bera.clement(a)gmail.com> wrote: > They may be useful. Imagine you are too lazy to create a subclass of Error, > but not lazy enough to create a test and copy paste a String. > Then you write in your method: > self error: 'some strange error happened' > And you can test it: > self shouldnt: [ "some strange code" ] raise: Error > whoseDescriptionIncludes: 'some strange error happened' description: 'the > strange error did not happen ! That's strange' > > Seriously, as you saw these methods are used only in their tests. I guess > you can remove them. Open fogz bug ? If something should not raise a KeyNotFound exception, which would you regard as more useful: "KeyNotFound" or "'foo' key not found" ? frank > 2013/7/9 Frank Shearar <frank.shearar(a)gmail.com> >> >> On 9 July 2013 16:24, Camillo Bruni <camillobruni(a)gmail.com> wrote: >> > Survey: who uses the following methods? and if yes why? >> > >> > - shouldnt: aBlock raise: anExceptionalEvent >> > whoseDescriptionDoesNotInclude: subString description: aString >> > - shouldnt: aBlock raise: anExceptionalEvent whoseDescriptionIncludes: >> > subString description: aString >> > >> > I honestly cannot wrap my head around these two methods. >> >> They show that the code in the block raises an _informative_ >> exception. So you get a FileNotFound exception... but what was the >> missing file? I don't know! Noone bothered to mention it! >> >> frank >> >

July 9, 2013

Re: [Pharo-dev] the return of the strange methods

by Max Leske

On 09.07.2013, at 17:42, ClÃ©ment Bera <bera.clement(a)gmail.com> wrote: > They may be useful. Imagine you are too lazy to create a subclass of Error, but not lazy enough to create a test and copy paste a String. > Then you write in your method: > self error: 'some strange error happened' > And you can test it: > self shouldnt: [ "some strange code" ] raise: Error whoseDescriptionIncludes: 'some strange error happened' description: 'the strange error did not happen ! That's strange' > > Seriously, as you saw these methods are used only in their tests. I guess you can remove them. Open fogz bug ? +1 > > > 2013/7/9 Frank Shearar <frank.shearar(a)gmail.com> > On 9 July 2013 16:24, Camillo Bruni <camillobruni(a)gmail.com> wrote: > > Survey: who uses the following methods? and if yes why? > > > > - shouldnt: aBlock raise: anExceptionalEvent whoseDescriptionDoesNotInclude: subString description: aString > > - shouldnt: aBlock raise: anExceptionalEvent whoseDescriptionIncludes: subString description: aString > > > > I honestly cannot wrap my head around these two methods. > > They show that the code in the block raises an _informative_ > exception. So you get a FileNotFound exception... but what was the > missing file? I don't know! Noone bothered to mention it! > > frank > >

July 9, 2013

Re: [Pharo-dev] [ANN] Amber 0.11.0 released!

by Norbert Hartl

Cool. I like the more frequent releases. And I'm happy that within the next two weeks I'll be able to work on it again. Norbert Am 09.07.2013 um 16:25 schrieb Nicolas Petton <petton.nicolas(a)gmail.com>: > Amber 0.11.0 released! > > * About the release > > Three months have passed and we are happy to announce the release > of Amber 0.11.0! > > Some numbers about this release: 433 commits by 13 committers, > increasing the number of core committers to 25. 50 unit tests > were added to the kernel, bringing us to 313 unit tests in total. > Since the last release 60 issues were closed, bringing us to 499 > issues closed. > > This release includes a lot of bug fixes, improvements to the > CLI, as well as a preview of the next IDE, named Helios. Amber > now also uses a CI server [1]. > > To try the Helios, the new IDE, open the helios.html page, or > evaluate in any other amber page `amber.loadHelios()`. > > The compiler also received some improvements, especially > regarding message send optimisations and super sends. > > Here's the list of commits and closed issues: > https://github.com/amber-smalltalk/amber/commits/master > https://github.com/amber-smalltalk/amber/issues?direction=desc&sort=updated… > > There is a lot more to come with Helios, a stepping debugger > based on the AST is in progress and currently in the 'debugger' > branch on GitHub. > > * Installing Amber from NPM > > To install amber from NPM, run > > npm install amber > > > * Migration from Amber 0.10.0 > > Amber compiled code should be compatible with Amber 0.10.0, but > recompiling is needed in order to get contexts working: > > Compiler new recompile: (Package named: 'MyPackage') classes. > (Package named: 'MyPackage') commit > > > * API changes > > 0.11.0: > > * AnnouncementSubscription use #valuable: instead of #block: (deprecated) > * AbstractCodeGenerator inherits from Object, not NodeVisitor > * Object>>printString > * replace >>printString with >>printOn: > * replace >>storeString with >>printString > * PackageLoader is now PackageHandler (>>commit: >>setupPackagenamed:prefix: >>ajaxPutAt:data: > * Package>>fetch: is now Package>>load: > * Package>>fetch:prefix: is now Package>>load:prefix: > * Queue>>front replaced by Queue>>next > * Queue>>frontIfAbsent: replaced by Queue>>nextIfAbsent: > * Queue>>back: replaced by Queue>>nextPut: > * smalltalk.addMethod() does not use explicit JS selector > * JSObjectProxy>>canForwardMessage: replaced by use of JSObjectProxy>>lookupProperty: with asJavaScriptSelector > * JSObjectProxy>>forwardMessage: replaced by explicit JSObjectProxy>>forwardMessage:withArguments: > * String>>asJavaScriptSelector moved to Kernel-Objects package > > + Object>>asString > + Object>>putOn: > + String>>isVowel > + Collection>>putOn: > + CharacterArray>>putOn: > + Stream>><< > + Stream>>write > + SequenceableCollection>>newStream > + SequenceableCollection>>readStream > + SequenceableCollection>>stream > + SequenceableCollection>>streamClass > + SequenceableCollection>>writeStream > + Collection>>isImmutable > + Stream>>nextPutString: > + StringStream>>nextPutString: > + JSStream>>nextPutClassRefFunction: > + String>>crlfSanitized > + inlined Block now also responds to >>value: > + Parser: split literal into runtimeLiteral and parseTimeLiteral > + Parser: write #(4 #(5 6 #()) 7) as #(4 (5 6 ()) 7) > + Parser: write #(#on:do: #Object) as #(on:do: Object) > + Parser: Symbols for binarie selectores > + Package>>commit > + AIContext>>initializeLocals > + ASTInterpreter>>withBlockContext: > + smalltalk.allSelectors() > + Object>>isCompiledMethod > + Object>>isPackage > + Object>>isBehavior > + ClassMoved Announcemen class > + Behavior>>includesBehavior: > + Environment>>classes > + Environment>>allSelectors > + Environment>>removeProtocol: > + Environment>>renameProtocol:to:in: > + CompiledMethod>>protocol: > + Smalltalk>>globalJsVariables > + Smalltalk>>addGlobalJsVariable: > + Smalltalk>>deleteGlobalJsVariable: > > > - Object>>storeOn: > - Object>>log:block: > - Object>>printNl > - Compiler-IR.st >>javascriptSelector > - Compiler-IR.st >>nextPutVar: > - Kernel-Collections.st >>asSuperSelector > - Collection>>readStream > - Collection>>stream > - Collection>>streamClass > - Collection>>writeStream > - Symbol class (replaced with String) > - IRInlinedNonLocalReturn class > - IRInlinedSend>>nonLocalReturnInliner > - IRNonLocalReturnInliner class > - Package>>dependencies > - Package>>dependencies: > - Package>>properties > - Package>>jsProperties > - Package>>jsProperties: > - Package>>propertiesAsJSON > - Package>>propertyAt: > - Package>>propertyAt:ifAbsent: > - Package>>propertyAt:put: > - Browser>>ajaxPutAt:data: > > > We hope you join us in developing Amber and having fun! Fork at > github, join in #amber-lang on freenode and hop onto the mailing > list. > > The Amber crew > > [1] https://travis-ci.org/amber-smalltalk/amber

July 9, 2013

Re: [Pharo-dev] the return of the strange methods

by ClÃ©ment Bera

They may be useful. Imagine you are too lazy to create a subclass of Error, but not lazy enough to create a test and copy paste a String. Then you write in your method: self error: 'some strange error happened' And you can test it: self shouldnt: [ "some strange code" ] raise: Error whoseDescriptionIncludes: 'some strange error happened' description: 'the strange error did not happen ! That's strange' Seriously, as you saw these methods are used only in their tests. I guess you can remove them. Open fogz bug ? 2013/7/9 Frank Shearar <frank.shearar(a)gmail.com> > On 9 July 2013 16:24, Camillo Bruni <camillobruni(a)gmail.com> wrote: > > Survey: who uses the following methods? and if yes why? > > > > - shouldnt: aBlock raise: anExceptionalEvent > whoseDescriptionDoesNotInclude: subString description: aString > > - shouldnt: aBlock raise: anExceptionalEvent whoseDescriptionIncludes: > subString description: aString > > > > I honestly cannot wrap my head around these two methods. > > They show that the code in the block raises an _informative_ > exception. So you get a FileNotFound exception... but what was the > missing file? I don't know! Noone bothered to mention it! > > frank > >

July 9, 2013

Re: [Pharo-dev] the return of the strange methods

by Frank Shearar

On 9 July 2013 16:24, Camillo Bruni <camillobruni(a)gmail.com> wrote: > Survey: who uses the following methods? and if yes why? > > - shouldnt: aBlock raise: anExceptionalEvent whoseDescriptionDoesNotInclude: subString description: aString > - shouldnt: aBlock raise: anExceptionalEvent whoseDescriptionIncludes: subString description: aString > > I honestly cannot wrap my head around these two methods. They show that the code in the block raises an _informative_ exception. So you get a FileNotFound exception... but what was the missing file? I don't know! Noone bothered to mention it! frank

July 9, 2013

the return of the strange methods

by Camillo Bruni

Survey: who uses the following methods? and if yes why? - shouldnt: aBlock raise: anExceptionalEvent whoseDescriptionDoesNotInclude: subString description: aString - shouldnt: aBlock raise: anExceptionalEvent whoseDescriptionIncludes: subString description: aString I honestly cannot wrap my head around these two methods.

July 9, 2013

Re: [Pharo-dev] [update 3.0] #30260

by Martin Dias

Christophe: now your ci build may be fixed. MartÃn On Tue, Jul 9, 2013 at 4:27 PM, Marcus Denker <marcus.denker(a)inria.fr>wrote: > 30260 > ----- > > 11150 Reshaping a class does not properly propagate the modification to > the subclasses of its subclasses > https://pharo.fogbugz.com/f/cases/11150 > > Diff information: > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Slot-MarcusDenker.344.diff > > http://smalltalkhub.com/mc/Pharo/Pharo30/main/SlotTests-MarcusDenker.41.diff > > >

July 9, 2013

Re: [Pharo-dev] How is GlorpOpenDBXDriverPoolingDriver supposed to work?

by Mariano Martinez Peck

Ahhh ok...I think I got it. The magic is in SelmaConnectionPool >> #connect: On Tue, Jul 9, 2013 at 11:50 AM, Mariano Martinez Peck < marianopeck(a)gmail.com> wrote: > Hi guys, > > There is something I don't understand. The idea > with GlorpOpenDBXDriverPoolingDriver is that it takes care of opening the > connections and have a pool, right? > > Now...I am at the glorp side...each time I want to do something I > instantiate a GlorpSession. Of course, I don't want to send #login to this > session because that's what the pool would do if necessary. So say I just > send a query with the session. I get a DNU because 'databaseDriver' is nil. > As you can see, databaseDriver is set in PharoDatabaseAccessor > >> loginIfError:. > of course, if I send #login or #loginIfError before doing the query the > pool "works"...but...I am opening a connection for each query. > > So I don't understand how this is supposed to work. How should I manage my > Glorp sessions with this pool? > > Thanks, > > -- > Mariano > http://marianopeck.wordpress.com > -- Mariano http://marianopeck.wordpress.com

July 9, 2013

How is GlorpOpenDBXDriverPoolingDriver supposed to work?

by Mariano Martinez Peck

Hi guys, There is something I don't understand. The idea with GlorpOpenDBXDriverPoolingDriver is that it takes care of opening the connections and have a pool, right? Now...I am at the glorp side...each time I want to do something I instantiate a GlorpSession. Of course, I don't want to send #login to this session because that's what the pool would do if necessary. So say I just send a query with the session. I get a DNU because 'databaseDriver' is nil. As you can see, databaseDriver is set in PharoDatabaseAccessor >> loginIfError:. of course, if I send #login or #loginIfError before doing the query the pool "works"...but...I am opening a connection for each query. So I don't understand how this is supposed to work. How should I manage my Glorp sessions with this pool? Thanks, -- Mariano http://marianopeck.wordpress.com

July 9, 2013