- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Fuel API bug

by Max Leske

Done. Name: ConfigurationOfFuel-MaxLeske.207 Author: MaxLeske Time: 4 August 2013, 4:49:17.037 pm UUID: 5cc59075-e365-4a58-a20b-22e40b2b70c9 Ancestors: ConfigurationOfFuel-MartinDias.206 * created new version 1.9.2 for development * pointed development to 1.9.2 * includes changes Camillo wanted to introduce into 1.9.1 (DateAndTime fix) On 04.08.2013, at 16:35, Max Leske <maxleske(a)gmail.com> wrote: > Yeah, no problem. I'll get on it right away. > > Max > > On 04.08.2013, at 16:10, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > >> Hi guys >> >> can you rename this method? >> >> on: aCollectionOrStream do: aBlock >> "Evaluates a block with a new stream based on the collection or stream. Answers the result of the block evaluation. Follows the style of FileStream>>fileNamed:do:." >> | aStream | >> aStream := self on: aCollectionOrStream. >> [ ^ aBlock value: aStream ] ensure: [ aStream close ] >> >> >> Please do not use on:do: for something that is not about exception (and announcements). >> >> It is too confusing and refactor after. >> >> Stef >

Aug. 4, 2013

Re: [Pharo-dev] Fuel API bug

by Max Leske

Yeah, no problem. I'll get on it right away. Max On 04.08.2013, at 16:10, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Hi guys > > can you rename this method? > > on: aCollectionOrStream do: aBlock > "Evaluates a block with a new stream based on the collection or stream. Answers the result of the block evaluation. Follows the style of FileStream>>fileNamed:do:." > | aStream | > aStream := self on: aCollectionOrStream. > [ ^ aBlock value: aStream ] ensure: [ aStream close ] > > > Please do not use on:do: for something that is not about exception (and announcements). > > It is too confusing and refactor after. > > Stef

Aug. 4, 2013

Re: [Pharo-dev] about on:do: -> onKey:do:

by Esteban Lorenzano

On Aug 4, 2013, at 4:11 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > No because the asKeyCombination is sent to the argument by the onKey:do: method. I don't really see the relation :) > We will be able to rename it anyway once we sort the problems. yep! most important is to move on and fix that annoying bug. > > >> I would use #onKeyCombination:do: to keep coherency with the framework. >> >> On Aug 4, 2013, at 3:04 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: >> >>> Hi ben and others >>> >>> we are introducing onKey:do: for bindings so that we can control the complexity and the registration >>> of announcements. So if you can I have a look it would be good. >>> >>> https://pharo.fogbugz.com/default.asp?11299 >>> >>> Stef >> >> > >

Aug. 4, 2013

Announcer problem :)

by StÃ©phane Ducasse

addDependent: anObject self announcer on: MorphChanged do: [ :ann | anObject update: ann selector ]. self announcer on: MorphChangedWithArguments do: [ :ann | anObject update: ann selector with: ann arguments ]. ^ anObject is an example of the problem because addDependent: was holding also weakly its dependent and now we cannot use weak with blocks. Stef

Aug. 4, 2013

Re: [Pharo-dev] about on:do: -> onKey:do:

by StÃ©phane Ducasse

No because the asKeyCombination is sent to the argument by the onKey:do: method. We will be able to rename it anyway once we sort the problems. > I would use #onKeyCombination:do: to keep coherency with the framework. > > On Aug 4, 2013, at 3:04 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > >> Hi ben and others >> >> we are introducing onKey:do: for bindings so that we can control the complexity and the registration >> of announcements. So if you can I have a look it would be good. >> >> https://pharo.fogbugz.com/default.asp?11299 >> >> Stef > >

Aug. 4, 2013

Fuel API bug

by StÃ©phane Ducasse

Hi guys can you rename this method? on: aCollectionOrStream do: aBlock "Evaluates a block with a new stream based on the collection or stream. Answers the result of the block evaluation. Follows the style of FileStream>>fileNamed:do:." | aStream | aStream := self on: aCollectionOrStream. [ ^ aBlock value: aStream ] ensure: [ aStream close ] Please do not use on:do: for something that is not about exception (and announcements). It is too confusing and refactor after. Stef

Aug. 4, 2013

Re: [Pharo-dev] about on:do: -> onKey:do:

by Esteban Lorenzano

I would use #onKeyCombination:do: to keep coherency with the framework. On Aug 4, 2013, at 3:04 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Hi ben and others > > we are introducing onKey:do: for bindings so that we can control the complexity and the registration > of announcements. So if you can I have a look it would be good. > > https://pharo.fogbugz.com/default.asp?11299 > > Stef

Aug. 4, 2013

about on:do: and weak

by StÃ©phane Ducasse

Hi guys we are looking at the memory leak problems with igor and here are the conclusions: we are renaming on:do: for shortcut into onKey:do: so that we can see a bit more (normally easy) Now the complex part. on:do: should not be used in weak announcement. because the block holds a context that prevents the garbage collection to reclaim the object. For blocks implicitly the receiver of the message containing the block is held strongly. Now the block cannot We are adding a message in the on:do: implementation and we will have a look at the complete image. on:do: should only be used for strong references. The problem is that for UI we need weak. So we are looking at users for now. Stef

Aug. 4, 2013

Re: [Pharo-dev] about on:do: -> onKey:do:

by Tudor Girba

Great. Doru On Sun, Aug 4, 2013 at 3:04 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr>wrote: > Hi ben and others > > we are introducing onKey:do: for bindings so that we can control the > complexity and the registration > of announcements. So if you can I have a look it would be good. > > https://pharo.fogbugz.com/default.asp?11299 > > Stef > -- www.tudorgirba.com "Every thing has its own flow"

Aug. 4, 2013

about on:do: -> onKey:do:

by StÃ©phane Ducasse

Hi ben and others we are introducing onKey:do: for bindings so that we can control the complexity and the registration of announcements. So if you can I have a look it would be good. https://pharo.fogbugz.com/default.asp?11299 Stef

Aug. 4, 2013