- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] [Issue 19852] Cached settings and moving images

by Eliot Miranda

Hi Guille, > On Jan 8, 2019, at 3:19 AM, Guillermo Polito <guillermopolito(a)gmail.com> wrote: > > Hi all, > > I was checking issue https://pharo.fogbugz.com/f/cases/19852 which is about the problems that arise when we move an image of location, and moreover when we move it between different platforms (windows to linux or mac for example). > > The problem are dangling file references pointing to invalid locations. > > We have found 4 of them: > > SystemResolver localdirectory is cached in a class variable > GTPlaybook caches the cache and stash directories in class variables > OMSessionStore retrieves at some point during startup an invalid file reference from the (wrongly cached) local directory > IceLibgitRepository Sharedrepositorieslocation is also cached > > All these are actually caused by settings, whose behavior is not defined when an image is moved. > There are several strange issues like, if we store settings, the local directory is stored, and then all images will (wrongly) use the same pharo-local directory of the first image. This is particularly annoying when using the launcher for example :). > > Now, we can leave this as it is right now and just move it to pharo8. > A quick fix for Pharo7 would be removing those settings and avoiding caching, but that is probably very disruptive too... > > Opinions? While a âproperâ fix might involve adding symbolic names that can be cross-platform (including using environment variables, etc) and that would indeed mean waiting for Pharo 8, surely something simple can be fine in the mean time. Why not have those classes maintain a âcurrent platformâ class var and a current directory on start up flush the file names if either the current platform or the current directory has changed? One would of course have to test the platform before the directory. Or even simpler, if the image name and directory are saved as strings (eg in Smalltalk as PreviousImageAndDirectory := { ... } and thereâs an accessor such as imageNameAndOrDirectoryHasChanged) then the file names can easily be changed on start up. Getting the startup order right might be a little tricky but surely not that hard in this case. On a related note I think time boxed releases are a bad idea. A system is ready when it is ready, based on proper acceptance criteria, such as tests, user experience reports, etc. when it is clearly broken it is clearly broken. Releasing a system that is clearly broken helps nobody. (I say that as the US prepares to enter the 2020 election cycle...) > > Guille

Jan. 8, 2019

[Pharo 7.0] Build #107: 22871-MC-makes-dirty-more-packages-than-expected

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #107 was: FAILURE. The Pull Request #2179 was integrated: "22871-MC-makes-dirty-more-packages-than-expected" Pull request url: https://github.com/pharo-project/pharo/pull/2179 Issue Url: https://pharo.fogbugz.com/f/cases/22871 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Jan. 8, 2019

[Pharo 8.0] Build #4: FAILURE

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #4 was: FAILURE. Could not extract further issue information from commit message: temporary using 70 vm (since we do not have a 80 vm yet) Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Jan. 8, 2019

[Pharo 8.0] Build #3: FAILURE

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #3 was: FAILURE. Could not extract further issue information from commit message: ensure version number Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Jan. 8, 2019

[Pharo 7.0] Build #106: 22669-UFFI-structures-are-not-recalculated-on-system-startup

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #106 was: SUCCESS. The Pull Request #1985 was integrated: "22669-UFFI-structures-are-not-recalculated-on-system-startup" Pull request url: https://github.com/pharo-project/pharo/pull/1985 Issue Url: https://pharo.fogbugz.com/f/cases/22669 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Jan. 8, 2019

[Pharo 7.0] Build #105: 22870-Remove-Compiler-packages-from-Pharo

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #105 was: SUCCESS. The Pull Request #2178 was integrated: "22870-Remove-Compiler-packages-from-Pharo" Pull request url: https://github.com/pharo-project/pharo/pull/2178 Issue Url: https://pharo.fogbugz.com/f/cases/22870 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Jan. 8, 2019

New book: Pharo with Style

by ducasse

Thanks Esteban I saw your feedback and I will go over it soon. Just busy deprecating my google accounts and other job duties. Stef

Jan. 8, 2019

Re: [Pharo-dev] [Issue 19852] Cached settings and moving images

by ducasse

Thanks guille for this analysis. I would move it to Pharo 8.0 Now I think that we should revive your analysis on state because I would love to have first class objects with a good and nice logic for such cases and others. The lifetime of a variable looks more complex than it looks. > On 8 Jan 2019, at 12:19, Guillermo Polito <guillermopolito(a)gmail.com> wrote: > > Hi all, > > I was checking issue https://pharo.fogbugz.com/f/cases/19852 <https://pharo.fogbugz.com/f/cases/19852> which is about the problems that arise when we move an image of location, and moreover when we move it between different platforms (windows to linux or mac for example). > > The problem are dangling file references pointing to invalid locations. > > We have found 4 of them: > > SystemResolver localdirectory is cached in a class variable > GTPlaybook caches the cache and stash directories in class variables > OMSessionStore retrieves at some point during startup an invalid file reference from the (wrongly cached) local directory > IceLibgitRepository Sharedrepositorieslocation is also cached > > All these are actually caused by settings, whose behavior is not defined when an image is moved. > There are several strange issues like, if we store settings, the local directory is stored, and then all images will (wrongly) use the same pharo-local directory of the first image. This is particularly annoying when using the launcher for example :). > > Now, we can leave this as it is right now and just move it to pharo8. > A quick fix for Pharo7 would be removing those settings and avoiding caching, but that is probably very disruptive too... > > Opinions? > > Guille

Jan. 8, 2019

[Issue 19852] Cached settings and moving images

by Guillermo Polito

Hi all, I was checking issue https://pharo.fogbugz.com/f/cases/19852 which is about the problems that arise when we move an image of location, and moreover when we move it between different platforms (windows to linux or mac for example). The problem are dangling file references pointing to invalid locations. We have found 4 of them: - SystemResolver localdirectory is cached in a class variable - GTPlaybook caches the cache and stash directories in class variables - OMSessionStore retrieves at some point during startup an invalid file reference from the (wrongly cached) local directory - IceLibgitRepository Sharedrepositorieslocation is also cached All these are actually caused by settings, whose behavior is not defined when an image is moved. There are several strange issues like, if we store settings, the local directory is stored, and then all images will (wrongly) use the same pharo-local directory of the first image. This is particularly annoying when using the launcher for example :). Now, we can leave this as it is right now and just move it to pharo8. A quick fix for Pharo7 would be removing those settings and avoiding caching, but that is probably very disruptive too... Opinions? Guille

Jan. 8, 2019

[Pharo 7.0] Build #104: 22867-Add-a-comment-to-Metacello-cypress-recent-fix

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #104 was: SUCCESS. The Pull Request #2176 was integrated: "22867-Add-a-comment-to-Metacello-cypress-recent-fix" Pull request url: https://github.com/pharo-project/pharo/pull/2176 Issue Url: https://pharo.fogbugz.com/f/cases/22867 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Jan. 8, 2019