- Pharo-dev - lists.pharo.org

[update 3.0] #30455

by Marcus Denker

30455 ----- 11790 add critic rule for keys do: -> keysDo: (and valuesDo:) https://pharo.fogbugz.com/f/cases/11790 11787 Trivial critic cleanup of CodeImport https://pharo.fogbugz.com/f/cases/11787 11793 Package Support on RBBrowserEnvironment https://pharo.fogbugz.com/f/cases/11793 11792 First simplistic file system tree inspector https://pharo.fogbugz.com/f/cases/11792 actually a FileReference tree inspector... lots of improvments possible inspect FileSystem workingDirectory and select the FileReference Tree Inspector Diff information: http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Inspector-MarcusDenker.1… http://smalltalkhub.com/mc/Pharo/Pharo30/main/Refactoring-Environment-Marcu… http://smalltalkhub.com/mc/Pharo/Pharo30/main/Refactoring-Critics-MarcusDen… http://smalltalkhub.com/mc/Pharo/Pharo30/main/NautilusCommon-MarcusDenker.1… http://smalltalkhub.com/mc/Pharo/Pharo30/main/Manifest-Core-MarcusDenker.16… http://smalltalkhub.com/mc/Pharo/Pharo30/main/CodeImport-MarcusDenker.37.di…

Oct. 5, 2013

Re: [Pharo-dev] [update 3.0] #30448

by Benjamin

I will have a look asap :P Ben On Oct 5, 2013, at 10:12 PM, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: > Hi Ben, > > Gofer new > smalltalkhubUser: 'PavelKrivanek' project: 'Periscope'; > package: 'Periscope'; > load. > > Nautilus pluginClasses add: {(Smalltalk at: #NautilusPeriscopePlugin). #none} . > > Very useful code: ;-) > > Periscope reset > > It still without experiments with own Morphic bindings, that will be > the next step :-) Feel free to commit any changes. > > Chees, > -- Pavel > > 2013/10/5 Benjamin <Benjamin.VanRyseghem.Pharo(a)gmail.com>: >> Can you point me where to load your code and how to end up in a situation >> where I can play with the spec ? :P >> >> Ben >> >> On Oct 4, 2013, at 11:11 PM, Pavel Krivanek <pavel.krivanek(a)gmail.com> >> wrote: >> >> Damn, the last row of the last plugins fills all the window... >> >> -- Pavel >> >> 2013/10/4 Pavel Krivanek <pavel.krivanek(a)gmail.com>: >> >> Thanks, this seems to work: >> >> defaultSpec >> >> | layout | >> layout := SpecLayout composed. >> self pluginClasses do: [ :c | >> layout add: {#model. #class. #pluginOf:. c. #defaultSpec} ]. >> >> ^ layout. >> >> >> plugin code on the instance side looks like this: >> >> defaultSpec >> >> ^ SpecLayout composed >> newRow:[: r | >> r add: #finderButtonModel; >> add: #browserButtonModel] >> height: 25. >> >> >> -- Pavel >> >> 2013/10/4 Benjamin <Benjamin.VanRyseghem.Pharo(a)gmail.com>: >> >> Since you are doing some really edge use of Spec, >> it's not covered by Spec easily. >> >> But if on you model you have a method returning your pluginClasses, you >> could do maybe: >> >> | layout | >> layout := SpecLayout composed. >> self pluginClasses do: [ :c | >> layout add: {#model. pluginOf:. c} ] >> >> I am not sure it works, but it worth a try :P >> >> Ben >> >> On Oct 4, 2013, at 9:28 PM, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: >> >> This was the original code for the spec that embeds plugins. As you >> can see, it had to use ugly addMorph:. I do not think that I need to >> do something special. Has the current Spec a better way how to do >> that? >> >> defaultSpec >> >> | spec | >> spec := OrderedCollection with: #ContainerModel. >> spec addAll: {#changeTableLayout. >> #listDirection:. #topToBottom. >> #hResizing:. #spaceFill. >> #vResizing:. #spaceFill.}. >> self pluginClasses do: [:c | >> spec add: #addMorph:. >> spec add: {(self pluginOf: c) defaultSpec}]. >> ^ spec asArray. >> >> 2013/10/4 Pavel Krivanek <pavel.krivanek(a)gmail.com>: >> >> In other words... I have a model that has some plugins. I need to >> generate a spec that embeds specs generated for each plugin. Models >> for this embedded specs must be the plugins, not the original model. >> >> -- Pavel >> >> 2013/10/4 Pavel Krivanek <pavel.krivanek(a)gmail.com>: >> >> well, and the version with "SpecLayout composed" when I do not need >> direct fractions? >> >> ^ SpecLayout composed >> newRow:[: r | >> r add: #finderButtonModel] >> height: 25 >> >> How to send #finderButtonModel to different object than SpecInterpreter >> model? >> >> -- Pavel >> >> 2013/10/4 Benjamin <Benjamin.VanRyseghem.Pharo(a)gmail.com>: >> >> ^{ #ContainerModel. >> >> #vShrinkWrap. >> >> #add:. {{self. #finderButtonModel}. >> >> #layout:. #(FrameLayout >> >> rightFraction: 0.125)}. >> >> #add:. {{self. #browserButtonModel}. >> >> #layout:. #(FrameLayout >> >> leftFraction: 0.125 >> rightFraction: 0.25)}} >> >> This should work, but looks strange though :P >> >> Ben >> >> On Oct 4, 2013, at 8:13 PM, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: >> >> Ben, >> >> how now should look code like this: >> >> defaultSpec >> >> ^{ #ComposableSpec. >> #vResizing:. #shrinkWrap. >> #add:. {{self. #finderButtonModel}. >> #layout:. #(FrameLayout >> rightFraction: 0.125)}. >> #add:. {{self. #browserButtonModel}. >> #layout:. #(FrameLayout >> leftFraction: 0.125 >> rightFraction: 0.25)}} >> >> -- Pavel >> >> 2013/10/4 Benjamin <Benjamin.VanRyseghem.Pharo(a)gmail.com>: >> >> For Spec users: >> >> The change is mostly backward compatible :) >> 2 things really changed: >> - direct access to a model's widget is not returning what it used to return. >> This is done on purpose since >> it's very often a bad idea to directly access the widget. >> - some behaviour on trees are now only available after the tree build. This >> is because some properties >> have been moved on the adapter directly, which is reachable only after the >> model build. >> You can use `whenBuiltDo:` to add post-build actions. >> >> Enjoy this new Spec :P >> >> Ben >> >> On Oct 4, 2013, at 2:31 PM, Marcus Denker <marcus.denker(a)inria.fr> wrote: >> >> 30448 >> ----- >> >> 11740 Remove Morphic dependency from Spec >> https://pharo.fogbugz.com/f/cases/11740 >> >> A Huge change from Ben... >> >> Diff information: >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tools-MarcusDenker.1292.diff >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tabs-MarcusDenker.33.diff >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Widgets-MarcusDenker.265… >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Tools-MarcusDenker.150.d… >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Tests-MarcusDenker.35.di… >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-MorphicAdapters-MarcusDe… >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-PolyWidgets-MarcusDenker… >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Layout-MarcusDenker.58.d… >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Inspector-MarcusDenker.1… >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Examples-MarcusDenker.48… >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Debugger-MarcusDenker.16… >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Core-MarcusDenker.175.di… >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Builder-MarcusDenker.43.… >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Bindings-MarcusDenker.35… >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/NautilusRefactoring-MarcusDen… >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Adapters-MarcusDenker.3.… >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/Manifest-CriticBrowser-Marcus… >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/Keymapping-Tools-Spec-MarcusD… >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/KeyChain-MarcusDenker.58.diff >> http://smalltalkhub.com/mc/Pharo/Pharo30/main/HudsonBuildTools20-MarcusDenk… >> >> >> >> >> >> >> >> >> >

Oct. 5, 2013

Re: [Pharo-dev] [update 3.0] #30448

by Pavel Krivanek

Hi Ben, Gofer new smalltalkhubUser: 'PavelKrivanek' project: 'Periscope'; package: 'Periscope'; load. Nautilus pluginClasses add: {(Smalltalk at: #NautilusPeriscopePlugin). #none} . Very useful code: ;-) Periscope reset It still without experiments with own Morphic bindings, that will be the next step :-) Feel free to commit any changes. Chees, -- Pavel 2013/10/5 Benjamin <Benjamin.VanRyseghem.Pharo(a)gmail.com>: > Can you point me where to load your code and how to end up in a situation > where I can play with the spec ? :P > > Ben > > On Oct 4, 2013, at 11:11 PM, Pavel Krivanek <pavel.krivanek(a)gmail.com> > wrote: > > Damn, the last row of the last plugins fills all the window... > > -- Pavel > > 2013/10/4 Pavel Krivanek <pavel.krivanek(a)gmail.com>: > > Thanks, this seems to work: > > defaultSpec > > | layout | > layout := SpecLayout composed. > self pluginClasses do: [ :c | > layout add: {#model. #class. #pluginOf:. c. #defaultSpec} ]. > > ^ layout. > > > plugin code on the instance side looks like this: > > defaultSpec > > ^ SpecLayout composed > newRow:[: r | > r add: #finderButtonModel; > add: #browserButtonModel] > height: 25. > > > -- Pavel > > 2013/10/4 Benjamin <Benjamin.VanRyseghem.Pharo(a)gmail.com>: > > Since you are doing some really edge use of Spec, > it's not covered by Spec easily. > > But if on you model you have a method returning your pluginClasses, you > could do maybe: > > | layout | > layout := SpecLayout composed. > self pluginClasses do: [ :c | > layout add: {#model. pluginOf:. c} ] > > I am not sure it works, but it worth a try :P > > Ben > > On Oct 4, 2013, at 9:28 PM, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: > > This was the original code for the spec that embeds plugins. As you > can see, it had to use ugly addMorph:. I do not think that I need to > do something special. Has the current Spec a better way how to do > that? > > defaultSpec > > | spec | > spec := OrderedCollection with: #ContainerModel. > spec addAll: {#changeTableLayout. > #listDirection:. #topToBottom. > #hResizing:. #spaceFill. > #vResizing:. #spaceFill.}. > self pluginClasses do: [:c | > spec add: #addMorph:. > spec add: {(self pluginOf: c) defaultSpec}]. > ^ spec asArray. > > 2013/10/4 Pavel Krivanek <pavel.krivanek(a)gmail.com>: > > In other words... I have a model that has some plugins. I need to > generate a spec that embeds specs generated for each plugin. Models > for this embedded specs must be the plugins, not the original model. > > -- Pavel > > 2013/10/4 Pavel Krivanek <pavel.krivanek(a)gmail.com>: > > well, and the version with "SpecLayout composed" when I do not need > direct fractions? > > ^ SpecLayout composed > newRow:[: r | > r add: #finderButtonModel] > height: 25 > > How to send #finderButtonModel to different object than SpecInterpreter > model? > > -- Pavel > > 2013/10/4 Benjamin <Benjamin.VanRyseghem.Pharo(a)gmail.com>: > > ^{ #ContainerModel. > > #vShrinkWrap. > > #add:. {{self. #finderButtonModel}. > > #layout:. #(FrameLayout > > rightFraction: 0.125)}. > > #add:. {{self. #browserButtonModel}. > > #layout:. #(FrameLayout > > leftFraction: 0.125 > rightFraction: 0.25)}} > > This should work, but looks strange though :P > > Ben > > On Oct 4, 2013, at 8:13 PM, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: > > Ben, > > how now should look code like this: > > defaultSpec > > ^{ #ComposableSpec. > #vResizing:. #shrinkWrap. > #add:. {{self. #finderButtonModel}. > #layout:. #(FrameLayout > rightFraction: 0.125)}. > #add:. {{self. #browserButtonModel}. > #layout:. #(FrameLayout > leftFraction: 0.125 > rightFraction: 0.25)}} > > -- Pavel > > 2013/10/4 Benjamin <Benjamin.VanRyseghem.Pharo(a)gmail.com>: > > For Spec users: > > The change is mostly backward compatible :) > 2 things really changed: > - direct access to a model's widget is not returning what it used to return. > This is done on purpose since > it's very often a bad idea to directly access the widget. > - some behaviour on trees are now only available after the tree build. This > is because some properties > have been moved on the adapter directly, which is reachable only after the > model build. > You can use `whenBuiltDo:` to add post-build actions. > > Enjoy this new Spec :P > > Ben > > On Oct 4, 2013, at 2:31 PM, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > 30448 > ----- > > 11740 Remove Morphic dependency from Spec > https://pharo.fogbugz.com/f/cases/11740 > > A Huge change from Ben... > > Diff information: > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tools-MarcusDenker.1292.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tabs-MarcusDenker.33.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Widgets-MarcusDenker.265… > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Tools-MarcusDenker.150.d… > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Tests-MarcusDenker.35.di… > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-MorphicAdapters-MarcusDe… > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-PolyWidgets-MarcusDenker… > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Layout-MarcusDenker.58.d… > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Inspector-MarcusDenker.1… > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Examples-MarcusDenker.48… > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Debugger-MarcusDenker.16… > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Core-MarcusDenker.175.di… > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Builder-MarcusDenker.43.… > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Bindings-MarcusDenker.35… > http://smalltalkhub.com/mc/Pharo/Pharo30/main/NautilusRefactoring-MarcusDen… > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Spec-Adapters-MarcusDenker.3.… > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Manifest-CriticBrowser-Marcus… > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Keymapping-Tools-Spec-MarcusD… > http://smalltalkhub.com/mc/Pharo/Pharo30/main/KeyChain-MarcusDenker.58.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/HudsonBuildTools20-MarcusDenk… > > > > > > > > >

Oct. 5, 2013

Re: [Pharo-dev] additional Milestone label for applications

by btc＠openinworld.com

Oct. 5, 2013

Re: [Pharo-dev] add me to the PharoExtras/Gettext package please

by Camillo Bruni

ok found it :), you're in On 2013-10-05, at 18:22, Camillo Bruni <camillobruni(a)gmail.com> wrote: > Which username? > > On 2013-10-05, at 18:14, Paul DeBruicker <pdebruic(a)gmail.com> wrote: > >> The Configuration there doesn't reference the Seaside related packages or the Gemstone version so I'd like to upload a config that does. >> >> >> >> >> Thanks >> >> Paul >

Oct. 5, 2013

Re: [Pharo-dev] add me to the PharoExtras/Gettext package please

by Camillo Bruni

Which username? On 2013-10-05, at 18:14, Paul DeBruicker <pdebruic(a)gmail.com> wrote: > The Configuration there doesn't reference the Seaside related packages or the Gemstone version so I'd like to upload a config that does. > > > > > Thanks > > Paul

Oct. 5, 2013

[update 3.0] #30454

by Marcus Denker

30454 ----- 11768 Small Code Critic cleanup of UpdateStreamer https://pharo.fogbugz.com/f/cases/11768 11785 add menu entry to run cleanup in the system menu https://pharo.fogbugz.com/f/cases/11785 11726 Code Critic: Variable used but not defined anywhere is wrong https://pharo.fogbugz.com/f/cases/11726 Diff information: http://smalltalkhub.com/mc/Pharo/Pharo30/main/UpdateStreamer-Core-MarcusDen… http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Support-MarcusDenker.9… http://smalltalkhub.com/mc/Pharo/Pharo30/main/Refactoring-Critics-MarcusDen… http://smalltalkhub.com/mc/Pharo/Pharo30/main/Morphic-Base-MarcusDenker.143…

Oct. 5, 2013

add me to the PharoExtras/Gettext package please

by Paul DeBruicker

The Configuration there doesn't reference the Seaside related packages or the Gemstone version so I'd like to upload a config that does. Thanks Paul

Oct. 5, 2013

Re: [Pharo-dev] additional Milestone label for applications

by Camillo Bruni

On 2013-10-05, at 09:47, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > On Oct 4, 2013, at 7:37 PM, btc(a)openinworld.com wrote: > >> btc(a)openinworld.com wrote: >>> I've been advised that for application related issues tracked on Fogbugz (e.g. for PharoLauncher) to avoid tagging the Milestone as 'Pharo3.0' - which is reserved for image related issues. Fair enough, but the only available alternative 'Later' just doesn't seem a good fit. Can adding another milestone be considered, like 'non-image' or 'application'. >>> btw, my reasoning for tagging with Pharo3.0 was to do with the idea of simultaneous release [1] of related tools with the image. With the CI now operating for a lot of projects, it is not unfeasible that such a co-ordinated release occur. This might be good to encourage participation in testing and bug hunting in the final weeks and maybe speed the uptake of 3.0. On the other hand, it might unreasonably stretch resources trying to co-ordinate it. >>> >>> [1] http://wiki.eclipse.org/Simultaneous_Release >>> >>> cheers -ben >>> >> Elsewhere I see a comment by Marcus that "we need to find a way how to use the bug tracker for projects..." I notice there is already a Projects field while the Areas field is entirely unused (perhaps this is from following the guidelines of [2]). One option might be recategorizing many of the existing Projects as Areas under one Project='Image'. Maybe that would require an unreasonable effort to implement, but I float the idea anyway. Perhaps the Fogbugz sysadmins have some tools that could assist. >> > > So the idea is that I want to have filter for > > "Need to be reviewed" > "need to be integrated" > > that are possible to get to empty (that is: that are only related to the image itself). > > https://pharo.fogbugz.com/f/filters/36/Review > https://pharo.fogbugz.com/f/filters/35/Integration > > e.g. > > https://pharo.fogbugz.com/f/filters/35/Integration > > has two issues that I can't act uppon. So they are not "to be included, because I can not > include them. > > How do we make a filter that shows me not the other projects? > > Marcus > I think it should just be fine if we define a different workflow (and thus different labels) for external projects...

Oct. 5, 2013

Re: [Pharo-dev] additional Milestone label for applications

by btc＠openinworld.com

Oct. 5, 2013