- Pharo-dev - lists.pharo.org

Start with a trivial improvement!

by Marcus Denker

One nice way to get in the mood of doing (and at the same time testing the system) is to start with trivial improvements. This is especially nice as a "starter" when you never contributed any change to Pharo. And by trivial I mean *really* mean trivial: -> a typo in a comment -> remove a temp not accessed -> clean out some trivial dead code -> do a simplistic refactoring of a bad smell, even inside a single method -> document something -> structure bad stuff better so it is easier to replace later Taken in itself, single changes like these have no influence, but: -> they get you in a mood of doing. -> they make you feel that Pharo is "owned" by you. -> take 1000 of those trivialities and they *do* make a difference. -> next time something bothers you, you will have the context of "I can just fix it". The critic tools is one way of finding these places, another is to just note down every time you see a triviality and later go through that list. The bug tracker can be source, too. Marcus

Oct. 10, 2013

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/30468 Home: https://github.com/pharo-project/pharo-core

Oct. 10, 2013

[pharo-project/pharo-core] 37e993: 30468

by GitHub

Branch: refs/heads/3.0 Home: https://github.com/pharo-project/pharo-core Commit: 37e993116ec8882e0a9fd775488cd4938f2666be https://github.com/pharo-project/pharo-core/commit/37e993116ec8882e0a9fd775… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2013-10-10 (Thu, 10 Oct 2013) Changed paths: A ScriptLoader30.package/ScriptLoader.class/instance/pharo - scripts/script123.st A ScriptLoader30.package/ScriptLoader.class/instance/pharo - updates/update30468.st M ScriptLoader30.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st A Spec-MorphicAdapters.package/AbstractMorphicAdapter.class/instance/testing/isMorphicAdapter.st A Spec-MorphicAdapters.package/extension/AbstractAdapter/instance/isMorphicAdapter.st A Spec-MorphicAdapters.package/extension/ComposableModel/instance/beginsWith_fromList_.st A Spec-MorphicAdapters.package/extension/ComposableModel/instance/ensureMorphicAdapter.st A Spec-MorphicAdapters.package/extension/ComposableModel/instance/ensureMorphicAdapterDo_.st A Spec-MorphicAdapters.package/extension/ComposableModel/instance/heightToDisplayInList_.st A Spec-MorphicAdapters.package/extension/ComposableModel/instance/heightToDisplayInTree_.st A Spec-MorphicAdapters.package/extension/ComposableModel/instance/listRenderOn_atRow_bounds_color_backgroundColor_from_.st A Spec-MorphicAdapters.package/extension/ComposableModel/instance/treeRenderOn_bounds_color_font_from_.st A Spec-MorphicAdapters.package/extension/ComposableModel/instance/widthToDisplayInList_.st A Spec-MorphicAdapters.package/extension/ComposableModel/instance/widthToDisplayInTree_.st Log Message: ----------- 30468 11786 CheckBoxModel>>doesNotUnderstand: #widthToDisplayInList: https://pharo.fogbugz.com/f/cases/11786 http://files.pharo.org/image/30/30468.zip

Oct. 10, 2013

Re: [Pharo-dev] [PROVENANCE INTERNET] Re: Please contributors fill up this form...

by Benjamin

PharoContributor new name: 'Benjamin Van Ryseghem'; id: 'BenjaminVanRyseghem'; email: 'benjamin.vanryseghem.pharo(a)gmail.com'; website: 'benjamin.vanryseghem.com'; description: 'Pharo core. Morphic maintainer. Spec author. Nautilus author. Responsible of quite some UIs'; image: 'http://www.gravatar.com/avatar/7367a4e9e6a838db7cd1b0ecdc234934.png'; yourself Ben On Oct 10, 2013, at 10:39 AM, Guillermo Polito <guillermopolito(a)gmail.com> wrote: > PharoContributor new > name: 'Guille Polito'; > id: 'guillep'; > email: 'guillermopolito(a)gmail.com'; > website: 'playingwithobjects.wordpress.com'; > description: 'Pharo core. Pharo bootstrap, DBXTalk, Keymappings, have traveled a bit to Mars, ocassional VMer. The wizard of Oz.'; > image: 'http://www.gravatar.com/avatar/e50b0970fbf94e7086ad065995e55b59.png'; > yourself

Oct. 10, 2013

Re: [Pharo-dev] CheckBoxModel DNU widthToDisplayInList

by Camillo Bruni

duplicate of https://pharo.fogbugz.com/f/cases/11786/CheckBoxModel-doesNotUnderstand-wid… On 2013-10-10, at 10:27, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Hi guys > > When I want to extract a method I get CheckBoxModel DNU widthToDisplayInList in 30467 > > heightToDisplayInList: is also missing > > https://pharo.fogbugz.com/f/cases/11838/CheckBoxModel-DNU-widthToDisplayInL… > > > > hUnadjustedScrollRange > "Ok, this is a bit messed up. We need to return the width of the widest item in the list. If we grab every item in the list, it defeats the purpose of LazyListMorph. If we don't, then we don't know the size. > > This is a compromise -- find the widest of the first 30 items, then double it, This width will be updated as new items are installed, so it will always be correct for the visible items. If you know a better way, please chime in." > > | itemsToCheck item index | > "Check for a cached value" > maxWidth ifNotNil:[^maxWidth]. > > listItems isEmpty ifTrue: [^0]. "don't set maxWidth if empty do will be recomputed when there are some items" > "Compute from scratch" > itemsToCheck := 30 min: (listItems size). > maxWidth := 0. > > "Check the first few items to get a representative sample of the rest of the list." > index := 1. > [index < itemsToCheck] whileTrue: > [ item := self getListItem: index. "Be careful not to actually install this item" > maxWidth := maxWidth max: (item widthToDisplayInList: self). > ^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > index:= index + 1. > ]. > > "Add some initial fudge if we didn't check all the items." > (itemsToCheck < listItems size) ifTrue:[maxWidth := maxWidth*2]. > > ^maxWidth > >

Oct. 10, 2013

Re: [Pharo-dev] [PROVENANCE INTERNET] Re: Please contributors fill up this form...

by Pavel Krivanek

PharoContributor new name: 'Pavel Krivanek'; id: 'PavelKrivanek'; email: 'pavel.krivanek(a)gmail.com'; website: 'http://www.pharo.cz/'; description: 'Contributor to Pharo remodularization effort. XUL-based native UI (Phobos), Periscope'; yourself 2013/10/10 Usman Bhatti <usman.bhatti(a)gmail.com>: > Here's mine. > > PharoContributor new > name: 'Usman Bhatti'; > id: 'usmanbhatti'; > email: 'usman.bhatti(a)synectique.eu'; > website: 'http://chercheurs.lille.inria.fr/~bhatti/'; > description: 'Program analysis, visualizations, Moose, GetText'; > yourself > > > > On Thu, Oct 10, 2013 at 10:39 AM, Guillermo Polito > <guillermopolito(a)gmail.com> wrote: >> >> PharoContributor new >> name: 'Guille Polito'; >> id: 'guillep'; >> email: 'guillermopolito(a)gmail.com'; >> website: 'playingwithobjects.wordpress.com'; >> description: 'Pharo core. Pharo bootstrap, DBXTalk, >> Keymappings, have traveled a bit to Mars, ocassional VMer. The wizard of >> Oz.'; >> image: >> 'http://www.gravatar.com/avatar/e50b0970fbf94e7086ad065995e55b59.png'; >> yourself >> >> >> On Thu, Oct 10, 2013 at 10:28 AM, Goubier Thierry <thierry.goubier(a)cea.fr> >> wrote: >>> >>> Updated: >>> >>> >>> PharoContributor new >>> name: 'Thierry Goubier'; >>> id: 'ThierryGoubier'; >>> email: 'thierry.goubier(a)cea.fr'; >>> website: 'http://www-list.cea.fr'; >>> description: 'Parsers, language design and analysis, >>> alternative IDE, gitfiletree, SmaCC, code traces.'; >>> image: >>> 'http://www.gravatar.com/avatar/b89bd8455c784aff8852c6925cceb9fa.png'; >>> yourself >>> >>> >>> Thierry >>> >>> Le 10/10/2013 09:18, Goubier Thierry a Ã©crit : >>>> >>>> Hi Stef, >>>> >>>> here is mine. >>>> >>>> Thierry >>>> >>>> Le 09/10/2013 13:34, StÃ©phane Ducasse a Ã©crit : >>>>> >>>>> Hi guys >>>>> >>>>> >>>>> I would like to get >>>>> contributors.pharo.org a bit more representative of Pharo. >>>>> >>>>> We should have Previous contributors and enhance the current list. >>>>> Can you please reply to this mail >>>>> >>>>> PharoContributor new >>>>> name: 'Thierry Goubier'; >>>>> id: 'ThierryGoubier'; >>>>> email: 'thierry.goubier(a)cea.fr'; >>>>> website: 'http://www-list.cea.fr'; >>>>> description: 'Parsers, language design and analysis, >>>>> alternative IDE, gitfiletree, SmaCC, code traces.'; >>>>> image: >>>>> >>>>> 'http://www.gravatar.com/avatar/193af464509ae8fbcc04abad70b72fc0?s=120'; >>>>> yourself >>>>> >>>>> >>>>> Stef >>>>> >>>> >>> >>> -- >>> Thierry Goubier >>> CEA list >>> Laboratoire des Fondations des SystÃ¨mes Temps RÃ©el EmbarquÃ©s >>> 91191 Gif sur Yvette Cedex >>> France >>> Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95 >>> >> >

Oct. 10, 2013

Re: [Pharo-dev] [PROVENANCE INTERNET] Re: Please contributors fill up this form...

by Guillaume Larcheveque

PharoContributor new name: 'Guillaume Larcheveque'; id: 'guillaumelarcheveque'; email: 'guillaume.larcheveque(a)gmail.com'; description: 'Program analysis, visualizations, Moose, Artefact, Parsers'; yourself 2013/10/10 Usman Bhatti <usman.bhatti(a)gmail.com> > Here's mine. > > PharoContributor new > name: 'Usman Bhatti'; > id: 'usmanbhatti'; > email: 'usman.bhatti(a)synectique.eu'; > website: 'http://chercheurs.lille.inria.fr/~bhatti/'; > description: 'Program analysis, visualizations, Moose, GetText'; > yourself > > > > On Thu, Oct 10, 2013 at 10:39 AM, Guillermo Polito < > guillermopolito(a)gmail.com> wrote: > >> PharoContributor new >> name: 'Guille Polito'; >> id: 'guillep'; >> email: 'guillermopolito(a)gmail.com <estebanlm(a)gmail.com>'; >> website: 'playingwithobjects.wordpress.com<http://smallworks.eu/> >> '; >> description: 'Pharo core. Pharo bootstrap, DBXTalk, >> Keymappings, have traveled a bit to Mars, ocassional VMer. The wizard of >> Oz.'; >> image: '* >> http://www.gravatar.com/avatar/e50b0970fbf94e7086ad065995e55b59.png*'; >> yourself >> >> >> On Thu, Oct 10, 2013 at 10:28 AM, Goubier Thierry <thierry.goubier(a)cea.fr >> > wrote: >> >>> Updated: >>> >>> >>> PharoContributor new >>> name: 'Thierry Goubier'; >>> id: 'ThierryGoubier'; >>> email: 'thierry.goubier(a)cea.fr'; >>> website: 'http://www-list.cea.fr'; >>> description: 'Parsers, language design and analysis, >>> alternative IDE, gitfiletree, SmaCC, code traces.'; >>> image: 'http://www.gravatar.com/**avatar/** >>> b89bd8455c784aff8852c6925cceb9**fa.png<http://www.gravatar.com/avatar/b89bd8455c784aff8852c6925cceb9fa.png> >>> '; >>> yourself >>> >>> >>> Thierry >>> >>> Le 10/10/2013 09:18, Goubier Thierry a Ã©crit : >>> >>>> Hi Stef, >>>> >>>> here is mine. >>>> >>>> Thierry >>>> >>>> Le 09/10/2013 13:34, StÃ©phane Ducasse a Ã©crit : >>>> >>>>> Hi guys >>>>> >>>>> >>>>> I would like to get >>>>> contributors.pharo.org a bit more representative of Pharo. >>>>> >>>>> We should have Previous contributors and enhance the current list. >>>>> Can you please reply to this mail >>>>> >>>>> PharoContributor new >>>>> name: 'Thierry Goubier'; >>>>> id: 'ThierryGoubier'; >>>>> email: 'thierry.goubier(a)cea.fr'; >>>>> website: 'http://www-list.cea.fr'; >>>>> description: 'Parsers, language design and analysis, >>>>> alternative IDE, gitfiletree, SmaCC, code traces.'; >>>>> image: >>>>> 'http://www.gravatar.com/**avatar/**193af464509ae8fbcc04abad70b72f** >>>>> c0?s=120<http://www.gravatar.com/avatar/193af464509ae8fbcc04abad70b72fc0?s=120> >>>>> '; >>>>> yourself >>>>> >>>>> >>>>> Stef >>>>> >>>>> >>>> >>> -- >>> Thierry Goubier >>> CEA list >>> Laboratoire des Fondations des SystÃ¨mes Temps RÃ©el EmbarquÃ©s >>> 91191 Gif sur Yvette Cedex >>> France >>> Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95 >>> >>> >> > -- *Guillaume Larcheveque*

Oct. 10, 2013

Re: [Pharo-dev] [PROVENANCE INTERNET] Re: Please contributors fill up this form...

by Usman Bhatti

Here's mine. PharoContributor new name: 'Usman Bhatti'; id: 'usmanbhatti'; email: 'usman.bhatti(a)synectique.eu'; website: 'http://chercheurs.lille.inria.fr/~bhatti/'; description: 'Program analysis, visualizations, Moose, GetText'; yourself On Thu, Oct 10, 2013 at 10:39 AM, Guillermo Polito < guillermopolito(a)gmail.com> wrote: > PharoContributor new > name: 'Guille Polito'; > id: 'guillep'; > email: 'guillermopolito(a)gmail.com <estebanlm(a)gmail.com>'; > website: 'playingwithobjects.wordpress.com<http://smallworks.eu/> > '; > description: 'Pharo core. Pharo bootstrap, DBXTalk, > Keymappings, have traveled a bit to Mars, ocassional VMer. The wizard of > Oz.'; > image: '* > http://www.gravatar.com/avatar/e50b0970fbf94e7086ad065995e55b59.png*'; > yourself > > > On Thu, Oct 10, 2013 at 10:28 AM, Goubier Thierry <thierry.goubier(a)cea.fr>wrote: > >> Updated: >> >> >> PharoContributor new >> name: 'Thierry Goubier'; >> id: 'ThierryGoubier'; >> email: 'thierry.goubier(a)cea.fr'; >> website: 'http://www-list.cea.fr'; >> description: 'Parsers, language design and analysis, >> alternative IDE, gitfiletree, SmaCC, code traces.'; >> image: 'http://www.gravatar.com/**avatar/** >> b89bd8455c784aff8852c6925cceb9**fa.png<http://www.gravatar.com/avatar/b89bd8455c784aff8852c6925cceb9fa.png> >> '; >> yourself >> >> >> Thierry >> >> Le 10/10/2013 09:18, Goubier Thierry a Ã©crit : >> >>> Hi Stef, >>> >>> here is mine. >>> >>> Thierry >>> >>> Le 09/10/2013 13:34, StÃ©phane Ducasse a Ã©crit : >>> >>>> Hi guys >>>> >>>> >>>> I would like to get >>>> contributors.pharo.org a bit more representative of Pharo. >>>> >>>> We should have Previous contributors and enhance the current list. >>>> Can you please reply to this mail >>>> >>>> PharoContributor new >>>> name: 'Thierry Goubier'; >>>> id: 'ThierryGoubier'; >>>> email: 'thierry.goubier(a)cea.fr'; >>>> website: 'http://www-list.cea.fr'; >>>> description: 'Parsers, language design and analysis, >>>> alternative IDE, gitfiletree, SmaCC, code traces.'; >>>> image: >>>> 'http://www.gravatar.com/**avatar/**193af464509ae8fbcc04abad70b72f** >>>> c0?s=120<http://www.gravatar.com/avatar/193af464509ae8fbcc04abad70b72fc0?s=120> >>>> '; >>>> yourself >>>> >>>> >>>> Stef >>>> >>>> >>> >> -- >> Thierry Goubier >> CEA list >> Laboratoire des Fondations des SystÃ¨mes Temps RÃ©el EmbarquÃ©s >> 91191 Gif sur Yvette Cedex >> France >> Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95 >> >> >

Oct. 10, 2013

Re: [Pharo-dev] How to delete an obsolete class ?

by Pavel Krivanek

Hi Olivier, firstly try Smalltalk fixObsoleteReferences. Then try this: Smalltalk tools pointerExplorer openOn: SystemNavigation default obsoleteClasses first. Look at every reference that is not related to the explorer itself and try to find why it is not garbage-collected. Cheers, -- Pavel 2013/10/10 Olivier Auverlot <olivier.auverlot(a)gmail.com>: > Hi Pavel, > > Thanks for your response. > > I tryed this morning and in fact, the obsolete class has not instances. > > SystemNavigation default obsoleteClasses {AnObsoletePVENodeStatus} > > SystemNavigation default obsoleteClasses collect: #allSubInstances. an Array(an OrderedCollection()) > > have you an idea how to remove this class ? > > Best regards > Olivier ;-) > > Le 9 oct. 2013 Ã 10:46, Pavel Krivanek a Ã©crit : > >> You need to check if it still does have some instances and kill them. >> Then find and remove all references to the class. >> >> SystemNavigation default obsoleteClasses. >> >> SystemNavigation default obsoleteClasses collect: #allSubInstances. >> >> SystemNavigation default obsoleteClasses first allSubInstances first pointersTo. >> >> etc... >> >> Good hunt >> -- Pavel >> >> 2013/10/9 Olivier Auverlot <olivier.auverlot(a)gmail.com>: >>> Hi, >>> >>> In my project, my code has a strange behavior when I'm reading all subclasses of an another class. >>> >>> The following code must visit all the subclasses of PVEStatus but I get a bad result. >>> >>> PVEStatus allSubclasses >>> do: [ :statusDatatype | >>> (aRawStatus at: 'type') = statusDatatype type >>> ifTrue: [ ^ statusDatatype getStatus: aRawStatus callback: self ] ] >>> >>> The answer contains #AnObsoletePVENodeStatus and this class doesn't exist. She doesn't appear in the class browser. I suppose that it's a rest of refactoring. How can I delete this obsolete class ? >>> >>> Best regards >>> Olivier ;-) >>> >>> >>> >> > >

Oct. 10, 2013

Re: [Pharo-dev] [PROVENANCE INTERNET] Re: Please contributors fill up this form...

by Guillermo Polito

PharoContributor new name: 'Guille Polito'; id: 'guillep'; email: 'guillermopolito(a)gmail.com <estebanlm(a)gmail.com>'; website: 'playingwithobjects.wordpress.com<http://smallworks.eu/> '; description: 'Pharo core. Pharo bootstrap, DBXTalk, Keymappings, have traveled a bit to Mars, ocassional VMer. The wizard of Oz.'; image: '* http://www.gravatar.com/avatar/e50b0970fbf94e7086ad065995e55b59.png*'; yourself On Thu, Oct 10, 2013 at 10:28 AM, Goubier Thierry <thierry.goubier(a)cea.fr>wrote: > Updated: > > > PharoContributor new > name: 'Thierry Goubier'; > id: 'ThierryGoubier'; > email: 'thierry.goubier(a)cea.fr'; > website: 'http://www-list.cea.fr'; > description: 'Parsers, language design and analysis, > alternative IDE, gitfiletree, SmaCC, code traces.'; > image: 'http://www.gravatar.com/**avatar/** > b89bd8455c784aff8852c6925cceb9**fa.png<http://www.gravatar.com/avatar/b89bd8455c784aff8852c6925cceb9fa.png> > '; > yourself > > > Thierry > > Le 10/10/2013 09:18, Goubier Thierry a Ã©crit : > >> Hi Stef, >> >> here is mine. >> >> Thierry >> >> Le 09/10/2013 13:34, StÃ©phane Ducasse a Ã©crit : >> >>> Hi guys >>> >>> >>> I would like to get >>> contributors.pharo.org a bit more representative of Pharo. >>> >>> We should have Previous contributors and enhance the current list. >>> Can you please reply to this mail >>> >>> PharoContributor new >>> name: 'Thierry Goubier'; >>> id: 'ThierryGoubier'; >>> email: 'thierry.goubier(a)cea.fr'; >>> website: 'http://www-list.cea.fr'; >>> description: 'Parsers, language design and analysis, >>> alternative IDE, gitfiletree, SmaCC, code traces.'; >>> image: >>> 'http://www.gravatar.com/**avatar/**193af464509ae8fbcc04abad70b72f** >>> c0?s=120<http://www.gravatar.com/avatar/193af464509ae8fbcc04abad70b72fc0?s=120> >>> '; >>> yourself >>> >>> >>> Stef >>> >>> >> > -- > Thierry Goubier > CEA list > Laboratoire des Fondations des SystÃ¨mes Temps RÃ©el EmbarquÃ©s > 91191 Gif sur Yvette Cedex > France > Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95 > >

Oct. 10, 2013