- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Contribute to pharo8.0 ?

by Guillermo Polito

Hi, there is an issue for this problem, https://github.com/pharo-project/pharo/issues/2379 We have identified the cause, I'll propose a fix now On Wed, Jan 30, 2019 at 8:44 AM ducasse <stepharo(a)netcourrier.com> wrote: > > > > There is currently a bug eating one character of the commit hash. So > > Iceberg does not find the hash and thinks we need a fetch. So currently > > we need to checkout Pharo8.0 in order to be in a good state :( > > OOPs is there a bug entry? > > > >> I also don't understand how to make an issue branch for > >> > >> https://github.com/pharo-project/pharo/issues/2395 > >> > >> Is it Iceberg > Pharo > Create new branch for issue or Iceberg > Github > > Create new branch for issue ? > > > > Just create a branch and choose the option to create a branch from a > > Github option. > > > > The other one was for Manuscript and is now useless for Pharo 8. I > > opened an issue in Iceberg to remove it but I did not got the time to > > contribute the change. > > > >> What is the difference ? > >> What about the Remote ? > >> Can I work with only an issue on GitHub ? > >> > > > > Yes! > > > > What I am doing currently: > > > > - Open an issue XX > > - Sync my fork Pharo8.0 branch via command line (This is optional and > > can also be done in Pharo. I just do it via command line because I like > > it better that way) > > how do you do it? Pull? > > > - Download a Pharo 8 image > > - Checkout the Pharo8.0 branch to get in a clean state because of the > > hash eating bug I mentioned earlier > > - Create a new branch from a github issue of the pharo remote > > - Do the changes and commit. I add `Fixes #XX` in the commit message to > > close automatically the issue when the PR is merged. > > - Push to my remote > > - Open a PR against Pharo8.0 through Iceberg > GitHub > Create new pull > > request > > and checkout the pharo 8 branch to fix the next one. > > > >> Is the documentation > >> > >> https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo > >> > >> really up to date ? > >> > > > > No > > > > We should correct the hash eating bug before updating it I think. > > > >> Sven > >> > >> > > > > > > -- > > Cyril Ferlicot > > https://ferlicot.fr > > > > > > -- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

Jan. 30, 2019

[Pharo 7.0] Build #146: Revert "18764-Remove-external-dependencies-from-Kernel-Tests-"

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #146 was: SUCCESS. The Pull Request #2411 was integrated: "Revert "18764-Remove-external-dependencies-from-Kernel-Tests-"" Pull request url: https://github.com/pharo-project/pharo/pull/2411 Issue Url: https://pharo.fogbugz.com/f/cases/revert Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Jan. 30, 2019

Re: [Pharo-dev] Contribute to pharo8.0 ?

by ducasse

> > There is currently a bug eating one character of the commit hash. So > Iceberg does not find the hash and thinks we need a fetch. So currently > we need to checkout Pharo8.0 in order to be in a good state :( OOPs is there a bug entry? > >> I also don't understand how to make an issue branch for >> >> https://github.com/pharo-project/pharo/issues/2395 >> >> Is it Iceberg > Pharo > Create new branch for issue or Iceberg > Github > Create new branch for issue ? > > Just create a branch and choose the option to create a branch from a > Github option. > > The other one was for Manuscript and is now useless for Pharo 8. I > opened an issue in Iceberg to remove it but I did not got the time to > contribute the change. > >> What is the difference ? >> What about the Remote ? >> Can I work with only an issue on GitHub ? >> > > Yes! > > What I am doing currently: > > - Open an issue XX > - Sync my fork Pharo8.0 branch via command line (This is optional and > can also be done in Pharo. I just do it via command line because I like > it better that way) how do you do it? Pull? > - Download a Pharo 8 image > - Checkout the Pharo8.0 branch to get in a clean state because of the > hash eating bug I mentioned earlier > - Create a new branch from a github issue of the pharo remote > - Do the changes and commit. I add `Fixes #XX` in the commit message to > close automatically the issue when the PR is merged. > - Push to my remote > - Open a PR against Pharo8.0 through Iceberg > GitHub > Create new pull > request and checkout the pharo 8 branch to fix the next one. > >> Is the documentation >> >> https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo >> >> really up to date ? >> > > No > > We should correct the hash eating bug before updating it I think. > >> Sven >> >> > > > -- > Cyril Ferlicot > https://ferlicot.fr >

Jan. 30, 2019

Re: [Pharo-dev] Contribute to pharo8.0 ?

by ducasse

Hi Sven > Hi, > > I am trying my first contribution / PR to pharo8.0 Excellent > I started with a latest zeroconfig 8.0 image/vm and I deleted my old fork and made a new one. > > But repairing the repository by fetching does not bring it to the detached state Often I do repair and I create a default branch. I call it bottom* > I also don't understand how to make an issue branch for > > https://github.com/pharo-project/pharo/issues/2395 > > Is it Iceberg > Pharo > Create new branch for issue or Iceberg > Github > Create new branch for issue ? > What is the difference ? I think that when you do a icebveg github then you you will query the published issues. with the other you just create a branch > What about the Remote ? you should point to the pharo remote and not your fork so that you do not get an invalid > Can I work with only an issue on GitHub ? No you can create a branch with your own name. > Is the documentation > > https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo > > really up to date ? probably not. > > Sven > >

Jan. 30, 2019

Re: [Pharo-dev] Contribute to pharo8.0 ?

by Cyril Ferlicot D.

Le 29/01/2019 Ã 23:47, Sven Van Caekenberghe a Ã©critÂ : > Hi, > > I am trying my first contribution / PR to pharo8.0 > > I started with a latest zeroconfig 8.0 image/vm and I deleted my old fork and made a new one. > > But repairing the repository by fetching does not bring it to the detached state > Hi, There is currently a bug eating one character of the commit hash. So Iceberg does not find the hash and thinks we need a fetch. So currently we need to checkout Pharo8.0 in order to be in a good state :( > I also don't understand how to make an issue branch for > > https://github.com/pharo-project/pharo/issues/2395 > > Is it Iceberg > Pharo > Create new branch for issue or Iceberg > Github > Create new branch for issue ? Just create a branch and choose the option to create a branch from a Github option. The other one was for Manuscript and is now useless for Pharo 8. I opened an issue in Iceberg to remove it but I did not got the time to contribute the change. > What is the difference ? > What about the Remote ? > Can I work with only an issue on GitHub ? > Yes! What I am doing currently: - Open an issue XX - Sync my fork Pharo8.0 branch via command line (This is optional and can also be done in Pharo. I just do it via command line because I like it better that way) - Download a Pharo 8 image - Checkout the Pharo8.0 branch to get in a clean state because of the hash eating bug I mentioned earlier - Create a new branch from a github issue of the pharo remote - Do the changes and commit. I add `Fixes #XX` in the commit message to close automatically the issue when the PR is merged. - Push to my remote - Open a PR against Pharo8.0 through Iceberg > GitHub > Create new pull request > Is the documentation > > https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo > > really up to date ? > No We should correct the hash eating bug before updating it I think. > Sven > > -- Cyril Ferlicot https://ferlicot.fr

Jan. 29, 2019

Contribute to pharo8.0 ?

by Sven Van Caekenberghe

Hi, I am trying my first contribution / PR to pharo8.0 I started with a latest zeroconfig 8.0 image/vm and I deleted my old fork and made a new one. But repairing the repository by fetching does not bring it to the detached state I also don't understand how to make an issue branch for https://github.com/pharo-project/pharo/issues/2395 Is it Iceberg > Pharo > Create new branch for issue or Iceberg > Github > Create new branch for issue ? What is the difference ? What about the Remote ? Can I work with only an issue on GitHub ? Is the documentation https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo really up to date ? Sven

Jan. 29, 2019

[Pharo 7.0] Build #145: 18764-Remove-external-dependencies-from-Kernel-Tests-

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #145 was: SUCCESS. The Pull Request #1748 was integrated: "18764-Remove-external-dependencies-from-Kernel-Tests-" Pull request url: https://github.com/pharo-project/pharo/pull/1748 Issue Url: https://pharo.fogbugz.com/f/cases/18764 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Jan. 29, 2019

[Pharo 7.0] Build #144: Object-centric MetaLink integration.

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #144 was: FAILURE. The Pull Request #2120 was integrated: "Object-centric MetaLink integration." Pull request url: https://github.com/pharo-project/pharo/pull/2120 Issue Url: https://pharo.fogbugz.com/f/cases/22830 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Jan. 29, 2019

[Pharo 8.0] Build #43: 2247-Add-possibility-to-open-file-references-in-the-native-browser

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #43 was: SUCCESS. The Pull Request #2248 was integrated: "2247-Add-possibility-to-open-file-references-in-the-native-browser" Pull request url: https://github.com/pharo-project/pharo/pull/2248 Issue Url: https://pharo.fogbugz.com/f/cases/2247 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Jan. 29, 2019

[Pharo 8.0] Build #42: 2405-NewValueHolder-should-use-hook-to-get-its-value

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #42 was: SUCCESS. The Pull Request #2408 was integrated: "2405-NewValueHolder-should-use-hook-to-get-its-value" Pull request url: https://github.com/pharo-project/pharo/pull/2408 Issue Url: https://pharo.fogbugz.com/f/cases/2405 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Jan. 29, 2019