- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Contribute to pharo8.0 ?

by Sven Van Caekenberghe

OK, I think I did it ;-) https://github.com/pharo-project/pharo/pull/2433 > On 1 Feb 2019, at 16:35, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > > You need to select pharo-project remote (because issues are listed there). > > Esteban > >> On 1 Feb 2019, at 16:04, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >> >> I am still stuck. >> >> I did >> >> $ curl -L get.pharo.org/64/80+vm | bash >> >> Repaired by specifying my local clone >> >> Repaired by fetching >> >> Not in detached state, cannot make branch from issue, screenshot: >> >> <Screenshot 2019-02-01 at 16.01.17.png> >> >> What am I doing wrong ? >> >> How do other people do it ? >> >>> On 31 Jan 2019, at 08:18, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: >>> >>> It is working now again as expected. >>> >>> The only difference is that you need to use "Github-Create new branch for issue..." instead of "Pharo-Create new branch for issue..." for the new issues reported on GitHub. >>> >>> -- Pavel >>> >>> st 30. 1. 2019 v 9:42 odesÃlatel Guillermo Polito <guillermopolito(a)gmail.com> napsal: >>> Hi, >>> >>> there is an issue for this problem, >>> >>> https://github.com/pharo-project/pharo/issues/2379 >>> >>> We have identified the cause, I'll propose a fix now >>> >>> On Wed, Jan 30, 2019 at 8:44 AM ducasse <stepharo(a)netcourrier.com> wrote: >>> > >>> > There is currently a bug eating one character of the commit hash. So >>> > Iceberg does not find the hash and thinks we need a fetch. So currently >>> > we need to checkout Pharo8.0 in order to be in a good state :( >>> >>> OOPs is there a bug entry? >>> > >>> >> I also don't understand how to make an issue branch for >>> >> >>> >> https://github.com/pharo-project/pharo/issues/2395 >>> >> >>> >> Is it Iceberg > Pharo > Create new branch for issue or Iceberg > Github > Create new branch for issue ? >>> > >>> > Just create a branch and choose the option to create a branch from a >>> > Github option. >>> > >>> > The other one was for Manuscript and is now useless for Pharo 8. I >>> > opened an issue in Iceberg to remove it but I did not got the time to >>> > contribute the change. >>> > >>> >> What is the difference ? >>> >> What about the Remote ? >>> >> Can I work with only an issue on GitHub ? >>> >> >>> > >>> > Yes! >>> > >>> > What I am doing currently: >>> > >>> > - Open an issue XX >>> > - Sync my fork Pharo8.0 branch via command line (This is optional and >>> > can also be done in Pharo. I just do it via command line because I like >>> > it better that way) >>> >>> how do you do it? Pull? >>> >>> > - Download a Pharo 8 image >>> > - Checkout the Pharo8.0 branch to get in a clean state because of the >>> > hash eating bug I mentioned earlier >>> > - Create a new branch from a github issue of the pharo remote >>> > - Do the changes and commit. I add `Fixes #XX` in the commit message to >>> > close automatically the issue when the PR is merged. >>> > - Push to my remote >>> > - Open a PR against Pharo8.0 through Iceberg > GitHub > Create new pull >>> > request >>> >>> and checkout the pharo 8 branch to fix the next one. >>> > >>> >> Is the documentation >>> >> >>> >> https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo >>> >> >>> >> really up to date ? >>> >> >>> > >>> > No >>> > >>> > We should correct the hash eating bug before updating it I think. >>> > >>> >> Sven >>> >> >>> >> >>> > >>> > >>> > -- >>> > Cyril Ferlicot >>> > https://ferlicot.fr >>> > >>> >>> >>> >>> >>> >>> -- >>> >>> Guille Polito >>> Research Engineer >>> >>> Centre de Recherche en Informatique, Signal et Automatique de Lille >>> CRIStAL - UMR 9189 >>> French National Center for Scientific Research - http://www.cnrs.fr >>> >>> Web: http://guillep.github.io >>> Phone: +33 06 52 70 66 13 >> >

Feb. 1, 2019

Re: [Pharo-dev] Contribute to pharo8.0 ?

by Esteban Lorenzano

You need to select pharo-project remote (because issues are listed there). Esteban > On 1 Feb 2019, at 16:04, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > I am still stuck. > > I did > > $ curl -L get.pharo.org/64/80+vm <http://get.pharo.org/64/80+vm> | bash > > Repaired by specifying my local clone > > Repaired by fetching > > Not in detached state, cannot make branch from issue, screenshot: > > <Screenshot 2019-02-01 at 16.01.17.png> > > What am I doing wrong ? > > How do other people do it ? > >> On 31 Jan 2019, at 08:18, Pavel Krivanek <pavel.krivanek(a)gmail.com <mailto:pavel.krivanek@gmail.com>> wrote: >> >> It is working now again as expected. >> >> The only difference is that you need to use "Github-Create new branch for issue..." instead of "Pharo-Create new branch for issue..." for the new issues reported on GitHub. >> >> -- Pavel >> >> st 30. 1. 2019 v 9:42 odesÃlatel Guillermo Polito <guillermopolito(a)gmail.com <mailto:guillermopolito@gmail.com>> napsal: >> Hi, >> >> there is an issue for this problem, >> >> https://github.com/pharo-project/pharo/issues/2379 >> >> We have identified the cause, I'll propose a fix now >> >> On Wed, Jan 30, 2019 at 8:44 AM ducasse <stepharo(a)netcourrier.com> wrote: >> > >> > There is currently a bug eating one character of the commit hash. So >> > Iceberg does not find the hash and thinks we need a fetch. So currently >> > we need to checkout Pharo8.0 in order to be in a good state :( >> >> OOPs is there a bug entry? >> > >> >> I also don't understand how to make an issue branch for >> >> >> >> https://github.com/pharo-project/pharo/issues/2395 >> >> >> >> Is it Iceberg > Pharo > Create new branch for issue or Iceberg > Github > Create new branch for issue ? >> > >> > Just create a branch and choose the option to create a branch from a >> > Github option. >> > >> > The other one was for Manuscript and is now useless for Pharo 8. I >> > opened an issue in Iceberg to remove it but I did not got the time to >> > contribute the change. >> > >> >> What is the difference ? >> >> What about the Remote ? >> >> Can I work with only an issue on GitHub ? >> >> >> > >> > Yes! >> > >> > What I am doing currently: >> > >> > - Open an issue XX >> > - Sync my fork Pharo8.0 branch via command line (This is optional and >> > can also be done in Pharo. I just do it via command line because I like >> > it better that way) >> >> how do you do it? Pull? >> >> > - Download a Pharo 8 image >> > - Checkout the Pharo8.0 branch to get in a clean state because of the >> > hash eating bug I mentioned earlier >> > - Create a new branch from a github issue of the pharo remote >> > - Do the changes and commit. I add `Fixes #XX` in the commit message to >> > close automatically the issue when the PR is merged. >> > - Push to my remote >> > - Open a PR against Pharo8.0 through Iceberg > GitHub > Create new pull >> > request >> >> and checkout the pharo 8 branch to fix the next one. >> > >> >> Is the documentation >> >> >> >> https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo >> >> >> >> really up to date ? >> >> >> > >> > No >> > >> > We should correct the hash eating bug before updating it I think. >> > >> >> Sven >> >> >> >> >> > >> > >> > -- >> > Cyril Ferlicot >> > https://ferlicot.fr >> > >> >> >> >> >> >> -- >> >> Guille Polito >> Research Engineer >> >> Centre de Recherche en Informatique, Signal et Automatique de Lille >> CRIStAL - UMR 9189 >> French National Center for Scientific Research - http://www.cnrs.fr >> >> Web: http://guillep.github.io >> Phone: +33 06 52 70 66 13 >

Feb. 1, 2019

Re: [Pharo-dev] Contribute to pharo8.0 ?

by Sven Van Caekenberghe

I am still stuck. I did $ curl -L get.pharo.org/64/80+vm | bash Repaired by specifying my local clone Repaired by fetching Not in detached state, cannot make branch from issue, screenshot: What am I doing wrong ? How do other people do it ? > On 31 Jan 2019, at 08:18, Pavel Krivanek <pavel.krivanek(a)gmail.com> wrote: > > It is working now again as expected. > > The only difference is that you need to use "Github-Create new branch for issue..." instead of "Pharo-Create new branch for issue..." for the new issues reported on GitHub. > > -- Pavel > > st 30. 1. 2019 v 9:42 odesÃlatel Guillermo Polito <guillermopolito(a)gmail.com> napsal: > Hi, > > there is an issue for this problem, > > https://github.com/pharo-project/pharo/issues/2379 > > We have identified the cause, I'll propose a fix now > > On Wed, Jan 30, 2019 at 8:44 AM ducasse <stepharo(a)netcourrier.com> wrote: > > > > There is currently a bug eating one character of the commit hash. So > > Iceberg does not find the hash and thinks we need a fetch. So currently > > we need to checkout Pharo8.0 in order to be in a good state :( > > OOPs is there a bug entry? > > > >> I also don't understand how to make an issue branch for > >> > >> https://github.com/pharo-project/pharo/issues/2395 > >> > >> Is it Iceberg > Pharo > Create new branch for issue or Iceberg > Github > Create new branch for issue ? > > > > Just create a branch and choose the option to create a branch from a > > Github option. > > > > The other one was for Manuscript and is now useless for Pharo 8. I > > opened an issue in Iceberg to remove it but I did not got the time to > > contribute the change. > > > >> What is the difference ? > >> What about the Remote ? > >> Can I work with only an issue on GitHub ? > >> > > > > Yes! > > > > What I am doing currently: > > > > - Open an issue XX > > - Sync my fork Pharo8.0 branch via command line (This is optional and > > can also be done in Pharo. I just do it via command line because I like > > it better that way) > > how do you do it? Pull? > > > - Download a Pharo 8 image > > - Checkout the Pharo8.0 branch to get in a clean state because of the > > hash eating bug I mentioned earlier > > - Create a new branch from a github issue of the pharo remote > > - Do the changes and commit. I add `Fixes #XX` in the commit message to > > close automatically the issue when the PR is merged. > > - Push to my remote > > - Open a PR against Pharo8.0 through Iceberg > GitHub > Create new pull > > request > > and checkout the pharo 8 branch to fix the next one. > > > >> Is the documentation > >> > >> https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo > >> > >> really up to date ? > >> > > > > No > > > > We should correct the hash eating bug before updating it I think. > > > >> Sven > >> > >> > > > > > > -- > > Cyril Ferlicot > > https://ferlicot.fr > > > > > > > > -- > > Guille Polito > Research Engineer > > Centre de Recherche en Informatique, Signal et Automatique de Lille > CRIStAL - UMR 9189 > French National Center for Scientific Research - http://www.cnrs.fr > > Web: http://guillep.github.io > Phone: +33 06 52 70 66 13

Feb. 1, 2019

Re: [Pharo-dev] Why RBComment is not RBCommentNode?

by ducasse

> On 31 Jan 2019, at 20:59, Manuel Leuenberger <leuenberger(a)inf.unibe.ch> wrote: > > +1 > > This would also help with the auto-formatter. This guy seems to put comments wherever it likes to put it. Iâm slowly working on tests and a new formatter but I got distracted. If someone wants to help let me know. The code is in mybecher/BlueInk on my github account. https://github.com/Ducasse/mybecher I would like to be able to really use it to reformat all Pharo But it will take time because Iâm eaten by admin. Stef >> On 31 Jan 2019, at 20:57, ducasse <stepharo(a)netcourrier.com> wrote: >> >> >> Hi >> >> In my journey in Pharo AST node I found RBComment and it is not a Node and I wonder why. >> To me RBComment should be a subclass of RBProgramNode and renamed RBCommentNode. >> >> Stef >> > >

Jan. 31, 2019

Re: [Pharo-dev] Why RBComment is not RBCommentNode?

by Manuel Leuenberger

+1 This would also help with the auto-formatter. This guy seems to put comments wherever it likes to put it. > On 31 Jan 2019, at 20:57, ducasse <stepharo(a)netcourrier.com> wrote: > > > Hi > > In my journey in Pharo AST node I found RBComment and it is not a Node and I wonder why. > To me RBComment should be a subclass of RBProgramNode and renamed RBCommentNode. > > Stef >

Jan. 31, 2019

Why RBComment is not RBCommentNode?

by ducasse

Hi In my journey in Pharo AST node I found RBComment and it is not a Node and I wonder why. To me RBComment should be a subclass of RBProgramNode and renamed RBCommentNode. Stef

Jan. 31, 2019

Re: [Pharo-dev] Migrating XML support to github/PharoContributions/

by Torsten Bergmann

[ Pharo current ] fork

Jan. 31, 2019

DuplicatedSlotName empty pre-debugger

by HernÃ¡n Morales Durand

Hi, When loading OpenPonk in Pharo 7, I have a duplicated slot name entry pre-debugger window but is empty (see attachment). Is this behavior well-known or on purpose? Cheers, HernÃ¡n

Jan. 31, 2019

Re: [Pharo-dev] Debugger opening on user halt and not Object>>halt

by Ben Coman

On Thu, 31 Jan 2019 at 17:15, Guillermo Polito <guillermopolito(a)gmail.com> wrote: > Hi Thomas, > > Check the pragma debuggerCompleteToSender and its users. I think it's > related to that. > BenComan probably can give a better insight since (if I recall correctly) > he introduced it? > Thats right. Use "Tools > Finder > Source" to search for... debuggerCompleteToSender ignoring where its a pragma. That leaves... Process>>complete: Process>>stepToHome: GTGenericStackDebugger>>filteredStack GTGenericStackDebugger>>setDebuggerToFirstNonFilteredContext The first was me. Not sure about the second. The latter two were someone else. > Guille > > On Wed, Jan 30, 2019 at 5:44 PM Thomas Dupriez < > tdupriez(a)ens-paris-saclay.fr> wrote: > >> Hello, >> >> Does someone know which is the code responsible for the debugger opening >> on the halt of the user instead of Object>>halt (see picture)? It's neat >> but it's not the regular behaviour so I'm guessing it is handled somewhere >> specifically for halt messages? >> > Its not just for halt, but for any method that you don't want the debugger opening in the method sending #signal. Is your snapshot based on modified code? In Pharo-7.0.1+build.146.sha.c48755acc5f489337be0e7abc882c15b1707b254 (32 Bit) in Playground I evaluate... 1 + 1. self halt. 2 + 2. and my top line is the same as your second line. cheers -ben

Jan. 31, 2019

[Pharo 8.0] Build #47: 2381 Add class comment to ManifestCodeImportCommandLineHandlers

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #47 was: SUCCESS. The Pull Request #2382 was integrated: "2381 Add class comment to ManifestCodeImportCommandLineHandlers" Pull request url: https://github.com/pharo-project/pharo/pull/2382 Issue Url: https://pharo.fogbugz.com/f/cases/2381 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Jan. 31, 2019