- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] CompiledMethod>>#= is broken

by Eliot Miranda

On Tue, Dec 3, 2013 at 9:49 AM, Oscar Nierstrasz <oscar.nierstrasz(a)gmail.com > wrote: > > The following code breaks: > > (SortedCollectionTest>>#testDo) = (SortedCollectionTest>>#testStoreOn). > > because it makes use of AdditionalMethodState>>#analogousCodeTo: which > tries to send #analogousCodeTo: to a property which is an Association. > > It seems to me the solution is to implement Association>>#analogousCodeTo: > with an equality test: > > analogousCodeTo: anObject > ^self class == anObject class > and: [ self = anObject ] > > Does this make sense? > Yes. I should have written it this way in the first place. Thanks. > > See: > > > https://pharo.fogbugz.com/f/cases/12077/MNU-in-AdditionalMethodState-analog… > > Oscar Nierstrasz > > > -- best, Eliot

Dec. 3, 2013

Re: [Pharo-dev] Unifying Testing Ideas

by Denis Kudriashov

Problem with TestCase approach is mixing two separate concerns. First is how we want to define system specifications. Another is how we can persist such specifications. When we stay at test case level we lost freedom for specification definition. We restricted with smalltalk language artifacts. For example, how we can group our tests? With classic test case approach we have four levels: packages, classes, protocols and methods. Now remember how many times you put long names for test like #shouldDoingSomethingWhenSomeSitiationHappensDuringAnotherSituationHappenButWhenSituation3NotHappen. And most times you have tests for each separate situation with same long test names. In smalltalk only way to refactor test names duplication is extraction same "when condition" to separate test case classes. But it means that you build classes with very long names and most times your test names stay big (but with reduced length). And do you know way how to group such classes? Only way is put such classes to own class category. Nobody doing this. Now imagine we don't care how to persist tests (specifications). We can model specifications with explicit objects which present #when, #should and other test artifacts, which can group specifications with arbitrary way. With true objects we don't name our specifications with method name convention. We can name tests with natural language, we can put names for "when" and "should" expressions with natural language. With objects we can build "smalltalk vision" of BDD framework. Really with smalltalk live system testing environment can be very different from other languages. BDD frameworks of other languages just changed names of "TDD dictionary". They all stay restricted with language syntax. So it is my vision. I really want to build such system but I have no time for this yet. Maybe Sean doing something similar? 2013/12/3 Esteban A. Maringolo <emaringolo(a)gmail.com> > 2013/12/3 Dennis Schetinin <chaetal(a)gmail.com> > > > > I see the only correct way to build a good testing environment: tests > should be basically objects, not methods. > > They are objects. Instances of TestCase. > > But for simplicity they're implemented in a single "factory" class, > the TestCase subclass... > > > > Esteban A. Maringolo > >

Dec. 3, 2013

Re: [Pharo-dev] 12259: FileSystem memory reads writesusing a binary stream by default

by Damien Cassou

Thanks Max for the report. Do you have an idea on how we could solve the problem ? The previous behaviour was not acceptable either because the streams that came out of a memory filesystem were the only ones with binary content On Dec 3, 2013 5:35 PM, "Max Leske" <maxleske(a)gmail.com> wrote: > Damien, Marcus > > this change breaks a lot of things in FileSystem-Git. I donât disagree > with the idea that reading characters should be default (one could argue > about itâ¦) but your change makes it IMPOSSIBLE to read bytes because > unprintable characters are discarded! So if my ByteArray is a NULL > terminated string, for instance, I can not check for the NULL termination > anymore. > > Cheers, > Max >

Dec. 3, 2013

CompiledMethod>>#= is broken

by Oscar Nierstrasz

The following code breaks: (SortedCollectionTest>>#testDo) = (SortedCollectionTest>>#testStoreOn). because it makes use of AdditionalMethodState>>#analogousCodeTo: which tries to send #analogousCodeTo: to a property which is an Association. It seems to me the solution is to implement Association>>#analogousCodeTo: with an equality test: analogousCodeTo: anObject ^self class == anObject class and: [ self = anObject ] Does this make sense? See: https://pharo.fogbugz.com/f/cases/12077/MNU-in-AdditionalMethodState-analog… Oscar Nierstrasz

Dec. 3, 2013

Slice 12324

by Stephan Eggermont

Can anyone put it in place? Canât seem to commit it

Dec. 3, 2013

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/30617 Home: https://github.com/pharo-project/pharo-core

Dec. 3, 2013

[pharo-project/pharo-core] b6872a: 30617

by GitHub

Branch: refs/heads/3.0 Home: https://github.com/pharo-project/pharo-core Commit: b6872a02e80a33aef212716a623945b5c135687c https://github.com/pharo-project/pharo-core/commit/b6872a02e80a33aef212716a… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2013-12-03 (Tue, 03 Dec 2013) Changed paths: A Komitter.package/KomitCacheRemote.class/README.md A Komitter.package/KomitCacheRemote.class/definition.st A Komitter.package/KomitHttpRemote.class/README.md A Komitter.package/KomitHttpRemote.class/definition.st R Komitter.package/KomitterUI.class/class/icons/historyIconData.st A Komitter.package/KomitterUI.class/class/icons/manageRemotesIcon.st A Komitter.package/KomitterUI.class/class/private-icons/historyIconData.st A Komitter.package/KomitterUI.class/class/private-icons/manageRemotesData.st M Komitter.package/KomitterUI.class/class/specs/defaultSpec.st M Komitter.package/KomitterUI.class/definition.st A Komitter.package/KomitterUI.class/instance/accessing/manageRemotes.st M Komitter.package/KomitterUI.class/instance/initialization/initializeWidgets.st A Komitter.package/KomitterUI.class/instance/private-icons/historyIcon.st A Komitter.package/KomitterUI.class/instance/private-icons/manageRemotesIcon.st A Komitter.package/KomitterUI.class/instance/private/openRemoteManager.st A Komitter.package/RemotesManager.class/README.md A Komitter.package/RemotesManager.class/class/icons/addRemoteIcon.st A Komitter.package/RemotesManager.class/class/icons/removeRemoteIcon.st A Komitter.package/RemotesManager.class/class/private-icons/addRemoteIconData.st A Komitter.package/RemotesManager.class/class/private-icons/removeRemoteIconData.st A Komitter.package/RemotesManager.class/class/specs/defaultSpec.st A Komitter.package/RemotesManager.class/definition.st A Komitter.package/RemotesManager.class/instance/accessing/addRemote.st A Komitter.package/RemotesManager.class/instance/accessing/packages.st A Komitter.package/RemotesManager.class/instance/accessing/remotes.st A Komitter.package/RemotesManager.class/instance/accessing/removeRemote.st A Komitter.package/RemotesManager.class/instance/initialization/buildRoots.st A Komitter.package/RemotesManager.class/instance/initialization/initialize.st A Komitter.package/RemotesManager.class/instance/initialization/initializePresenter.st A Komitter.package/RemotesManager.class/instance/initialization/initializeWidgets.st A Komitter.package/RemotesManager.class/instance/private-icons/addRemoteIcon.st A Komitter.package/RemotesManager.class/instance/private-icons/removeRemoteIcon.st A Komitter.package/RemotesManager.class/instance/private/addRepository.st A Komitter.package/RemotesManager.class/instance/private/change_forRemote_.st A Komitter.package/RemotesManager.class/instance/private/doIfNotSilent_.st A Komitter.package/RemotesManager.class/instance/private/newRepository.st A Komitter.package/RemotesManager.class/instance/private/removeRepository.st A Komitter.package/RemotesManager.class/instance/private/silentWhile_.st A Komitter.package/RemotesManager.class/instance/private/updateRemoteSelectionFrom_.st A Komitter.package/RemotesManager.class/instance/protocol/packages_.st A Komitter.package/RemotesManager.class/instance/protocol/title.st A Komitter.package/extension/MCCacheRepository/instance/isCache.st A Komitter.package/extension/MCCacheRepository/instance/koRemote.st M Komitter.package/extension/MCHttpRepository/instance/koRemote.st A Komitter.package/extension/MCRepository/instance/isCache.st M Morphic-Base.package/HaloMorph.class/instance/geometry/worldBoundsForMorph_.st R Morphic-Base.package/ListItemWrapper.class/instance/as yet unclassified/canBeDragged.st R Morphic-Base.package/ListItemWrapper.class/instance/as yet unclassified/handlesMouseOver_.st R Morphic-Base.package/ListItemWrapper.class/instance/as yet unclassified/hasEquivalentIn_.st R Morphic-Base.package/ListItemWrapper.class/instance/as yet unclassified/wantsDroppedObject_.st A Morphic-Base.package/ListItemWrapper.class/instance/testing/canBeDragged.st A Morphic-Base.package/ListItemWrapper.class/instance/testing/handlesMouseOver_.st A Morphic-Base.package/ListItemWrapper.class/instance/testing/hasEquivalentIn_.st A Morphic-Base.package/ListItemWrapper.class/instance/testing/wantsDroppedObject_.st M Morphic-Base.package/MenuMorph.class/instance/events/updateColor.st M Morphic-Base.package/MenuMorph.class/instance/keyboard control/selectMoreItem_.st M Morphic-Base.package/Paragraph.class/instance/editing/actionAttributesUnder_event_do_.st M Morphic-Base.package/SimpleHierarchicalListMorph.class/instance/search/basicKeyPressed_.st M Morphic-Base.package/SystemWindow.class/instance/menu actions/makeSecondTopmost.st M Morphic-Base.package/SystemWindow.class/instance/menu actions/sendToBack.st M Morphic-Base.package/SystemWindow.class/instance/panes/setUpdatablePanesFrom_.st M Morphic-Base.package/TextMorphForEditView.class/instance/event handling/mouseDown_.st M Morphic-Core.package/HandMorph.class/instance/halo handling/obtainHalo_.st M Morphic-Core.package/WorldState.class/instance/alarms/removeAlarm_for_.st A Morphic-Core.package/WorldState.class/instance/hands/is_overlappingDamagedAreaIn_.st M Morphic-Core.package/WorldState.class/instance/hands/selectHandsToDrawForDamage_.st M Nautilus.package/extension/TBehavior/instance/methodNamed_ifAbsent_.st M Polymorph-Widgets.package/LazyMorphListMorph.class/instance/as yet unclassified/userString.st M Polymorph-Widgets.package/ListDialogWindow.class/instance/button behavior/browseAction.st M Polymorph-Widgets.package/ListDialogWindow.class/instance/morphic protocol/searchAccept_.st M Polymorph-Widgets.package/PopupChoiceDialogWindow.class/instance/as yet unclassified/switchToNextColumn.st M Polymorph-Widgets.package/PopupChoiceDialogWindow.class/instance/as yet unclassified/switchToPreviousColumn.st M Polymorph-Widgets.package/TaskbarMorph.class/instance/as yet unclassified/updateTasks.st M Ring-Core-Kernel.package/extension/TBehavior/instance/methodsInProtocol_.st A ScriptLoader30.package/ScriptLoader.class/instance/pharo - scripts/script272.st A ScriptLoader30.package/ScriptLoader.class/instance/pharo - updates/update30617.st M ScriptLoader30.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M SmartSuggestions.package/SugsMockContext.class/instance/api-context/selectedMethod.st M Spec-Inspector.package/EyeTreeInspector.class/instance/accessing/tree.st M Tests.package/TraitFileOutTest.class/instance/testing/testFileOutTrait.st M Traits.package/TBehavior.class/instance/accessing method dictionary/sourceCodeAt_.st M Traits.package/TBehavior.class/instance/accessing method dictionary/sourceCodeAt_ifAbsent_.st M Traits.package/TBehavior.class/instance/testing method dictionary/whichSelectorsAccess_.st M Traits.package/TBehavior.class/instance/testing method dictionary/whichSelectorsStoreInto_.st Log Message: ----------- 30617 12321 less senders of #methodDict https://pharo.fogbugz.com/f/cases/12321 12328 TreeInspector DNU https://pharo.fogbugz.com/f/cases/12328 12314 Add a view to link/add new remotes https://pharo.fogbugz.com/f/cases/12314 12325 HaloMorph >> #worldBoundsForMorph: calls deprecated outsetBy: https://pharo.fogbugz.com/f/cases/12325 12312 Cleanup on some Morphic methods https://pharo.fogbugz.com/f/cases/12312 http://files.pharo.org/image/30/30617.zip

Dec. 3, 2013

12259: FileSystem memory reads writesusing a binary stream by default

by Max Leske

Damien, Marcus this change breaks a lot of things in FileSystem-Git. I donât disagree with the idea that reading characters should be default (one could argue about itâ¦) but your change makes it IMPOSSIBLE to read bytes because unprintable characters are discarded! So if my ByteArray is a NULL terminated string, for instance, I can not check for the NULL termination anymore. Cheers, Max

Dec. 3, 2013

Re: [Pharo-dev] Unifying Testing Ideas

by Sean P. DeNigris

Attila Magyar wrote > did you want something like this? > mock a: anyArgument b: exactArgument1 c: exactArgument2 Exactly. Attila Magyar wrote > I rarely use / > does / > , as far as I remember it is not even documented. I don't know the code > behind the test but based on the names it looks like an adapter like > thing. (e.g. a thin wrapper above a 3rd party api with not too much logic > inside). If this is the case, normally I would test it with integration > tests, instead of mocks. Yes it's a wrapper. It should be tested with integration/acceptance tests. But, it wraps callouts to a C dynamic library via NB, so it's hard to test - i.e. crashes the VM, etc. Interactions with it deserve to be tested via unit tests (in general I drop down to unit tests inside a failing integration/acceptance test anyway). Anyway, does: is very important. Stubbing (can & (does: | answers:)) and mocking (should) seemed kind of like a nature-vs-nurture debate for a while, but there is a lot of overlap. Sometimes you need one, sometimes the other, and sometimes both (as shown in my example, although I kept thinking that in practice I'd probably write a test double by hand to be reused in other places). In fact, #does: and #answers: could easily be merged, using double dispatch to pass either a block or a value. Unrelatedly, it would be slightly clearer to rename "anything" to "anyMessage". "anything" makes it seem like it could be passed as an argument, which doesn't work. Or alternately, you could probably rename AnyMessage to Anything and combine its API with that of AnyArgument if they don't clash... ----- Cheers, Sean -- View this message in context: http://forum.world.st/Unifying-Testing-Ideas-tp4726787p4727086.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Dec. 3, 2013

Re: [Pharo-dev] Versionner Impressions

by Sean P. DeNigris

Stephan Eggermont wrote > Didi you compare it to Metaceller in Moose? No I don't know about that one (except that it exists)... ----- Cheers, Sean -- View this message in context: http://forum.world.st/Versionner-Impressions-tp4726902p4727082.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Dec. 3, 2013