- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] help about codeImporter

by Stephan Eggermont

Ben wrote: >who put a Ã´ in the code at the first place ? :P Doesnât happen often, Iâm happy to observe. Strings in code with interesting characters are a much more common problem, though. Made it impossible to import MCs into Gemstone. Stephan

Dec. 6, 2013

Re: [Pharo-dev] Review someone

by Benjamin

It used to be regex, but regex are slow (and far slower than just string comparison) Ben On 06 Dec 2013, at 12:20, Stephan Eggermont <stephan(a)stack.nl> wrote: > Would it make sense to check the search string for complex strings (*\?) and switch to > regex searching then? That should be a simple extension (later). > > Stephan > > >

Dec. 6, 2013

Re: [Pharo-dev] Review someone

by Stephan Eggermont

Would it make sense to check the search string for complex strings (*\?) and switch to regex searching then? That should be a simple extension (later). Stephan

Dec. 6, 2013

Re: [Pharo-dev] Review someone

by Stephan Eggermont

Just tried in 30624. Looks good to me. Works a lot faster. Is not trivial to load by hand, it needs search strings entered (nil isnât empty) The way the search is forked doesnât interfere with the UI thread? Stephan

Dec. 6, 2013

Re: [Pharo-dev] Review someone

by Sven Van Caekenberghe

On 06 Dec 2013, at 10:38, Benjamin <benjamin.vanryseghem.pharo(a)gmail.com> wrote: > Hi guys, > > could someone have a look at this issue ? > https://pharo.fogbugz.com/default.asp?12304 I do not really understand why a contribution from you that passes validation needs another extra approval. I mean, you commit stuff all the time, dangerous stuff (spec, etc..) that can break everything. And you fix the problems that accidentally introduce. It slows down the whole process for little quality gain. And the more slices get stale, the more work for the original contributor. > Itâs pretty simple, but I am facing the MC filter slowness 200 times per day, > so if someone review it, then we can put it into Pharo, and make the world a better place to live. > > > So if you want in a coupe of minutes makes me happy, and a better world for you children, you know what to do :) > > Ben >

Dec. 6, 2013

Re: [Pharo-dev] help about codeImporter

by StÃ©phane Ducasse

Some code from middle age. Still not having a coherent behavior is a problem to me. > who put a Ã´ in the code at the first place ? :P > > Ben

Dec. 6, 2013

Re: [Pharo-dev] Review someone

by StÃ©phane Ducasse

I will :) Stef On Dec 6, 2013, at 10:38 AM, Benjamin <Benjamin.VanRyseghem.Pharo(a)gmail.com> wrote: > Hi guys, > > could someone have a look at this issue ? > https://pharo.fogbugz.com/default.asp?12304 > > Itâs pretty simple, but I am facing the MC filter slowness 200 times per day, > so if someone review it, then we can put it into Pharo, and make the world a better place to live. > > > So if you want in a coupe of minutes makes me happy, and a better world for you children, you know what to do :) > > Ben >

Dec. 6, 2013

A Push to clear the issue tracker...

by Marcus Denker

Hi, With the end of the year close and a relase of Pharo3 planed for Marchâ¦ it is the right time to clean the issue tracker. -> Have a look at all the issues assigned to you. All current? Some action that can be done? Will you really work on it? -> Double check *all* issues that you submitted. - Is it maybe already fixed? - did someone ask you a question? - Is it really an issue for the public tracker? An issue tracker is not a personal TODO list! -> Double check that all bugs you know do actually have an issue tracker entry. -> Try to fix one or two little things over christmas holidays. We have less open bugs than subscribers to this listâ¦. Marcus

Dec. 6, 2013

Re: [Pharo-dev] [Spy] How to inject code *inside* a method

by Marcus Denker

On 06 Dec 2013, at 10:01, Roberto Minelli <roberto.minelli(a)usi.ch> wrote: > Hi guys, > > I am using Spy for my project, and I need to do something which, on top of my knowledge, is not supported. > > Here is the point: Spy allows to insert code before (#beforeRun:with:in:) and after (#afterRun:with:in:) and works perfectly. > > Now suppose I want to inject some code *inside* the method, e.g., > > aMethodToBeProfiled > > do something > > "Injected code accessing some fields of the current instance of this objectâ > Transcript show: self field asString. > > Is there any support for this? > Here is how to do it on the IR level: A class TestMy with test ^x + 1 + x byte code is: 13 <00> pushRcvr: 0 14 <76> pushConstant: 1 15 <B0> send: + 16 <00> pushRcvr: 0 17 <B0> send: + 18 <7C> returnTop âget a copy of the IR tree" irMethod := (TestMy>>#test) ir copy. âget all instance variable access IR instructionsâ allIvarAccesses := irMethod allInstructionsMatching: [ :ir |ir isInstVarAccess]. âinsert code for â1 haltâ before all of them" allIvarAccesses do: [ :each | each addInstructionsBefore: { IRInstruction pushLiteral: 1. IRInstruction send: #halt. IRInstruction popTop }]. âgenerate a new compiledMethod" cm := irMethod generate: (TestMy>>#test) trailer. âinstall in the class" TestMy addSelector: #test withMethod: cm. 17 <76> pushConstant: 1 18 <D0> send: halt 19 <87> pop 20 <00> pushRcvr: 0 21 <76> pushConstant: 1 22 <B0> send: + 23 <76> pushConstant: 1 24 <D0> send: halt 25 <87> pop 26 <00> pushRcvr: 0 27 <B0> send: + 28 <7C> returnTop â> TestMy new test What is now yet wiring is quick return methods â> need to clear the primitive in that case, should not be hard to do.

Dec. 6, 2013

Re: [Pharo-dev] [Spy] How to inject code *inside* a method

by Marcus Denker

On 06 Dec 2013, at 10:51, Roberto Minelli <roberto.minelli(a)usi.ch> wrote: > WOW.. Thank you guys for such answers!! It seems this is an hot topic. > > However, now I will try to hack something on top of Spy and look at Phantom in the weekend ;) > Phantom does *not* support sub-method elements. Marcus

Dec. 6, 2013