- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Missing collectAsSet: in Pharo 3.0

by Roberto Minelli

So if "self do: [:each | tally := tally + 1]" computes the size of a collection, why do we need the #size selector? On Dec 10, 2013, at 3:08 PM, Igor Stasenko <siguctua(a)gmail.com> wrote: > So if collect:as: does the job why the hell add yet another selector?

Dec. 10, 2013

Re: [Pharo-dev] Missing collectAsSet: in Pharo 3.0

by Igor Stasenko

On 10 December 2013 14:47, Nicolas Cellier < nicolas.cellier.aka.nice(a)gmail.com> wrote: > A fact is that there are way too many methods in (Sequenceable)Collection > already, with duplicated implementations/features. > So if collect:as: does the job why the hell add yet another selector? > > +1 > > 2013/12/10 Roberto Minelli <roberto.minelli(a)usi.ch> > >> IMHO having two common usages of #flatCollect:as: and #collect:as: is >> good. Then, do whatever you want. In my image I have #collectAsSet:. >> >> On Dec 10, 2013, at 2:40 PM, Esteban Lorenzano <estebanlm(a)gmail.com> >> wrote: >> >> > IMO, if there is an error, then is the presence of #flatCollectAsSet:, >> not the absence of the other(s). >> > >> > Esteban >> > >> > >> > On Tue, Dec 10, 2013 at 2:38 PM, Nicolas Cellier < >> nicolas.cellier.aka.nice(a)gmail.com> wrote: >> > And then rejectAsSet: selectAsHeap: etc... >> > A big -1 >> > >> > >> > 2013/12/10 Yuriy Tymchuk <yuriy.tymchuk(a)me.com> >> > >> > On 10 Dec 2013, at 14:26, Roberto Minelli <roberto.minelli(a)usi.ch> >> wrote: >> > >> > > No. Since #flatCollectAsSet: is in the image, #collectAsSet: should >> be in the image as well. >> > > >> > > And then, since we want clean code #collectAsSet: is cleaner than >> #collect:as:. >> > >> > Yes, but this also means that you need to implement: >> > >> > collectAsArray: >> > collectAsOrderedCollection: >> > collectAsBag: >> > â¦ >> > >> > :) >> > >> > > >> > > On Dec 10, 2013, at 2:23 PM, Esteban Lorenzano <estebanlm(a)gmail.com> >> wrote: >> > > >> > >> I don't think it has to be in the image, >> > >> >> > >> After all, you can just replace your calls for #collect:as: >> > >> >> > >> Esteban >> > >> >> > >> >> > >> >> > >> >> > >> On Tue, Dec 10, 2013 at 2:21 PM, Roberto Minelli < >> roberto.minelli(a)usi.ch> wrote: >> > >> Hi, >> > >> >> > >> In Pharo 3 you guys integrated Doruâs CollectionsExtension package, >> which is great. >> > >> >> > >> You forgot, however, to integrate the utility method #collectAsSet: >> I was using in several places in my code. >> > >> >> > >> It should be simply >> > >> ^ self collect: aBlock as: Set >> > >> >> > >> Could someone please put this in the standard image please? Thanks. >> > >> >> > >> Cheers, >> > >> R >> > >> >> > > >> > > >> > >> > >> > >> > >> >> >> > -- Best regards, Igor Stasenko.

Dec. 10, 2013

Re: [Pharo-dev] Missing collectAsSet: in Pharo 3.0

by Nicolas Cellier

A fact is that there are way too many methods in (Sequenceable)Collection already, with duplicated implementations/features. So if collect:as: does the job why the hell add yet another selector? 2013/12/10 Roberto Minelli <roberto.minelli(a)usi.ch> > IMHO having two common usages of #flatCollect:as: and #collect:as: is > good. Then, do whatever you want. In my image I have #collectAsSet:. > > On Dec 10, 2013, at 2:40 PM, Esteban Lorenzano <estebanlm(a)gmail.com> > wrote: > > > IMO, if there is an error, then is the presence of #flatCollectAsSet:, > not the absence of the other(s). > > > > Esteban > > > > > > On Tue, Dec 10, 2013 at 2:38 PM, Nicolas Cellier < > nicolas.cellier.aka.nice(a)gmail.com> wrote: > > And then rejectAsSet: selectAsHeap: etc... > > A big -1 > > > > > > 2013/12/10 Yuriy Tymchuk <yuriy.tymchuk(a)me.com> > > > > On 10 Dec 2013, at 14:26, Roberto Minelli <roberto.minelli(a)usi.ch> > wrote: > > > > > No. Since #flatCollectAsSet: is in the image, #collectAsSet: should be > in the image as well. > > > > > > And then, since we want clean code #collectAsSet: is cleaner than > #collect:as:. > > > > Yes, but this also means that you need to implement: > > > > collectAsArray: > > collectAsOrderedCollection: > > collectAsBag: > > â¦ > > > > :) > > > > > > > > On Dec 10, 2013, at 2:23 PM, Esteban Lorenzano <estebanlm(a)gmail.com> > wrote: > > > > > >> I don't think it has to be in the image, > > >> > > >> After all, you can just replace your calls for #collect:as: > > >> > > >> Esteban > > >> > > >> > > >> > > >> > > >> On Tue, Dec 10, 2013 at 2:21 PM, Roberto Minelli < > roberto.minelli(a)usi.ch> wrote: > > >> Hi, > > >> > > >> In Pharo 3 you guys integrated Doruâs CollectionsExtension package, > which is great. > > >> > > >> You forgot, however, to integrate the utility method #collectAsSet: I > was using in several places in my code. > > >> > > >> It should be simply > > >> ^ self collect: aBlock as: Set > > >> > > >> Could someone please put this in the standard image please? Thanks. > > >> > > >> Cheers, > > >> R > > >> > > > > > > > > > > > > > > > > >

Dec. 10, 2013

Re: [Pharo-dev] Missing collectAsSet: in Pharo 3.0

by Roberto Minelli

IMHO having two common usages of #flatCollect:as: and #collect:as: is good. Then, do whatever you want. In my image I have #collectAsSet:. On Dec 10, 2013, at 2:40 PM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > IMO, if there is an error, then is the presence of #flatCollectAsSet:, not the absence of the other(s). > > Esteban > > > On Tue, Dec 10, 2013 at 2:38 PM, Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> wrote: > And then rejectAsSet: selectAsHeap: etc... > A big -1 > > > 2013/12/10 Yuriy Tymchuk <yuriy.tymchuk(a)me.com> > > On 10 Dec 2013, at 14:26, Roberto Minelli <roberto.minelli(a)usi.ch> wrote: > > > No. Since #flatCollectAsSet: is in the image, #collectAsSet: should be in the image as well. > > > > And then, since we want clean code #collectAsSet: is cleaner than #collect:as:. > > Yes, but this also means that you need to implement: > > collectAsArray: > collectAsOrderedCollection: > collectAsBag: > â¦ > > :) > > > > > On Dec 10, 2013, at 2:23 PM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > > > >> I don't think it has to be in the image, > >> > >> After all, you can just replace your calls for #collect:as: > >> > >> Esteban > >> > >> > >> > >> > >> On Tue, Dec 10, 2013 at 2:21 PM, Roberto Minelli <roberto.minelli(a)usi.ch> wrote: > >> Hi, > >> > >> In Pharo 3 you guys integrated Doruâs CollectionsExtension package, which is great. > >> > >> You forgot, however, to integrate the utility method #collectAsSet: I was using in several places in my code. > >> > >> It should be simply > >> ^ self collect: aBlock as: Set > >> > >> Could someone please put this in the standard image please? Thanks. > >> > >> Cheers, > >> R > >> > > > > > > > >

Dec. 10, 2013

Re: [Pharo-dev] Missing collectAsSet: in Pharo 3.0

by Yuriy Tymchuk

I think that collectAsSet: is used a lot because we convert collection and remove duplicates. So it wonât be the same with select: . But I prefer to use #removeDuplicates, because this explicitly says: I want to remove duplicates, and not use a side effects of Set. Anyway have a nice day guys, we are building an amazing system. Cheers! Uko On 10 Dec 2013, at 14:38, Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> wrote: > And then rejectAsSet: selectAsHeap: etc... > A big -1 > > > 2013/12/10 Yuriy Tymchuk <yuriy.tymchuk(a)me.com> > > On 10 Dec 2013, at 14:26, Roberto Minelli <roberto.minelli(a)usi.ch> wrote: > > > No. Since #flatCollectAsSet: is in the image, #collectAsSet: should be in the image as well. > > > > And then, since we want clean code #collectAsSet: is cleaner than #collect:as:. > > Yes, but this also means that you need to implement: > > collectAsArray: > collectAsOrderedCollection: > collectAsBag: > â¦ > > :) > > > > > On Dec 10, 2013, at 2:23 PM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > > > >> I don't think it has to be in the image, > >> > >> After all, you can just replace your calls for #collect:as: > >> > >> Esteban > >> > >> > >> > >> > >> On Tue, Dec 10, 2013 at 2:21 PM, Roberto Minelli <roberto.minelli(a)usi.ch> wrote: > >> Hi, > >> > >> In Pharo 3 you guys integrated Doruâs CollectionsExtension package, which is great. > >> > >> You forgot, however, to integrate the utility method #collectAsSet: I was using in several places in my code. > >> > >> It should be simply > >> ^ self collect: aBlock as: Set > >> > >> Could someone please put this in the standard image please? Thanks. > >> > >> Cheers, > >> R > >> > > > > > > >

Dec. 10, 2013

Re: [Pharo-dev] Missing collectAsSet: in Pharo 3.0

by Esteban Lorenzano

IMO, if there is an error, then is the presence of #flatCollectAsSet:, not the absence of the other(s). Esteban On Tue, Dec 10, 2013 at 2:38 PM, Nicolas Cellier < nicolas.cellier.aka.nice(a)gmail.com> wrote: > And then rejectAsSet: selectAsHeap: etc... > A big -1 > > > 2013/12/10 Yuriy Tymchuk <yuriy.tymchuk(a)me.com> > >> >> On 10 Dec 2013, at 14:26, Roberto Minelli <roberto.minelli(a)usi.ch> wrote: >> >> > No. Since #flatCollectAsSet: is in the image, #collectAsSet: should be >> in the image as well. >> > >> > And then, since we want clean code #collectAsSet: is cleaner than >> #collect:as:. >> >> Yes, but this also means that you need to implement: >> >> collectAsArray: >> collectAsOrderedCollection: >> collectAsBag: >> â¦ >> >> :) >> >> > >> > On Dec 10, 2013, at 2:23 PM, Esteban Lorenzano <estebanlm(a)gmail.com> >> wrote: >> > >> >> I don't think it has to be in the image, >> >> >> >> After all, you can just replace your calls for #collect:as: >> >> >> >> Esteban >> >> >> >> >> >> >> >> >> >> On Tue, Dec 10, 2013 at 2:21 PM, Roberto Minelli < >> roberto.minelli(a)usi.ch> wrote: >> >> Hi, >> >> >> >> In Pharo 3 you guys integrated Doruâs CollectionsExtension package, >> which is great. >> >> >> >> You forgot, however, to integrate the utility method #collectAsSet: I >> was using in several places in my code. >> >> >> >> It should be simply >> >> ^ self collect: aBlock as: Set >> >> >> >> Could someone please put this in the standard image please? Thanks. >> >> >> >> Cheers, >> >> R >> >> >> > >> > >> >> >> >

Dec. 10, 2013

Re: [Pharo-dev] Missing collectAsSet: in Pharo 3.0

by Benjamin

Being consistent does not mean we have to be absolute :) Ben On 10 Dec 2013, at 14:38, Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> wrote: > And then rejectAsSet: selectAsHeap: etc... > A big -1 > > > 2013/12/10 Yuriy Tymchuk <yuriy.tymchuk(a)me.com> > > On 10 Dec 2013, at 14:26, Roberto Minelli <roberto.minelli(a)usi.ch> wrote: > > > No. Since #flatCollectAsSet: is in the image, #collectAsSet: should be in the image as well. > > > > And then, since we want clean code #collectAsSet: is cleaner than #collect:as:. > > Yes, but this also means that you need to implement: > > collectAsArray: > collectAsOrderedCollection: > collectAsBag: > â¦ > > :) > > > > > On Dec 10, 2013, at 2:23 PM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > > > >> I don't think it has to be in the image, > >> > >> After all, you can just replace your calls for #collect:as: > >> > >> Esteban > >> > >> > >> > >> > >> On Tue, Dec 10, 2013 at 2:21 PM, Roberto Minelli <roberto.minelli(a)usi.ch> wrote: > >> Hi, > >> > >> In Pharo 3 you guys integrated Doruâs CollectionsExtension package, which is great. > >> > >> You forgot, however, to integrate the utility method #collectAsSet: I was using in several places in my code. > >> > >> It should be simply > >> ^ self collect: aBlock as: Set > >> > >> Could someone please put this in the standard image please? Thanks. > >> > >> Cheers, > >> R > >> > > > > > > >

Dec. 10, 2013

Re: [Pharo-dev] Missing collectAsSet: in Pharo 3.0

by Nicolas Cellier

And then rejectAsSet: selectAsHeap: etc... A big -1 2013/12/10 Yuriy Tymchuk <yuriy.tymchuk(a)me.com> > > On 10 Dec 2013, at 14:26, Roberto Minelli <roberto.minelli(a)usi.ch> wrote: > > > No. Since #flatCollectAsSet: is in the image, #collectAsSet: should be > in the image as well. > > > > And then, since we want clean code #collectAsSet: is cleaner than > #collect:as:. > > Yes, but this also means that you need to implement: > > collectAsArray: > collectAsOrderedCollection: > collectAsBag: > â¦ > > :) > > > > > On Dec 10, 2013, at 2:23 PM, Esteban Lorenzano <estebanlm(a)gmail.com> > wrote: > > > >> I don't think it has to be in the image, > >> > >> After all, you can just replace your calls for #collect:as: > >> > >> Esteban > >> > >> > >> > >> > >> On Tue, Dec 10, 2013 at 2:21 PM, Roberto Minelli < > roberto.minelli(a)usi.ch> wrote: > >> Hi, > >> > >> In Pharo 3 you guys integrated Doruâs CollectionsExtension package, > which is great. > >> > >> You forgot, however, to integrate the utility method #collectAsSet: I > was using in several places in my code. > >> > >> It should be simply > >> ^ self collect: aBlock as: Set > >> > >> Could someone please put this in the standard image please? Thanks. > >> > >> Cheers, > >> R > >> > > > > > > >

Dec. 10, 2013

Re: [Pharo-dev] Missing collectAsSet: in Pharo 3.0

by Yuriy Tymchuk

On 10 Dec 2013, at 14:26, Roberto Minelli <roberto.minelli(a)usi.ch> wrote: > No. Since #flatCollectAsSet: is in the image, #collectAsSet: should be in the image as well. > > And then, since we want clean code #collectAsSet: is cleaner than #collect:as:. Yes, but this also means that you need to implement: collectAsArray: collectAsOrderedCollection: collectAsBag: â¦ :) > > On Dec 10, 2013, at 2:23 PM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > >> I don't think it has to be in the image, >> >> After all, you can just replace your calls for #collect:as: >> >> Esteban >> >> >> >> >> On Tue, Dec 10, 2013 at 2:21 PM, Roberto Minelli <roberto.minelli(a)usi.ch> wrote: >> Hi, >> >> In Pharo 3 you guys integrated Doruâs CollectionsExtension package, which is great. >> >> You forgot, however, to integrate the utility method #collectAsSet: I was using in several places in my code. >> >> It should be simply >> ^ self collect: aBlock as: Set >> >> Could someone please put this in the standard image please? Thanks. >> >> Cheers, >> R >> > >

Dec. 10, 2013

Re: [Pharo-dev] Missing collectAsSet: in Pharo 3.0

by Yuriy Tymchuk

On 10 Dec 2013, at 14:23, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > I don't think it has to be in the image, > > After all, you can just replace your calls for #collect:as: I agree. But either you have both collectAsSet: flatCollectAsSet: or you have none. But now there is only flatCollectAsSet: which rises a question: âwhy there is no collectAsSet: ?â Cheers! Uko > > Esteban > > > > > On Tue, Dec 10, 2013 at 2:21 PM, Roberto Minelli <roberto.minelli(a)usi.ch> wrote: > Hi, > > In Pharo 3 you guys integrated Doruâs CollectionsExtension package, which is great. > > You forgot, however, to integrate the utility method #collectAsSet: I was using in several places in my code. > > It should be simply > ^ self collect: aBlock as: Set > > Could someone please put this in the standard image please? Thanks. > > Cheers, > R >

Dec. 10, 2013