- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] enabled: and menuRegistration problem

by StÃ©phane Ducasse

We fixed it :) We moved the extensions to the packages so that we can unload nautilus. > Could you provide a way to reproduce it ? we could not without unloading Nautilus :) > > Because debugging from within Mail is quite tedious :P oh yes. Stef > > Ben > > On 11 Dec 2013, at 10:20, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > >> Hi >> >> I got a bug with menu (I'm trying to reproduce it but this is a real bug) >> >> because in >> >> interpretRegistration: aRegistration >> item enabled >> ifNil: [ node enabled: boolean not ] >> ifNotNil: [:boolean | node enabled: boolean ]. >> >> >> I will not comment on the fact that enabled should return a boolean >> but the problem is that node does not understand enabled: >> >> >> item enabled >> ifNil: [ node enabledBlock: item enabledBlock ] >> node is a MenuRegistration and items is PragmaMenuAndShortcutRegistrationItem >> ifNotNil: [:boolean | node enabled: boolean ]. >> >> And not of course does not understand enabledBlock: >> >> >> >> interpretRegistration: aRegistration >> | root | >> root := MenuRegistration owner: self. >> aRegistration items do: [:item || node | >> node := item group >> ifNil: [ root item: item item ] >> ifNotNil: [:grp | root group: grp ]. >> item with >> ifNotNil: [:block || old | >> old := aRegistration currentRoot. >> aRegistration currentRoot: node name. >> [ node with: block ] ensure: [ aRegistration currentRoot: old ]] >> ifNil: [ >> item action >> ifNil: [ >> node >> target: item target; >> arguments: item arguments; >> selector: item selector ] >> ifNotNil:[ >> node >> action: item action ]]. >> node >> keyText: item keyText; >> help: item help; >> icon: item icon; >> order: item order; >> parent: item parent. >> item enabled >> ifNil: [ node ] >> ifNotNil: [:boolean | node enabled: boolean ]. >> item label >> ifNotNil: [ node label: item label ]. >> item default ifNotNil: [ :d | >> node label: node label, ' (', d asString, ')']. >> item isWithSeparatorAfter >> ifTrue: [ node withSeparatorAfter ]] >

Dec. 11, 2013

Re: [Pharo-dev] [ANN] Neo-Caching

by Nicolas Petton

This is awesome! Thanks Sven :) Nico Sven Van Caekenberghe writes: > On 10 Dec 2013, at 23:09, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > >> Sven thanks a lot >> How can we resist to push this in Pharo 30 :) > > That is the idea, and I will do it, but I would first like some feedback/validation. > >> Stef >> >> On Dec 10, 2013, at 4:54 PM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >> >>> Hi, >>> >>> Caching is an important technique to trade time (speed of execution) for space (memory consumption) in computation. Used correctly, caching can significantly improve an applicationâs performance. >>> >>> Given the key/value nature of a cache, a Dictionary is often the first data structure used for implementing it. This is however not a good idea since a simple Dictionary is unbounded by definition and can/will lead to explosive cache growth. >>> >>> Quick and dirty hacks to turn a Dictionary into a least-recently-used (LRU) and/or time-to-live (TTL) based limited cache are often incorrect and inefficient. >>> >>> The LRUCache implementation currently in Pharo is too simple and not efficient, being O(n) on its main operation. >>> >>> Pharo deserves and needs a good LRU/TTL cache implementation that can/should be used uniformly in various places of the system and in code built on top of it. That is why I implemented a proposal. >>> >>> Neo-Caching is an implementation of both a good LRU cache as well as a TTL extension of it. The caches are easy to use, yet have a number of interesting features. The implementation is properly O(1) on its main operations and is 2 to 3 times faster than LRUCache. The package also contains a double linked list implementation. The code comes with a full set of unit tests. There are class and method comments and the code is easy to read. >>> >>> The code (which has no dependencies) can be found here >>> >>> http://mc.stfx.eu/Neo >>> http://www.smalltalkhub.com/mc/SvenVanCaekenberghe/Neo/main >>> >>> There is only one package to load. The code has been written in Pharo 3.0 but it should run on older versions as well. >>> >>> >>> Code >>> >>> >>> Letâs create a 16K ordered collection of keys that have some repetitions in them with a reasonable distribution: >>> >>> data := Array streamContents: [ :out | >>> 1 to: 4096 do: [ :each | >>> each primeFactorsOn: out. >>> out nextPut: each ] ]. >>> data := data collect: [ :each | each asWords ]. >>> >>> By using #asWords the keys have better hash properties. Now, we put all this in a cache: >>> >>> cache := NeoLRUCache new. >>> cache maximumWeight: 512. >>> cache factory: [ :key | key ]. >>> data do: [ :each | cache at: each ]. >>> cache. >>> >>> ==> a NeoLRUCache(#512 512/512 [ 1 ] [ :key | key ] 72%) >>> >>> We had a 72% hit ratio, which is good. The cache is of course full, 512/512 with 512 entries (not necessarily the same thing, see further). >>> >>> We can now benchmark this: >>> >>> [ data do: [ :each | cache at: each ] ] bench. >>> >>> ==> '35.8 per second.â >>> >>> And compare it to LRUCache: >>> >>> cache := LRUCache size: 512 factory: [ :key | key ]. >>> >>> [ data do: [ :each | cache at: each ] ] bench. >>> >>> ==> '12.6 per second.â >>> >>> >>> Features >>> >>> >>> Instead of just counting the number of entries, which is the default behaviour, the concept of weight is used to determine when a cache is full. For each cached value, a block or selector is used to compute its weight. When adding a new entry causes the weight to exceed a maximum, eviction of the least recently used item(s) takes place, until the weight is again below the maximum. >>> >>> cache >>> computeWeight: #sizeInMemory; >>> maximumWeight: 16*1024. >>> >>> Will keep the cache below 16Kb in real memory usage. This can be very useful when caching various sized images or MC packages, for example. >>> >>> By default, no concurrent access protection takes place, but optionally a semaphore for mutual exclusion can be used. This slows down access. >>> >>> cache useSemaphore. >>> >>> NeoTTLCache extends NeoLRUCache by maintaining a timestamp for each cached value. Upon cache hit, there is a check to see if this timestamp is not older than the allowed time to live. If so, the value is stale and will be recomputed. >>> >>> (cache := NeoTTLCache new) >>> timeToLive: 10 minutes; >>> factory: [ :key | ZnEasy get: key ]; >>> maximumWeight: 32*1024; >>> computeWeight: #contentLength. >>> >>> cache at: âhttp://zn.stfx.eu/zn/numbers.txt'. >>> >>> ==> a ZnResponse(200 OK text/plain;charset=utf-8 71B) >>> >>> cache >>> >>> ==> a NeoTTLCache(#1 71/32768 #contentLength [ :key | ZnEasy get: key ] 0% 0:00:10:00) >>> >>> Would be a simple HTTP cache, keeping resolved URLs in memory for 10 minutes maximum before refreshing them. It uses #contentLength on ZnResponse to compute the weight. You can see from the print string that there is now 1 entry, while the weight is 17 bytes out of 32768. >>> >>> >>> These are the main points, please have a look at the code. Feedback is welcome. >>> >>> Regards, >>> >>> Sven >>> >>> >> >> -- Nicolas Petton http://nicolas-petton.fr

Dec. 11, 2013

Re: [Pharo-dev] enabled: and menuRegistration problem

by Benjamin

Could you provide a way to reproduce it ? Because debugging from within Mail is quite tedious :P Ben On 11 Dec 2013, at 10:20, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Hi > > I got a bug with menu (I'm trying to reproduce it but this is a real bug) > > because in > > interpretRegistration: aRegistration > item enabled > ifNil: [ node enabled: boolean not ] > ifNotNil: [:boolean | node enabled: boolean ]. > > > I will not comment on the fact that enabled should return a boolean > but the problem is that node does not understand enabled: > > > item enabled > ifNil: [ node enabledBlock: item enabledBlock ] > node is a MenuRegistration and items is PragmaMenuAndShortcutRegistrationItem > ifNotNil: [:boolean | node enabled: boolean ]. > > And not of course does not understand enabledBlock: > > > > interpretRegistration: aRegistration > | root | > root := MenuRegistration owner: self. > aRegistration items do: [:item || node | > node := item group > ifNil: [ root item: item item ] > ifNotNil: [:grp | root group: grp ]. > item with > ifNotNil: [:block || old | > old := aRegistration currentRoot. > aRegistration currentRoot: node name. > [ node with: block ] ensure: [ aRegistration currentRoot: old ]] > ifNil: [ > item action > ifNil: [ > node > target: item target; > arguments: item arguments; > selector: item selector ] > ifNotNil:[ > node > action: item action ]]. > node > keyText: item keyText; > help: item help; > icon: item icon; > order: item order; > parent: item parent. > item enabled > ifNil: [ node ] > ifNotNil: [:boolean | node enabled: boolean ]. > item label > ifNotNil: [ node label: item label ]. > item default ifNotNil: [ :d | > node label: node label, ' (', d asString, ')']. > item isWithSeparatorAfter > ifTrue: [ node withSeparatorAfter ]]

Dec. 11, 2013

Re: [Pharo-dev] self item returns a string

by StÃ©phane Ducasse

On Dec 11, 2013, at 10:31 AM, Benjamin <Benjamin.VanRyseghem.Pharo(a)gmail.com> wrote: > Sorry but I wrote part of this code 3 years ago, so I really do not remember :( No problem. We tried during 30 min with pavel but failed. We should have a look again. Stef > > Ben > > On 11 Dec 2013, at 09:51, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > >> Hi ben >> >> Im trying to fix the problem of the finder putting too many string around the arguments. >> if you type 'a' . 'b' . 'ab' and example >> you will get '''a''' . '''b''' >> >> so I found that >> >> displayString >> >> self halt. >> ^ self item asString >> >> self item returns a byteString and item is not redefined in FinderNode >> >> I tried to change it to >> >> displayString >> >> >> ^ self item >> >> but self item is already '''a '''' >> >> the item on the node is already a '''a''''â¦. >> >> So I tried to check how the node were populated but I could not get childrenItems to work. >> >> >

Dec. 11, 2013

Re: [Pharo-dev] self item returns a string

by Benjamin

Sorry but I wrote part of this code 3 years ago, so I really do not remember :( Ben On 11 Dec 2013, at 09:51, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Hi ben > > Im trying to fix the problem of the finder putting too many string around the arguments. > if you type 'a' . 'b' . 'ab' and example > you will get '''a''' . '''b''' > > so I found that > > displayString > > self halt. > ^ self item asString > > self item returns a byteString and item is not redefined in FinderNode > > I tried to change it to > > displayString > > > ^ self item > > but self item is already '''a '''' > > the item on the node is already a '''a''''â¦. > > So I tried to check how the node were populated but I could not get childrenItems to work. > >

Dec. 11, 2013

enabled: and menuRegistration problem

by StÃ©phane Ducasse

Hi I got a bug with menu (I'm trying to reproduce it but this is a real bug) because in interpretRegistration: aRegistration item enabled ifNil: [ node enabled: boolean not ] ifNotNil: [:boolean | node enabled: boolean ]. I will not comment on the fact that enabled should return a boolean but the problem is that node does not understand enabled: item enabled ifNil: [ node enabledBlock: item enabledBlock ] node is a MenuRegistration and items is PragmaMenuAndShortcutRegistrationItem ifNotNil: [:boolean | node enabled: boolean ]. And not of course does not understand enabledBlock: interpretRegistration: aRegistration | root | root := MenuRegistration owner: self. aRegistration items do: [:item || node | node := item group ifNil: [ root item: item item ] ifNotNil: [:grp | root group: grp ]. item with ifNotNil: [:block || old | old := aRegistration currentRoot. aRegistration currentRoot: node name. [ node with: block ] ensure: [ aRegistration currentRoot: old ]] ifNil: [ item action ifNil: [ node target: item target; arguments: item arguments; selector: item selector ] ifNotNil:[ node action: item action ]]. node keyText: item keyText; help: item help; icon: item icon; order: item order; parent: item parent. item enabled ifNil: [ node ] ifNotNil: [:boolean | node enabled: boolean ]. item label ifNotNil: [ node label: item label ]. item default ifNotNil: [ :d | node label: node label, ' (', d asString, ')']. item isWithSeparatorAfter ifTrue: [ node withSeparatorAfter ]]

Dec. 11, 2013

Re: [Pharo-dev] is the through working on the debugger?

by Marcus Denker

reported is only 10332 Issues when using âThrough" https://pharo.fogbugz.com/f/cases/10332 On 11 Dec 2013, at 10:01, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Hi guys > > with pavel we think that we found a bug on the through of the debugger (to jump inside a block). > Is it a well-known bug? > > Stef

Dec. 11, 2013

Re: [Pharo-dev] is the through working on the debugger?

by StÃ©phane Ducasse

False alert it is working. On Dec 11, 2013, at 10:01 AM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Hi guys > > with pavel we think that we found a bug on the through of the debugger (to jump inside a block). > Is it a well-known bug? > > Stef

Dec. 11, 2013

is the through working on the debugger?

by StÃ©phane Ducasse

Hi guys with pavel we think that we found a bug on the through of the debugger (to jump inside a block). Is it a well-known bug? Stef

Dec. 11, 2013

self item returns a string

by StÃ©phane Ducasse

Hi ben Im trying to fix the problem of the finder putting too many string around the arguments. if you type 'a' . 'b' . 'ab' and example you will get '''a''' . '''b''' so I found that displayString self halt. ^ self item asString self item returns a byteString and item is not redefined in FinderNode I tried to change it to displayString ^ self item but self item is already '''a '''' the item on the node is already a '''a''''â¦. So I tried to check how the node were populated but I could not get childrenItems to work.

Dec. 11, 2013