- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Issue 12832 OpalCompiler / Debugger

by Camille Teruel

On 14 fÃ©vr. 2014, at 00:45, Nicolai Hess <nicolaihess(a)web.de> wrote: > Thank you camille, > I still don't fully understand, why it is so hard to make it work for all use cases. > It looks like a simple thing, make a sourceNode for the current context! > > So for me it looks like the main problem is to distinguish these cases: > Create a SourceNode for > a) Method or > b) Block or > c) MethodContext or > d) BlockContext > and at the moment we are mixing case c/d/b It's easy for method and block. For MethodContext, it's harder. I would love if I could write: MethodContext>>sourceNode ^ self isBlockContext ifTrue: [ closureOrNil sourceNode ] ifFalse: [ method sourceNode ]. but it doesn't work because inlined blocks don't create a new context: 1 to: 1 do: [ :i | ^ thisContext isBlockContext ] returns false. So instead we have to rely on pc->IR nodes and IR nodes->AST nodes mappings. But everything is not mapped as you would expect yet in these two mappings. I found that: - the (pushLiteral: nil) bytecodes used to mark the number of block temporaries have corresponding IR nodes but these node are mapped with the AST block node instead of the AST sequence node. - the (pushTemp: n) bytecodes used to push the copied values of blocks don't have corresponding IR nodes so no AST node is associated with them. - the block return bytecodes are mapped to the block node instead of the sequence. Fixing these mapping is not easy, and it's too big a change for Pharo 3. So we have to deal with the current mapping for now. > > Thank you ben, for finding/looking at the failing tests. > > (I wished we would have an improved debugger, showing > sourcecode, AST, IR and bytecode linked together :-) > > > > 2014-02-13 16:27 GMT+01:00 Camille Teruel <camille.teruel(a)gmail.com>: > Hi Nicolai, > > I opened the issue 12875 and committed a fix. > Can you look at it? > > > On 11 fÃ©vr. 2014, at 11:54, Nicolai Hess <nicolaihess(a)web.de> wrote: > > > Ben, Camille, can you take a look at this code > > |a b| > > a:='String'. > > b:='t'. > > a collectWithIndex:[:c :i | c < b] > > > > Debug this code and step over until you reach the > > collectWithIndex: method, the context inspector will show > > a,b,c,i even though only a and b are in the current scope. > > And it'll show the wrong values > > a->'String' > > b->'String' > > c->'String' > > i->'t' > > > > (This does not happen with old compiler and it does not > > happen in 307052) > >

Feb. 14, 2014

[pharo-project/pharo-core] e97ba0: 30760

by GitHub

Branch: refs/heads/3.0 Home: https://github.com/pharo-project/pharo-core Commit: e97ba0b74972f88f605f450012dc76fb6a503329 https://github.com/pharo-project/pharo-core/commit/e97ba0b74972f88f605f4500… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2014-02-14 (Fri, 14 Feb 2014) Changed paths: M RPackage-Core.package/extension/TBehavior/instance/originalName.st M Ring-Core-Containers.package/RGOrganization.class/README.md M Ring-Core-Kernel.package/RGClassInstanceVariableDefinition.class/README.md M Ring-Core-Kernel.package/RGClassVariableDefinition.class/README.md M Ring-Core-Kernel.package/RGDefinition.class/README.md M Ring-Core-Kernel.package/RGGlobalVariableDefinition.class/README.md M Ring-Core-Kernel.package/RGInstanceVariableDefinition.class/README.md M Ring-Core-Kernel.package/RGPoolVariableDefinition.class/README.md M Ring-Core-Kernel.package/RGVariableDefinition.class/README.md M Ring-Tests-Containers.package/RGContainerTest.class/README.md M Ring-Tests-Containers.package/RGNamespaceTest.class/README.md M Ring-Tests-Containers.package/RGPackageTest.class/README.md M Ring-Tests-Containers.package/RGSliceTest.class/README.md M Ring-Tests-Kernel.package/RGClassDefinitionTest.class/README.md M Ring-Tests-Kernel.package/RGCommentDefinitionTest.class/README.md M Ring-Tests-Kernel.package/RGGlobalDefinitionTest.class/README.md M Ring-Tests-Kernel.package/RGMethodDefinitionTest.class/README.md M Ring-Tests-Kernel.package/RGTraitDefinitionTest.class/README.md M Ring-Tests-Kernel.package/RGVariableDefinitionTest.class/README.md M Ring-Tests-Monticello.package/RGMonticelloTest.class/README.md A ScriptLoader30.package/ScriptLoader.class/instance/pharo - scripts/script413.st A ScriptLoader30.package/ScriptLoader.class/instance/pharo - updates/update30760.st M ScriptLoader30.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 30760 12874 Error on TBehavior>>originalName when the class is not in system dictionary but also does not start with AnObsolete https://pharo.fogbugz.com/f/cases/12874 12868 Class comments missing for Ring package https://pharo.fogbugz.com/f/cases/12868 http://files.pharo.org/image/30/30760.zip

Feb. 14, 2014

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/30760 Home: https://github.com/pharo-project/pharo-core

Feb. 14, 2014

Re: [Pharo-dev] Bugfix to '/foo:bar' asUrl

by Sven Van Caekenberghe

I think we are getting somewhere (it is about time). $+ is handled in any usage of ZnPercentEncoder, independent of context and safeSet. That is not right, it is only valid in the context of application/x-www-form-urlencoded get/post requests: http://en.wikipedia.org/wiki/Percent-encoding#The_application.2Fx-www-form-… Outside of that specific use case, $+ becomes space, should not be done, I think. OK, now I have something concrete to work with. I still would like to be able to run the Seaside Ajax functional test though. On 14 Feb 2014, at 11:42, Johan Brichau <johan(a)inceptive.be> wrote: > > On 14 Feb 2014, at 10:44, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > >> So any percent-encoded character is accepted [ but being encoded means that its meaning as structuring element is lost, consider $/ ], not necessarily encoded on output. > > Right, but here the exact opposite happens. > A reserved character (+) was included as an encoded character (%2B), gets correctly decoded by Zinc but then never gets encoded again when printing the url, hence become a structuring element representing a space in the printed url. > > Because a WAUrl is constructed from incoming ZnUrl's printString, the WAUrl gets to read the '+' instead of the '%2B'. > > The following code snippet is now true, but should be false imho: > > (ZnUrl fromString: (ZnUrl fromString: 'http://localhost/?param=foo%2Bbar') printString) printString = 'http://localhost/?param=foo%20bar' > > Johan

Feb. 14, 2014

Re: [Pharo-dev] Bugfix to '/foo:bar' asUrl

by Sven Van Caekenberghe

On 14 Feb 2014, at 11:54, Johan Brichau <johan(a)inceptive.be> wrote: > > On 14 Feb 2014, at 11:33, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > >>>> Is there a standard functional Seaside Ajax test that I can use to see this for myself ? >>> >>> localhost:8080/tests/functional-ajaxified >>> >>> WAUrlEncodingFunctionalTest >>> >>> enter a + in the form >> >> That is not in my image (I got started with ConfigurationOfBootstrap which seems to load plain ConfigurationOfSeaside3). But I have seen these tests in the past. >> >> What groups should I load additionally ? >> >> Sorry... > > No worries, thank _you_ for taking a look into this! > The 'Tests' group contains those tests. On the page, it's the second-to-last element in the drop down. Yes, I see the function tests, but not the functional-ajaxified ones...

Feb. 14, 2014

Re: [Pharo-dev] Bugfix to '/foo:bar' asUrl

by Johan Brichau

On 14 Feb 2014, at 11:33, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >>> Is there a standard functional Seaside Ajax test that I can use to see this for myself ? >> >> localhost:8080/tests/functional-ajaxified >> >> WAUrlEncodingFunctionalTest >> >> enter a + in the form > > That is not in my image (I got started with ConfigurationOfBootstrap which seems to load plain ConfigurationOfSeaside3). But I have seen these tests in the past. > > What groups should I load additionally ? > > Sorry... No worries, thank _you_ for taking a look into this! The 'Tests' group contains those tests. On the page, it's the second-to-last element in the dropdown. Johan

Feb. 14, 2014

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/30759 Home: https://github.com/pharo-project/pharo-core

Feb. 14, 2014

[pharo-project/pharo-core] 7d5308: 30759

by GitHub

Branch: refs/heads/3.0 Home: https://github.com/pharo-project/pharo-core Commit: 7d5308ef2de9267e2bc3bffd747ce11e84005d76 https://github.com/pharo-project/pharo-core/commit/7d5308ef2de9267e2bc3bffd… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2014-02-14 (Fri, 14 Feb 2014) Changed paths: M EmergencyEvaluator.package/Transcripter.class/class/menu/emergencyEvaluatorMenuOn_.st M Komitter.package/Komitter.class/class/world menu/komitterMenuOn_.st M Manifest-CriticBrowser.package/CriticBrowser.class/class/menu/criticsBrowserMenuOn_.st M Morphic-Core.package/WorldState.class/class/world menu items/screenShotCommandOn_.st M RecentSubmissions.package/RecentMessageList.class/class/setting/recentMessageListMenuOn_.st M SUnit-Core.package/TestAnnouncement.class/README.md M SUnit-Help.package/SUnitAPIDocumentation.class/README.md M SUnit-Tests.package/ClassFactoryForTestCaseTest.class/README.md M SUnit-Tests.package/ClassFactoryWithOrganizationTest.class/README.md M SUnit-Tests.package/ExampleSetTest.class/README.md M SUnit-Tests.package/FailingTestResourceTestCase.class/README.md M SUnit-Tests.package/ManyTestResourceTestCase.class/README.md M SUnit-Tests.package/ResumableTestFailureTestCase.class/README.md M SUnit-Tests.package/SUnitExtensionsTest.class/README.md M SUnit-Tests.package/SimpleTestResource.class/README.md M SUnit-Tests.package/SimpleTestResourceA.class/README.md M SUnit-Tests.package/SimpleTestResourceA1.class/README.md M SUnit-Tests.package/SimpleTestResourceA2.class/README.md M SUnit-Tests.package/SimpleTestResourceB.class/README.md M SUnit-Tests.package/SimpleTestResourceB1.class/README.md M SUnit-Tests.package/SimpleTestResourceCircular.class/README.md M SUnit-Tests.package/SimpleTestResourceCircular1.class/README.md M SUnit-Tests.package/SimpleTestResourceTestCase.class/README.md M SUnit-Tests.package/TestCaseTest.class/README.md A ScriptLoader30.package/ScriptLoader.class/instance/pharo - scripts/script412.st A ScriptLoader30.package/ScriptLoader.class/instance/pharo - updates/update30759.st M ScriptLoader30.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Shout.package/SHPreferences.class/README.md M Shout.package/SHStyleElement.class/README.md M ShoutTests.package/SHParserST80Test.class/README.md M Spec-Tools.package/DualChangeSorterApplication.class/class/menu/menuCommandOn_.st M Tools.package/FileList.class/class/world menu/menuCommandOn_.st M Tools.package/FileList.class/instance/private/put_.st M Tools.package/Finder.class/class/menu/finderMenuOn_.st M Tools.package/MetacelloConfigurationBrowser.class/class/registration/menuCommandOn_.st M Tools.package/MetacelloConfigurationBrowser.class/instance/icons/taskbarIcon.st M Tools.package/ProcessBrowser.class/class/world menu/menuCommandOn_.st M Tools.package/TimeProfiler.class/class/world menu/menuCommandOn_.st M Transcript.package/ThreadSafeTranscript.class/class/world menu/menuCommandOn_.st M Versionner-Spec-Browser.package/VersionnerSpecBrowser.class/class/ui/menuCommandOn_.st Log Message: ----------- 30759 12849 Tools menu should be more clean https://pharo.fogbugz.com/f/cases/12849 12870 Class comments missing for Shout package https://pharo.fogbugz.com/f/cases/12870 12754 FileBrowser save on files smaller than the original not working https://pharo.fogbugz.com/f/cases/12754 12869 Class comments missing in SUnit packages https://pharo.fogbugz.com/f/cases/12869 http://files.pharo.org/image/30/30759.zip

Feb. 14, 2014

[Pharo3][Issue Tracker] Open issued down to 17

by Marcus Denker

Hi, Issues tagged âmust fixâ or higher for Pharo3 is now at 17: https://pharo.fogbugz.com/f/filters/64/3-0-TODO Pls check if something is missing, or wrong. Marcus

Feb. 14, 2014

Re: [Pharo-dev] Bugfix to '/foo:bar' asUrl

by Johan Brichau

On 14 Feb 2014, at 10:44, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > So any percent-encoded character is accepted [ but being encoded means that its meaning as structuring element is lost, consider $/ ], not necessarily encoded on output. Right, but here the exact opposite happens. A reserved character (+) was included as an encoded character (%2B), gets correctly decoded by Zinc but then never gets encoded again when printing the url, hence become a structuring element representing a space in the printed url. Because a WAUrl is constructed from incoming ZnUrl's printString, the WAUrl gets to read the '+' instead of the '%2B'. The following code snippet is now true, but should be false imho: (ZnUrl fromString: (ZnUrl fromString: 'http://localhost/?param=foo%2Bbar') printString) printString = 'http://localhost/?param=foo%20bar' Johan

Feb. 14, 2014