- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Missing tests for FFI in CI

by Guillermo Polito

Hi Stephan, Le jeu. 21 mars 2019 Ã 21:39, Stephan Eggermont <stephan(a)stack.nl> a Ã©crit : > ducasse <stepharo(a)netcourrier.com> wrote: > > Hello Stefan > > > > Can you report the exact call you were doing? > > I talked with G and Pablo and the bug they fixed is not the same. > > Now they would like to experiment and write tests for all the platform. > > BOOL GetExitCodeProcess( > HANDLE hProcess, > LPDWORD lpExitCode > ); > what are your mappings for BOOL, HANDLE and LPDWORD? Those are user defined types :) > I was trying to get the exit code of a running process on windows. That > didnât work, so we started again with OSWindows on a clean Pharo 8. There > we noticed that the currentProcess was not [ 255 255 255 255 255 255 255 > 255] but [ 255 255 255 255 0 0 0 0]. That (and the test being green in 32 > bit) triggered the idea. We did a quick and dirty change to verify, and > then found out that the Squeak code had cleaner fixes. > > Stephan > > > > > -- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13

March 21, 2019

Re: [Pharo-dev] How to download a patched file?

by Gabriel Cotelli

See my previous email. I've just clicked the already available buttons in the diff view: "View File" and then "Raw" in the next page opened. On Thu, Mar 21, 2019 at 5:32 PM Max Leske <maxleske(a)gmail.com> wrote: > Hi Eliot, > > > On 21 Mar 2019, at 21:00, Eliot Miranda wrote: > > > Hi GitHub mavens, > > > > how does one download a specific patched file from GitHub? I > > want to > > test Pablo's fix here: > > > > https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381 > > platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m > > <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381/files#diff-0 > > > > > > I don't want to go through "View File", or clone, or anything else. I > > just > > want the file itself. How do I get it? > > You'll have to know the commit hash, then you can grap it by path: > > https://raw.githubusercontent.com/OpenSmalltalk/opensmalltalk-vm/1a09bae437… > > AFAIK, there's no direct way to get to the file directly from the diff > view. > > Max > > > > > _,,,^..^,,,_ > > best, Eliot > > > >

March 21, 2019

Re: [Pharo-dev] Missing tests for FFI in CI

by Stephan Eggermont

ducasse <stepharo(a)netcourrier.com> wrote: > Hello Stefan > > Can you report the exact call you were doing? > I talked with G and Pablo and the bug they fixed is not the same. > Now they would like to experiment and write tests for all the platform. BOOL GetExitCodeProcess( HANDLE hProcess, LPDWORD lpExitCode ); I was trying to get the exit code of a running process on windows. That didnât work, so we started again with OSWindows on a clean Pharo 8. There we noticed that the currentProcess was not [ 255 255 255 255 255 255 255 255] but [ 255 255 255 255 0 0 0 0]. That (and the test being green in 32 bit) triggered the idea. We did a quick and dirty change to verify, and then found out that the Squeak code had cleaner fixes. Stephan

March 21, 2019

Re: [Pharo-dev] How to download a patched file?

by Max Leske

Hi Eliot, On 21 Mar 2019, at 21:00, Eliot Miranda wrote: > Hi GitHub mavens, > > how does one download a specific patched file from GitHub? I > want to > test Pablo's fix here: > > https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381 > platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m > <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381/files#diff-0> > > I don't want to go through "View File", or clone, or anything else. I > just > want the file itself. How do I get it? You'll have to know the commit hash, then you can grap it by path: https://raw.githubusercontent.com/OpenSmalltalk/opensmalltalk-vm/1a09bae437… AFAIK, there's no direct way to get to the file directly from the diff view. Max > > _,,,^..^,,,_ > best, Eliot

March 21, 2019

Re: [Pharo-dev] How to download a patched file?

by Gabriel Cotelli

Clicked "View File" button, then "Raw" button in the new page that gets opened. On Thu, Mar 21, 2019 at 5:21 PM Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > Hi Gabriel, > > On Thu, Mar 21, 2019 at 1:15 PM Gabriel Cotelli <g.cotelli(a)gmail.com> > wrote: > >> >> https://raw.githubusercontent.com/OpenSmalltalk/opensmalltalk-vm/1a09bae437… >> and save as ? >> > > great. This works (provided one selects "Page Source"). But how did you > get to that link? > > >> >> On Thu, Mar 21, 2019 at 5:01 PM Eliot Miranda <eliot.miranda(a)gmail.com> >> wrote: >> >>> Hi GitHub mavens, >>> >>> how does one download a specific patched file from GitHub? I want >>> to test Pablo's fix here: >>> >>> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381 >>> platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m >>> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381/files#diff-0> >>> >>> I don't want to go through "View File", or clone, or anything else. I >>> just want the file itself. How do I get it? >>> >>> _,,,^..^,,,_ >>> best, Eliot >>> >> > > -- > _,,,^..^,,,_ > best, Eliot >

March 21, 2019

Re: [Pharo-dev] How to download a patched file?

by Eliot Miranda

Hi Gabriel, On Thu, Mar 21, 2019 at 1:15 PM Gabriel Cotelli <g.cotelli(a)gmail.com> wrote: > > https://raw.githubusercontent.com/OpenSmalltalk/opensmalltalk-vm/1a09bae437… > and save as ? > great. This works (provided one selects "Page Source"). But how did you get to that link? > > On Thu, Mar 21, 2019 at 5:01 PM Eliot Miranda <eliot.miranda(a)gmail.com> > wrote: > >> Hi GitHub mavens, >> >> how does one download a specific patched file from GitHub? I want >> to test Pablo's fix here: >> >> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381 >> platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m >> <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381/files#diff-0> >> >> I don't want to go through "View File", or clone, or anything else. I >> just want the file itself. How do I get it? >> >> _,,,^..^,,,_ >> best, Eliot >> > -- _,,,^..^,,,_ best, Eliot

March 21, 2019

Re: [Pharo-dev] How to download a patched file?

by Gabriel Cotelli

https://raw.githubusercontent.com/OpenSmalltalk/opensmalltalk-vm/1a09bae437… and save as ? On Thu, Mar 21, 2019 at 5:01 PM Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > Hi GitHub mavens, > > how does one download a specific patched file from GitHub? I want to > test Pablo's fix here: > > https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381 > platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m > <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381/files#diff-0> > > I don't want to go through "View File", or clone, or anything else. I > just want the file itself. How do I get it? > > _,,,^..^,,,_ > best, Eliot >

March 21, 2019

How to download a patched file?

by Eliot Miranda

Hi GitHub mavens, how does one download a specific patched file from GitHub? I want to test Pablo's fix here: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381 platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m <https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/381/files#diff-0> I don't want to go through "View File", or clone, or anything else. I just want the file itself. How do I get it? _,,,^..^,,,_ best, Eliot

March 21, 2019

Re: [Pharo-dev] Questions about DebugSession>>isContextPostMortem:

by Eliot Miranda

Hi Thomas, Hi Max, On Thu, Mar 21, 2019 at 3:35 AM Max Leske <maxleske(a)gmail.com> wrote: > On 21 Mar 2019, at 11:06, Thomas Dupriez wrote: > > Hi Thomas, > > > Hello, > > > > While looking at the DebugSession>>isContextPostMortem: method (code > > below), I got three questions: > > > > 1) There is a check for whether the suspendedContext (top context) of > > the process is nil. Does it even make sense for a process not to have > > any top context? > > Yes, only suspended processes have a suspendedContext. Also, the process > might have been terminated already. > > > > > 2) It seems that all the last 3 lines are doing is to check whether > > selectedContext is in the context chain of the process. Could they be > > rewritten into this simpler one-liner? `|^ (suspendedContext > > hasContext: selectedContext) not`| > > Yes, I think that would work. > > > > > 3) Overall, this method says that a context C is "post mortem" if the > > process controlled by the DebugSession has a top context and C is not > > in its context chain. That's the practical definition. Could someone > > shed some light on the high-level definition of "post mortem"? Because > > "post mortem" is like "after death", but the death of what? A context > > that merely belongs to another context chain would be considered "post > > mortem" by the practical definition, but there's no death in this > > case... > > || > > > > You can create a copy of a process' stack. That stack will behave like a > process in the debugger but it can't run, as the VM doesn't have a > process to which the context are attached, hence it's considered > post-mortem. > > > > > ``` > > > > |DebugSession>>isContextPostMortem: selectedContext "return whether > > we're inspecting a frozen exception without a process attached" | > > suspendedContext | suspendedContext := interruptedProcess > > suspendedContext. suspendedContext ifNil: [ ^ false ]. > > (suspendedContext == selectedContext) ifTrue: [ ^ false ]. ^ > > (suspendedContext findContextSuchThat: [:c | c sender == > > selectedContext]) isNil ``` | > In addition a context is post-mortem if its pc is nil, which at least in Squeak is answered by the Context>>isDead method. So I might look at writing that method as DebugSession>>isContextPostMortem: selectedContext "Answer if we're inspecting a frozen exception without a process attached." ^selectedContext isDead or: [(interruptedProcess suspendedContext hasContext: selectedContext) not] > > > > Does someone know the answer to some (or all) of these questions? > > > > Thomas > > > Hope that helps. > > Max > > -- _,,,^..^,,,_ best, Eliot

March 21, 2019

Re: [Pharo-dev] Missing tests for FFI in CI

by ducasse

Hello Stefan Can you report the exact call you were doing? I talked with G and Pablo and the bug they fixed is not the same. Now they would like to experiment and write tests for all the platform. Stef > On 21 Mar 2019, at 08:00, Stephan Eggermont <stephan(a)stack.nl> wrote: > > Yesterday, we tracked down a serious issue in 64 bit FFI. After giving up > with our own code, we made a fresh start with the latest base image and > OSWindows. We were finally able to figure out what went wrong with two > simple tests that were failing in 64 bit that worked correctly in 32 bit. > > FFIConstantHandleType externalType is the wrong size > > After confirming that and making it work, we were told that a number of FFI > fixes were done by Nicolas and Eliot in Squeak that did not get integrated > in Pharo. Applying the changes from the latest Squeak FFI resolved the > problem, and a few that we were unaware of. > > Stephan > > > >

March 21, 2019