- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Random refactoring on UITheme or what?

by Sergi Reyner

2014-03-22 10:55 GMT+00:00 Esteban Lorenzano <estebanlm(a)gmail.com>: > > So... I suppose we need to do both: clean removing the old ones and fix the > ones we decide to keep :) > While talking about themes... IÂ´d like to have at least one theme that supports changing the window color, without looking childish like the Squeak one (which seems to have disappeared) or awful like the Vistary one (ok, itÂ´s not THAT bad, but I donÂ´t like it :D). Has color ever worked at all with any other theme? I just tried a Pharo 1.3 image and it was already broken back then. I gave it a couple of tries but ended up lost amongst the classes. Cheers, Sergi

March 22, 2014

Re: [Pharo-dev] Bug in Rectangle?

by Nicolas Cellier

2014-03-22 12:20 GMT+01:00 Nicolas Cellier < nicolas.cellier.aka.nice(a)gmail.com>: > From the st80 ages, rectangle have allways been oriented. > You have an origin and a corner inst var, not 2 corners or vertices. > And you have creation messages Rectangle class>>origin:corner: > The conventions are that of latin scribes, the orientation of rectangle > should be (left->right , top->down) > > There is an assumption that a rectangle with negative width (right->left) > or height (bottom->top) should be treated as empty. > And this was globally well maintained except a few breakages introduced in > Squeak along the years (but I hope I corrected most of the slips since > then). > > Now Igor and Stephane had another view more geometric and un-oriented, and > wanted to change conventions/handling of empty rectangles in Pharo. > I don't know how far they went, or even if it is feasible at all... IMO, > it's a recipe for maximizing breakage/gain ratio. > > Note that VW has Rectangle class>>vertex:vertex:, and we probably should > add such message... > > > > Something like: Point>>vertex: aPoint ^aRectangle vertex: self vertex: aPoint Rectangle class>>vertex: point1 vertex: point2 ^self origin: (point1 min: point2) corner: (point1 max: point2) > > 2014-03-21 15:15 GMT+01:00 Noury Bouraqadi <bouraqadi(a)gmail.com>: > > Inverting the origin and the corner of a rectangle changes the result of >> intersection. >> I guess it's a bug, though I imagine that changing the code of Rectangle >> is likely to have deep/undesired consequences.. >> >> (0@0 corner: 100@100) intersects: (-50@ -50 corner: 80@80) ==> true >> (100@100 corner: 0@0) intersects: (-50@ -50 corner: 80@80) ==> false >> !!!! >> >> Noury >> >> >> >> >> >

March 22, 2014

Re: [Pharo-dev] Bug in Rectangle?

by Nicolas Cellier

>From the st80 ages, rectangle have allways been oriented. You have an origin and a corner inst var, not 2 corners or vertices. And you have creation messages Rectangle class>>origin:corner: The conventions are that of latin scribes, the orientation of rectangle should be (left->right , top->down) There is an assumption that a rectangle with negative width (right->left) or height (bottom->top) should be treated as empty. And this was globally well maintained except a few breakages introduced in Squeak along the years (but I hope I corrected most of the slips since then). Now Igor and Stephane had another view more geometric and un-oriented, and wanted to change conventions/handling of empty rectangles in Pharo. I don't know how far they went, or even if it is feasible at all... IMO, it's a recipe for maximizing breakage/gain ratio. Note that VW has Rectangle class>>vertex:vertex:, and we probably should add such message... 2014-03-21 15:15 GMT+01:00 Noury Bouraqadi <bouraqadi(a)gmail.com>: > Inverting the origin and the corner of a rectangle changes the result of > intersection. > I guess it's a bug, though I imagine that changing the code of Rectangle > is likely to have deep/undesired consequences.. > > (0@0 corner: 100@100) intersects: (-50@ -50 corner: 80@80) ==> true > (100@100 corner: 0@0) intersects: (-50@ -50 corner: 80@80) ==> false !!!! > > Noury > > > > >

March 22, 2014

Re: [Pharo-dev] Random refactoring on UITheme or what?

by Hilaire Fernandes

Phil, What is the darktheme? Years ago I produced a Sugar theme for DrGeo on XO OLPC[1]. It is a black and white theme[2]. Thanks Hilaire [1] http://blog.ofset.org/hilaire/index.php?post/2010/07/20/Pharo-Smalltalk-on-… [2] http://blog.ofset.org/hilaire/index.php?post/2010/07/17/Sugar-theme-fpr-Pha… Le 22/03/2014 10:28, phil(a)highoctane.be a Ã©crit : > And the darktheme can only come out of serious refactorings I think. -- Dr. Geo http://drgeo.eu

March 22, 2014

Re: [Pharo-dev] Random refactoring on UITheme or what?

by Esteban Lorenzano

Hi Hilaire, There are many themes that needs to be removed (Pharo -is the old one-, Orange, Blue). Then others we need to decide what we do with them. For example, I have the feeling that vistary theme is so bad that no one uses it, but I can be wrong (and maybe is not so bad and is just me who hates the vista look). But watery is very well done and deserves to survive, I think. But well.. some problems are inherent to the âthemeâ mechanism (the thing that makes buttons not appear on hover for exampleâ¦ it happens almost whenever you change a theme). Soâ¦ I suppose we need to do both: clean removing the old ones and fix the ones we decide to keep :) Esteban On 22 Mar 2014, at 11:50, Hilaire Fernandes <hilaire.fernandes(a)gmail.com> wrote: > Hello, > > Well, if you can't do it, don't. I mean there is no obligation to > refactor working stuff if you don't have the resource to go from A to Z. > It is ok. > > Then I *don't* understand something else: why so many new themes? It is > ridiculous to see PharoTheme, BlueTheme, OrangeTheme, Pharo3Theme. Some > are not even working properly. > May be there is a logic, but I don't get it. > > For the broken Vistary theme, I identified the problem, and I'll let Ben > apply the fix as it seems appropriate to him[1]. > > Thanks > > Hilaire > > > [1] https://pharo.fogbugz.com/f/cases/13112/Broken-Vistary-theme > > > > Le 22/03/2014 10:42, Sven Van Caekenberghe a Ã©crit : >> The theme stuff is really hard and complex. It is impossible to maintain multiple ones, especially if those are seldom used. Maybe it would have been better to remove all those that are not properly maintained. But that would not have made you happy either I guess. >> >> It is really simple: with the limited resources that we have, we cannot maintain all of them. >> >> On 22 Mar 2014, at 09:33, Hilaire Fernandes <hilaire.fernandes(a)gmail.com> wrote: >> >>> Hello, >>> >>> <bitter> >>> In Pharo3, the UITheme hierarchy seems to have been hit by random >>> refactoring (it really looks like that) because it is broken in so many >>> place[1][2][3] and in such obvious way (very visible). >>> >>> It will be nice the random refactorers take(s) full responsibility to do >>> the job from A to Z, and not only from A to H. >>> </bitter> >>> >>> [1] https://pharo.fogbugz.com/f/cases/12554/Broken-Watery-theme >>> [2] https://pharo.fogbugz.com/f/cases/13112/Broken-Vistary-theme >>> [3] https://pharo.fogbugz.com/f/cases/13114/Broken-PharoTheme >>> >>> Thanks >>> >>> Hilaire >>> >>> >>> -- >>> Dr. Geo http://drgeo.eu >> >> >> > > -- > Dr. Geo http://drgeo.eu > >

March 22, 2014

Re: [Pharo-dev] Random refactoring on UITheme or what?

by Hilaire Fernandes

Hello, Well, if you can't do it, don't. I mean there is no obligation to refactor working stuff if you don't have the resource to go from A to Z. It is ok. Then I *don't* understand something else: why so many new themes? It is ridiculous to see PharoTheme, BlueTheme, OrangeTheme, Pharo3Theme. Some are not even working properly. May be there is a logic, but I don't get it. For the broken Vistary theme, I identified the problem, and I'll let Ben apply the fix as it seems appropriate to him[1]. Thanks Hilaire [1] https://pharo.fogbugz.com/f/cases/13112/Broken-Vistary-theme Le 22/03/2014 10:42, Sven Van Caekenberghe a Ã©crit : > The theme stuff is really hard and complex. It is impossible to maintain multiple ones, especially if those are seldom used. Maybe it would have been better to remove all those that are not properly maintained. But that would not have made you happy either I guess. > > It is really simple: with the limited resources that we have, we cannot maintain all of them. > > On 22 Mar 2014, at 09:33, Hilaire Fernandes <hilaire.fernandes(a)gmail.com> wrote: > >> Hello, >> >> <bitter> >> In Pharo3, the UITheme hierarchy seems to have been hit by random >> refactoring (it really looks like that) because it is broken in so many >> place[1][2][3] and in such obvious way (very visible). >> >> It will be nice the random refactorers take(s) full responsibility to do >> the job from A to Z, and not only from A to H. >> </bitter> >> >> [1] https://pharo.fogbugz.com/f/cases/12554/Broken-Watery-theme >> [2] https://pharo.fogbugz.com/f/cases/13112/Broken-Vistary-theme >> [3] https://pharo.fogbugz.com/f/cases/13114/Broken-PharoTheme >> >> Thanks >> >> Hilaire >> >> >> -- >> Dr. Geo http://drgeo.eu > > > -- Dr. Geo http://drgeo.eu

March 22, 2014

Re: [Pharo-dev] Random refactoring on UITheme or what?

by Sven Van Caekenberghe

The theme stuff is really hard and complex. It is impossible to maintain multiple ones, especially if those are seldom used. Maybe it would have been better to remove all those that are not properly maintained. But that would not have made you happy either I guess. It is really simple: with the limited resources that we have, we cannot maintain all of them. On 22 Mar 2014, at 09:33, Hilaire Fernandes <hilaire.fernandes(a)gmail.com> wrote: > Hello, > > <bitter> > In Pharo3, the UITheme hierarchy seems to have been hit by random > refactoring (it really looks like that) because it is broken in so many > place[1][2][3] and in such obvious way (very visible). > > It will be nice the random refactorers take(s) full responsibility to do > the job from A to Z, and not only from A to H. > </bitter> > > [1] https://pharo.fogbugz.com/f/cases/12554/Broken-Watery-theme > [2] https://pharo.fogbugz.com/f/cases/13112/Broken-Vistary-theme > [3] https://pharo.fogbugz.com/f/cases/13114/Broken-PharoTheme > > Thanks > > Hilaire > > > -- > Dr. Geo http://drgeo.eu

March 22, 2014

Re: [Pharo-dev] Random refactoring on UITheme or what?

by phil＠highoctane.be

Themes are hard to change in 2.0 And the darktheme can only come out of serious refactorings I think. So, I've got hope that we move forward on that and there will indeed be serious breakage along the way. Phil On Sat, Mar 22, 2014 at 9:48 AM, Pharo4Stef <pharo4Stef(a)free.fr> wrote: > > > <bitter> > > In Pharo3, the UITheme hierarchy seems to have been hit by random > > refactoring (it really looks like that) because it is broken in so many > > place[1][2][3] and in such obvious way (very visible). > > > > It will be nice the random refactorers take(s) full responsibility to do > > the job from A to Z, and not only from A to H. > > </bitter> > > > > [1] https://pharo.fogbugz.com/f/cases/12554/Broken-Watery-theme > > [2] https://pharo.fogbugz.com/f/cases/13112/Broken-Vistary-theme > > [3] https://pharo.fogbugz.com/f/cases/13114/Broken-PharoTheme > > > > Thanks > > Thanks hilaire. > > Indeed this is sometimes difficult to do things :) > I think that we should be more cautious about > - making sure that changes fully works. I can tell you that when > we worked three days with igor to clean the frame API > it was a huge work but we when over all the corners and nobody saw > even that we worked. > - deprecate more > > Now you see you are the first one to report this. > > Stef >

March 22, 2014

Re: [Pharo-dev] Random refactoring on UITheme or what?

by Pharo4Stef

> <bitter> > In Pharo3, the UITheme hierarchy seems to have been hit by random > refactoring (it really looks like that) because it is broken in so many > place[1][2][3] and in such obvious way (very visible). > > It will be nice the random refactorers take(s) full responsibility to do > the job from A to Z, and not only from A to H. > </bitter> > > [1] https://pharo.fogbugz.com/f/cases/12554/Broken-Watery-theme > [2] https://pharo.fogbugz.com/f/cases/13112/Broken-Vistary-theme > [3] https://pharo.fogbugz.com/f/cases/13114/Broken-PharoTheme > > Thanks Thanks hilaire. Indeed this is sometimes difficult to do things :) I think that we should be more cautious about - making sure that changes fully works. I can tell you that when we worked three days with igor to clean the frame API it was a huge work but we when over all the corners and nobody saw even that we worked. - deprecate more Now you see you are the first one to report this. Stef

March 22, 2014

Random refactoring on UITheme or what?

by Hilaire Fernandes

Hello, <bitter> In Pharo3, the UITheme hierarchy seems to have been hit by random refactoring (it really looks like that) because it is broken in so many place[1][2][3] and in such obvious way (very visible). It will be nice the random refactorers take(s) full responsibility to do the job from A to Z, and not only from A to H. </bitter> [1] https://pharo.fogbugz.com/f/cases/12554/Broken-Watery-theme [2] https://pharo.fogbugz.com/f/cases/13112/Broken-Vistary-theme [3] https://pharo.fogbugz.com/f/cases/13114/Broken-PharoTheme Thanks Hilaire -- Dr. Geo http://drgeo.eu

March 22, 2014