- Pharo-dev - lists.pharo.org

[Pharo 8.0] Build #173: FAILURE

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #173 was: FAILURE. Could not extract further issue information from commit message: Update config.yml fixes #2982 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

March 22, 2019

Re: [Pharo-dev] ZdcAbstractSocketStream>>peekFor:?

by Sven Van Caekenberghe

I accepted it, thanks for the PR! > On 17 Mar 2019, at 08:45, Alistair Grant <akgrant0710(a)gmail.com> wrote: > > Hi Sven, > > > On Sat, 16 Mar 2019 at 20:28, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >> >> Here please, https://github.com/svenvc/zodiac > > Done. The changes were made in Pharo 8 and it's added lots of > methodProperties.json files. I assume this is because you haven't had > to make changes since Iceberg was updated. Let me know if it is a > problem. > > Thanks, > Alistair > > >>> On 16 Mar 2019, at 20:23, Alistair Grant <akgrant0710(a)gmail.com> wrote: >>> >>> Hi Sven, >>> >>> On Sat, 16 Mar 2019 at 20:16, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >>>> >>>> Since there is #peek there is no reason not to add #peekFor: as >>>> >>>> peekFor: object >>>> "Answer false and do not move over the next element if it is not equal to object, or if the receiver is at the end. >>>> Answer true and move over the next element when it is equal to object." >>>> >>>> ^ self peek = object >>>> ifTrue: [ >>>> self next. >>>> true ] >>>> ifFalse: [ false ] >>> >>> Great, thanks. >>> >>> I'm happy to submit a PR, but vaguely remember that submitting it to >>> pharo-project/pharo creates more work for you. Where should this be >>> submitted (and in general for Zinc submissions)? >>> >>> Thanks again, >>> Alistair >>> >>> >>> >>>> But note that the Zdc socket streams do not make a difference between synchronous / asynchronous - IIRC I would say they block (they are also always binary and flush when their buffer is full). >>>> >>>> Peeking in the context of a socket / network stream will block, just like reading. >>>> >>>>> On 16 Mar 2019, at 19:44, Alistair Grant <akgrant0710(a)gmail.com> wrote: >>>>> >>>>> Hi Esteban, >>>>> On Sat, 16 Mar 2019 at 19:37, Esteban Maringolo <emaringolo(a)gmail.com> wrote: >>>>>> >>>>>> I don't know the answer but how could you peek for data that has yet not come through the socket? In the buffer? Should it block? >>>>> >>>>> From memory: It depends on the mode of the stream: >>>>> >>>>> If synchronous: peeking will block until data is available. >>>>> If asynchronous: if data is available, the next byte / character is >>>>> returned. If no data is available, nil is returned. If nil is >>>>> returned, you need to check if the socked is #atEnd to determine >>>>> whether it is the end of the stream or just nothing available now. >>>>> >>>>> Cheers, >>>>> Alistair >>>>> >>>>> >>>>> >>>>>> Regards. >>>>>> >>>>>> El sÃ¡b., 16 de mar. de 2019 12:23, Alistair Grant <akgrant0710(a)gmail.com> escribiÃ³: >>>>>>> >>>>>>> Hi Sven, >>>>>>> >>>>>>> Unlike most streams that support #peek, ZdcAbstractSocketStream >>>>>>> doesn't support #peekFor:. >>>>>>> >>>>>>> Is this intentional, or an oversight? >>>>>>> >>>>>>> Thanks, >>>>>>> Alistair >> >> >

March 22, 2019

[Pharo 8.0] Build #172: Update issue URL in build report email

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #172 was: SUCCESS. The Pull Request #2985 was integrated: "Update issue URL in build report email" Pull request url: https://github.com/pharo-project/pharo/pull/2985 Issue Url: https://github.com/pharo-project/pharo/issues/Pharo8.0 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

March 22, 2019

Re: [Pharo-dev] [Issue Tracker] installed some robots

by Marcus Denker

This seems to be quite niceâ¦ we are now step by step improving the bot messages e.g. https://github.com/pharo-project/pharo/issues/2971 https://github.com/pharo-project/pharo/issues/2982 I have installed one more bot for now: https://probot.github.io/apps/reminders/ Use the /remind slash command to set a reminder on any comment box on GitHub and you'll get a ping about it again when the reminder is due. Use any form of /remind me [what] [when], such as: /remind me to deploy on Oct 10 /remind me next Monday to review the requirements /remind me that the specs on the rotary girder need checked in 6 months > On 21 Mar 2019, at 11:35, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > They seem to all work. > > The âStaleâ plugin somehow marked two already merged PRs as staleâ¦ which is odd. > But else it seems to work. > >> On 21 Mar 2019, at 10:34, Marcus Denker <marcus.denker(a)inria.fr> wrote: >> >> Hi, >> >> I have added some robots to the github account https://github.com/pharo-project >> >> For for main repository https://github.com/pharo-project/pharo I have enabled by adding the required configs to .github/ : >> >> >> Work In Progress: Prevent merging of Pull Requests with "WIP" in the title >> https://github.com/marketplace/wip >> >> No Response: Closes Issues where the author hasn't responded to a request for more information >> >> If the tag more-information-needed is set and no answer provided, issue is closed in 14 days. >> >> https://probot.github.io/apps/no-response/ >> >> Request Info: Requests more info on issues and pull requests with the default title or an empty body. >> it sets the more-information-needed flag. >> https://probot.github.io/apps/request-info/ >> >> >> Stale: Close stale Issues and Pull Requests >> >> https://github.com/probot/stale >> Issues: daysUntilStale: 240, daysUntilClose: 60 >> Pulls: daysUntilStale: 20, daysUntilClose: 10 >> >> >> >

March 22, 2019

[Pharo 8.0] Build #171: Remove incorrect test

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #171 was: SUCCESS. The Pull Request #2977 was integrated: "Remove incorrect test" Pull request url: https://github.com/pharo-project/pharo/pull/2977 Issue Url: https://pharo.fogbugz.com/f/cases/patch Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

March 22, 2019

[ANN] Next Pharo Sprint: March 29

by Marcus Denker

We will organize a Pharo sprint / Moose dojo March 29, starting at 10:00am. (Local Time Paris). Goals of this sprint: - Pharo 7 backports, Pharo 8, - Check issues from old Issue tracker Remote Sprint: Remotely, you can join us on Discord. During the sprint, we synchronize local and remote Pharo sprinters: http://pharo.org/contribute-events We have added a (right now empty) Board to coordinate the work: https://github.com/orgs/pharo-project/projects/9 Known Local Sprint meetings Lille/France: It will be at the Inria Lille, Building B, third floor (RMoD offices). As the building is not open to the public, please contact us before if you plan to come

March 22, 2019

[Pharo 8.0] Build #170: 2972-MailAddressTokenizer-doesnt-handle-non-ascii-characters

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #170 was: SUCCESS. The Pull Request #2973 was integrated: "2972-MailAddressTokenizer-doesnt-handle-non-ascii-characters" Pull request url: https://github.com/pharo-project/pharo/pull/2973 Issue Url: https://pharo.fogbugz.com/f/cases/2972 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

March 22, 2019

[Pharo 8.0] Build #169: 2955-speedup-isAccessedIn-in-BooleanSlot-and-PropertySlot

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #169 was: FAILURE. The Pull Request #2956 was integrated: "2955-speedup-isAccessedIn-in-BooleanSlot-and-PropertySlot" Pull request url: https://github.com/pharo-project/pharo/pull/2956 Issue Url: https://pharo.fogbugz.com/f/cases/2955 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

March 22, 2019

Re: [Pharo-dev] [Issue Tracker] installed some robots

by Ben Coman

Thanks. This is useful. On Thu, 21 Mar 2019 at 17:34, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > Request Info: Requests more info on issues and pull requests with the > default title or an empty body. > it sets the more-information-needed flag. > https://probot.github.io/apps/request-info/ > Can more info be added to the generic message... > We would appreciate it if you could provide us with more info about this issue/pr! "This issue has either a default title or empty body. We would appreciate it if you could provide more info about this issue/pr!" Stale: Close stale Issues and Pull Requests > > https://github.com/probot/stale > Issues: daysUntilStale: 240, daysUntilClose: 60 > Pulls: daysUntilStale: 20, daysUntilClose: 10 > Same general thing about Stalebot comments, I opened... https://github.com/pharo-project/pharo/issues/2971 cheers -ben

March 22, 2019

Re: [Pharo-dev] Missing tests for FFI in CI

by Stephan Eggermont

Guillermo Polito <guillermopolito(a)gmail.com> wrote: >> >> BOOL GetExitCodeProcess( >> HANDLE hProcess, >> LPDWORD lpExitCode >> ); >> > > what are your mappings for BOOL, HANDLE and LPDWORD? Those are user defined > types :) > I downloaded the stable version of OSWindows from the catalog Stephan

March 21, 2019