- Pharo-dev - lists.pharo.org

[pharo-project/pharo-core] fd7e82: 40100

by GitHub

Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: fd7e82f07cfab0301e2c96e4761ffd4f271cd48d https://github.com/pharo-project/pharo-core/commit/fd7e82f07cfab0301e2c96e4… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2014-07-18 (Fri, 18 Jul 2014) Changed paths: A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script100.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40100.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st A Slot.package/extension/Association/instance/emitStore_.st A Slot.package/extension/Association/instance/emitValue_.st R Traits.package/TClass.class/instance/initialize-release/declare_.st Log Message: ----------- 40100 - make Globals and Class binding compact - workaround for Associations appearing in globals and classPools due to Undeclared handling http://files.pharo.org/image/40/40100.zip

July 18, 2014

Re: [Pharo-dev] Association dnu emitValue:

by Marcus Denker

>> I added tests in 099 to check that all binding are correct in Smalltalk globals and all classPools. >> >> It seems that someone is adding global somehow with the wrong class (Association instead of >> GlobalVar (a subclass of Association). >> >> But #at:put: should do the right thing in SystemDictionaryâ¦ >> >> The most likely candidate is Undeclared handlingâ¦ yes, that has to be it. The unknown binding is >> put into Undeclared as an association and then just moved over, while it should switch the type >> (depending on if it is a global or a class var). >> >> I will fix that. >> >> as a workaround, you can add the method >> >> emitValue: methodBuilder >> methodBuilder pushLiteralVariable: self. >> > I will add for now the workaroundâ¦ I found the place where to fix it, too, but that needs then some testing. > > This is now in update #100 Marcus

July 18, 2014

Re: [Pharo-dev] Association dnu emitValue:

by Marcus Denker

On 18 Jul 2014, at 10:38, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > On 18 Jul 2014, at 10:26, Marcus Denker <marcus.denker(a)inria.fr> wrote: > >> >> On 18 Jul 2014, at 10:20, Marcus Denker <marcus.denker(a)inria.fr> wrote: >> >>> >>> On 18 Jul 2014, at 10:16, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: >>> >>>> Hi, >>>> >>>> when my image tries to run startup scripts I get: >>>> >>>> Association(Object)>>doesNotUnderstand: #emitValue: >>>> >>>> Should I report it? >>> >>> >>> Yes. It should not happen. >>> >>> But startup script are very strange as they somehow hold onto compiled code. >> >> Do you have a way to recreate it? >> >> What happens is that somehow a global or class variable still is an association. >> (I just added tests that make sure that Smalltalk globals as well as all classPools are well >> formedâ¦) > > I added tests in 099 to check that all binding are correct in Smalltalk globals and all classPools. > > It seems that someone is adding global somehow with the wrong class (Association instead of > GlobalVar (a subclass of Association). > > But #at:put: should do the right thing in SystemDictionaryâ¦ > > The most likely candidate is Undeclared handlingâ¦ yes, that has to be it. The unknown binding is > put into Undeclared as an association and then just moved over, while it should switch the type > (depending on if it is a global or a class var). > > I will fix that. > > as a workaround, you can add the method > > emitValue: methodBuilder > methodBuilder pushLiteralVariable: self. > I will add for now the workaroundâ¦ I found the place where to fix it, too, but that needs then some testing. Marcus

July 18, 2014

Re: [Pharo-dev] [pharo-project/pharo-core] 9ebdd6: 40099

by Pavel Krivanek

Great, now the shrinking to the basic image does not have any overrides nor ugly hacks. https://ci.inria.fr/pharo/view/4.0-Bootstrap/job/Pharo-4.0-Bootstrap-Step-1… -- Pavel 2014-07-18 10:32 GMT+02:00 GitHub <noreply(a)github.com>: > Branch: refs/heads/4.0 > Home: https://github.com/pharo-project/pharo-core > Commit: 9ebdd640712f23c1c3055d066972c2034e3ca45e > > https://github.com/pharo-project/pharo-core/commit/9ebdd640712f23c1c3055d06… > Author: Jenkins Build Server <board(a)pharo-project.org> > Date: 2014-07-18 (Fri, 18 Jul 2014) > > Changed paths: > R Graphics-Primitives.package/Color.class/class/as yet > unclassified/aaFontsColormapDepth.st > R Graphics-Primitives.package/Color.class/class/as yet > unclassified/cachedColormapFrom_to_.st > A > Graphics-Primitives.package/Color.class/class/colormaps/aaFontsColormapDepth.st > A > Graphics-Primitives.package/Color.class/class/colormaps/cachedColormapFrom_to_.st > M > Graphics-Primitives.package/Color.class/instance/printing/shortPrintString.st > M Graphics-Primitives.package/EllipseMidpointTracer.class/ > definition.st > M > Graphics-Primitives.package/EllipseMidpointTracer.class/instance/initialize/on_.st > A NativeBoost-Unix.package/UnixEnvironment.class/README.md > A > NativeBoost-Unix.package/UnixEnvironment.class/class/testing/isDefaultFor_.st > A NativeBoost-Unix.package/UnixEnvironment.class/definition.st > A NativeBoost-Unix.package/UnixEnvironment.class/instance/accessing/ > environ.st > A > NativeBoost-Unix.package/UnixEnvironment.class/instance/enumeration/keysAndValuesDo_.st > A > NativeBoost-Unix.package/UnixEnvironment.class/instance/private/environAt_.st > A > NativeBoost-Unix.package/UnixEnvironment.class/instance/private/setEnv_value_.st > A NativeBoost-Win32.package/Win32Environment.class/README.md > A > NativeBoost-Win32.package/Win32Environment.class/class/testing/isDefaultFor_.st > A NativeBoost-Win32.package/Win32Environment.class/definition.st > A > NativeBoost-Win32.package/Win32Environment.class/instance/accessing/environmentStrings.st > A > NativeBoost-Win32.package/Win32Environment.class/instance/enumeration/keysAndValuesDo_.st > A > NativeBoost-Win32.package/Win32Environment.class/instance/private/getEnvSize_.st > A > NativeBoost-Win32.package/Win32Environment.class/instance/private/getEnv_.st > A > NativeBoost-Win32.package/Win32Environment.class/instance/private/getEnv_buffer_size_.st > A > NativeBoost-Win32.package/Win32Environment.class/instance/private/setEnv_value_.st > A > NativeBoost-Win32.package/Win32Environment.class/instance/private/unsetEnv_.st > A > ReleaseTests.package/ReleaseTest.class/instance/testing/testAllClassPoolBindingAreClassVariables.st > A > ReleaseTests.package/ReleaseTest.class/instance/testing/testAllGlobalBindingAreGlobalVariables.st > A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/ > script99.st > A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/ > update40099.st > M > ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st > M Slot.package/ClassVariable.class/README.md > M > Slot.package/ClassVariable.class/instance/meta-object-protocol/link_.st > A Slot.package/ClassVariable.class/instance/testing/isClassVariable.st > M Slot.package/GlobalVariable.class/README.md > A Slot.package/GlobalVariable.class/instance/as yet > unclassified/definingClass.st > M > Slot.package/GlobalVariable.class/instance/meta-object-protocol/link_.st > A > Slot.package/GlobalVariable.class/instance/testing/isGlobalVariable.st > R > Slot.package/LiteralVariable.class/instance/meta-object-protocol/link_.st > A > Slot.package/LiteralVariable.class/instance/testing/isClassVariable.st > A > Slot.package/LiteralVariable.class/instance/testing/isGlobalVariable.st > R System-Platforms.package/UnixEnvironment.class/README.md > R > System-Platforms.package/UnixEnvironment.class/class/testing/isDefaultFor_.st > R System-Platforms.package/UnixEnvironment.class/definition.st > R System-Platforms.package/UnixEnvironment.class/instance/accessing/ > environ.st > R > System-Platforms.package/UnixEnvironment.class/instance/enumeration/keysAndValuesDo_.st > R > System-Platforms.package/UnixEnvironment.class/instance/private/environAt_.st > R > System-Platforms.package/UnixEnvironment.class/instance/private/setEnv_value_.st > R System-Platforms.package/Win32Environment.class/README.md > R > System-Platforms.package/Win32Environment.class/class/testing/isDefaultFor_.st > R System-Platforms.package/Win32Environment.class/definition.st > R > System-Platforms.package/Win32Environment.class/instance/accessing/environmentStrings.st > R > System-Platforms.package/Win32Environment.class/instance/enumeration/keysAndValuesDo_.st > R > System-Platforms.package/Win32Environment.class/instance/private/getEnvSize_.st > R > System-Platforms.package/Win32Environment.class/instance/private/getEnv_.st > R > System-Platforms.package/Win32Environment.class/instance/private/getEnv_buffer_size_.st > R > System-Platforms.package/Win32Environment.class/instance/private/setEnv_value_.st > R > System-Platforms.package/Win32Environment.class/instance/private/unsetEnv_.st > M > Tests.package/OSEnvironmentTest.class/instance/tests/testEnvironmentFor.st > > Log Message: > ----------- > 40099 > 13576 Small code critique cleanup Graphics-Primitives > https://pharo.fogbugz.com/f/cases/13576 > > 13587 add tests to make sure globals and class vars use the right bindings > https://pharo.fogbugz.com/f/cases/13587 > > 13580 move UnixEnvironment and Win32Environment to NativeBoost > https://pharo.fogbugz.com/f/cases/13580 > > http://files.pharo.org/image/40/40099.zip > > >

July 18, 2014

Re: [Pharo-dev] Association dnu emitValue:

by Marcus Denker

On 18 Jul 2014, at 10:26, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > On 18 Jul 2014, at 10:20, Marcus Denker <marcus.denker(a)inria.fr> wrote: > >> >> On 18 Jul 2014, at 10:16, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: >> >>> Hi, >>> >>> when my image tries to run startup scripts I get: >>> >>> Association(Object)>>doesNotUnderstand: #emitValue: >>> >>> Should I report it? >> >> >> Yes. It should not happen. >> >> But startup script are very strange as they somehow hold onto compiled code. > > Do you have a way to recreate it? > > What happens is that somehow a global or class variable still is an association. > (I just added tests that make sure that Smalltalk globals as well as all classPools are well > formedâ¦) I added tests in 099 to check that all binding are correct in Smalltalk globals and all classPools. It seems that someone is adding global somehow with the wrong class (Association instead of GlobalVar (a subclass of Association). But #at:put: should do the right thing in SystemDictionaryâ¦ The most likely candidate is Undeclared handlingâ¦ yes, that has to be it. The unknown binding is put into Undeclared as an association and then just moved over, while it should switch the type (depending on if it is a global or a class var). I will fix that. as a workaround, you can add the method emitValue: methodBuilder methodBuilder pushLiteralVariable: self. to Association. Marcus

July 18, 2014

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/40099 Home: https://github.com/pharo-project/pharo-core

July 18, 2014

[pharo-project/pharo-core] 9ebdd6: 40099

by GitHub

Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: 9ebdd640712f23c1c3055d066972c2034e3ca45e https://github.com/pharo-project/pharo-core/commit/9ebdd640712f23c1c3055d06… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2014-07-18 (Fri, 18 Jul 2014) Changed paths: R Graphics-Primitives.package/Color.class/class/as yet unclassified/aaFontsColormapDepth.st R Graphics-Primitives.package/Color.class/class/as yet unclassified/cachedColormapFrom_to_.st A Graphics-Primitives.package/Color.class/class/colormaps/aaFontsColormapDepth.st A Graphics-Primitives.package/Color.class/class/colormaps/cachedColormapFrom_to_.st M Graphics-Primitives.package/Color.class/instance/printing/shortPrintString.st M Graphics-Primitives.package/EllipseMidpointTracer.class/definition.st M Graphics-Primitives.package/EllipseMidpointTracer.class/instance/initialize/on_.st A NativeBoost-Unix.package/UnixEnvironment.class/README.md A NativeBoost-Unix.package/UnixEnvironment.class/class/testing/isDefaultFor_.st A NativeBoost-Unix.package/UnixEnvironment.class/definition.st A NativeBoost-Unix.package/UnixEnvironment.class/instance/accessing/environ.st A NativeBoost-Unix.package/UnixEnvironment.class/instance/enumeration/keysAndValuesDo_.st A NativeBoost-Unix.package/UnixEnvironment.class/instance/private/environAt_.st A NativeBoost-Unix.package/UnixEnvironment.class/instance/private/setEnv_value_.st A NativeBoost-Win32.package/Win32Environment.class/README.md A NativeBoost-Win32.package/Win32Environment.class/class/testing/isDefaultFor_.st A NativeBoost-Win32.package/Win32Environment.class/definition.st A NativeBoost-Win32.package/Win32Environment.class/instance/accessing/environmentStrings.st A NativeBoost-Win32.package/Win32Environment.class/instance/enumeration/keysAndValuesDo_.st A NativeBoost-Win32.package/Win32Environment.class/instance/private/getEnvSize_.st A NativeBoost-Win32.package/Win32Environment.class/instance/private/getEnv_.st A NativeBoost-Win32.package/Win32Environment.class/instance/private/getEnv_buffer_size_.st A NativeBoost-Win32.package/Win32Environment.class/instance/private/setEnv_value_.st A NativeBoost-Win32.package/Win32Environment.class/instance/private/unsetEnv_.st A ReleaseTests.package/ReleaseTest.class/instance/testing/testAllClassPoolBindingAreClassVariables.st A ReleaseTests.package/ReleaseTest.class/instance/testing/testAllGlobalBindingAreGlobalVariables.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script99.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40099.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Slot.package/ClassVariable.class/README.md M Slot.package/ClassVariable.class/instance/meta-object-protocol/link_.st A Slot.package/ClassVariable.class/instance/testing/isClassVariable.st M Slot.package/GlobalVariable.class/README.md A Slot.package/GlobalVariable.class/instance/as yet unclassified/definingClass.st M Slot.package/GlobalVariable.class/instance/meta-object-protocol/link_.st A Slot.package/GlobalVariable.class/instance/testing/isGlobalVariable.st R Slot.package/LiteralVariable.class/instance/meta-object-protocol/link_.st A Slot.package/LiteralVariable.class/instance/testing/isClassVariable.st A Slot.package/LiteralVariable.class/instance/testing/isGlobalVariable.st R System-Platforms.package/UnixEnvironment.class/README.md R System-Platforms.package/UnixEnvironment.class/class/testing/isDefaultFor_.st R System-Platforms.package/UnixEnvironment.class/definition.st R System-Platforms.package/UnixEnvironment.class/instance/accessing/environ.st R System-Platforms.package/UnixEnvironment.class/instance/enumeration/keysAndValuesDo_.st R System-Platforms.package/UnixEnvironment.class/instance/private/environAt_.st R System-Platforms.package/UnixEnvironment.class/instance/private/setEnv_value_.st R System-Platforms.package/Win32Environment.class/README.md R System-Platforms.package/Win32Environment.class/class/testing/isDefaultFor_.st R System-Platforms.package/Win32Environment.class/definition.st R System-Platforms.package/Win32Environment.class/instance/accessing/environmentStrings.st R System-Platforms.package/Win32Environment.class/instance/enumeration/keysAndValuesDo_.st R System-Platforms.package/Win32Environment.class/instance/private/getEnvSize_.st R System-Platforms.package/Win32Environment.class/instance/private/getEnv_.st R System-Platforms.package/Win32Environment.class/instance/private/getEnv_buffer_size_.st R System-Platforms.package/Win32Environment.class/instance/private/setEnv_value_.st R System-Platforms.package/Win32Environment.class/instance/private/unsetEnv_.st M Tests.package/OSEnvironmentTest.class/instance/tests/testEnvironmentFor.st Log Message: ----------- 40099 13576 Small code critique cleanup Graphics-Primitives https://pharo.fogbugz.com/f/cases/13576 13587 add tests to make sure globals and class vars use the right bindings https://pharo.fogbugz.com/f/cases/13587 13580 move UnixEnvironment and Win32Environment to NativeBoost https://pharo.fogbugz.com/f/cases/13580 http://files.pharo.org/image/40/40099.zip

July 18, 2014

Re: [Pharo-dev] Association dnu emitValue:

by Marcus Denker

On 18 Jul 2014, at 10:20, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > On 18 Jul 2014, at 10:16, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > >> Hi, >> >> when my image tries to run startup scripts I get: >> >> Association(Object)>>doesNotUnderstand: #emitValue: >> >> Should I report it? > > > Yes. It should not happen. > > But startup script are very strange as they somehow hold onto compiled code. Do you have a way to recreate it? What happens is that somehow a global or class variable still is an association. (I just added tests that make sure that Smalltalk globals as well as all classPools are well formedâ¦) Marcus

July 18, 2014

Re: [Pharo-dev] Association dnu emitValue:

by Pavel Krivanek

Pharo-4.0-Bootstrap-Step-2.0-ConfigurationOfSUnit job is failing because of this issue too. -- Pavel 2014-07-18 10:20 GMT+02:00 Marcus Denker <marcus.denker(a)inria.fr>: > > On 18 Jul 2014, at 10:16, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > > > Hi, > > > > when my image tries to run startup scripts I get: > > > > Association(Object)>>doesNotUnderstand: #emitValue: > > > > Should I report it? > > > Yes. It should not happen. > > But startup script are very strange as they somehow hold onto compiled > code. > > > Uko > > > > P.S. here is stack: > > > > Association(Object)>>doesNotUnderstand: #emitValue: > > OCLiteralVariable>>emitValue: > > OCASTTranslatorForValue(OCASTTranslator)>>visitVariableNode: > > RBVariableNode>>acceptVisitor: > > OCASTTranslatorForValue(RBProgramNodeVisitor)>>visitNode: > > OCASTTranslatorForValue(OCASTTranslator)>>visitNode: > > OCASTTranslatorForValue(OCASTTranslator)>>emitMessageNode: > > OCASTTranslatorForValue(OCASTTranslator)>>visitMessageNode: > > RBMessageNode>>acceptVisitor: > > OCASTTranslatorForValue(RBProgramNodeVisitor)>>visitNode: > > OCASTTranslatorForValue(OCASTTranslator)>>visitNode: > > OCASTTranslatorForEffect>>emitIfTrue: > > OCASTTranslatorForEffect(OCASTTranslator)>>visitMessageNode: > > RBMessageNode>>acceptVisitor: > > OCASTTranslatorForEffect(RBProgramNodeVisitor)>>visitNode: > > OCASTTranslatorForEffect(OCASTTranslator)>>visitNode: > > [ :each | self visitNode: each ] in > OCASTTranslatorForEffect>>visitSequenceNode: in Block: [ :each | self > visitNode: each ] > > OrderedCollection>>do: > > OCASTTranslatorForEffect>>visitSequenceNode: > > RBSequenceNode>>acceptVisitor: > > OCASTTranslatorForEffect(RBProgramNodeVisitor)>>visitNode: > > OCASTTranslatorForEffect(OCASTTranslator)>>visitNode: > > OCASTTranslator>>visitMethodNode: > > RBMethodNode>>acceptVisitor: > > OCASTTranslator(RBProgramNodeVisitor)>>visitNode: > > OCASTTranslator>>visitNode: > > RBMethodNode>>generateIR > > RBMethodNode>>generate: > > [ > > [ > > ast := self parse. > > self doSemanticAnalysis ] > > on: OCSourceCodeChanged > > do: [ :notification | > > self source: notification newSourceCode. > > notification retry ]. > > cm := ast generate: self compilationContext compiledMethodTrailer ] in > OpalCompiler>>compile in Block: [ ... > > BlockClosure>>on:do: > > > > > > >

July 18, 2014

Re: [Pharo-dev] Association dnu emitValue:

by Marcus Denker

On 18 Jul 2014, at 10:16, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > Hi, > > when my image tries to run startup scripts I get: > > Association(Object)>>doesNotUnderstand: #emitValue: > > Should I report it? Yes. It should not happen. But startup script are very strange as they somehow hold onto compiled code. > Uko > > P.S. here is stack: > > Association(Object)>>doesNotUnderstand: #emitValue: > OCLiteralVariable>>emitValue: > OCASTTranslatorForValue(OCASTTranslator)>>visitVariableNode: > RBVariableNode>>acceptVisitor: > OCASTTranslatorForValue(RBProgramNodeVisitor)>>visitNode: > OCASTTranslatorForValue(OCASTTranslator)>>visitNode: > OCASTTranslatorForValue(OCASTTranslator)>>emitMessageNode: > OCASTTranslatorForValue(OCASTTranslator)>>visitMessageNode: > RBMessageNode>>acceptVisitor: > OCASTTranslatorForValue(RBProgramNodeVisitor)>>visitNode: > OCASTTranslatorForValue(OCASTTranslator)>>visitNode: > OCASTTranslatorForEffect>>emitIfTrue: > OCASTTranslatorForEffect(OCASTTranslator)>>visitMessageNode: > RBMessageNode>>acceptVisitor: > OCASTTranslatorForEffect(RBProgramNodeVisitor)>>visitNode: > OCASTTranslatorForEffect(OCASTTranslator)>>visitNode: > [ :each | self visitNode: each ] in OCASTTranslatorForEffect>>visitSequenceNode: in Block: [ :each | self visitNode: each ] > OrderedCollection>>do: > OCASTTranslatorForEffect>>visitSequenceNode: > RBSequenceNode>>acceptVisitor: > OCASTTranslatorForEffect(RBProgramNodeVisitor)>>visitNode: > OCASTTranslatorForEffect(OCASTTranslator)>>visitNode: > OCASTTranslator>>visitMethodNode: > RBMethodNode>>acceptVisitor: > OCASTTranslator(RBProgramNodeVisitor)>>visitNode: > OCASTTranslator>>visitNode: > RBMethodNode>>generateIR > RBMethodNode>>generate: > [ > [ > ast := self parse. > self doSemanticAnalysis ] > on: OCSourceCodeChanged > do: [ :notification | > self source: notification newSourceCode. > notification retry ]. > cm := ast generate: self compilationContext compiledMethodTrailer ] in OpalCompiler>>compile in Block: [ ... > BlockClosure>>on:do: > >

July 18, 2014