- Pharo-dev - lists.pharo.org

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/40122 Home: https://github.com/pharo-project/pharo-core

July 24, 2014

[pharo-project/pharo-core] 66a818: 40122

by GitHub

Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: 66a8182c2a1b6f8de3417956bcf73e50e86fe2e6 https://github.com/pharo-project/pharo-core/commit/66a8182c2a1b6f8de3417956… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2014-07-24 (Thu, 24 Jul 2014) Changed paths: A Morphic-Base.package/TransformationMorph.class/instance/accessing/embeddedWindowOrNil.st R Morphic-Base.package/extension/PasteUpMorph/instance/windowsSatisfying_.st M Morphic-Core.package/HandMorph.class/instance/private events/generateMouseEvent_.st A Morphic-Core.package/Morph.class/instance/accessing/embeddedWindowOrNil.st A Morphic-Core.package/PasteUpMorph.class/instance/accessing/currentWindow.st A Morphic-Core.package/PasteUpMorph.class/instance/accessing/windowsSatisfying_.st A Morphic-Widgets-Windows.package/SystemWindow.class/instance/accessing/embeddedWindowOrNil.st M OpalCompiler-Core.package/OpalCompiler.class/instance/public access/compile.st R Polymorph-Widgets.package/extension/PasteUpMorph/instance/currentWindow.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script122.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40122.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 40122 13675 safer windows enumeration https://pharo.fogbugz.com/f/cases/13675 13676 safer usage of KMBuffer in HandMorph >> #generateMouseEvent: https://pharo.fogbugz.com/f/cases/13676 13669 CompilerNotifying test failing on main build https://pharo.fogbugz.com/f/cases/13669 13674 safer access to top current window https://pharo.fogbugz.com/f/cases/13674 13667 Delete empty package System-Tools https://pharo.fogbugz.com/f/cases/13667 http://files.pharo.org/image/40/40122.zip

July 24, 2014

Komitter in 30852?

by Stephan Eggermont

Anyone tried Komitter recently in Pharo 3? I get about 4 to 6 debugger windows per change. Don't try on an image with lots of open changes... Stephan

July 24, 2014

Re: [Pharo-dev] [Pharo4] Weekend Project 1: Cleanup Low-Level animation code

by stepharo

Yes marcus may be we should add that description to pharo roadmaps on github. I like to document design problems that I encounter but cannot fix fast. Stef On 24/7/14 10:28, Marcus Denker wrote: > Hi, > > Now with holidays comingâ¦ maybe someone wants to do a small Pharo related Project with impact on the future? > > Here is suggestion 1. > > Context: cleanup graphics. (so e.g. one could replace the canvas later). > > Details > ====== > Morphic has some very arcane code for animating moving morphs around that bypasses layers. > > DisplayObject has these methods: > > follow:while: > follow:while:bitsBehind:startingLoc: > slideFrom:to:nSteps:delay: > slideWithFirstFrom:to:nSteps:delay: > displayOnPort:at:rule: > > They are used by morphic for some not really important animation that for sure > can be directly done by moving the morphs as morphs around. Bypassing > and directly using low level (not even Canvas level) functionality is for sure not needed. > > On the Morph level the users are: > > slideBackToFormerSituation: > vanishAfterSlidingTo:event: > animationForMoveSuccess: > > What to do? > > -> rewrite the morphic level code to just move the morphs around. > -> delete all the code from DisplayObject > -> review âGrafPortâ usage, as this might have been the last client. > > > Marcus >

July 24, 2014

Re: [Pharo-dev] Refactor Nautilus

by stepharo

On 24/7/14 10:23, Nicolai Hess wrote: > If no one raises objections, I would like to start on refactor / cleanup > nautilus code. Wonderful! I can review your changes if this helps you (I really like when other people do it for me). > This includes: > > renaming / recategorizing > solve code critics shown in Critics Browser > split classes (AbstractNautilusUI has 427 methods 24 instvars ) > stronger separation between the browser model, browser state > and browser UI. > > review event handling and UI updating > (sometimes there is a difference between what the UI shows > as selected and the selection the model(s) holds > > maybe: > create one package pane widget for package and groups > (therefore move all that package vs groups handling from > nautilus ui to that widget) > merge Nautilus and PackageTreeNautilus > > (I don't consider all of Nautilus bad code, it has well > designed parts, it just has grown meanwhile...) Sure improving does not mean that previous code is bad. Iterations are the way to learn. > How to update the code? > > Working with slices makes it easier to find changes > that introduces new bugs. > Otherwise it takes time to do it in such small steps and I don't > know if those changes are reviewed at all. do the best that can help you and what we can try is to give priority to the integration stream. Like that you avoid to have dependencies between the changes. This is what I try to do when I work on polymorph. I try to work on two unrelated topics (tools and widgets) so that the changes can be pushed to the stream and I can always work with the latest update > > So, I would try to group the changes. > 1. code critics > 2. renameing/ simple refactoring > 3. .... one simple change at a time but steadily. stef > > > nicolai > > >

July 24, 2014

Re: [Pharo-dev] Refactor Nautilus

by Esteban Lorenzano

please, go ahead :) On 24 Jul 2014, at 10:23, Nicolai Hess <nicolaihess(a)web.de> wrote: > If no one raises objections, I would like to start on refactor / cleanup > nautilus code. > > This includes: > > renaming / recategorizing > solve code critics shown in Critics Browser > split classes (AbstractNautilusUI has 427 methods 24 instvars ) > stronger separation between the browser model, browser state > and browser UI. > > review event handling and UI updating > (sometimes there is a difference between what the UI shows > as selected and the selection the model(s) holds > > maybe: > create one package pane widget for package and groups > (therefore move all that package vs groups handling from > nautilus ui to that widget) > merge Nautilus and PackageTreeNautilus > > (I don't consider all of Nautilus bad code, it has well > designed parts, it just has grown meanwhile...) > > How to update the code? > > Working with slices makes it easier to find changes > that introduces new bugs. > Otherwise it takes time to do it in such small steps and I don't > know if those changes are reviewed at all. > > So, I would try to group the changes. > 1. code critics > 2. renameing/ simple refactoring > 3. .... > > > nicolai > > >

July 24, 2014

[Pharo4] Weekend Project 1: Cleanup Low-Level animation code

by Marcus Denker

Hi, Now with holidays comingâ¦ maybe someone wants to do a small Pharo related Project with impact on the future? Here is suggestion 1. Context: cleanup graphics. (so e.g. one could replace the canvas later). Details ====== Morphic has some very arcane code for animating moving morphs around that bypasses layers. DisplayObject has these methods: follow:while: follow:while:bitsBehind:startingLoc: slideFrom:to:nSteps:delay: slideWithFirstFrom:to:nSteps:delay: displayOnPort:at:rule: They are used by morphic for some not really important animation that for sure can be directly done by moving the morphs as morphs around. Bypassing and directly using low level (not even Canvas level) functionality is for sure not needed. On the Morph level the users are: slideBackToFormerSituation: vanishAfterSlidingTo:event: animationForMoveSuccess: What to do? -> rewrite the morphic level code to just move the morphs around. -> delete all the code from DisplayObject -> review âGrafPortâ usage, as this might have been the last client. Marcus

July 24, 2014

Re: [Pharo-dev] Refactor Nautilus

by Baptiste Quide

Good luck for that. I will have a look because the tool which allows to watch package dependencies embeds the Nautilus Browser, and i'm one of the maintainer at this time. Baptiste ----- Mail original ----- > De: "Nicolai Hess" <nicolaihess(a)web.de> > Ã: "Pharo Development List" <pharo-dev(a)lists.pharo.org> > EnvoyÃ©: Jeudi 24 Juillet 2014 10:23:15 > Objet: [Pharo-dev] Refactor Nautilus > If no one raises objections, I would like to start on refactor / cleanup > nautilus code. > This includes: > renaming / recategorizing > solve code critics shown in Critics Browser > split classes (AbstractNautilusUI has 427 methods 24 instvars ) > stronger separation between the browser model, browser state > and browser UI. > review event handling and UI updating > (sometimes there is a difference between what the UI shows > as selected and the selection the model(s) holds > maybe: > create one package pane widget for package and groups > (therefore move all that package vs groups handling from > nautilus ui to that widget) > merge Nautilus and PackageTreeNautilus > (I don't consider all of Nautilus bad code, it has well > designed parts, it just has grown meanwhile...) > How to update the code? > Working with slices makes it easier to find changes > that introduces new bugs. > Otherwise it takes time to do it in such small steps and I don't > know if those changes are reviewed at all. > So, I would try to group the changes. > 1. code critics > 2. renameing/ simple refactoring > 3. .... > nicolai

July 24, 2014

Re: [Pharo-dev] Package Dependencies Analysis : new features

by stepharo

I used it all yesterday evening :) I could not commit my changes because I could not rollbakc some of them but the tools is really great!!!! On 23/7/14 16:59, stepharo wrote: > I tried with Morphic-widgets and this is really cool because it is > really helping me to spot problems!!! > > Stef > > On 23/7/14 14:49, Baptiste Quide wrote: >> Hello Pharos Users, >> >> Since the first release of Package Dependencies Analysis, here is a >> summary of improvements : >> >> - tool is available in World Menu (Tools > Package Dependencies >> Browser) : choose your packages and browse dependencies. >> - add/remove packages into the analysis. >> - you can refresh the current analysis manually (for instance if you >> change a piece of code to remove/add dependency) >> - filter the packages displaying by name >> - button "find cycles" allows to find all cycles in the system where >> the selected packages in the tree are (it could take a while the >> first time you click) >> - contextual menu (right click) to browse scoped dependencies or find >> cycles among the selected packages in the tree >> >> Then, in the window displaying cycles among packages : >> >> - only dependencies among packages in the cycle are displaying (no >> outgoing dependencies) >> - packages appear by order (if you see aCycle : A, B, C, the cycle is >> A -> B -> C -> A) >> >> See more details : http://www.baptistequide.fr/packagedependencies.php >> >> Regards, >> >> Baptiste >

July 24, 2014

Refactor Nautilus

by Nicolai Hess

If no one raises objections, I would like to start on refactor / cleanup nautilus code. This includes: renaming / recategorizing solve code critics shown in Critics Browser split classes (AbstractNautilusUI has 427 methods 24 instvars ) stronger separation between the browser model, browser state and browser UI. review event handling and UI updating (sometimes there is a difference between what the UI shows as selected and the selection the model(s) holds maybe: create one package pane widget for package and groups (therefore move all that package vs groups handling from nautilus ui to that widget) merge Nautilus and PackageTreeNautilus (I don't consider all of Nautilus bad code, it has well designed parts, it just has grown meanwhile...) How to update the code? Working with slices makes it easier to find changes that introduces new bugs. Otherwise it takes time to do it in such small steps and I don't know if those changes are reviewed at all. So, I would try to group the changes. 1. code critics 2. renameing/ simple refactoring 3. .... nicolai

July 24, 2014