- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] this notion of submorphs is a plain bad design idea

by stepharo

and yes this one too items ^ submorphs select: [:m | m isKindOf: MenuItemMorph] What a fucking bad design practice! Stef

July 24, 2014

Re: [Pharo-dev] this notion of submorphs is a plain bad design idea

by stepharo

Another nice example hasItems "Answer if the receiver has menu items" ^ submorphs anySatisfy: [:each | each isKindOf: MenuItemMorph]

July 24, 2014

Re: [Pharo-dev] Deprecator

by Ben Coman

July 24, 2014

this notion of submorphs is a plain bad design idea

by stepharo

Not talking about the non polymorphic API.... like that we get such bad isKindOf: ... and brittle to package code. Stef removeStayUpBox | box ext | submorphs isEmpty ifTrue: [^self]. (submorphs first isAlignmentMorph) ifFalse: [^self]. box := submorphs first submorphs last. ext := box extent. (box isKindOf: IconicButton) ifTrue: [box labelGraphic: (Form extent: ext depth: 8); shedSelvedge; borderWidth: 0; lock]. box extent: ext. addTitle: aString icon: aForm updatingSelector: aSelector updateTarget: aTarget "Add a title line at the top of this menu Make aString its initial contents. If aSelector is not nil, then periodically obtain fresh values for its contents by sending aSelector to aTarget.." "Overridden to support menu dragging from the title-bar" | title titleContainer | title := AlignmentMorph newColumn. self setTitleParametersFor: title. "" aForm isNil ifTrue: [titleContainer := title] ifFalse: [| pair | pair := AlignmentMorph newRow. pair color: Color transparent. pair hResizing: #shrinkWrap. pair layoutInset: 0. "" pair addMorphBack: aForm asMorph. "" titleContainer := AlignmentMorph newColumn. titleContainer color: Color transparent. titleContainer vResizing: #shrinkWrap. titleContainer wrapCentering: #center. titleContainer cellPositioning: #topCenter. titleContainer layoutInset: 0. pair addMorphBack: titleContainer. "" title addMorphBack: pair]. "" aSelector ifNil: ["" aString asString linesDo: [:line | titleContainer addMorphBack: (StringMorph contents: line font: StandardFonts menuFont)]] ifNotNil: [| stringMorph | stringMorph := (aTarget perform: aSelector) asStringMorph. stringMorph font: StandardFonts menuFont. stringMorph lock. titleContainer addMorphBack: stringMorph]. "" title setProperty: #titleString toValue: aString. self addMorphFront: title. "" title useSquareCorners. title on: #mouseDown send: #mouseDownInTitle: to: self. (self hasProperty: #needsTitlebarWidgets) ifTrue: [self addStayUpIcons] addStayUpItem "Append a menu item that can be used to toggle this menu's persistence." (self valueOfProperty: #hasTitlebarWidgets ifAbsent: [ false ]) ifTrue: [ ^self ]. self addStayUpIcons. addStayUpItemSpecial "Append a menu item that can be used to toggle this menu's persistent." "This variant is resistant to the MVC compatibility in #setInvokingView:" (self valueOfProperty: #hasTitlebarWidgets ifAbsent: [ false ]) ifTrue: [ ^self ]. self addStayUpIcons.

July 24, 2014

Re: [Pharo-dev] pharo4 inbox (nearly) empty?

by stepharo

July 24, 2014

Re: [Pharo-dev] pharo4 inbox (nearly) empty?

by stepharo

nicolai esteban restarted the server and it sounds better. I proposed to copy the inbox and flush it also. Stef On 24/7/14 17:22, Nicolai Hess wrote: > http://smalltalkhub.com/mc/Pharo/Pharo40Inbox/main > This is all I see in this repository: > > # SLICE-Issue-13627-Move-Transcript-to-Tools-Transcript-StephaneDucasse.1.mcz > <http://smalltalkhub.com/mc/Pharo/Pharo40Inbox/SLICE-Issue-13627-Move-Transc…> > Refactoring-Tests-Core-MarkRizun.98.mcz > <http://smalltalkhub.com/mc/Pharo/Pharo40Inbox/Refactoring-Tests-Core-MarkRi…> > # Transcript-StephaneDucasse.26.mcz > <http://smalltalkhub.com/mc/Pharo/Pharo40Inbox/Transcript-StephaneDucasse.26…> > # Tool-Transcript-StephaneDucasse.3.mcz > <http://smalltalkhub.com/mc/Pharo/Pharo40Inbox/Tool-Transcript-StephaneDucas…> > # SLICE-Issue-13681-replace-Smalltalk-tools-shortcuts-with-Morph-shortcutHandler-PavelKrivanek.1.mcz > <http://smalltalkhub.com/mc/Pharo/Pharo40Inbox/SLICE-Issue-13681-replace-Sma…> > # Deprecated40-PavelKrivanek.21.mcz > <http://smalltalkhub.com/mc/Pharo/Pharo40Inbox/Deprecated40-PavelKrivanek.21…> > # Keymapping-Core-PavelKrivanek.192.mcz > <http://smalltalkhub.com/mc/Pharo/Pharo40Inbox/Keymapping-Core-PavelKrivanek…> > # Morphic-Core-PavelKrivanek.91.mcz > <http://smalltalkhub.com/mc/Pharo/Pharo40Inbox/Morphic-Core-PavelKrivanek.91…> > # SLICE-Issue-13682-Pack-of-simple-refactorings-MarkRizun.1.mcz > <http://smalltalkhub.com/mc/Pharo/Pharo40Inbox/SLICE-Issue-13682-Pack-of-sim…> > # Nautilus-MarkRizun.765.mcz > <http://smalltalkhub.com/mc/Pharo/Pharo40Inbox/Nautilus-MarkRizun.765.mcz> > # NautilusRefactoring-MarkRizun.172.mcz > <http://smalltalkhub.com/mc/Pharo/Pharo40Inbox/NautilusRefactoring-MarkRizun…> > # Refactoring-Core-MarkRizun.242.mcz > <http://smalltalkhub.com/mc/Pharo/Pharo40Inbox/Refactoring-Core-MarkRizun.24…> ># > >

July 24, 2014

Re: [Pharo-dev] pharo4 inbox (nearly) empty?

by btc＠openinworld.com

July 24, 2014

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/40123 Home: https://github.com/pharo-project/pharo-core

July 24, 2014

[pharo-project/pharo-core] c48491: 40123

by GitHub

Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: c4849128db83ff8b14df87f710c678eb11435dc3 https://github.com/pharo-project/pharo-core/commit/c4849128db83ff8b14df87f7… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2014-07-24 (Thu, 24 Jul 2014) Changed paths: A Deprecated40.package/extension/ToolRegistry/instance/shortcuts.st R Keymapping-Core.package/KMShortcutHandler.class/class/tools/registerToolsOn_.st A Morphic-Core.package/Morph.class/class/shortcuts/shortcutsHandler.st A Morphic-Core.package/Morph.class/class/shortcuts/shortcutsHandler_.st M Morphic-Core.package/Morph.class/definition.st M Morphic-Core.package/Morph.class/instance/event handling/handleKeystroke_.st A Morphic-Core.package/Morph.class/instance/shortcuts/shortcutsHandler.st M Morphic-Widgets-Tree.package/MorphTreeListManager.class/instance/selection change/noteRemovalOfAll_.st M Morphic-Widgets-Tree.package/MorphTreeMorph.class/instance/updating/noteRemovalOfAll_.st M Morphic-Widgets-Tree.package/MorphTreeNodeMorph.class/instance/initialization/initWithContents_prior_forList_indentLevel_.st M Morphic-Widgets-Tree.package/MorphTreeNodeMorph.class/instance/updating/toggleExpandedState.st M Nautilus.package/AbstractNautilusUI.class/class/menu/classesMenu_.st A NautilusRefactoring.package/NautilusRefactoring.class/instance/class/insertSubclass.st A NautilusRefactoring.package/NautilusRefactoring.class/instance/class/insertSuperclass.st A NautilusRefactoring.package/NautilusRefactoring.class/instance/inst var/moveInstVarToClass_.st A NautilusRefactoring.package/NautilusRefactoring.class/instance/method/moveMethodToClassFor_.st A NautilusRefactoring.package/NautilusRefactoring.class/instance/private-class/privateInsertSubclassFor_.st A NautilusRefactoring.package/NautilusRefactoring.class/instance/private-class/privateInsertSuperclassFor_.st A NautilusRefactoring.package/NautilusRefactoring.class/instance/private-inst var/privateMoveInstVarToClass_.st A NautilusRefactoring.package/NautilusRefactoring.class/instance/private-method/privateMoveMethodToClassFor_.st M NautilusRefactoring.package/extension/ClassDescription/instance/instVarRefactoring_.st M NautilusRefactoring.package/extension/ClassDescription/instance/methodRefactoring_.st M NautilusRefactoring.package/extension/ClassDescription/instance/refactoringSubmenu_.st A Refactoring-Core.package/RBAddClassRefactoringTest.class/README.md A Refactoring-Core.package/RBAddClassRefactoringTest.class/definition.st A Refactoring-Core.package/RBMoveInstVarToClassRefactoring.class/README.md A Refactoring-Core.package/RBMoveInstVarToClassRefactoring.class/class/as yet unclassified/model_variable_class_oldClass_.st A Refactoring-Core.package/RBMoveInstVarToClassRefactoring.class/definition.st A Refactoring-Core.package/RBMoveInstVarToClassRefactoring.class/instance/accessing/oldClass_.st A Refactoring-Core.package/RBMoveInstVarToClassRefactoring.class/instance/preconditions/preconditions.st A Refactoring-Core.package/RBMoveInstVarToClassRefactoring.class/instance/transforming/collectSendersOfInstVar.st A Refactoring-Core.package/RBMoveInstVarToClassRefactoring.class/instance/transforming/transform.st A Refactoring-Core.package/RBMoveMethodToClassRefactoring.class/README.md A Refactoring-Core.package/RBMoveMethodToClassRefactoring.class/class/instance creation/method_class_.st A Refactoring-Core.package/RBMoveMethodToClassRefactoring.class/class/instance creation/model_method_class_.st A Refactoring-Core.package/RBMoveMethodToClassRefactoring.class/definition.st A Refactoring-Core.package/RBMoveMethodToClassRefactoring.class/instance/initialize-release/method_class_.st A Refactoring-Core.package/RBMoveMethodToClassRefactoring.class/instance/preconditions/preconditions.st A Refactoring-Core.package/RBMoveMethodToClassRefactoring.class/instance/printing/storeOn_.st A Refactoring-Core.package/RBMoveMethodToClassRefactoring.class/instance/transforming/transform.st M Refactoring-Tests-Core.package/RBFooLintRuleTest.class/README.md M Refactoring-Tests-Core.package/RBFooLintRuleTest.class/definition.st A Refactoring-Tests-Core.package/RBFooLintRuleTest.class/instance/as yet unclassified/foo.st A Refactoring-Tests-Core.package/RBMoveInstVarToClassTest.class/README.md A Refactoring-Tests-Core.package/RBMoveInstVarToClassTest.class/definition.st A Refactoring-Tests-Core.package/RBMoveInstVarToClassTest.class/instance/failure tests/testMoveInstVarToClassAlreadyDefined.st A Refactoring-Tests-Core.package/RBMoveMethodToClassTest.class/README.md A Refactoring-Tests-Core.package/RBMoveMethodToClassTest.class/definition.st A Refactoring-Tests-Core.package/RBMoveMethodToClassTest.class/instance/failure tests/testMethodAlreadyDefined.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script123.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40123.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 40123 13539 receiver of "NodeModel" is Nil https://pharo.fogbugz.com/f/cases/13539 13681 replace Smalltalk tools shortcuts with Morph shortcutHandler https://pharo.fogbugz.com/f/cases/13681 13682 Pack of simple refactorings https://pharo.fogbugz.com/f/cases/13682 http://files.pharo.org/image/40/40123.zip

July 24, 2014

pharo4 inbox (nearly) empty?

by Nicolai Hess

July 24, 2014