- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Default line endings while writing to a file stream

by Guillermo Polito

> El 2 jun 2019, a las 20:45, ducasse <stepharo(a)netcourrier.com> escribiÃ³: > > Sven > > why not having this as extension. Iâd even propose to have it by default: a FileReference writeStream can return a ZnNewLineWriterStream wrapping the corresponding stream. By default it can be configured with the systemâs default line ending convention (least surprise?). And then users can change it accordinglyâ¦ Now I ask also myself what we could do when reading line endings from a file. Iâm 98.761% convinced that in the image we should have a single line ending convention for strings, and that we should convert internal strings to the external representation of convenience explicitly. In this direction we could make that default read streams in FileSystem to automatically transform external line endings into internal line endings. > > Stef > > >> On 2 Jun 2019, at 13:52, Alistair Grant <akgrant0710(a)gmail.com> wrote: >> >> Hi Ben, >> >> On Fri, 31 May 2019 at 07:08, Ben Coman <btc(a)openinworld.com> wrote: >>> >>> >>> I'm on Windows wanting to write a text file with LF endings. >>> The code developed on Linux is thus... >>> (destinationDirectory / 'README.md') ensureCreateFile >>> writeStreamDo: [ :stream | stream nextPutAll: class comment ] >> >> I've come across this so many times that I always add a couple of >> methods to my image: >> >> ZnEncodedStream>>asNewLineStream >> "Answer the receiver wrapped with a ZnNewLineWriterStream" >> ^ZnNewLineWriterStream on: self! ! >> >> >> ZnNewLineWriterStream>>asNewLineStream >> "Answer the receiver wrapped with a ZnNewLineWriterStream" >> ^self! ! >> >> >> You could then modify the example above to be: >> >> stream asNewLineStream forLf nextPutAll: class comment >> >> Cheers, >> Alistair >> >> >> >>> and I am stuck with CR line endings. >>> The specific symptom is that it screws `git diff` >>> Here is a simple experiment... >>> testfile := 'README.md' asFileReference. >>> testfile ensureCreateFile writeStreamDo: [ :stream | >>> stream nextPutAll: 'aa >>> bb' ]. >>> testfile binaryReadStream contents at: 3 "==> Character cr " >>> >>> I think its safe to assume on Linux that will result in "==> Character lf " >>> but can someone please confirm? >>> >>> So my issue is that I've got >>> #ensureCreateFile - returns a FileReference >>> and >>> :stream - is a ZnCharacterWriteStream wrapping a ZnBufferedWriteStream wrapping BinaryFileStream. >>> >>> and neither seem to have an easily accessible defaultLineEnding setting. >>> Indeed, line endings are not a property of FileReference >>> and Binary & Characters have nothing to do with line endings, >>> and questionable if Buffering is related. >>> >>> Its more a property of a File, but IIUC that is being deprecated (??) >>> >>> MultiByteFileStream has #lineEndConvention: >>> but IIUC that also is being deprecated. >>> >>> So what is the proper way to force default line endings? >>> >>> >>> ------ >>> Now while composing this email I discovered String>>withUnixLineEndings. >>> So I have a solution... >>> testfile := 'README.md' asFileReference. >>> testfile ensureCreateFile writeStreamDo: [ :stream | >>> stream nextPutAll: 'aa >>> bb' withUnixLineEndings ]. >>> (testfile binaryReadStream contents at: 3) asCharacter "==> Character lf " >>> >>> but that seems to imply that on Windows... >>> 'aa >>> bb' at: 3 "==> Character cr " >>> >>> and on Linux (someone please confirm)... >>> 'aa >>> bb' at: 3 "==> Character lf " >>> >>> and that is *very* curious. Strange that I never noticed it before and obviously that hasn't hurt me, >>> but considering the Principal Of Least Surprise it leaves me feeling somewhat violated :) >> > > >

June 2, 2019

[Pharo 8.0] Build #308: 3447-hex-deserves-an-executable-comment

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #308 was: SUCCESS. The Pull Request #3448 was integrated: "3447-hex-deserves-an-executable-comment" Pull request url: https://github.com/pharo-project/pharo/pull/3448 Issue Url: https://github.com/pharo-project/pharo/issues/3447 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

June 2, 2019

Re: [Pharo-dev] Default line endings while writing to a file stream

by ducasse

Sven why not having this as extension. Stef > On 2 Jun 2019, at 13:52, Alistair Grant <akgrant0710(a)gmail.com> wrote: > > Hi Ben, > > On Fri, 31 May 2019 at 07:08, Ben Coman <btc(a)openinworld.com> wrote: >> >> >> I'm on Windows wanting to write a text file with LF endings. >> The code developed on Linux is thus... >> (destinationDirectory / 'README.md') ensureCreateFile >> writeStreamDo: [ :stream | stream nextPutAll: class comment ] > > I've come across this so many times that I always add a couple of > methods to my image: > > ZnEncodedStream>>asNewLineStream > "Answer the receiver wrapped with a ZnNewLineWriterStream" > ^ZnNewLineWriterStream on: self! ! > > > ZnNewLineWriterStream>>asNewLineStream > "Answer the receiver wrapped with a ZnNewLineWriterStream" > ^self! ! > > > You could then modify the example above to be: > > stream asNewLineStream forLf nextPutAll: class comment > > Cheers, > Alistair > > > >> and I am stuck with CR line endings. >> The specific symptom is that it screws `git diff` >> Here is a simple experiment... >> testfile := 'README.md' asFileReference. >> testfile ensureCreateFile writeStreamDo: [ :stream | >> stream nextPutAll: 'aa >> bb' ]. >> testfile binaryReadStream contents at: 3 "==> Character cr " >> >> I think its safe to assume on Linux that will result in "==> Character lf " >> but can someone please confirm? >> >> So my issue is that I've got >> #ensureCreateFile - returns a FileReference >> and >> :stream - is a ZnCharacterWriteStream wrapping a ZnBufferedWriteStream wrapping BinaryFileStream. >> >> and neither seem to have an easily accessible defaultLineEnding setting. >> Indeed, line endings are not a property of FileReference >> and Binary & Characters have nothing to do with line endings, >> and questionable if Buffering is related. >> >> Its more a property of a File, but IIUC that is being deprecated (??) >> >> MultiByteFileStream has #lineEndConvention: >> but IIUC that also is being deprecated. >> >> So what is the proper way to force default line endings? >> >> >> ------ >> Now while composing this email I discovered String>>withUnixLineEndings. >> So I have a solution... >> testfile := 'README.md' asFileReference. >> testfile ensureCreateFile writeStreamDo: [ :stream | >> stream nextPutAll: 'aa >> bb' withUnixLineEndings ]. >> (testfile binaryReadStream contents at: 3) asCharacter "==> Character lf " >> >> but that seems to imply that on Windows... >> 'aa >> bb' at: 3 "==> Character cr " >> >> and on Linux (someone please confirm)... >> 'aa >> bb' at: 3 "==> Character lf " >> >> and that is *very* curious. Strange that I never noticed it before and obviously that hasn't hurt me, >> but considering the Principal Of Least Surprise it leaves me feeling somewhat violated :) >

June 2, 2019

Re: [Pharo-dev] Versioning with Iceberg

by ducasse

> On 2 Jun 2019, at 20:19, Shaping <shaping(a)uurda.org> wrote: > > [â¦] I prefer the more detailed syntax highlighting in VW. > > Check the styler look for <style> in Pharo because you can create your own. > > I donât see this in Settings. I see âSyntax Highlightingâ¦â It is not exposed in the settings. Probably because it had its own preferences and we should migrate it. I created the issue: https://github.com/pharo-project/pharo/issues/3449 Now we will see if we succeed to find the time to work on it. Check SHRBTextStyler <styleTable: â¦> here is the default style blueStyleTable "color can be a valid argument to Color class>>colorFrom: , or nil to use the editor text color. Multiple emphases can be specified using an array e.g. #(bold italic). If emphasis is not specified, #normal will be used. if pixel height is not specified , then the editor font size will be used. " <styleTable: 'Blue'> ^ #( "(symbol color [emphasisSymbolOrArray [textStyleName [pixelHeight]]])" (default black) (invalid red) (excessCode red) (comment (gray darker)) (unfinishedComment (red muchDarker)) (#'$' (red muchDarker)) (character (red muchDarker)) (integer (red muchDarker)) (number (red muchDarker)) (#- (red muchDarker)) (symbol (magenta muchDarker)) (stringSymbol (magenta muchDarker)) (literalArray (magenta muchDarker)) (string (magenta muchDarker) normal) (unfinishedString red normal) (assignment nil) (ansiAssignment nil) (literal nil italic) (keyword (black)) (binary (black)) (unary (black)) (#self (cyan muchDarker )) (#super (cyan muchDarker )) (#true (red muchDarker)) (#false (red muchDarker)) (#nil (red muchDarker)) (#thisContext (cyan muchDarker )) (#return (cyan muchDarker ) bold) (patternArg (blue muchDarker)) (methodArg (blue muchDarker)) (blockPatternArg (blue muchDarker)) (blockArg (blue muchDarker)) (argument (blue muchDarker)) (blockTempVar (blue muchDarker)) (blockPatternTempVar (blue muchDarker)) (instVar (blue muchDarker)) (workspaceVar (blue muchDarker)) (tempVar (blue muchDarker)) (patternTempVar (blue muchDarker)) (poolConstant (blue muchDarker)) (classVar (blue muchDarker)) (globalVar (blue muchDarker)) (incompleteIdentifier blue italic) (incompleteKeyword nil italic) (incompleteBinary nil italic) (incompleteUnary nil italic) (undefinedIdentifier red) (undefinedKeyword red) (undefinedBinary red) (undefinedUnary red) (patternKeyword nil bold) (patternBinary nil bold) (patternUnary nil bold) (blockArgColon black) (leftParenthesis black) (rightParenthesis black) (leftParenthesis1 (green muchDarker)) (rightParenthesis1 (green muchDarker)) (leftParenthesis2 (magenta muchDarker)) (rightParenthesis2 (magenta muchDarker)) (leftParenthesis3 (red muchDarker)) (rightParenthesis3 (red muchDarker)) (leftParenthesis4 (green darker)) (rightParenthesis4 (green darker)) (leftParenthesis5 (orange darker)) (rightParenthesis5 (orange darker)) (leftParenthesis6 (magenta darker)) (rightParenthesis6 (magenta darker)) (leftParenthesis7 blue) (rightParenthesis7 blue) (blockStart black) (blockEnd black) (blockStart1 (green muchDarker)) (blockEnd1 (green muchDarker)) (blockStart2 (magenta muchDarker)) (blockEnd2 (magenta muchDarker)) (blockStart3 (red muchDarker)) (blockEnd3 (red muchDarker)) (blockStart4 (green darker)) (blockEnd4 (green darker)) (blockStart5 (orange darker)) (blockEnd5 (orange darker)) (blockStart6 (magenta darker)) (blockEnd6 (magenta darker)) (blockStart7 blue) (blockEnd7 blue) (arrayStart black) (arrayEnd black) (arrayStart1 black) (arrayEnd1 black) (leftBrace black) (rightBrace black) (cascadeSeparator black) (statementSeparator black) (methodTempBar (black)) (blockTempBar (black)) (blockArgsBar (black)) (externalCallType black) (externalCallTypePointerIndicator black) (primitiveOrExternalCallStart black bold) (primitiveOrExternalCallEnd black bold) (primitive (green muchDarker)) (pragmaKeyword (green muchDarker)) (pragmaUnary (green muchDarker)) (pragmaBinary (green muchDarker)) (externalFunctionCallingConvention (green muchDarker) bold) (module (green muchDarker) bold)) > > We need to do one for the dark theme. > There are a lot of variations. > >> I forgot all the differences, but recall more levels of parentheses can be colored uniquely in VW and so can block-argument variables. That would be a first small project: make Pharo syntax highlight at least as good as VWâs. I need to do the same for formatting, which I've not checked out very thoroughly yet. > > For formatting check the BIformatter. > > I cannot find class BIFormatter in the 7.0.3 image. What must I load? BIConfigurableFormatter is in the image. You have it in the settings. > > > We are working on > - adding tests (we have about 150 tests ready to get integrated > - working on a new tool to see and understand the settings > - we want to make sure that we can pretty print the complete system > so we will come probably with an extended pretty printer. > > Sounds good. > >> The other thing that has been causing problems and about which I've written some examples in Fogbugz (which no one is using anymore for Paroâand I didnât know, lol) is that Pharo labels are truncated if you switch to a monospace font. I can't see what I'm doing some of the time because the labels are chopped, and there is no automatic formatting of the fields to accommodate the new font, which is not even very big--just normal-sized monospace. I suppose Spec takes care of this problem systematically and that this is why nothing else has been done to fix the problem. > > Yes this is super annoying. Can you check with Spec 20 and this should be fixed. > > Iâm not sure what Spec 20 is. Are you referring to this document in progress: > This document is just the description of the integration of Commander2 with Spec20. Spec20 has examples. Check SpecDemo Check the examples in Spec-Examples. but I just see that latest version is frrezing the image :( > https://travis-ci.com/SquareBracketAssociates/BuildingApplicationWithSpec2 <https://travis-ci.com/SquareBracketAssociates/BuildingApplicationWithSpec2> > > ? >

June 2, 2019

SpecDemo open freezes the system ...

by ducasse

In latest P8

June 2, 2019

Re: [Pharo-dev] Iceberg: No Project Founds

by Shaping

On 2 Jun 2019, at 19:22, Shaping <shaping(a)uurda.org <mailto:shaping@uurda.org> > wrote: >From a 64-bit Pharo 7.0.3 I cloned UpdatedPharoByExample and immediately saw in red âNo Project Foundâ. Why is this and what must I do to fix it? GitKraken shows that the repo is healthy. But what are you clone a book repo only containing pillar file? Iceberg right now manages code. Right, I thought there were code examples in the project and that this would be enough for Iceberg to work with it. Try to clone of my Containers-Stack repo to see. The name of the GitHub repo to clone isâ¦? Shaping

June 2, 2019

Re: [Pharo-dev] Environments

by Shaping

Is the sequence: dev, alpha, beta, release? no alpha=dev Okay. We are working on Modules for Pharo now this is tricky and it can impact the complete system. Yes, it is very tricky and can cause chaos and destroy much utility if not managed correctly. Since Squeak3.9 Iâm working on removing hardocded usage of Smalltalk instead of an environment or se;lf class environment. So that one day we can try module/namespace for real. Now when porting code from VW to Pharo 1.0 :) I just did a mapping namespace to prefix and change the class name in VW to have prefixName. This is basically what the exporters are doing from VW. Right. I donât see Spec2 in Pharo 8. I suppose I need to load it. No it is directly in. In a virgin 8.0 dev image I see refs to âSpecâ in Packages but not to âSpec2â. Is the Spec book still relevant? Not fully we will start to port the book. Okay. Is Spec2 mostly about the back-end changes for use of GTK? No it is a massive change. - Introducing new layouts (deprecated the interpreter design) - soon using Commander2 for menus and the rest - many many cleans - Introduction of application and more. Okay, sounds good. Shaping

June 2, 2019

Re: [Pharo-dev] Versioning with Iceberg

by Shaping

[â¦] I prefer the more detailed syntax highlighting in VW. Check the styler look for <style> in Pharo because you can create your own. I donât see this in Settings. I see âSyntax Highlightingâ¦â We need to do one for the dark theme. There are a lot of variations. I forgot all the differences, but recall more levels of parentheses can be colored uniquely in VW and so can block-argument variables. That would be a first small project: make Pharo syntax highlight at least as good as VWâs. I need to do the same for formatting, which I've not checked out very thoroughly yet. For formatting check the BIformatter. I cannot find class BIFormatter in the 7.0.3 image. What must I load? We are working on - adding tests (we have about 150 tests ready to get integrated - working on a new tool to see and understand the settings - we want to make sure that we can pretty print the complete system so we will come probably with an extended pretty printer. Sounds good. The other thing that has been causing problems and about which I've written some examples in Fogbugz (which no one is using anymore for Paroâand I didnât know, lol) is that Pharo labels are truncated if you switch to a monospace font. I can't see what I'm doing some of the time because the labels are chopped, and there is no automatic formatting of the fields to accommodate the new font, which is not even very big--just normal-sized monospace. I suppose Spec takes care of this problem systematically and that this is why nothing else has been done to fix the problem. Yes this is super annoying. Can you check with Spec 20 and this should be fixed. Iâm not sure what Spec 20 is. Are you referring to this document in progress: https://travis-ci.com/SquareBracketAssociates/BuildingApplicationWithSpec2 ? Now the font logic is one of the few parts that we did not revisit yet but it is not way it should. Also may users hardcode standardFontsâ¦.( the ugly singleton strike back). Are you aware of "extension methods" ? Where a method you add to a built-in Pharo class (Collection for example) is saved/loaded with your package. Then you only need to manage your package not Pharo built-in packages as well. Yes, I'm trying to get an Iceberg-on-Git groove going so that I can make my own packages for extensions/overrides. yes us know we can also do some screen sharing with you to get you up to speed. [..] Cloning the Pharo Track repo from the command line is done like this... $ git clone <mailto:git@github.com:exercism/pharo-smalltalk.git> git@github.com:exercism/pharo-smalltalk.git Sure, but we can do this in Icebergâand it works. So why use the command line? which creates a folder with the same name as the repo (i.e. "pharo-smalltalk") As a git GUI, Iceberg does the same. Indeed, Iceberg uses libgit2 to do this, so the behaviour is standard git. I was commenting on the ergonomics, and yes this is very much a Git thing. Git is bad :) but this is the way to go. The API sucks. Yes, it has terminology problems too. Shaping

June 2, 2019

[Pharo 8.0] Build #307: 3064-Each-assert-like-method-in-TestRunner-should-have-the-dual-deny-method

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #307 was: SUCCESS. The Pull Request #3403 was integrated: "3064-Each-assert-like-method-in-TestRunner-should-have-the-dual-deny-method" Pull request url: https://github.com/pharo-project/pharo/pull/3403 Issue Url: https://github.com/pharo-project/pharo/issues/3064 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

June 2, 2019

[Pharo 8.0] Build #306: Update CODE_OF_CONDUCT.md

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #306 was: FAILURE. The Pull Request #3441 was integrated: "Update CODE_OF_CONDUCT.md" Pull request url: https://github.com/pharo-project/pharo/pull/3441 Issue Url: https://github.com/pharo-project/pharo/issues/patch Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

June 2, 2019