- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Browsing Object is slow

by Camille Teruel

On 7 aoÃ»t 2014, at 14:26, Nicolai Hess <nicolaihess(a)web.de> wrote: > Yes, that are may changes. > > I think I was a bit confused about > showHierarchy : show the real hierarchy of an class > and > showHierarchy : show the classes in a package sorted hierarchically. > > The first one is enabled by the hierarchy/flat-Button (show packages) > The second one is enabled by a "showhierarch" setting You see I was unaware of the setting :) BTW, it doesn't change the way classes are displayed when I disable it. > > 2014-08-07 13:47 GMT+02:00 Camille Teruel <camille.teruel(a)gmail.com>: > Hi everyone, > > I noticed that browsing Object take several seconds (5s on my machine). Evaluate Nautilus openOnClass: Object. > After profiling, I found it's because of ClassWidget>>setCachedHierarchyClass: that calls SortHierarchically class>>buildHierarchyForClasses: with a big collection of classes. > But the browser opens on the package view by default, not the hierarchy view. > So if I replace: > > ClassWidget>>showHierarchy: anObject > showHierarchy := anObject. > self selectedClass ifNotNil:[: class | > self setCachedHierarchyClass: class] > by: > > ClassWidget>>showHierarchy: aBoolean > (showHierarchy := aBoolean) > ifTrue: [ self selectedClass ifNotNil: [ :class | self setCachedHierarchyClass: class] ] > > it solves the problem. > But I don't know that part of the system well and I don't know if it's the correct thing to do or if we should try to improve performances of SortHierarchically instead. > So tell me what you think about it. > Here is the bug entry: https://pharo.fogbugz.com/f/cases/13795/Browsing-certain-classes-takes-seve… > > Thanks, > Camille >

Aug. 7, 2014

Re: [Pharo-dev] Browsing Object is slow

by Nicolai Hess

Yes, that are may changes. I think I was a bit confused about showHierarchy : show the real hierarchy of an class and showHierarchy : show the classes in a package sorted hierarchically. The first one is enabled by the hierarchy/flat-Button (show packages) The second one is enabled by a "showhierarch" setting 2014-08-07 13:47 GMT+02:00 Camille Teruel <camille.teruel(a)gmail.com>: > Hi everyone, > > I noticed that browsing Object take several seconds (5s on my machine). > Evaluate Nautilus openOnClass: Object. > After profiling, I found it's because of > ClassWidget>>setCachedHierarchyClass: that calls SortHierarchically > class>>buildHierarchyForClasses: with a big collection of classes. > But the browser opens on the package view by default, not the hierarchy > view. > So if I replace: > > ClassWidget>>showHierarchy: anObject > showHierarchy := anObject. > self selectedClass ifNotNil:[: class | > self setCachedHierarchyClass: class] > by: > > ClassWidget>>showHierarchy: aBoolean > (showHierarchy := aBoolean) > ifTrue: [ self selectedClass ifNotNil: [ :class | self > setCachedHierarchyClass: class] ] > > it solves the problem. > But I don't know that part of the system well and I don't know if it's the > correct thing to do or if we should try to improve performances of > SortHierarchically instead. > So tell me what you think about it. > Here is the bug entry: > https://pharo.fogbugz.com/f/cases/13795/Browsing-certain-classes-takes-seve… > > > Thanks, > Camille >

Aug. 7, 2014

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/40158 Home: https://github.com/pharo-project/pharo-core

Aug. 7, 2014

[pharo-project/pharo-core] 16bf1f: 40158

by GitHub

Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: 16bf1f532670c1b0647fe8644d359c9427f6529e https://github.com/pharo-project/pharo-core/commit/16bf1f532670c1b0647fe864… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2014-08-07 (Thu, 07 Aug 2014) Changed paths: R Collections-Abstract.package/HashedCollection.class/instance/explorer/hasContentsInExplorer.st R Collections-Sequenceable.package/OrderedCollection.class/instance/testing/hasContentsInExplorer.st R Collections-Strings.package/String.class/instance/testing/hasContentsInExplorer.st R Kernel.package/Float.class/instance/testing/hasContentsInExplorer.st R NECompletion.package/extension/ObjectExplorer/instance/guessTypeForName_.st R NECompletion.package/extension/ObjectExplorer/instance/isCodeCompletionAllowed.st R NECompletion.package/extension/ObjectExplorer/instance/selectedClassOrMetaClass.st R Polymorph-TaskbarIcons.package/extension/ObjectExplorer/instance/taskbarIcon.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script158.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40158.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st R Shout.package/extension/ObjectExplorer/instance/shoutAboutToStyle_.st R Shout.package/extension/ObjectExplorer/instance/shoutParser_.st A Spec-Inspector.package/extension/Object/instance/explore.st R Tool-Explorer.package/ObjectExplorer.class/README.md R Tool-Explorer.package/ObjectExplorer.class/class/setting/showIcons.st R Tool-Explorer.package/ObjectExplorer.class/class/setting/showIcons_.st R Tool-Explorer.package/ObjectExplorer.class/class/tools registry/openOn_.st R Tool-Explorer.package/ObjectExplorer.class/definition.st R Tool-Explorer.package/ObjectExplorer.class/instance/accessing/contentsSelection.st R Tool-Explorer.package/ObjectExplorer.class/instance/accessing/doItContext.st R Tool-Explorer.package/ObjectExplorer.class/instance/accessing/doItReceiver.st R Tool-Explorer.package/ObjectExplorer.class/instance/accessing/explorerFor_.st R Tool-Explorer.package/ObjectExplorer.class/instance/accessing/getCurrentSelection.st R Tool-Explorer.package/ObjectExplorer.class/instance/accessing/getList.st R Tool-Explorer.package/ObjectExplorer.class/instance/accessing/label.st R Tool-Explorer.package/ObjectExplorer.class/instance/accessing/object.st R Tool-Explorer.package/ObjectExplorer.class/instance/accessing/parentObject.st R Tool-Explorer.package/ObjectExplorer.class/instance/accessing/rootObject.st R Tool-Explorer.package/ObjectExplorer.class/instance/accessing/rootObject_.st R Tool-Explorer.package/ObjectExplorer.class/instance/accessing/selector.st R Tool-Explorer.package/ObjectExplorer.class/instance/acessing - morphs/textMorph.st R Tool-Explorer.package/ObjectExplorer.class/instance/acessing - morphs/treeListMorph.st R Tool-Explorer.package/ObjectExplorer.class/instance/acessing - morphs/window.st R Tool-Explorer.package/ObjectExplorer.class/instance/menus/addTo_fromMenuModelOf_.st R Tool-Explorer.package/ObjectExplorer.class/instance/menus/buildMenuForNoSelection_.st R Tool-Explorer.package/ObjectExplorer.class/instance/menus/buildMenuForSelection_.st R Tool-Explorer.package/ObjectExplorer.class/instance/menus/codePaneMenu_shifted_.st R Tool-Explorer.package/ObjectExplorer.class/instance/menus/defsOfSelection.st R Tool-Explorer.package/ObjectExplorer.class/instance/menus/explorePointers.st R Tool-Explorer.package/ObjectExplorer.class/instance/menus/exploreSelection.st R Tool-Explorer.package/ObjectExplorer.class/instance/menus/exploreStrongPointers.st R Tool-Explorer.package/ObjectExplorer.class/instance/menus/explorerKey_from_.st R Tool-Explorer.package/ObjectExplorer.class/instance/menus/genericMenu_.st R Tool-Explorer.package/ObjectExplorer.class/instance/menus/inspectSelection.st R Tool-Explorer.package/ObjectExplorer.class/instance/menus/referencesToSelection.st R Tool-Explorer.package/ObjectExplorer.class/instance/menus/selectedClass.st R Tool-Explorer.package/ObjectExplorer.class/instance/monitoring/monitorList.st R Tool-Explorer.package/ObjectExplorer.class/instance/monitoring/monitor_.st R Tool-Explorer.package/ObjectExplorer.class/instance/monitoring/release.st R Tool-Explorer.package/ObjectExplorer.class/instance/monitoring/shouldGetStepsFrom_.st R Tool-Explorer.package/ObjectExplorer.class/instance/monitoring/step.st R Tool-Explorer.package/ObjectExplorer.class/instance/monitoring/stopMonitoring.st R Tool-Explorer.package/ObjectExplorer.class/instance/monitoring/world.st R Tool-Explorer.package/ObjectExplorer.class/instance/updating/noteNewSelection_.st R Tool-Explorer.package/ObjectExplorer.class/instance/updating/update_.st R Tool-Explorer.package/ObjectExplorer.class/instance/user interface/expandTreeInMorph_.st R Tool-Explorer.package/ObjectExplorer.class/instance/user interface/explorerFor_withLabel_.st R Tool-Explorer.package/ObjectExplorer.class/instance/user interface/initialExtent.st R Tool-Explorer.package/ObjectExplorer.class/instance/user interface/openExplorerFor_.st R Tool-Explorer.package/ObjectExplorer.class/instance/user interface/openExplorerFor_withLabel_.st R Tool-Explorer.package/ObjectExplorer.class/instance/user interface/trash.st R Tool-Explorer.package/ObjectExplorer.class/instance/user interface/trash_.st R Tool-Explorer.package/ObjectExplorerWrapper.class/README.md R Tool-Explorer.package/ObjectExplorerWrapper.class/class/as yet unclassified/with_name_model_.st R Tool-Explorer.package/ObjectExplorerWrapper.class/class/as yet unclassified/with_name_model_parent_.st R Tool-Explorer.package/ObjectExplorerWrapper.class/definition.st R Tool-Explorer.package/ObjectExplorerWrapper.class/instance/accessing/contents.st R Tool-Explorer.package/ObjectExplorerWrapper.class/instance/accessing/hasContents.st R Tool-Explorer.package/ObjectExplorerWrapper.class/instance/accessing/icon.st R Tool-Explorer.package/ObjectExplorerWrapper.class/instance/accessing/parent.st R Tool-Explorer.package/ObjectExplorerWrapper.class/instance/accessing/parent_.st R Tool-Explorer.package/ObjectExplorerWrapper.class/instance/accessing/selector.st R Tool-Explorer.package/ObjectExplorerWrapper.class/instance/accessing/setItem_name_model_.st R Tool-Explorer.package/ObjectExplorerWrapper.class/instance/accessing/setItem_name_model_parent_.st R Tool-Explorer.package/ObjectExplorerWrapper.class/instance/converting/asString.st R Tool-Explorer.package/ObjectExplorerWrapper.class/instance/monitoring/refresh.st R Tool-Explorer.package/PointerExplorer.class/README.md R Tool-Explorer.package/PointerExplorer.class/definition.st R Tool-Explorer.package/PointerExplorer.class/instance/accessing/getList.st R Tool-Explorer.package/PointerExplorerWrapper.class/README.md R Tool-Explorer.package/PointerExplorerWrapper.class/definition.st R Tool-Explorer.package/PointerExplorerWrapper.class/instance/accessing/contents.st R Tool-Explorer.package/PointerExplorerWrapper.class/instance/testing/hasContents.st R Tool-Explorer.package/StrongPointerExplorer.class/README.md R Tool-Explorer.package/StrongPointerExplorer.class/definition.st R Tool-Explorer.package/StrongPointerExplorer.class/instance/as yet unclassified/getList.st R Tool-Explorer.package/StrongPointerExplorerWrapper.class/README.md R Tool-Explorer.package/StrongPointerExplorerWrapper.class/definition.st R Tool-Explorer.package/StrongPointerExplorerWrapper.class/instance/accessing/contents.st R Tool-Explorer.package/extension/Collection/instance/explorerContents.st R Tool-Explorer.package/extension/Collection/instance/explorerContentsWithIndexCollect_.st R Tool-Explorer.package/extension/CompiledMethod/instance/explorerContents.st R Tool-Explorer.package/extension/Dictionary/instance/customizeExplorerContents.st R Tool-Explorer.package/extension/Dictionary/instance/explorerContentsWithIndexCollect_.st R Tool-Explorer.package/extension/Integer/instance/explorerContents.st R Tool-Explorer.package/extension/Integer/instance/hasContentsInExplorer.st R Tool-Explorer.package/extension/Object/instance/asExplorerString.st R Tool-Explorer.package/extension/Object/instance/customizeExplorerContents.st R Tool-Explorer.package/extension/Object/instance/explore.st R Tool-Explorer.package/extension/Object/instance/hasContentsInExplorer.st R Tool-Explorer.package/extension/SequenceableCollection/instance/customizeExplorerContents.st R Tool-Explorer.package/extension/SmallDictionary/instance/customizeExplorerContents.st R Tool-Explorer.package/extension/SmallDictionary/instance/explorerContentsWithIndexCollect_.st Log Message: ----------- 40158 11709 remove old ObjectExplorer https://pharo.fogbugz.com/f/cases/11709 http://files.pharo.org/image/40/40158.zip

Aug. 7, 2014

Re: [Pharo-dev] Athens WorldMorph

by Alexandre Bergel

Yes, nice to hear from you Alexandre > On 7 Aug 2014, at 07:37, Tudor Girba <tudor(a)tudorgirba.com> wrote: > > Hi Igor! Nice to hear from you again :) > > Doru > > >> On Thu, Aug 7, 2014 at 1:31 PM, Igor Stasenko <siguctua(a)gmail.com> wrote: >> Very nice! Please commit this code to Athens repository. >> We will integrate it >> >> http://smalltalkhub.com/mc/Pharo/Athens/main >> >> This is a good way to debug stuff without killing own world :) >> >> Just in case, i added you as Athens contributor, so you can commit. >> >> >> >>> On 7 August 2014 12:14, Nicolai Hess <nicolaihess(a)web.de> wrote: >>> I created some fogbugz entries for morphs drawing with athens api. >>> >>> And a parent case 13790 "Port what is needed for Athens (drawing morphs)" >>> >>> We can test the Athens based drawing by putting the morphs into an >>> AthensWrapMorph. >>> But this is difficult for Morph like Dialog, Menus and SystemWindows. >>> >>> So for testing purpose I attached changeset to the >>> issue 13790 : >>> a small hack for making a second WorldMorph working in a Morph. >>> I omit all the small little details that are needed to make a >>> second WorldMorph fully working. I just wanted to make >>> sure the second WorldMorph doesn't constantly try to occupy >>> the whole display. >>> The real fun is to put this WorldMorph inside an AthensWrapMorph. >>> That way we can test Athens based drawing even for Morphs >>> like the WorldMenu or SystemWindows. >>> Just drag and drop a Morph or Window between >>> the Athens WorldMorph and the real WorldMorph. >>> >>> Open the AthensWrapWorldMorph with: >>> AthensWrapWorldMorph new openInWorld >>> >>> >>> nicolai >> >> >> >> -- >> Best regards, >> Igor Stasenko. > > > > -- > www.tudorgirba.com > > "Every thing has its own flow"

Aug. 7, 2014

Re: [Pharo-dev] Browsing Object is slow

by Esteban Lorenzano

On 07 Aug 2014, at 13:49, Benjamin <Benjamin.VanRyseghem.Pharo(a)gmail.com> wrote: > Without testing it more, I canât tell you, > but your code seems to make sense :) +1 > > > Ben > > On 07 Aug 2014, at 13:47, Camille Teruel <camille.teruel(a)gmail.com> wrote: > >> Hi everyone, >> >> I noticed that browsing Object take several seconds (5s on my machine). Evaluate Nautilus openOnClass: Object. >> After profiling, I found it's because of ClassWidget>>setCachedHierarchyClass: that calls SortHierarchically class>>buildHierarchyForClasses: with a big collection of classes. >> But the browser opens on the package view by default, not the hierarchy view. >> So if I replace: >> >> ClassWidget>>showHierarchy: anObject >> showHierarchy := anObject. >> self selectedClass ifNotNil:[: class | >> self setCachedHierarchyClass: class] >> by: >> >> ClassWidget>>showHierarchy: aBoolean >> (showHierarchy := aBoolean) >> ifTrue: [ self selectedClass ifNotNil: [ :class | self setCachedHierarchyClass: class] ] >> >> it solves the problem. >> But I don't know that part of the system well and I don't know if it's the correct thing to do or if we should try to improve performances of SortHierarchically instead. >> So tell me what you think about it. >> Here is the bug entry: https://pharo.fogbugz.com/f/cases/13795/Browsing-certain-classes-takes-seve… >> >> Thanks, >> Camille >

Aug. 7, 2014

Re: [Pharo-dev] Browsing Object is slow

by Benjamin

Without testing it more, I canât tell you, but your code seems to make sense :) Ben On 07 Aug 2014, at 13:47, Camille Teruel <camille.teruel(a)gmail.com> wrote: > Hi everyone, > > I noticed that browsing Object take several seconds (5s on my machine). Evaluate Nautilus openOnClass: Object. > After profiling, I found it's because of ClassWidget>>setCachedHierarchyClass: that calls SortHierarchically class>>buildHierarchyForClasses: with a big collection of classes. > But the browser opens on the package view by default, not the hierarchy view. > So if I replace: > > ClassWidget>>showHierarchy: anObject > showHierarchy := anObject. > self selectedClass ifNotNil:[: class | > self setCachedHierarchyClass: class] > by: > > ClassWidget>>showHierarchy: aBoolean > (showHierarchy := aBoolean) > ifTrue: [ self selectedClass ifNotNil: [ :class | self setCachedHierarchyClass: class] ] > > it solves the problem. > But I don't know that part of the system well and I don't know if it's the correct thing to do or if we should try to improve performances of SortHierarchically instead. > So tell me what you think about it. > Here is the bug entry: https://pharo.fogbugz.com/f/cases/13795/Browsing-certain-classes-takes-seve… > > Thanks, > Camille

Aug. 7, 2014

Browsing Object is slow

by Camille Teruel

Hi everyone, I noticed that browsing Object take several seconds (5s on my machine). Evaluate Nautilus openOnClass: Object. After profiling, I found it's because of ClassWidget>>setCachedHierarchyClass: that calls SortHierarchically class>>buildHierarchyForClasses: with a big collection of classes. But the browser opens on the package view by default, not the hierarchy view. So if I replace: ClassWidget>>showHierarchy: anObject showHierarchy := anObject. self selectedClass ifNotNil:[: class | self setCachedHierarchyClass: class] by: ClassWidget>>showHierarchy: aBoolean (showHierarchy := aBoolean) ifTrue: [ self selectedClass ifNotNil: [ :class | self setCachedHierarchyClass: class] ] it solves the problem. But I don't know that part of the system well and I don't know if it's the correct thing to do or if we should try to improve performances of SortHierarchically instead. So tell me what you think about it. Here is the bug entry: https://pharo.fogbugz.com/f/cases/13795/Browsing-certain-classes-takes-seve… Thanks, Camille

Aug. 7, 2014

Re: [Pharo-dev] could we get double click => open an inspector

by Esteban Lorenzano

heâ¦ mail bad sent :P it was: AFAIK, double click now dives in (it navigates the inspection, without spawning a new window). If you want a new window, you have cmd+i (and the menu). cheers, Esteban On 07 Aug 2014, at 12:43, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: > afaik, > > > On Thu, Aug 7, 2014 at 12:37 PM, stepharo <stepharo(a)free.fr> wrote: > Hi > > in the debugger I think that we could double-click on a inspected items and get a new inspector. > So could the eyeinspector open a new on doubleclick? > > Stef > >

Aug. 7, 2014

Re: [Pharo-dev] Athens WorldMorph

by Tudor Girba

Hi Igor! Nice to hear from you again :) Doru On Thu, Aug 7, 2014 at 1:31 PM, Igor Stasenko <siguctua(a)gmail.com> wrote: > Very nice! Please commit this code to Athens repository. > We will integrate it > > http://smalltalkhub.com/mc/Pharo/Athens/main > > This is a good way to debug stuff without killing own world :) > > Just in case, i added you as Athens contributor, so you can commit. > > > > On 7 August 2014 12:14, Nicolai Hess <nicolaihess(a)web.de> wrote: > >> I created some fogbugz entries for morphs drawing with athens api. >> >> And a parent case 13790 "Port what is needed for Athens (drawing morphs)" >> >> We can test the Athens based drawing by putting the morphs into an >> AthensWrapMorph. >> But this is difficult for Morph like Dialog, Menus and SystemWindows. >> >> So for testing purpose I attached changeset to the >> issue 13790 : >> a small hack for making a second WorldMorph working in a Morph. >> I omit all the small little details that are needed to make a >> second WorldMorph fully working. I just wanted to make >> sure the second WorldMorph doesn't constantly try to occupy >> the whole display. >> The real fun is to put this WorldMorph inside an AthensWrapMorph. >> That way we can test Athens based drawing even for Morphs >> like the WorldMenu or SystemWindows. >> Just drag and drop a Morph or Window between >> the Athens WorldMorph and the real WorldMorph. >> >> Open the AthensWrapWorldMorph with: >> AthensWrapWorldMorph new openInWorld >> >> >> nicolai >> > > > > -- > Best regards, > Igor Stasenko. > -- www.tudorgirba.com "Every thing has its own flow"

Aug. 7, 2014