- Pharo-dev - lists.pharo.org

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/40212 Home: https://github.com/pharo-project/pharo-core

Sept. 9, 2014

[pharo-project/pharo-core] ad77d8: 40212

by GitHub

Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: ad77d8ed262bf1e2bb0e75291fce7ee4ef70fc7c https://github.com/pharo-project/pharo-core/commit/ad77d8ed262bf1e2bb0e7529… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2014-09-09 (Tue, 09 Sep 2014) Changed paths: M Announcements-View.package/AnnouncementSpy.class/instance/building/build.st A KernelTests.package/BehaviorTest.class/instance/tests/testCanPerform.st M KernelTests.package/BehaviorTest.class/instance/tests/testCanUnderstand.st M Nautilus.package/AbstractNautilusUI.class/class/shortcuts/buildButtonsShortcutsOn_.st M Nautilus.package/AbstractNautilusUI.class/instance/accessing/selectedPackageWithoutChangingSelectionInternally_.st M Nautilus.package/AbstractNautilusUI.class/instance/accessing/selectedPackageWithoutChangingSelection_.st M Nautilus.package/AbstractNautilusUI.class/instance/accessing/showGroups_.st M Nautilus.package/AbstractNautilusUI.class/instance/accessing/showHierarchy.st A Nautilus.package/AbstractNautilusUI.class/instance/accessing/showHierarchy_.st R Nautilus.package/AbstractNautilusUI.class/instance/accessing/showPackages.st M Nautilus.package/AbstractNautilusUI.class/instance/accessing/showPackagesSilently_.st M Nautilus.package/AbstractNautilusUI.class/instance/accessing/showPackages_.st A Nautilus.package/AbstractNautilusUI.class/instance/accessing/sortHierarchically.st M Nautilus.package/AbstractNautilusUI.class/instance/buttons behavior/hierarchyButtonEnabled.st M Nautilus.package/AbstractNautilusUI.class/instance/buttons behavior/hierarchyButtonLabel.st M Nautilus.package/AbstractNautilusUI.class/instance/buttons behavior/hierarchyButtonState.st M Nautilus.package/AbstractNautilusUI.class/instance/buttons behavior/toggleShowPackages.st M Nautilus.package/AbstractNautilusUI.class/instance/events handling/listMouseDown_.st A Nautilus.package/ClassWidget.class/instance/accessing/sortHierarchically.st M Nautilus.package/ClassWidget.class/instance/private list model/classWrapper_.st A Nautilus.package/ClassWidget.class/instance/private/createClassListFor_.st A Nautilus.package/ClassWidget.class/instance/private/loadClassHierarchyListElements.st M Nautilus.package/ClassWidget.class/instance/private/loadClassesListElements.st A Nautilus.package/ClassWidget.class/instance/private/loadPackageClassListElements.st A Nautilus.package/ClassWidget.class/instance/private/wrapFlat_.st M Nautilus.package/Nautilus.class/class/opening/openInEnvironment_.st M Nautilus.package/Nautilus.class/class/opening/openOnClass_inEnvironment_.st M Nautilus.package/Nautilus.class/class/opening/openOnClass_onProtocol_inEnvironment_.st M Nautilus.package/Nautilus.class/class/opening/openOnMethod_inEnvironment_.st R Nautilus.package/Nautilus.class/class/opening/openOnPackage_class_category_method_group_showGroups_showHierarchy_showPackages_showComment_showInstance_showCategories_.st R Nautilus.package/Nautilus.class/class/opening/openOnPackage_class_category_method_group_showGroups_showHierarchy_showPackages_showComment_showInstance_showCategories_inEnvironment_.st A Nautilus.package/Nautilus.class/class/opening/openOnPackage_class_category_method_group_showGroups_sortHierarchically_showHierarchy_showComment_showInstance_showCategories_.st A Nautilus.package/Nautilus.class/class/opening/openOnPackage_class_category_method_group_showGroups_sortHierarchically_showHierarchy_showComment_showInstance_showCategories_inEnvironment_.st M Nautilus.package/Nautilus.class/class/opening/openOnPackage_inEnvironment_.st M Nautilus.package/Nautilus.class/instance/accessing/showHierarchy.st M Nautilus.package/Nautilus.class/instance/accessing/showHierarchy_.st A Nautilus.package/Nautilus.class/instance/accessing/sortHierarchically.st A Nautilus.package/Nautilus.class/instance/accessing/sortHierarchically_.st M Nautilus.package/Nautilus.class/instance/browser compatibility/spawnHierarchy.st M Nautilus.package/NautilusUI.class/instance/accessing/selectedClassWithoutChangingSelectionInternally_.st M Nautilus.package/NautilusUI.class/instance/accessing/selectedClassWithoutChangingSelection_.st M Nautilus.package/NautilusUI.class/instance/menus behavior/fullBrowse.st M Nautilus.package/PackageTreeNautilusUI.class/instance/accessing/showPackages_.st M Nautilus.package/PackageTreeNautilusUI.class/instance/private dispatch/fullBrowseFromPackage_.st M Nautilus.package/PackageTreeNautilusUI.class/instance/private dispatch/fullBrowseFromTag_.st A Nautilus.package/SortAlphabeticallyClassList.class/README.md A Nautilus.package/SortAlphabeticallyClassList.class/class/instance creation/buildHierarchyForClasses_.st A Nautilus.package/SortAlphabeticallyClassList.class/class/instance creation/buildListFor_in_.st A Nautilus.package/SortAlphabeticallyClassList.class/definition.st A Nautilus.package/SortAlphabeticallyClassList.class/instance/accessing/list.st A Nautilus.package/SortAlphabeticallyClassList.class/instance/accessing/list_.st A Nautilus.package/SortAlphabeticallyClassList.class/instance/accessing/sortedElements.st A Nautilus.package/SortAlphabeticallyClassList.class/instance/combining/%2C.st A Nautilus.package/SortAlphabeticallyClassList.class/instance/initialization/initialize.st M NautilusCommon.package/NautilusHistoryEntry.class/instance/accessing/showHierarchy.st M NautilusCommon.package/NautilusHistoryEntry.class/instance/accessing/showHierarchy_.st A NautilusCommon.package/NautilusHistoryEntry.class/instance/accessing/sortHierarchically.st A NautilusCommon.package/NautilusHistoryEntry.class/instance/accessing/sortHierarchically_.st M NautilusCommon.package/NautilusHistoryEntry.class/instance/private/with_.st M NautilusCommon.package/NautilusHistoryEntry.class/instance/protocol/=.st M NautilusCommon.package/NautilusHistoryEntry.class/instance/protocol/applyTo_.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script212.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40212.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Spec-Inspector.package/EyeSyntaxTreeInspector.class/instance/api/childrenForObject_.st M Traits.package/TBehavior.class/instance/testing method dictionary/canUnderstand_.st Log Message: ----------- 40212 13977 Temporary variable list is not read nor write in AnnouncementSpy>>#build https://pharo.fogbugz.com/f/cases/13977 13976 MNU formattedCode on EyeSyntaxTreeInspector showing a RBLiteralNode https://pharo.fogbugz.com/f/cases/13976 13962 canPerform: same as canUnderstand: https://pharo.fogbugz.com/f/cases/13962 13943 Nautilus Refactoring 8: rename "showHierarchy" https://pharo.fogbugz.com/f/cases/13943 http://files.pharo.org/image/40/40212.zip

Sept. 9, 2014

Re: [Pharo-dev] TxText-Athens can not load into pharo4

by Marcus Denker

On 09 Sep 2014, at 09:53, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > On 08 Sep 2014, at 20:19, Nicolai Hess <nicolaihess(a)web.de> wrote: > >> TxHorizontalSlider>>#extent: >> writes to method argument >> >> extent: newExtent >> >> newExtent := newExtent x @ self defaultWidth. >> >> super extent: newExtent >> >> This can not be loaded in Pharo4.0 anymore. >> >> We should have made a compiler setting for this too :) >> > > I think we should make it fail in such a way that when you load code non-interactively it just > prints an error on the transcript, while is raises a real error when in interactive mode. > (like what happens with non-exisitng variables) > We could solve the âassignment to block argâ transition the same way: allow it for non-iteractive code loading, but when editing, raise an error. This way we do not even need a preference for that. Marcus

Sept. 9, 2014

Re: [Pharo-dev] TxText-Athens can not load into pharo4

by Marcus Denker

On 08 Sep 2014, at 20:19, Nicolai Hess <nicolaihess(a)web.de> wrote: > TxHorizontalSlider>>#extent: > writes to method argument > > extent: newExtent > > newExtent := newExtent x @ self defaultWidth. > > super extent: newExtent > > This can not be loaded in Pharo4.0 anymore. > > We should have made a compiler setting for this too :) > I think we should make it fail in such a way that when you load code non-interactively it just prints an error on the transcript, while is raises a real error when in interactive mode. (like what happens with non-exisitng variables) Marcus

Sept. 9, 2014

Re: [Pharo-dev] XMLPullParser hex bug

by stepharo

Super! On 9/9/14 01:34, HernÃ¡n Morales Durand wrote: > I reviewed your changes and they are ok, so I have uploaded a new > ConfigurationOfXMLPullParser with your changes as stable with version > 1.4 and development as 1.5. All test pass in 3.0 loading from > ConfigurationBrowser. > Thanks for the fix Tommaso, > > HernÃ¡n

Sept. 9, 2014

New Cog VMs available

by Eliot Miranda

...at http://www.mirandabanda.org/files/Cog/VM/VM.r3072. CogVM binaries as per VMMaker.oscog-eem.876/r3072 Fix bad regression in FilePlugin>>primitiveFileSetPosition introduces around r2797 that breaks > 1Gb file access. Change manifest files on Windows to make app HIGHDPIAWARE. Create a manifest for the consolevm and include it in the archive. Fix bug with become where duplicate entries in the input array would crash the system (thanks Igor). Make nameOfClass: more robust, in both the real and simulated VMs. Regenerate sources after refactoring Slang code to ask classes what methods they want to include based on their initializationOptions inst var instead of the centralized VMMaker. Generate Spur Newspeak VMs with the new CompiledMethod header format. This will break the Newspeak Spur bootstrap until NOF generation and/or loading is fixed. -- best, Eliot

Sept. 9, 2014

[Smalltalks 2014] --- Invitation

by Andres Valloud

Sept. 9, 2014

Re: [Pharo-dev] XMLPullParser hex bug

by HernÃ¡n Morales Durand

I reviewed your changes and they are ok, so I have uploaded a new ConfigurationOfXMLPullParser with your changes as stable with version 1.4 and development as 1.5. All test pass in 3.0 loading from ConfigurationBrowser. Thanks for the fix Tommaso, HernÃ¡n 2014-09-08 19:46 GMT-03:00 Tommaso Dal Sasso <tommaso.dalsasso(a)gmail.com>: > I uploaded the changes. > > I did not notice the development package, so i uploaded the changes again > to integrate your last changes (sorry for the garbage in the commit > history). > Since there was a package that was not in stable, I did not change the > ConfigurationOf, is it safe to push it to stable? > > Thanks, > Tommaso > > P.s.: of course I also added the test cases ;-) > > > > On 08/09/14 16:51, HernÃ¡n Morales Durand wrote: > >> Done. >> >> Cheers, >> >> HernÃ¡n >> >> 2014-09-08 10:18 GMT-03:00 Tommaso Dal Sasso <tommaso.dalsasso(a)gmail.com >> <mailto:tommaso.dalsasso@gmail.com>>: >> >> >> On 08/09/14 15:16, HernÃ¡n Morales Durand wrote: >> >> Tommaso I can give you access to the repository if you send me >> your SmalltalkHub user name. >> Cheers, >> >> HernÃ¡n >> >> Sure, it is dalsat >> Thanks, >> >> Tommaso >> >> 2014-09-08 6:28 GMT-03:00 Tommaso Dal Sasso >> <tommaso.dalsasso(a)gmail.com >> <mailto:tommaso.dalsasso@gmail.com> >> <mailto:tommaso.dalsasso@gmail.com >> >> <mailto:tommaso.dalsasso@gmail.com>>>: >> >> >> Hello everybody, >> >> I found a bug while playing with the XMLPullParser: >> >> When using XML entities encoded in hexadecimal the parser >> throws >> an exception. >> For example: 
 is the hexadecimal encoding of 
 >> which is >> the line feed. >> If you try to parse: '<tag contents="one&#xAtwo" />' you get a >> "Expected Number" error. >> >> >> I investigated the problem, and found that it is caused by the >> method XMLPullParser>>readNumberBase: >> >> If the base of the parsed number is not 10, it executes the >> following lines: >> numberString := self nextUpTo: $;. >> self stream skip: -1. >> [...] >> >> However, the method nextUpTo: does not exist. A MNU is >> then raised >> and handled in nextCharReference: by a greedy >> "on: Error do: [:ex | self errorExpected: 'Number.']." >> thus causing the exception. >> >> The solution is either to implement nextUpTo: or to change >> it in >> one of the two existing methods: nextUpToAll: or >> nextTrimmedBlanksUpTo: >> Example: numberString := self nextUpToAll: ';'. >> >> Also, in the following line, it calls the accessor >> "stream", which >> does not exist and causes the same problem. >> The solution here is to change >> self stream skip: -1. >> into >> stream skip: -1. >> >> The following two test cases show the problem. The first >> one shows >> the correct behavior: >> >> XMLPullParserTest>>testASCIIEntity >> | parser | >> >> parser := XMLPullParser parse: ' >> <tag contents="one
two" />'. >> >> self assert: (parser next at: #contents) equals: >> (Character lf >> join: #(one two)) >> >> >> The second one shows the error: >> >> XMLPullParserTest>>testUnicodeEntity >> | parser | >> >> parser := XMLPullParser parse: ' >> <tag contents="one
two" />'. >> >> self assert: (parser next at: #contents) equals: >> (Character lf >> join: #(one two)) >> >> >> I hope it is clear enough. I can also commit the fix >> myself, if >> you give me write access. >> >> Thanks, >> Tommaso >> >> >> >> >> >> > >

Sept. 8, 2014

Re: [Pharo-dev] XMLPullParser hex bug

by Tommaso Dal Sasso

I uploaded the changes. I did not notice the development package, so i uploaded the changes again to integrate your last changes (sorry for the garbage in the commit history). Since there was a package that was not in stable, I did not change the ConfigurationOf, is it safe to push it to stable? Thanks, Tommaso P.s.: of course I also added the test cases ;-) On 08/09/14 16:51, HernÃ¡n Morales Durand wrote: > Done. > > Cheers, > > HernÃ¡n > > 2014-09-08 10:18 GMT-03:00 Tommaso Dal Sasso > <tommaso.dalsasso(a)gmail.com <mailto:tommaso.dalsasso@gmail.com>>: > > > On 08/09/14 15:16, HernÃ¡n Morales Durand wrote: > > Tommaso I can give you access to the repository if you send me > your SmalltalkHub user name. > Cheers, > > HernÃ¡n > > Sure, it is dalsat > Thanks, > > Tommaso > > 2014-09-08 6:28 GMT-03:00 Tommaso Dal Sasso > <tommaso.dalsasso(a)gmail.com > <mailto:tommaso.dalsasso@gmail.com> > <mailto:tommaso.dalsasso@gmail.com > <mailto:tommaso.dalsasso@gmail.com>>>: > > > Hello everybody, > > I found a bug while playing with the XMLPullParser: > > When using XML entities encoded in hexadecimal the parser > throws > an exception. > For example: 
 is the hexadecimal encoding of 
 > which is > the line feed. > If you try to parse: '<tag contents="one&#xAtwo" />' you get a > "Expected Number" error. > > > I investigated the problem, and found that it is caused by the > method XMLPullParser>>readNumberBase: > > If the base of the parsed number is not 10, it executes the > following lines: > numberString := self nextUpTo: $;. > self stream skip: -1. > [...] > > However, the method nextUpTo: does not exist. A MNU is > then raised > and handled in nextCharReference: by a greedy > "on: Error do: [:ex | self errorExpected: 'Number.']." > thus causing the exception. > > The solution is either to implement nextUpTo: or to change > it in > one of the two existing methods: nextUpToAll: or > nextTrimmedBlanksUpTo: > Example: numberString := self nextUpToAll: ';'. > > Also, in the following line, it calls the accessor > "stream", which > does not exist and causes the same problem. > The solution here is to change > self stream skip: -1. > into > stream skip: -1. > > The following two test cases show the problem. The first > one shows > the correct behavior: > > XMLPullParserTest>>testASCIIEntity > | parser | > > parser := XMLPullParser parse: ' > <tag contents="one
two" />'. > > self assert: (parser next at: #contents) equals: > (Character lf > join: #(one two)) > > > The second one shows the error: > > XMLPullParserTest>>testUnicodeEntity > | parser | > > parser := XMLPullParser parse: ' > <tag contents="one
two" />'. > > self assert: (parser next at: #contents) equals: > (Character lf > join: #(one two)) > > > I hope it is clear enough. I can also commit the fix > myself, if > you give me write access. > > Thanks, > Tommaso > > > > >

Sept. 8, 2014

TxText-Athens can not load into pharo4

by Nicolai Hess

TxHorizontalSlider>>#extent: writes to method argument extent: newExtent newExtent := newExtent x @ self defaultWidth. super extent: newExtent This can not be loaded in Pharo4.0 anymore. We should have made a compiler setting for this too :) nicolai

Sept. 8, 2014