- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Failing #obsoleteClasses test

by Max Leske

> On 02.11.2014, at 18:28, Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > > Hi Max, > > could the cache be reimplemented using WeakArray? Stuff like this is a drag. eg in Squeak the Windows menu holds onto all the windows that were open when last the menu was opened. So to get a window reclaimed after being closed if you opened the Windows menu you have to open it again. I must fix that. No idea. I really didnât look at what it does, I just tracked pointers ;) But yes, maybe that would be a good idea. Adding âASTCache reset.â all over the place is not really a good strategy. Iâll send a copy of this message to Marcus and ClÃ©ment; I suspect they might know more about the AST stuff. Cheers, Max > > Eliot (phone) > > On Nov 2, 2014, at 8:43 AM, Max Leske <maxleske(a)gmail.com <mailto:maxleske@gmail.com>> wrote: > >> I spent a couple of hours trying to find out why the #obsoleteClasses test sporadically fails. Iâve found one candidate that fixes all the failures that I could produces. Simply put, any test that does something AST related (e.g. runs critics) *has to* reset the ASTCache during #tearDown: >> >> ASTCache reset. >> >> Iâve found two test classes that needed to be adapted: SmalllintManifestCheckerTest and VSReleaseDevelopmentVersionCommandTest. >> >> Issue with slice: https://pharo.fogbugz.com/f/cases/14375/Random-obsoleteClasses-test-failures <https://pharo.fogbugz.com/f/cases/14375/Random-obsoleteClasses-test-failures> >> >> Cheers, >> Max

Nov. 2, 2014

ImageCleaner interaction with Delay

by Ben Coman

ImageCleaner>>cleanUpForRelease calls >>cleanUpMethods which calls Delay class>>startTimerEventLoop. I thought this would have started with a clean/empty suspended delays heap, but it carries forward the old SuspendedDelays. So if there happened to be a suspended delay expiring in a month's time, that would not be affected by ImageCleaner and would end up in the release. I believe the correct behaviour would be for ImageCleaner to produce a clean/empty suspended delays, and so that no waiting processing get stuck, signal any remaining suspended delays when the timer event loop is stopped by Delay class>>stopTimerEventLoop. Any objections? cheers -ben

Nov. 2, 2014

Re: [Pharo-dev] Failing #obsoleteClasses test

by Ben Coman

Max Leske wrote: > I spent a couple of hours trying to find out why the #obsoleteClasses > test sporadically fails. Iâve found one candidate that fixes all the > failures that I could produces. Simply put, any test that does something > AST related (e.g. runs critics) *has to* reset the ASTCache during > #tearDown: > > ASTCache reset. > > Iâve found two test classes that needed to be > adapted: SmalllintManifestCheckerTest > and VSReleaseDevelopmentVersionCommandTest. > > Issue with > slice: https://pharo.fogbugz.com/f/cases/14375/Random-obsoleteClasses-test-failures > > Cheers, > Max nice find.

Nov. 2, 2014

Make Nautilus to automatically categorize new methods (if needed) and remove empty protocols

by Luc Fabresse

Hi, cf. https://pharo.fogbugz.com/default.asp?14376 to eventually integrate. Cheers, #Luc

Nov. 2, 2014

Re: [Pharo-dev] Failing #obsoleteClasses test

by Eliot Miranda

Hi Max, could the cache be reimplemented using WeakArray? Stuff like this is a drag. eg in Squeak the Windows menu holds onto all the windows that were open when last the menu was opened. So to get a window reclaimed after being closed if you opened the Windows menu you have to open it again. I must fix that. Eliot (phone) On Nov 2, 2014, at 8:43 AM, Max Leske <maxleske(a)gmail.com> wrote: > I spent a couple of hours trying to find out why the #obsoleteClasses test sporadically fails. Iâve found one candidate that fixes all the failures that I could produces. Simply put, any test that does something AST related (e.g. runs critics) *has to* reset the ASTCache during #tearDown: > > ASTCache reset. > > Iâve found two test classes that needed to be adapted: SmalllintManifestCheckerTest and VSReleaseDevelopmentVersionCommandTest. > > Issue with slice: https://pharo.fogbugz.com/f/cases/14375/Random-obsoleteClasses-test-failures > > Cheers, > Max

Nov. 2, 2014

Re: [Pharo-dev] Unpackaged code

by Max Leske

> On 29.10.2014, at 10:00, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > >> On 29 Oct 2014, at 09:54, Max Leske <maxleske(a)gmail.com <mailto:maxleske@gmail.com>> wrote: >> >> >>> On 29.10.2014, at 09:45, Marcus Denker <marcus.denker(a)inria.fr <mailto:marcus.denker@inria.fr>> wrote: >>> >>>>> >>>>> @free.fr <http://free.fr/>> >>>>> We need the concept of âthis is code that is automatically generated, it is not part of any package and this is meant to be like thatâ. >>>> >>>> Nautilus (or RPackage?) does provide the âUnpackagedâ category. Wouldnât that be âgood enoughâ for now? >>>> >>> People would emmediatly report bugs that there is unpackaged code. >> >> True. >> >>> We need to concept of âthis is ok that there is no packageâ. >> >> But we donât have that right now. And the problem with nil as category remains. How about replacing a nil category with âUnpackagedâ implicitly for the time being? It would at least âfixâ one problem. >> > > Ok. > > Marcus > Issue with slice: https://pharo.fogbugz.com/f/cases/14371/Traits-should-not-be-allowed-to-hav… <https://pharo.fogbugz.com/f/cases/14371/Traits-should-not-be-allowed-to-hav…> Cheers, Max

Nov. 2, 2014

Failing #obsoleteClasses test

by Max Leske

I spent a couple of hours trying to find out why the #obsoleteClasses test sporadically fails. Iâve found one candidate that fixes all the failures that I could produces. Simply put, any test that does something AST related (e.g. runs critics) *has to* reset the ASTCache during #tearDown: ASTCache reset. Iâve found two test classes that needed to be adapted: SmalllintManifestCheckerTest and VSReleaseDevelopmentVersionCommandTest. Issue with slice: https://pharo.fogbugz.com/f/cases/14375/Random-obsoleteClasses-test-failures <https://pharo.fogbugz.com/f/cases/14375/Random-obsoleteClasses-test-failures> Cheers, Max

Nov. 2, 2014

Re: [Pharo-dev] encodings and regex clash?

by Max Leske

> On 02.11.2014, at 14:59, stepharo <stepharo(a)free.fr> wrote: > > > On 2/11/14 12:37, Max Leske wrote: >>> On 01.11.2014, at 22:07, stepharo <stepharo(a)free.fr> wrote: >>> >>> Hi guys >>> >>> I'm doing a small variable expansion to relocate my webpage. I want to expand -base- into <base>http://sdmeta.gforge.inria.fr</base> >>> Now it works when I test with some strings inside the image >>> >>> >>> trying >>> "self new trying" >>> >>> ^ self sample >>> copyWithRegex: '-BASE-' >>> matchesReplacedWith: self baseString. >>> >>> sample >>> >>> >>> ^ '<?xml version="1.0" encoding="ISO-8859-1"?> >>> <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en"> >>> <link rel="stylesheet" href="stef.css"/> >>> <head> >>> -BASE- >>> <title>Dr. Stéphane Ducasse</title> >>> </head>' >>> >>> baseString >>> ^ '<base>http://sdmeta.gforge.inria.fr </base>' >>> >>> self new trying results >>> >>> '<?xml version="1.0" encoding="ISO-8859-1"?> >>> <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en"> >>> <link rel="stylesheet" href="stef.css"/> >>> <head> >>> <base>http://sdmeta.gforge.inria.fr </base> >>> <title>Dr. Stéphane Ducasse</title> >>> </head>' >>> >>> and this is good. >>> >>> Now when I work with a stream it does. >>> >>> >>> >>> contentsOf: aFileSystemFile >>> "self new contentsOf: (FileSystem workingDirectory / 'Books.html') " >>> contents := aFileSystemFile readStream contents >>> >>> tryingContents >>> "self new tryings" >>> >>> ^ self sample >>> copyWithRegex: '-BASE-' >>> matchesReplacedWith: contents. >> >> Whatâs the âwrongâ output you get here? > > In fact I get the stream contents but the regex does not match. > I suspect a problem with the encodings of the file. Do you have an idea? Stef Noâ¦ I donât see how encoding could be a problem. Can you create a minimal working (failing) test file and post it?

Nov. 2, 2014

Re: [Pharo-dev] Trouble while defining a customized tab in GT inspector

by Luc Fabresse

Hi Doru, Thanks for your answer. It worked as you suggested, but I had to copy three methods of ObjectVariablesBrowser (evaluatorIn:, printStringOf: and stringWithoutInitialCommentFrom:) to reproduce the evaluator part of the tab. I am not really happy with that but perhaps there is no other way. I still think that the startOn: method of ObjectVariablesBrowser should not loose the object passed in. Any explanation why an ObjectVariablesBrowser cannot be "pluggable"? Cheers, Luc 2014-11-01 21:15 GMT+01:00 Tudor Girba <tudor(a)tudorgirba.com>: > Hi, > > Sorry for the late reply. > > Indeed the ObjectVariablesBrowser does not work with another object then > the one of the tab. If you want to define a custom tab, you should simply > create a table with the desired variables. For example, take a look at > Morph>>gtInspectorMorphExtensionIn:. This one exposes the extensions > dictionary as a separate tab. It probably matches what you want. > > Let me know if you still have troubles. > > Cheers, > Doru > > > > On Wed, Oct 29, 2014 at 10:29 PM, Luc Fabresse <luc.fabresse(a)gmail.com> > wrote: > >> Hi all, >> >> I try to play with the GT inspector (thx Andrei and Doru for the great >> hands on session @ ESUG'14!). >> >> In short, I try to add a customized tab for Persons objects using a >> PersonUI facade and a subclass of GTObjectVariablesBrowser (ok I can >> explain why if needed ;-)). Like that: >> >> Person>>gtInspectorCustomUIIn: composite >> <gtInspectorPresentationOrder: 5> >> ^ (composite custom: (MyGTCustomObjectVariablesBrowser new startOn: >> (PersonUI on: self) )) " <----- HERE" >> title: 'Customized view'; >> yourself >> >> But, the #variableValuePairsFor: message is not sent to the PersonUI >> object but to the Person object even if I passed a PersonUI one to the >> #startOn: method (cf. HERE). >> startOn: seems to not store properly the object to use afterwards or I >> missed a something. Did I? >> >> please find a code sample attached if needed. >> Try: >> Person new inspect >> >> Thx for any hint, >> Cheers, >> >> #Luc >> > > > > -- > www.tudorgirba.com > > "Every thing has its own flow" >

Nov. 2, 2014

Re: [Pharo-dev] Super fast delay

by Ben Coman

Eliot Miranda wrote: > > > On Wed, Oct 29, 2014 at 12:14 PM, Ben Coman <btc(a)openinworld.com > <mailto:btc@openinworld.com>> wrote: > > Holger Hans Peter Freyther wrote: > > On Wed, Oct 29, 2014 at 06:54:57PM +0100, Holger Hans Peter > Freyther wrote: > > On Wed, Oct 29, 2014 at 10:03:03AM +0100, Norbert Hartl wrote: > > Good Evening, > > > Hi again, > > I don't know how you debug startUp issues. I just added an > OrderedCollection > into the systemdictionary and use it as a log.. > > time ./bin/pharo --nodisplay ./TimerTest3.image eval "(Delay > forSeconds: 3) wait. (Smalltalk at: #Foo) do: [:each | > FileStream stderr nextPutAll: each printString; cr].1" > ... old events from saving the image... > {#handleTimerEvent->7147} > {#handleTimerEvent->7167} > {#resumptionTime->7187} > {#handleTimerEvent->7167} > {#handleTimerEvent->7187} > {#start->true} > {#start->393102159} > {#start->393102159} > {#resumptionTime->3279} > {#handleTimerEvent->279} > {#adjustResum->-393098880} > {#restoreWithActiveDelay->266} > {#adjustResum->-393098601} > 1 > > real 0m0.294s > user 0m0.244s > sys 0m0.048s > > > So what happens is Delay class>>#startU is called. and > ActiveDelayStartTime is being set to 393102159. Then the > delay is being created and resumptionTime is set to 3279. > At the first time handleTimerEvent runs the milliSecondClock > jumped backwards from 393102159 to 3279 which leads to > an adjustment of the time. > > > a.) Why does the time jump backwards like this during the > resumption of the image? "3279" is not the old time nor > the new starting time. > > b.) So even if that is a "wrap" around. Why does it go > wrong? Are there unit tests for the clock wraps around? > > > There are no unit tests, I guess since its all done using class > variables its too hard test without disturbing the system. > > Now I have spent the last week refactoring this out to the > instance-side of a new class "DelayScheduler" which should help with > getting unit tests. Its ready for review [1], maybe you could take > a look. > > [1] https://pharo.fogbugz.com/__default.asp?14261 > <https://pharo.fogbugz.com/default.asp?14261> > > Maybe it is the same reason delays just don't work after > image resumption? > > The "first" issue appears that when start is being executed > that the clock is still wrong. At the same the clock is > being considered wrapped the resumption time was actually > already "correct' (3279 instead of 393102159+3279). > > Does this ring a bell? > > holger > > > > btw, its too late in the night for me to try something, but I have > been wondering, should the check for clock roll-over occur > immediately after > TimingSemaphore wait > wakes up. That is, before the Schedule and Finish requests are > handled ??? > > > The check for rollover should be thrown away and the system implemented > over the VM's support for 64-bit microseconds since 1901. It's in the > VM, it isn't susceptible to rollover for ~ 50,000 years, and doesn't > require the millisecond clock to be synced to the second clock, because > all times can be derived from the one 64-bit microsecond clock. > > -- > best, > Eliot The performance of the Delay timer event loop is noted in the code to be critical, however... "Time millisecondClockValue" returns a SmallInteger, which is an immediate object while "Time microsecondClockValue" returns a LargePositiveInteger, which is not. So theoretically will calculations and comparisons based on the second be slower ? Actually my performance testing so far hasn't found it to be slower, but I am interested in the general case. cheers -ben

Nov. 2, 2014