- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] [pharo-project/pharo-core] 4834e8: 40521

by Ben Coman

Just a note that build 40521 downloads with a dirty Polymorph-Geometry package. cheers -ben On Sat, Feb 28, 2015 at 7:37 AM, GitHub <noreply(a)github.com> wrote: > Branch: refs/heads/4.0 > Home: https://github.com/pharo-project/pharo-core > Commit: 4834e88ae552b702f80b32799c142bb9101e56a3 > > https://github.com/pharo-project/pharo-core/commit/4834e88ae552b702f80b3279… > Author: Jenkins Build Server <board(a)pharo-project.org> > Date: 2015-02-28 (Sat, 28 Feb 2015) > > Changed paths: > A Graphics-Shapes.package/PathShape.class/README.md > A Graphics-Shapes.package/PathShape.class/class/as yet > unclassified/vertices_.st > A Graphics-Shapes.package/PathShape.class/definition.st > A > Graphics-Shapes.package/PathShape.class/instance/accessing/basicBounds.st > A Graphics-Shapes.package/PathShape.class/instance/accessing/bounds.st > A Graphics-Shapes.package/PathShape.class/instance/accessing/bounds_.st > A Graphics-Shapes.package/PathShape.class/instance/accessing/ > vertices.st > A > Graphics-Shapes.package/PathShape.class/instance/accessing/vertices_.st > A Graphics-Shapes.package/PathShape.class/instance/as yet > unclassified/addVertex_.st > A Graphics-Shapes.package/PathShape.class/instance/as yet > unclassified/calculatedBounds.st > A Graphics-Shapes.package/PathShape.class/instance/as yet > unclassified/containsPoint_.st > A Graphics-Shapes.package/PathShape.class/instance/as yet > unclassified/segmentsDo_.st > A Graphics-Shapes.package/PathShape.class/instance/initialization/ > initialize.st > A Graphics-Shapes.package/Polygon.class/README.md > A Graphics-Shapes.package/Polygon.class/definition.st > A Graphics-Shapes.package/Polygon.class/instance/as yet > unclassified/containsPoint_.st > A Graphics-Shapes.package/Polygon.class/instance/as yet > unclassified/segmentsDo_.st > A Graphics-Shapes.package/Shape.class/README.md > A Graphics-Shapes.package/Shape.class/definition.st > A Graphics-Shapes.package/Shape.class/instance/as yet > unclassified/basicContainsPoint_.st > A Graphics-Shapes.package/Shape.class/instance/as yet unclassified/ > bounds.st > A Graphics-Shapes.package/Shape.class/instance/as yet > unclassified/containsPoint_.st > M > Morphic-Base.package/extension/GradientFillStyle/instance/changeColorOf_rampIndex_.st > R Polymorph-Geometry.package/PathShape.class/README.md > R Polymorph-Geometry.package/PathShape.class/class/as yet > unclassified/vertices_.st > R Polymorph-Geometry.package/PathShape.class/definition.st > R > Polymorph-Geometry.package/PathShape.class/instance/accessing/basicBounds.st > R Polymorph-Geometry.package/PathShape.class/instance/accessing/ > bounds.st > R > Polymorph-Geometry.package/PathShape.class/instance/accessing/bounds_.st > R Polymorph-Geometry.package/PathShape.class/instance/accessing/ > vertices.st > R > Polymorph-Geometry.package/PathShape.class/instance/accessing/vertices_.st > R Polymorph-Geometry.package/PathShape.class/instance/as yet > unclassified/addVertex_.st > R Polymorph-Geometry.package/PathShape.class/instance/as yet > unclassified/calculatedBounds.st > R Polymorph-Geometry.package/PathShape.class/instance/as yet > unclassified/containsPoint_.st > R Polymorph-Geometry.package/PathShape.class/instance/as yet > unclassified/segmentsDo_.st > R Polymorph-Geometry.package/PathShape.class/instance/initialization/ > initialize.st > R Polymorph-Geometry.package/Polygon.class/README.md > R Polymorph-Geometry.package/Polygon.class/definition.st > R Polymorph-Geometry.package/Polygon.class/instance/as yet > unclassified/containsPoint_.st > R Polymorph-Geometry.package/Polygon.class/instance/as yet > unclassified/segmentsDo_.st > R Polymorph-Geometry.package/Shape.class/README.md > R Polymorph-Geometry.package/Shape.class/definition.st > R Polymorph-Geometry.package/Shape.class/instance/as yet > unclassified/basicContainsPoint_.st > R Polymorph-Geometry.package/Shape.class/instance/as yet unclassified/ > bounds.st > R Polymorph-Geometry.package/Shape.class/instance/as yet > unclassified/containsPoint_.st > M Reflectivity-Tests.package/ReflectiveMethodTest.class/instance/tests > - creation/testCreateReflectiveMethodAndInvalidate.st > M Reflectivity-Tests.package/ReflectiveMethodTest.class/instance/tests > - creation/testInvalidate.st > R Reflectivity-Tests.package/ReflectiveMethodTest.class/instance/tests > - creation/testInvalidateWithLinCount.st > A Reflectivity-Tests.package/ReflectiveMethodTest.class/instance/tests > - creation/testInvalidateWithLinkCount.st > R Reflectivity-Tests.package/ReflectivityExamples.class/instance/as > yet unclassified/exampleMethod.st > A > Reflectivity-Tests.package/ReflectivityExamples.class/instance/example - > simple/exampleMethod.st > M > Reflectivity.package/ReflectiveMethod.class/instance/evaluation/recompileAST.st > M > Reflectivity.package/ReflectiveMethod.class/instance/evaluation/run_with_in_.st > M > Reflectivity.package/ReflectiveMethod.class/instance/invalidate/destroyTwin.st > A > Reflectivity.package/ReflectiveMethod.class/instance/invalidate/installCompiledMethod.st > R ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/ > script520.st > A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/ > script521.st > R ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/ > update40520.st > A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/ > update40521.st > M > ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st > A Spec-Help.package/SpecExamples.class/README.md > A Spec-Help.package/SpecExamples.class/class/accessing/bookName.st > A Spec-Help.package/SpecExamples.class/class/accessing/pages.st > A Spec-Help.package/SpecExamples.class/class/pages/firstExample.st > A Spec-Help.package/SpecExamples.class/class/pages/moreExamples.st > A Spec-Help.package/SpecExamples.class/class/pages/secondExample.st > A Spec-Help.package/SpecExamples.class/definition.st > A Spec-Help.package/SpecHelpTopics.class/README.md > A Spec-Help.package/SpecHelpTopics.class/class/accessing/bookName.st > A Spec-Help.package/SpecHelpTopics.class/class/accessing/key.st > A Spec-Help.package/SpecHelpTopics.class/class/accessing/pages.st > A Spec-Help.package/SpecHelpTopics.class/class/pages/introduction.st > A Spec-Help.package/SpecHelpTopics.class/class/pages/terminology.st > A Spec-Help.package/SpecHelpTopics.class/definition.st > A Spec-Help.package/SpecLayouts.class/README.md > A Spec-Help.package/SpecLayouts.class/class/accessing/bookName.st > A Spec-Help.package/SpecLayouts.class/class/accessing/pages.st > A Spec-Help.package/SpecLayouts.class/class/pages/columns.st > A Spec-Help.package/SpecLayouts.class/class/pages/columnsAndRows.st > A Spec-Help.package/SpecLayouts.class/class/pages/intro.st > A Spec-Help.package/SpecLayouts.class/class/pages/rows.st > A Spec-Help.package/SpecLayouts.class/definition.st > A Spec-Help.package/TheHeartOfSpec.class/README.md > A Spec-Help.package/TheHeartOfSpec.class/class/accessing/bookName.st > A Spec-Help.package/TheHeartOfSpec.class/class/accessing/pages.st > A > Spec-Help.package/TheHeartOfSpec.class/class/pages/initializePresenter.st > A > Spec-Help.package/TheHeartOfSpec.class/class/pages/initializeWidgets.st > A Spec-Help.package/TheHeartOfSpec.class/class/pages/intro.st > A Spec-Help.package/TheHeartOfSpec.class/class/pages/layouts.st > A > Spec-Help.package/TheHeartOfSpec.class/class/pages/widgetInstantiation.st > A Spec-Help.package/TheHeartOfSpec.class/definition.st > > Log Message: > ----------- > 40521 > 14420 What to do with Polymorph-Geometry > https://pharo.fogbugz.com/f/cases/14420 > > 14950 Spec help added to the Help Browser > https://pharo.fogbugz.com/f/cases/14950 > > 15013 enable recompile on run:with:in: > https://pharo.fogbugz.com/f/cases/15013 > > 15015 GradientFillStyle color selection broken > https://pharo.fogbugz.com/f/cases/15015 > > http://files.pharo.org/image/40/40521.zip > > >

March 1, 2015

Re: [Pharo-dev] Smart Suggestions based on text selection such as extract method seems to be broken.

by Thierry Goubier

Stef, Look if smart suggestion isn't affected by the token / ast change. Thierry Le 28 fÃ©vr. 2015 18:55, "stepharo" <stepharo(a)free.fr> a Ã©crit : > Hi > > Smart Suggestions based on text selection such as extract method seems to > be broken. > if I press command-T on a node, when I select extract method, the complete > or part of the method > is selected. I thought that it was working. > > Stef > >

Feb. 28, 2015

Re: [Pharo-dev] [Reflectivity] Compiler AST transformation Plugins

by Thierry Goubier

Cool. Per class customizable code rewriting. Great for extendable frameworks. Thierry Le 28 fÃ©vr. 2015 16:18, "Marcus Denker" <marcus.denker(a)inria.fr> a Ã©crit : > A simple AST-transformer plugin architecture for Opal... > > -> subclass OCCompilerASTPlugin > -> implement #transform e.g. > > transform > | rule | > rule := RBParseTreeRewriter replaceLiteral: 42 with: 'meaning of life'. > rule executeTree: ast. > ^ast > > The plugin can be activated *per class hierarchy* by overriding #compiler > > compiler > "the example plugin is active for this class" > ^super compiler addPlugin: ASTPluginMeaningOfLife. > > or of course for a single compilation: > > (Smalltalk compiler addPlugin: ASTPluginMeaningOfLife) evaluate: '42' > > For review here: > > https://pharo.fogbugz.com/f/cases/15019/Compiler-AST-transformation-Plugins > > Marcus >

Feb. 28, 2015

[Reflectivity] Trello Board

by Marcus Denker

Hi, I added a board for this one, too https://trello.com/b/m5cxaAxB/reflectivity <https://trello.com/b/m5cxaAxB/reflectivity> Marcus

Feb. 28, 2015

[Pharo4][Slots] Trello Board

by Marcus Denker

Hi, I want to try to keep the TODO in a Trello board, this should make it easier for people that want to help to pick something todoâ¦ I will post some simple actions, too. (for example tests that need to be written). https://trello.com/b/d59lgZFB/slots <https://trello.com/b/d59lgZFB/slots> Marcus

Feb. 28, 2015

[Reflectivity] Compiler AST transformation Plugins

by Marcus Denker

A simple AST-transformer plugin architecture for Opal... -> subclass OCCompilerASTPlugin -> implement #transform e.g. transform | rule | rule := RBParseTreeRewriter replaceLiteral: 42 with: 'meaning of life'. rule executeTree: ast. ^ast The plugin can be activated *per class hierarchy* by overriding #compiler compiler "the example plugin is active for this class" ^super compiler addPlugin: ASTPluginMeaningOfLife. or of course for a single compilation: (Smalltalk compiler addPlugin: ASTPluginMeaningOfLife) evaluate: â42â For review here: https://pharo.fogbugz.com/f/cases/15019/Compiler-AST-transformation-Plugins Marcus

Feb. 28, 2015

Zn using String>>#substrings:

by Sven Van Caekenberghe

Hi, Zinc HTTP Components' latest stable version 2.6.2 which was integrated in Pharo 4.0 is using String>>#substrings: instead of String>>#subStrings: For Pharo 4 this is of course OK. String>>#substrings: was also added to Pharo 3.0. For Pharo 2.0 Zinc will load a 'forward compatibility' package to add the missing method. If you are working in/with an older/existing Pharo 3.0 things will not be solved automatically. Either add the method yourself, or load 'Zinc-pharo2-forward-compatibility' manually. It might even be possible to update the image, but I haven't tried that. HTH, Sven

Feb. 28, 2015

Re: [Pharo-dev] Unkownselector Warning: removed for now

by Marcus Denker

> On 28 Feb 2015, at 09:39, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > Hi, > > With the AST changes, we now create the RBMessageNode with a selector. Before it was an array of parts, > which means that the Symbol was not created in the Parser. > > This means, we used to check in the Semantic Analysis when visiting the RBMessageNode if the selector already > is in the Symboltable and raise a warning else. > > After discussing with Pablo, we decided to not implement this functionality on the level of the Parser (where the symbol > is now created). > > - this is purely a âlintâ like warning. It has nothing to do with Syntax (nor with semantics). > - it should be implemented on the tool level > - it should not raise the annoying dialog, but instead put a red line under the symbol > - The non existing selector is coloured red by the syntax highlighting already now (until you acceptâ¦) > > Thus: We will for now remove the warning, it will come back as part of the IDE later. There we will be able to do > a *much* better job, too. (e.g. not check against existing symbols, but existing method selectors). > e.g. Symbol allSymbols size "59965". (CompiledMethod allInstances collect: #selector) asSet size â42260" Marcus

Feb. 28, 2015

Unkownselector Warning: removed for now

by Marcus Denker

Hi, With the AST changes, we now create the RBMessageNode with a selector. Before it was an array of parts, which means that the Symbol was not created in the Parser. This means, we used to check in the Semantic Analysis when visiting the RBMessageNode if the selector already is in the Symboltable and raise a warning else. After discussing with Pablo, we decided to not implement this functionality on the level of the Parser (where the symbol is now created). - this is purely a âlintâ like warning. It has nothing to do with Syntax (nor with semantics). - it should be implemented on the tool level - it should not raise the annoying dialog, but instead put a red line under the symbol - The non existing selector is coloured red by the syntax highlighting already now (until you acceptâ¦) Thus: We will for now remove the warning, it will come back as part of the IDE later. There we will be able to do a *much* better job, too. (e.g. not check against existing symbols, but existing method selectors). Marcus

Feb. 28, 2015

Re: [Pharo-dev] The evil twin in 40516

by Marcus Denker

> On 27 Feb 2015, at 23:11, Thierry Goubier <thierry.goubier(a)gmail.com> wrote: > > Le 27/02/2015 20:26, Marcus Denker a Ã©crit : >> >>> On 27 Feb 2015, at 19:48, Thierry Goubier <thierry.goubier(a)gmail.com> wrote: >>> >>> Hi Markus, >>> >>> if I understand correctly some of the possibilities: >>> >>> - I can use RBParseTreeSearcher / RBParseTreeRewriter on the twin AST. >>> >>> (any example how to install / invalidate the twin AST after an effective RBParseTreeRewriter operation?) >>> >> Yes, but I would do it on a copyâ¦ that is, do the change in run:with:in: on a copy, generate code from that, >> keep the original. >> An AST that follows the text is kind of nice for e.g. navigation. >> >>> - Any change to the Twin AST is reflected in the method bytecode (as long as one does invalidate). >>> >> yes. >> >>> This would mean being able to put tracing code with RB patterns, no? And without having to do a recompilation of the traced method? >>> >> >> Yes. At first I want to have something simple: a MOP based on the MetaLinks. But one could do the same with RB transformations: >> put them as annotation on the method, then on recompile take them into account. > > Maybe I'm not understanding everything, so would that be correct: > > - If I inject additional behavior with meta-links, then they just annotate the AST and do not really change it. > > Now, since writing dedicated ast visitors takes quite some code, what could work is to have a RBParseTreeMetaWriter: use a RB pattern to find the right ast node, and add whatever meta-link there. > Yes. The experiment right now does not use the rewriter, but we should have a look. Marcus

Feb. 28, 2015