- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Step by step contribute

by ducasse

> On 8 Sep 2019, at 14:22, Hilaire <hilaire(a)drgeo.eu> wrote: > > hum, with some sort of luck I got it working as it should and in the > process understood a bit the workflow. the workflow is your fork pharo then iceberg will clone you also commit to your working copy when you are in trouble select repair the items are sorted in order of use probability you commit commit commit to your working copy then push to your fork then PR from your fork to pharo remote > In the tutorial, a few words explaining it could be useful to git > newbies as me. > > Hilaire > > Le 08/09/2019 Ã 14:12, Hilaire a Ã©crit : >> What should I do now? > > -- > Dr. Geo > http://drgeo.eu > > >

Sept. 8, 2019

Re: [Pharo-dev] Step by step contribute

by ducasse

> On 8 Sep 2019, at 14:12, Hilaire <hilaire(a)drgeo.eu> wrote: > > Hi, > > Reading the tutorial > https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo > > * At > https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo#solvi… > > I don't have Detached Working Copy but uncommited changes. > > * When I create a new branch from issue, should I use origin or pharo > repo ? When I fill in the issue number with origin I have an > INVALID-ISSUE title you should use the pharo one because this is the one that contains the bug entries > With pharo-project repo, it fetches the title correctly though. So I > take this one. Yes this is correct. > > > * https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo#step-… > > To push the change, (I need to pull to push?). A question is raised > "pharo has ongoing modifications (uncommit changes) Indeed I did not > commit. It was not mentioned in tutorial. Was it forgotten or do I miss > something? So I commit it. When you push it will check and will pull automatically. > Ah, now when I create the pull request, it complains the branch does not > exist and I should commit before and push the changes. You should commit to your fork push to your fork and do a PR (because the PR is from a branch of your repo to a branch to the pharo repo) > Likely I should not have commited in the first place. No committing is always good. > > What should I do now? What I do in general is download latest image repair in detached copy I do create new branch (I call bottomxâ¦) repair then I do create branch from issue commit commit push then PR If you need help we can organise a screen sharing session. > > Hilaire > > -- > Dr. Geo > http://drgeo.eu > > >

Sept. 8, 2019

Re: [Pharo-dev] Step by step contribute

by Hilaire

hum, with some sort of luck I got it working as it should and in the process understood a bit the workflow. In the tutorial, a few words explaining it could be useful to git newbies as me. Hilaire Le 08/09/2019 Ã 14:12, Hilaire a Ã©critÂ : > What should I do now? -- Dr. Geo http://drgeo.eu

Sept. 8, 2019

Step by step contribute

by Hilaire

Hi, Reading the tutorial https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo * At https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo#solvi… I don't have Detached Working Copy but uncommited changes. * When I create a new branch from issue, should I use origin or pharo repo ? When I fill in the issue number with origin I have an INVALID-ISSUE title With pharo-project repo, it fetches the title correctly though. So I take this one. * https://github.com/pharo-project/pharo/wiki/Contribute-a-fix-to-Pharo#step-… To push the change, (I need to pull to push?). A question is raised "pharo has ongoing modifications (uncommit changes) Indeed I did not commit. It was not mentioned in tutorial. Was it forgotten or do I miss something? So I commit it. Ah, now when I create the pull request, it complains the branch does not exist and I should commit before and push the changes. Likely I should not have commited in the first place. What should I do now? Hilaire -- Dr. Geo http://drgeo.eu

Sept. 8, 2019

Re: [Pharo-dev] Slot definition API?

by tesonep＠gmail.com

Hi, I really like the idea of returning a node object for the initialization. >From seeing the class definition, I think we should assume that: - the receiver of the slot instantiation message is a Slot. - the parameters to the slot instatiation message are literals or literal-only expressions. Do you think that these assumptions / constraints are cool / enough? Cheers. On Sun, 8 Sep 2019, 09:41 ducasse, <stepharo(a)netcourrier.com> wrote: > Hi > > Iâm fixing the class definition parser and I have a question. > > Iâm stabilizing the API of CDSlotNode > > > 1 âfirst' => LazyClassVariable default: 5. > 2 âsecond' => InstanceVariableSlot. > 3 âinstVar3â > > Here is a proposal > > slotdefinition(3) name ? variable name > >>> âinstVar3' > > slotDefinition(2) slotClass? > >>> InstanceVariableSlot > > slotDefinition(1) initializationMessage > >>> 'default: 5â > or better > >>> Node(default: 5) if it exist > > S. > > > >

Sept. 8, 2019

Comment colouring is funky

by Hilaire

Hi, On P7, I see this dual comment colouring. White before any code instruction then gray. Do I miss something? Hilaire -- Dr. Geo http://drgeo.eu

Sept. 8, 2019

Slot definition API?

by ducasse

Hi Iâm fixing the class definition parser and I have a question. Iâm stabilizing the API of CDSlotNode 1 âfirst' => LazyClassVariable default: 5. 2 âsecond' => InstanceVariableSlot. 3 âinstVar3â Here is a proposal slotdefinition(3) name ? variable name >>> âinstVar3' slotDefinition(2) slotClass? >>> InstanceVariableSlot slotDefinition(1) initializationMessage >>> 'default: 5â or better >>> Node(default: 5) if it exist S.

Sept. 8, 2019

Re: [Pharo-dev] possible Windows Update "1903" Iceberg problem

by Christopher Fuhrman

I can also confirm that Iceberg via SSH was crashing on my Windows 1903 update, and putting those DLLs in Documents\Pharo\vms\80-x64 allows Iceberg to work without a VM crash. I did not test on 70-x64. Good work! On Thu, 5 Sep 2019 at 10:02, Christopher Fuhrman < christopher.fuhrman(a)etsmtl.ca> wrote: > This sounds great, Pablo. > > Just to clarify on how to test, if I'm using Pharo Launcher, do I just > replace the .dll files from your .zip > in C:\Users\{me}\Documents\Pharo\vms\80-x64 (and/or \70-x64)? > > On Thu, 5 Sep 2019 at 09:34, tesonep(a)gmail.com <tesonep(a)gmail.com> wrote: > >> Hi all, >> with Guille we have been working in this issue since Monday, it >> was a complicated issue to solve as we require to compile and test >> different versions of the libgit2 library and its dependencies >> (openssl and libssh2). >> We have a workaround for using ssh in windows. >> We have produced a new set of libraries with the correct versions. >> These libraries are available in >> https://drive.google.com/open?id=1fwAVyrEEXkGOAuyAh1wASRRSv3SjZ3R1 >> The idea is to start testing them while we are working on a new >> release of the VM. >> >> Cheers, >> Pablo >> >> On Wed, Sep 4, 2019 at 10:05 AM Guillermo Polito >> <guillermopolito(a)gmail.com> wrote: >> > >> > Hi all, >> > >> > Sorry for not communicating better :). >> > We know this is an important issue and we did move it to top priority >> even prior to this email ;). >> > Doru, to answer you, what people can do for the moment is to test what >> we are going to propose in a couple of hours in your windows machines. >> > With Pablo we have tested in several Windows 10 machines pre- and post- >> update 1903. Still we would like people testing on their setups and other >> windows versions >> > >> > We have been working the last couple of days debugging openssh and >> libgit, and building a version with a more up-to-date version of openssh. >> > We will come back later this morning / early afternoon with >> > - a new vm setup using up to date versions of openssh >> > - a description of workarounds for those tied to old versions of the VM >> > So people can test. >> > >> > Cheers, >> > Guille and Pablo >> > >> > > El 4 sept 2019, a las 8:38, ducasse <stepharo(a)netcourrier.com> >> escribiÃ³: >> > > >> > > I saw everybody super busy and I imagine that they will reply soon. >> > > Iâm travelling to give Pharo lectures. >> > > >> > >> On 3 Sep 2019, at 19:23, Tudor Girba <tudor(a)tudorgirba.com> wrote: >> > >> >> > >> Hi, >> > >> >> > >> Is there a way to speed the work on this one? >> > >> >> > >> At this moment, people cannot load any code in Pharo on Windows 10. >> > >> >> > >> Cheers, >> > >> Doru >> > >> >> > >> -- >> > >> www.feenk.com >> > >> "Every thing has its own flow." >> > >> >> > >>> On 28 Aug 2019, at 16:20, ducasse <stepharo(a)netcourrier.com> wrote: >> > >>> >> > >>> tx doru >> > >>> >> > >>> Stef >> > >>> >> > >>>> On 28 Aug 2019, at 16:01, Tudor Girba <tudor(a)tudorgirba.com> >> wrote: >> > >>>> >> > >>>> Hi >> > >>>> >> > >>>> I opened an issue: >> https://github.com/pharo-project/pharo/issues/4437 >> > >>>> >> > >>>> I believe this should be treated as critical given that we cannot >> load code in Pharo 7 (or 8) which makes it almost useless for users. >> > >>>> >> > >>>> Cheers, >> > >>>> Doru >> > >>>> >> > >>>> >> > >>>>> On Aug 27, 2019, at 10:54 AM, Tudor Girba <tudor(a)tudorgirba.com> >> wrote: >> > >>>>> >> > >>>>> Hi, >> > >>>>> >> > >>>>> We just encountered this on two different machines. We got this >> after the update to Windows 1903. For us itâs a critical issue at this >> point. What can we do to help with this? >> > >>>>> >> > >>>>> Cheers, >> > >>>>> Doru >> > >>>>> >> > >>>>> >> > >>>>> >> > >>>>>> On Aug 17, 2019, at 12:50 PM, Ben Coman <btc(a)openInWorld.com> >> wrote: >> > >>>>>> >> > >>>>>> hi Stef, >> > >>>>>> I feel you missed my point. Probably I wasn't clear this has >> already been tested with latest Pharo 8 launched by PharoLauncher. >> > >>>>>> The problem occurs with Pharo 7.0.3(64 bit) and with >> Pharo8.0-SNAPSHOT-build.635(64 bit) >> > >>>>>> after Microsoft Windows Update 1903... >> > >>>>>> >> https://www.computerworld.com/article/3409621/microsoft-starts-windows-10s-… >> > >>>>>> >> > >>>>>> If indeed 1903 is the cause, with this update now being *forced* >> down on people, this will potentially soon impact more and more Windows >> users. >> > >>>>>> But my guess that 1903 is the culprit needs to be confirmed. >> > >>>>>> So I am requesting someone with access to multiple Windows >> machines directly compare a 1903 machine with a pre-1903 machine. >> > >>>>>> >> > >>>>>> cheers -ben >> > >>>>>> >> > >>>>>> On Sat, 17 Aug 2019 at 12:58, ducasse <stepharo(a)netcourrier.com> >> wrote: >> > >>>>>> Hi ben >> > >>>>>> >> > >>>>>> in the pharo launcher if you click on P8.0 (development version) >> you get access to all the builds. >> > >>>>>> >> > >>>>>> Stef >> > >>>>>> >> > >>>>>>> On 16 Aug 2019, at 16:02, Ben Coman <btc(a)openinworld.com> >> wrote: >> > >>>>>>> >> > >>>>>>> IThis morning the May 2019 Windows Update "1903" forced itself >> onto my computer and now 64-bits Pharo seems to have a problem with >> git_remote_fetch() FFI callout. I no longer have a non-1903 machine to >> directly compare behaviour before "1903". Can someone familiar with this >> area with both "pre-1903" and "1903" machines triage whether "1903" is >> indeed the cause? >> > >>>>>>> >> > >>>>>>> A few other recent reports are noted here... >> > >>>>>>> https://github.com/pharo-project/pharo/issues/3418 >> > >>>>>>> >> > >>>>>>> cheers -ben >> > >>>>>> >> > >>>>> >> > >>>>> -- >> > >>>>> feenk.com >> > >>>>> >> > >>>>> "Not knowing how to do something is not an argument for how it >> cannot be done." >> > >>>>> >> > >>>> >> > >>>> -- >> > >>>> feenk.com >> > >>>> >> > >>>> âLive like you mean it." >> > >>>> >> > >>>> >> > >>> >> > >>> >> > >>> >> > >> >> > > >> > > >> > > >> > >> > >> >> >> -- >> Pablo Tesone. >> tesonep(a)gmail.com >> >> > > -- > Christopher Fuhrman, P.Eng., PhD > > *Professeur au DÃ©partement de gÃ©nie logiciel et des technologies de > l'informationÃTS (Ãcole de technologie supÃ©rieure)* > > http://profs.etsmtl.ca/cfuhrman > +1 514 396 8638 > *L'ÃTS est une constituante de l'UniversitÃ© du QuÃ©bec* > -- Christopher Fuhrman, P.Eng., PhD *Professeur au DÃ©partement de gÃ©nie logiciel et des technologies de l'informationÃTS (Ãcole de technologie supÃ©rieure)* http://profs.etsmtl.ca/cfuhrman +1 514 396 8638 *L'ÃTS est une constituante de l'UniversitÃ© du QuÃ©bec*

Sept. 8, 2019

[Pharo 8.0] Build #710: 4370-Trait-composition-slots-method-contains-duplication

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #710 was: SUCCESS. The Pull Request #4371 was integrated: "4370-Trait-composition-slots-method-contains-duplication" Pull request url: https://github.com/pharo-project/pharo/pull/4371 Issue Url: https://github.com/pharo-project/pharo/issues/4370 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Sept. 7, 2019

[Pharo 8.0] Build #709: 4447-[CI] Wget log is too verbose

by ci-pharo-ci-jenkins2＠inria.fr

There is a new Pharo build available! The status of the build #709 was: FAILURE. The Pull Request #4448 was integrated: "4447-[CI] Wget log is too verbose" Pull request url: https://github.com/pharo-project/pharo/pull/4448 Issue Url: https://github.com/pharo-project/pharo/issues/4447 Build Url: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%2…

Sept. 7, 2019