- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Release with Dark Theme

by stepharo

comments about color is to be taken with care. Le 24/4/15 02:48, Sean P. DeNigris a Ã©crit : > Why didn't/don't we make it the default for 4.0? Everyone seems to love it, > and people are commenting that the UI looks dated. > > > > ----- > Cheers, > Sean > -- > View this message in context: http://forum.world.st/Release-with-Dark-Theme-tp4821496.html > Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com. > >

April 24, 2015

Re: [Pharo-dev] [Pharo-users] QualityAssistant v0.4

by stepharo

Le 23/4/15 19:57, Ben Coman a Ã©crit : > Making code critics more visible --> expect a flood of opinions about > the usefulness of rules and what they mean, and Uko should not be > responsible for all of them :) This is an area where gathering usage > statistics (similar to Spotter) might be very useful - if there was > some way to record which rules people have issues with. This was planned :) I envisioned that and we brainstorm with Yko around 8 months ago :). Stef > cheers -ben > > On Thu, Apr 23, 2015 at 12:06 AM, Cyril Ferlicot > <cyril.ferlicot(a)gmail.com <mailto:cyril.ferlicot@gmail.com>> wrote: > > Hi ! > Your quality assistant say to me "repeated method in the superclass" > (If a class is overriding a method, it should use a different code. Is > meaningless to have a method in a class and in its superclass) but > i've 3 methods into my class and all overrides a method with "^ > shouldBeImplemented" in the superclass. > I think something is wrong with this warning :) > > > On 22 April 2015 at 16:45, Yuriy Tymchuk <yuriy.tymchuk(a)me.com > <mailto:yuriy.tymchuk@me.com>> wrote: > > Good point, this brings up two problems. > > > > 1) The rule can improve detection by checking the type is the > message is > > sent to self > > 2) Automatic fixing should display the changes and letting you > decide > > whether you want to apply them. > > > > 1st will take some time. 2nd will be soon in QA :) > > > > Uko > > > > > > On 22 Apr 2015, at 16:33, Johan Fabry <jfabry(a)dcc.uchile.cl > <mailto:jfabry@dcc.uchile.cl>> wrote: > > > > Some weird behavior in quality assistant. Have a look at this > method: > > > > duplicateVar: aVarName > > > > self show: 'Var: ', aVarName, ' redefinition ignored'. > > > > This raises the issue: âUse cascaded nextPutAll:âs instead of #, in > > nextPutAll:â It also pops up the automatic rewrite icon, so I > clicked on it > > to see how it would transform the code. Result: > > > > duplicateVar: aVarName > > self > > show: 'Var: ' , aVarName; > > show: ' redefinition ignored' > > > > Needless to say, thatâs not a behavior preserving transformation. > > > > > > On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk(a)me.com > <mailto:yuriy.tymchuk@me.com>> wrote: > > > > Please give me a feedback about your experience, as I want to > make it even > > more useful. Either write me an email, or open an entry at: > > https://github.com/Uko/QualityAssistant/issues > > > > > > > > > > ---> Save our in-boxes! http://emailcharter.org <--- > > > > Johan Fabry - http://pleiad.cl/~jfabry > <http://pleiad.cl/%7Ejfabry> > > PLEIAD lab - Computer Science Department (DCC) - University > of Chile > > > > > > > > -- > Cheers > Cyril Ferlicot > >

April 24, 2015

Re: [Pharo-dev] Release with Dark Theme

by Ben Coman

Its a bit late to make such a prominent change. Maybe in the Welcome info just note how to activate it. cheers -ben On Fri, Apr 24, 2015 at 7:48 AM, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > Why didn't/don't we make it the default for 4.0? Everyone seems to love it, > and people are commenting that the UI looks dated. > > > > ----- > Cheers, > Sean > -- > View this message in context: > http://forum.world.st/Release-with-Dark-Theme-tp4821496.html > Sent from the Pharo Smalltalk Developers mailing list archive at > Nabble.com. > >

April 24, 2015

Release with Dark Theme

by Sean P. DeNigris

Why didn't/don't we make it the default for 4.0? Everyone seems to love it, and people are commenting that the UI looks dated. ----- Cheers, Sean -- View this message in context: http://forum.world.st/Release-with-Dark-Theme-tp4821496.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

April 23, 2015

Re: [Pharo-dev] [Pharo-users] QualityAssistant v0.4

by Mariano Martinez Peck

Thank you Yuiry. Super cool. I have just start migrating my client app to 4.0 and start using it full day long. And the first thing I did (after setting dark theme) is to load this tool. I also agree with the rest that I don't see much of a difference regarding modularity whether this tool is loaded in the image by default or not. On the contrary, whether it can be cleanly unloaded or not, which are and how managed are the dependencies etc, does refer to modularity. But that's my opinion only. Cheers, On Thu, Apr 23, 2015 at 2:51 PM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > It is coming ;) > > On 23 Apr 2015, at 18:57, Ben Coman <btc(a)openinworld.com> wrote: > > Making code critics more visible --> expect a flood of opinions about the > usefulness of rules and what they mean, and Uko should not be responsible > for all of them :) This is an area where gathering usage statistics > (similar to Spotter) might be very useful - if there was some way to record > which rules people have issues with. > cheers -ben > > On Thu, Apr 23, 2015 at 12:06 AM, Cyril Ferlicot <cyril.ferlicot(a)gmail.com > > wrote: > >> Hi ! >> Your quality assistant say to me "repeated method in the superclass" >> (If a class is overriding a method, it should use a different code. Is >> meaningless to have a method in a class and in its superclass) but >> i've 3 methods into my class and all overrides a method with "^ >> shouldBeImplemented" in the superclass. >> I think something is wrong with this warning :) >> >> >> On 22 April 2015 at 16:45, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: >> > Good point, this brings up two problems. >> > >> > 1) The rule can improve detection by checking the type is the message is >> > sent to self >> > 2) Automatic fixing should display the changes and letting you decide >> > whether you want to apply them. >> > >> > 1st will take some time. 2nd will be soon in QA :) >> > >> > Uko >> > >> > >> > On 22 Apr 2015, at 16:33, Johan Fabry <jfabry(a)dcc.uchile.cl> wrote: >> > >> > Some weird behavior in quality assistant. Have a look at this method: >> > >> > duplicateVar: aVarName >> > >> > self show: 'Var: ', aVarName, ' redefinition ignored'. >> > >> > This raises the issue: âUse cascaded nextPutAll:âs instead of #, in >> > nextPutAll:â It also pops up the automatic rewrite icon, so I clicked >> on it >> > to see how it would transform the code. Result: >> > >> > duplicateVar: aVarName >> > self >> > show: 'Var: ' , aVarName; >> > show: ' redefinition ignored' >> > >> > Needless to say, thatâs not a behavior preserving transformation. >> > >> > >> > On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: >> > >> > Please give me a feedback about your experience, as I want to make it >> even >> > more useful. Either write me an email, or open an entry at: >> > https://github.com/Uko/QualityAssistant/issues >> > >> > >> > >> > >> > ---> Save our in-boxes! http://emailcharter.org <--- >> > >> > Johan Fabry - http://pleiad.cl/~jfabry >> > PLEIAD lab - Computer Science Department (DCC) - University of Chile >> > >> > >> >> >> >> -- >> Cheers >> Cyril Ferlicot >> >> > > -- Mariano http://marianopeck.wordpress.com

April 23, 2015

Re: [Pharo-dev] [Pharo-users] QualityAssistant v0.4

by Yuriy Tymchuk

It is coming ;) > On 23 Apr 2015, at 18:57, Ben Coman <btc(a)openinworld.com> wrote: > > Making code critics more visible --> expect a flood of opinions about the usefulness of rules and what they mean, and Uko should not be responsible for all of them :) This is an area where gathering usage statistics (similar to Spotter) might be very useful - if there was some way to record which rules people have issues with. > cheers -ben > > On Thu, Apr 23, 2015 at 12:06 AM, Cyril Ferlicot <cyril.ferlicot(a)gmail.com <mailto:cyril.ferlicot@gmail.com>> wrote: > Hi ! > Your quality assistant say to me "repeated method in the superclass" > (If a class is overriding a method, it should use a different code. Is > meaningless to have a method in a class and in its superclass) but > i've 3 methods into my class and all overrides a method with "^ > shouldBeImplemented" in the superclass. > I think something is wrong with this warning :) > > > On 22 April 2015 at 16:45, Yuriy Tymchuk <yuriy.tymchuk(a)me.com <mailto:yuriy.tymchuk@me.com>> wrote: > > Good point, this brings up two problems. > > > > 1) The rule can improve detection by checking the type is the message is > > sent to self > > 2) Automatic fixing should display the changes and letting you decide > > whether you want to apply them. > > > > 1st will take some time. 2nd will be soon in QA :) > > > > Uko > > > > > > On 22 Apr 2015, at 16:33, Johan Fabry <jfabry(a)dcc.uchile.cl <mailto:jfabry@dcc.uchile.cl>> wrote: > > > > Some weird behavior in quality assistant. Have a look at this method: > > > > duplicateVar: aVarName > > > > self show: 'Var: ', aVarName, ' redefinition ignored'. > > > > This raises the issue: âUse cascaded nextPutAll:âs instead of #, in > > nextPutAll:â It also pops up the automatic rewrite icon, so I clicked on it > > to see how it would transform the code. Result: > > > > duplicateVar: aVarName > > self > > show: 'Var: ' , aVarName; > > show: ' redefinition ignored' > > > > Needless to say, thatâs not a behavior preserving transformation. > > > > > > On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk(a)me.com <mailto:yuriy.tymchuk@me.com>> wrote: > > > > Please give me a feedback about your experience, as I want to make it even > > more useful. Either write me an email, or open an entry at: > > https://github.com/Uko/QualityAssistant/issues <https://github.com/Uko/QualityAssistant/issues> > > > > > > > > > > ---> Save our in-boxes! http://emailcharter.org <http://emailcharter.org/> <--- > > > > Johan Fabry - http://pleiad.cl/~jfabry <http://pleiad.cl/~jfabry> > > PLEIAD lab - Computer Science Department (DCC) - University of Chile > > > > > > > > -- > Cheers > Cyril Ferlicot > >

April 23, 2015

Re: [Pharo-dev] [Pharo-users] QualityAssistant v0.4

by Ben Coman

Making code critics more visible --> expect a flood of opinions about the usefulness of rules and what they mean, and Uko should not be responsible for all of them :) This is an area where gathering usage statistics (similar to Spotter) might be very useful - if there was some way to record which rules people have issues with. cheers -ben On Thu, Apr 23, 2015 at 12:06 AM, Cyril Ferlicot <cyril.ferlicot(a)gmail.com> wrote: > Hi ! > Your quality assistant say to me "repeated method in the superclass" > (If a class is overriding a method, it should use a different code. Is > meaningless to have a method in a class and in its superclass) but > i've 3 methods into my class and all overrides a method with "^ > shouldBeImplemented" in the superclass. > I think something is wrong with this warning :) > > > On 22 April 2015 at 16:45, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > > Good point, this brings up two problems. > > > > 1) The rule can improve detection by checking the type is the message is > > sent to self > > 2) Automatic fixing should display the changes and letting you decide > > whether you want to apply them. > > > > 1st will take some time. 2nd will be soon in QA :) > > > > Uko > > > > > > On 22 Apr 2015, at 16:33, Johan Fabry <jfabry(a)dcc.uchile.cl> wrote: > > > > Some weird behavior in quality assistant. Have a look at this method: > > > > duplicateVar: aVarName > > > > self show: 'Var: ', aVarName, ' redefinition ignored'. > > > > This raises the issue: âUse cascaded nextPutAll:âs instead of #, in > > nextPutAll:â It also pops up the automatic rewrite icon, so I clicked on > it > > to see how it would transform the code. Result: > > > > duplicateVar: aVarName > > self > > show: 'Var: ' , aVarName; > > show: ' redefinition ignored' > > > > Needless to say, thatâs not a behavior preserving transformation. > > > > > > On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > > > > Please give me a feedback about your experience, as I want to make it > even > > more useful. Either write me an email, or open an entry at: > > https://github.com/Uko/QualityAssistant/issues > > > > > > > > > > ---> Save our in-boxes! http://emailcharter.org <--- > > > > Johan Fabry - http://pleiad.cl/~jfabry > > PLEIAD lab - Computer Science Department (DCC) - University of Chile > > > > > > > > -- > Cheers > Cyril Ferlicot > >

April 23, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50009 Home: https://github.com/pharo-project/pharo-core

April 23, 2015

[pharo-project/pharo-core] 54ae88: 50009

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 54ae881ebaaa1f40f5369cf6af2e3688ef86c166 https://github.com/pharo-project/pharo-core/commit/54ae881ebaaa1f40f5369cf6… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-04-23 (Thu, 23 Apr 2015) Changed paths: M KernelTests.package/ClassTest.class/instance/testing/testClassRespectsPolymorphismWithTrait.st M Monticello.package/MCLazyVersionInfo.class/instance/initialization/initializeWithName_id_message_date_time_author_ancestors_stepChildren_.st M Monticello.package/MCVersionInfo.class/instance/initialization/initializeWithName_id_message_date_time_author_ancestors_stepChildren_.st M MonticelloGUI.package/MCFileRepositoryInspector.class/instance/accessing/selectedPackageAncestors.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script617.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script618.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50008.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50009.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50009 15372 forward port pharaoh: 15339 Monticello with spotter extension methods throws MNU errors when browsing packages in repos that don https://pharo.fogbugz.com/f/cases/15372 15380 Failing test: ClassTest.testClassRespectsPolymorphismWithTrait https://pharo.fogbugz.com/f/cases/15380 http://files.pharo.org/image/50/50009.zip

April 23, 2015

RPackage: 'accessing' vs 'all accessing' Protocol

by Sean P. DeNigris

What is the distinction of 'all accessing'? ----- Cheers, Sean -- View this message in context: http://forum.world.st/RPackage-accessing-vs-all-accessing-Protocol-tp482146… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

April 23, 2015