- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Tx Pass

by Sean P. DeNigris

Sean P. DeNigris wrote > > Sean P. DeNigris wrote >> Issue 15414: TxText Cleanup for Pharo 5.0 #1 >> https://pharo.fogbugz.com/default.asp?15414 > It would be great to get this into the image ASAP so I can keep working on > it :) I fixed the validation errors. The two left seem unrelated. https://ci.inria.fr/pharo/job/Pharo-5.0-Issue-Validator/667//artifact/valid… Are we okay to include? ----- Cheers, Sean -- View this message in context: http://forum.world.st/Tx-Pass-tp4822173p4822238.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

April 27, 2015

Re: [Pharo-dev] Are these changes good enough

by Marcus Denker

> On 27 Apr 2015, at 18:37, Sergio Fedi <sergio.fedi(a)gmail.com> wrote: > > Hi, I'm new to the Pharo community and recently installed Pharo 4.0. > > While using it I've found that the TestRunner didn't have coverage and after investigating a little I've found that is was almost there and I made it work. > > Is this change something I could submit as a Fix? > (as per in http://pharo.org/contribute-propose-fix <http://pharo.org/contribute-propose-fix>) > Yes! Marcus

April 27, 2015

Pharo 4.0 - display

by recursive68＠gmail.com

Oh well, that's better than having artefacts (to use correct terminology) from my point of view in the mean-time. No, there isn't pixilation. Thanks.

April 27, 2015

Re: [Pharo-dev] Are these changes good enough

by Sven Van Caekenberghe

Yes please ;-) > On 27 Apr 2015, at 18:37, Sergio Fedi <sergio.fedi(a)gmail.com> wrote: > > Hi, I'm new to the Pharo community and recently installed Pharo 4.0. > > While using it I've found that the TestRunner didn't have coverage and after investigating a little I've found that is was almost there and I made it work. > > Is this change something I could submit as a Fix? > (as per in http://pharo.org/contribute-propose-fix) >

April 27, 2015

Are these changes good enough

by Sergio Fedi

Hi, I'm new to the Pharo community and recently installed Pharo 4.0. While using it I've found that the TestRunner didn't have coverage and after investigating a little I've found that is was almost there and I made it work. Is this change something I could submit as a Fix? (as per in http://pharo.org/contribute-propose-fix)

April 27, 2015

Re: [Pharo-dev] sometimes Shout changes the selection during styling

by Andrei Chis

That would work for me. Styling the text if the process doing the styling did not finish or is stuck does not feel as the right thing to do. On Mon, Apr 27, 2015 at 6:25 PM, Ben Coman <btc(a)openinworld.com> wrote: > > > On Mon, Apr 27, 2015 at 8:41 PM, Andrei Chis <chisvasileandrei(a)gmail.com> > wrote: > >> Hi, >> >> In the glamour debugger that we use in moose we are now having the >> following problem: >> - the selection of a PluggableTextMorph is, quite randomly , changed >> during styling. >> >> If I revert the fix for issue 15240 >> <https://pharo.fogbugz.com/f/cases/15240> then it works ok. >> Also if I change in SHTextStyler>>#styleInBackgroundProcess: from >> >> sem waitTimeoutSeconds: 5. >> view ifNotNil: [ view stylerStyledInBackground: text ] >> >> to: >> >> (sem waitTimeoutSeconds: 5) ifFalse: [ >> view ifNotNil: [ view stylerStyledInBackground: text ] ] >> >> it works ok. In the second snippet we only do the styling if the styler >> completed. >> >> >> If I look at the senders of styleInBackgroundProcess: there is another >> strange issue. >> First PluggableTextMorph>>#setText: calls either style: >> or styleInBackgroundProcess:, depending in the size of the text. >> Then, PluggableTextMorph>>#setText: >> calls PluggableTextMorph>>#setTextBasic:, which calls >> PluggableTextMorph>>#hasUnacceptedEdits: which in turn >> calls again styleInBackgroundProcess:. >> So when you set the text if the size of the text is small Shout will try >> to style the text with and without a background process. If you call >> hasUnacceptedEdits: >> manually when initializing the morph then three processes will be started >> for doing the styling. >> >> Removing the calls to styleInBackgroundProcess: from >> PluggableTextMorph>>#hasUnacceptedEdits: and >> PluggableTextMorph>>#basicHasUnacceptedEdits:. >> also solves the problem with the changing selection. >> >> Cheers, >> Andrei >> > > Perhaps we should have... > > sem > waitTimeoutSeconds: 5 > ifSignalled: [ view ifNotNil: [ view stylerStyledInBackground: > text ] ] > ifTimedOut: [ "do nothing" ]. > > cheers -ben >

April 27, 2015

Re: [Pharo-dev] sometimes Shout changes the selection during styling

by Ben Coman

On Mon, Apr 27, 2015 at 8:41 PM, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: > Hi, > > In the glamour debugger that we use in moose we are now having the > following problem: > - the selection of a PluggableTextMorph is, quite randomly , changed > during styling. > > If I revert the fix for issue 15240 > <https://pharo.fogbugz.com/f/cases/15240> then it works ok. > Also if I change in SHTextStyler>>#styleInBackgroundProcess: from > > sem waitTimeoutSeconds: 5. > view ifNotNil: [ view stylerStyledInBackground: text ] > > to: > > (sem waitTimeoutSeconds: 5) ifFalse: [ > view ifNotNil: [ view stylerStyledInBackground: text ] ] > > it works ok. In the second snippet we only do the styling if the styler > completed. > > > If I look at the senders of styleInBackgroundProcess: there is another > strange issue. > First PluggableTextMorph>>#setText: calls either style: > or styleInBackgroundProcess:, depending in the size of the text. > Then, PluggableTextMorph>>#setText: > calls PluggableTextMorph>>#setTextBasic:, which calls > PluggableTextMorph>>#hasUnacceptedEdits: which in turn > calls again styleInBackgroundProcess:. > So when you set the text if the size of the text is small Shout will try > to style the text with and without a background process. If you call > hasUnacceptedEdits: > manually when initializing the morph then three processes will be started > for doing the styling. > > Removing the calls to styleInBackgroundProcess: from > PluggableTextMorph>>#hasUnacceptedEdits: and > PluggableTextMorph>>#basicHasUnacceptedEdits:. > also solves the problem with the changing selection. > > Cheers, > Andrei > Perhaps we should have... sem waitTimeoutSeconds: 5 ifSignalled: [ view ifNotNil: [ view stylerStyledInBackground: text ] ] ifTimedOut: [ "do nothing" ]. cheers -ben

April 27, 2015

Re: [Pharo-dev] Fogbugz Area

by Esteban Lorenzano

> On 27 Apr 2015, at 17:44, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > > EstebanLM wrote >>> Which is the appropriate one >> None. > > Meaning a) it doesn't matter or b) we need to create a new one? meaning: we are over designing out bug tracker and it will be a pain in the not so far future. We need to apply a refactor there :) > > > EstebanLM wrote >> the monkey now can check also configurations > > Ah, I see now... Cool! > <http://forum.world.st/file/n4822212/Screenshot_2015-04-27_11.png> exactly :) > > > > ----- > Cheers, > Sean > -- > View this message in context: http://forum.world.st/Fogbugz-Area-tp4822198p4822212.html > Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com. >

April 27, 2015

Re: [Pharo-dev] Fogbugz Area

by Sean P. DeNigris

EstebanLM wrote >> Which is the appropriate one > None. Meaning a) it doesn't matter or b) we need to create a new one? EstebanLM wrote > the monkey now can check also configurations Ah, I see now... Cool! <http://forum.world.st/file/n4822212/Screenshot_2015-04-27_11.png> ----- Cheers, Sean -- View this message in context: http://forum.world.st/Fogbugz-Area-tp4822198p4822212.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

April 27, 2015

Re: [Pharo-dev] Tx Pass

by Nicolai Hess

2015-04-27 16:49 GMT+02:00 Sean P. DeNigris <sean(a)clipperadams.com>: > Sean P. DeNigris wrote > > Issue 15414: TxText Cleanup for Pharo 5.0 #1 > > https://pharo.fogbugz.com/default.asp?15414 > > It would be great to get this into the image ASAP so I can keep working on > it :) > I created a new configuration with your fixes and put it in the inbox (issue 15414 <https://pharo.fogbugz.com/default.asp?15414>). It would be great to have some more reviewers and if other people talk about their changes as well. (There were other new version of the packages that are not included (mostly from camille teruel). As no one else actively maintained the txtext repository, I stepped in to help. But if no one talks to me about the changes, they won't be included) nicolai > > > > ----- > Cheers, > Sean > -- > View this message in context: > http://forum.world.st/Tx-Pass-tp4822173p4822199.html > Sent from the Pharo Smalltalk Developers mailing list archive at > Nabble.com. > >

April 27, 2015