- Pharo-dev - lists.pharo.org

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50022 Home: https://github.com/pharo-project/pharo-core

April 29, 2015

Re: [Pharo-dev] Rectangle Center

by Ben Coman

On Wed, Apr 29, 2015 at 10:12 PM, Peter UhnÃ¡k <i.uhnak(a)gmail.com> wrote: > > > On Wed, Apr 29, 2015 at 3:51 PM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> > wrote: > >> >> On 29 Apr 2015, at 15:18, Sean P. DeNigris <sean(a)clipperadams.com> wrote: >> >> Natalia Tymchuk wrote >> >> Should it really be like that? >> >> >> The problem is that you can't have half-a-pixel if a dimension is odd >> >> >> Well, the methods is not called #centerPixel, nor is the class called >> PixelatedRectangle. Both #origin and #corner return not rounded values. And >> any way, I invite everyone to read the bug report by Tommaso, he described >> in a really nice way: >> https://pharo.fogbugz.com/f/cases/15445/Rectangle-center-not-really-a-cente… >> > > I thought so too, but if you read the class comment: > "I represent a rectangular area of the screen." > > So it seems designed for screen, and screen operates on whole pixels. > Thus there is no reason to round #origin or #corner because it will be > always integer (for screen). > > So maybe split into Rectangle (=An actual rectangle) without rounding and > ScreenRectangle? > > Peter > Yeah. But how old is that class comment? :) Rectangle>>aboveCenter is dated 2000. Rectangle>>center has no date. The world moves on.... so we can make it what we will. Simple naive fix... change the class comment (if indeed usage has moved on from assumption of a pixelated screen) So apart from working around class comments, what do we gain by having two types or Rectangles? cheers -ben

April 29, 2015

[Pharo5] Testers needed: AST based syntax highlighting

by Marcus Denker

Hi, We need some people to test using the AST based highlighter instead of Shout. SHRBTextStyler useAstColoring: true. I got some DNU but I canât reproduce it anymore. Marcus

April 29, 2015

Re: [Pharo-dev] Rectangle Center

by Nicolai Hess

2015-04-29 16:09 GMT+02:00 Ben Coman <btc(a)openinworld.com>: > > > On Wed, Apr 29, 2015 at 9:18 PM, Sean P. DeNigris <sean(a)clipperadams.com> > wrote: > >> Natalia Tymchuk wrote >> > Should it really be like that? >> >> The problem is that you can't have half-a-pixel if a dimension is odd >> >> >> > Will it be more applicable with the move to vector basis of Athens? > cheers -ben > > For athens, you'll have to make sure it is indeed a Float, and not a Fraction. (Some athens methods explicitly call #asFloat for their arguments - but not all).

April 29, 2015

Re: [Pharo-dev] [Reflectivity] MetaLinks with metalevel

by Clara Allende

Yay! This is super cool :) Thanks Marcus! 2015-04-29 11:21 GMT-03:00 Marcus Denker <marcus.denker(a)inria.fr>: > Hi, > > The next step: meta level support. > > Imagine you put a link in a method like OrderedCollection>>#add:, and then > the meta level itself class that method againâ¦ endless loop. > This e.g would happen easily if you would use a link to put a watch-point > somewhere... > > With this Slice: > > https://pharo.fogbugz.com/f/cases/15447/Links-with-MetaContext > > MetaLinks now can optionally model the meta-level: when calling a link, it > is increased. This happens only when setting a level explicitly > with #level: like here: > > link := MetaLink new > metaObject: <something>; > selector: #someSelector > level: 0. > > Keep in mind that it is fairly heavy, using a Process-Local variable. > > On the TODO: > > -> support for links on primitive methods (by wrapping them) > -> parameters for conditions > -> parameters for the method called on the meta object > -> âsymbolicâ meta objects #object, #node and #class > -> links on Slots > -> links on Globals > > and of course breakpoints, we have now everything already that we need. > > Marcus >

April 29, 2015

[Reflectivity] MetaLinks with metalevel

by Marcus Denker

Hi, The next step: meta level support. Imagine you put a link in a method like OrderedCollection>>#add:, and then the meta level itself class that method againâ¦ endless loop. This e.g would happen easily if you would use a link to put a watch-point somewhere... With this Slice: https://pharo.fogbugz.com/f/cases/15447/Links-with-MetaContext <https://pharo.fogbugz.com/f/cases/15447/Links-with-MetaContext> MetaLinks now can optionally model the meta-level: when calling a link, it is increased. This happens only when setting a level explicitly with #level: like here: link := MetaLink new metaObject: <something>; selector: #someSelector level: 0. Keep in mind that it is fairly heavy, using a Process-Local variable. On the TODO: -> support for links on primitive methods (by wrapping them) -> parameters for conditions -> parameters for the method called on the meta object -> âsymbolicâ meta objects #object, #node and #class -> links on Slots -> links on Globals and of course breakpoints, we have now everything already that we need. Marcus

April 29, 2015

Re: [Pharo-dev] Rectangle Center

by Peter UhnÃ¡k

On Wed, Apr 29, 2015 at 3:51 PM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > > On 29 Apr 2015, at 15:18, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > > Natalia Tymchuk wrote > > Should it really be like that? > > > The problem is that you can't have half-a-pixel if a dimension is odd > > > Well, the methods is not called #centerPixel, nor is the class called > PixelatedRectangle. Both #origin and #corner return not rounded values. And > any way, I invite everyone to read the bug report by Tommaso, he described > in a really nice way: > https://pharo.fogbugz.com/f/cases/15445/Rectangle-center-not-really-a-cente… > I thought so too, but if you read the class comment: "I represent a rectangular area of the screen." So it seems designed for screen, and screen operates on whole pixels. Thus there is no reason to round #origin or #corner because it will be always integer (for screen). So maybe split into Rectangle (=An actual rectangle) without rounding and ScreenRectangle? Peter

April 29, 2015

Re: [Pharo-dev] Rectangle Center

by Ben Coman

On Wed, Apr 29, 2015 at 9:18 PM, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > Natalia Tymchuk wrote > > Should it really be like that? > > The problem is that you can't have half-a-pixel if a dimension is odd > > > Will it be more applicable with the move to vector basis of Athens? cheers -ben

April 29, 2015

Re: [Pharo-dev] Class Comment Template Suggestion

by Ben Coman

+1 -- I always liked the first person feel I got from Smalltalk class comments. You might add something like comments should be written in "first person from the perspective of the class" -0.5 -- Maybe the third person CRC style is better for external documentation (?) cheers -ben On Wed, Apr 29, 2015 at 9:17 PM, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > The class comment template begins: "For the Class part: State the name of > the class with one line description: For example, I'm xxx the root of the > hierarchy of visitor objects." > > Unlike a traditional CRC card, we are already in a live programming > environment with good tools! So the class name is duplicated info (the > browser already shows this) which will have to be manually changed on a > class rename. Also, the specific example provides an implementation detail > duplicated by the class hierarchy tree already shown in the browser. I'd > like to change it to: "For the Class part: State a one line summary. For > example, "I represent a paragraph of text."" > > Any objections? > > > > ----- > Cheers, > Sean > -- > View this message in context: > http://forum.world.st/Class-Comment-Template-Suggestion-tp4822890.html > Sent from the Pharo Smalltalk Developers mailing list archive at > Nabble.com. > >

April 29, 2015

Re: [Pharo-dev] Rectangle Center

by Yuriy Tymchuk

> On 29 Apr 2015, at 15:18, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > > Natalia Tymchuk wrote >> Should it really be like that? > > The problem is that you can't have half-a-pixel if a dimension is odd Well, the methods is not called #centerPixel, nor is the class called PixelatedRectangle. Both #origin and #corner return not rounded values. And any way, I invite everyone to read the bug report by Tommaso, he described in a really nice way: https://pharo.fogbugz.com/f/cases/15445/Rectangle-center-not-really-a-cente… <https://pharo.fogbugz.com/f/cases/15445/Rectangle-center-not-really-a-cente…> Uko > > > > ----- > Cheers, > Sean > -- > View this message in context: http://forum.world.st/Rectangle-Center-tp4822883p4822891.html > Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com. >

April 29, 2015