- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Problem with changes?

by Martin Dias

I did some refactorings in .changes related code, but that was by June, I think. So... not me! :-) El sÃ¡b., 8 de agosto de 2015 15:02, Stephan Eggermont <stephan(a)stack.nl> escribiÃ³: > On 08/08/15 14:16, stepharo wrote: > > Hi > > > > since a couple of versions I have the impression that removing, adding a > > method, browsing a version is sloooooowwwww. > > Do you get the same feeling? > > Something is slow, at least in 50205 > > Stephan > > > >

Aug. 10, 2015

Re: [Pharo-dev] some questions about bloc

by stepharo

Thanks nicolai for all these questions. Writing more tests is cool. I started and each time alain imporved Bloc :) Alain is driving somwhere in vacation with nearly no internet. Stef > BlAlarmQueue > - split into two classes? > Queue : managing the add/remove/sort > Scheduler : process the Alarms > - alarm/alarmqueue both accessing and check the time "Time now" > I would put both checks to, either the alarm OR the queue/scheduler. > And don't use "Time now" explicit, if we put this behind a method > call, we > can easily create alarm queue mocs for unit tests. > - readding periodic alarms: shouldn't this be done by the alarm itself > - the queue should not care, whether a alarm is periodic. > > Some alarm examples put the queue into the morphs property dictionary. > I could find out why > this is necessary. > > > Layout: > Box/Column/Row Layout and corresponding cells define a double linked > list, we already > have a DoubleLinkedList, can we use the DoubleLinkedList instead of > reimplmenting this > on the layout/cells? Yes. > Tablelayout: is this "work in progress" or abandoned? Currently it > shares much code with > the BoxLayout, but it does not look like it is working. I think that this is more a work in progress. > > Theming: > #theme is a property of BlProtoView - isn't this to low level for > defining theming support? > How would you theme a CircleView or an ImageView? > > > Animation: > what are all these "Logics"? > animationLogic > toLogic > stepLogic and steppedLogic(!?) > ifLogic .... I would really like to see if Viva animation could be used in Bloc. StephaneDucasse / PetitsBazars > viva Alex used it for Roassal and this is nice but we need more experience and to check if it is compatible with the design of bloc. Is this a software pattern ? I have never seen this before. > (For example we use "sortBlock" but not "sortLogic"). > How about ValueHolder or good old "Block". > > And "ifLogic" sounds like a condition, why don't we name it. ... > condition? > And putting all this "logic" into one animation class scares me. > > > About the class comment syntax: > - is this pillar syntax? I think this is difficult to read. Do you use > that syntax, because we > want to use a pillar as comment text and build a renderer for this or > is it to share comments between class comments and the bloc doc book, > easily? yes. > I can help with documenting the classes but I find it difficult to see > which parts of bloc > are just tests/proof of concept or are supposed to be in the final > version. Maybe I miss the big picture? > What I can tell is that I tried several times and bloc changed at that time :) Now it is ***much*** more stable so this is the time to push. Did you read a bit the documentation we started on BlocCore? So having tests would be nice. I was planning to start to port some little classes I have around the game such as ledMorph and other to see how it goes. Stef

Aug. 10, 2015

Re: [Pharo-dev] some questions about bloc

by Stephan Eggermont

On 09/08/15 21:57, Nicolai Hess wrote: > But why dont we put this into a BlThemeableView ? > All subclasses of BlProtoView that want to support color or fillstyles, > now have a theme property too. > Why do they need a color property if the color is theme-dependent. Because the theme only provides default values (and reset to theme). Stephan

Aug. 9, 2015

Re: [Pharo-dev] some questions about bloc

by Nicolai Hess

2015-08-09 20:17 GMT+02:00 Aliaksei Syrel <alex.syrel(a)gmail.com>: > Hi > Thanks for your response. > Animation was copied from other project and has nothing to do with Bloc. > However, it is still there for a moment. BTW, example on the class side is > still morphic. > Yes, but it only works in a bloc world > Yes, it does not make any sense to theme CircleView and ImageView, but it > makes sense to theme their subclasses, like BrButtonView. Theming mechanism > is not integrated in Bloc for now. > But why dont we put this into a BlThemeableView ? All subclasses of BlProtoView that want to support color or fillstyles, now have a theme property too. Why do they need a color property if the color is theme-dependent. Btw. what is that strange hierarchy for BrButtonView: BlProtoView -> BlView -> BlEnclosedView -> BlRectangleView -> BlRoundedRectangleView -> BrRectangleView -> BrStringView -> BrButtonView A BlRectangleView, a RoundedRectangleView and a BrRectangleView? I think I don't understand bloc Cheers, > Alex > On Aug 9, 2015 7:29 PM, "Nicolai Hess" <nicolaihess(a)web.de> wrote: > >> BlAlarmQueue >> - split into two classes? >> Queue : managing the add/remove/sort >> Scheduler : process the Alarms >> - alarm/alarmqueue both accessing and check the time "Time now" >> I would put both checks to, either the alarm OR the queue/scheduler. >> And don't use "Time now" explicit, if we put this behind a method call, >> we >> can easily create alarm queue mocs for unit tests. >> - readding periodic alarms: shouldn't this be done by the alarm itself - >> the queue should not care, whether a alarm is periodic. >> >> Some alarm examples put the queue into the morphs property dictionary. I >> could find out why >> this is necessary. >> >> >> Layout: >> Box/Column/Row Layout and corresponding cells define a double linked >> list, we already >> have a DoubleLinkedList, can we use the DoubleLinkedList instead of >> reimplmenting this >> on the layout/cells? >> >> Tablelayout: is this "work in progress" or abandoned? Currently it shares >> much code with >> the BoxLayout, but it does not look like it is working. >> >> Theming: >> #theme is a property of BlProtoView - isn't this to low level for >> defining theming support? >> How would you theme a CircleView or an ImageView? >> >> >> Animation: >> what are all these "Logics"? >> animationLogic >> toLogic >> stepLogic and steppedLogic(!?) >> ifLogic .... >> >> Is this a software pattern ? I have never seen this before. >> (For example we use "sortBlock" but not "sortLogic"). >> How about ValueHolder or good old "Block". >> >> And "ifLogic" sounds like a condition, why don't we name it. ... >> condition? >> And putting all this "logic" into one animation class scares me. >> >> >> About the class comment syntax: >> - is this pillar syntax? I think this is difficult to read. Do you use >> that syntax, because we >> want to use a pillar as comment text and build a renderer for this or is >> it to share comments between class comments and the bloc doc book, easily? >> >> I can help with documenting the classes but I find it difficult to see >> which parts of bloc >> are just tests/proof of concept or are supposed to be in the final >> version. Maybe I miss the big picture? >> >> >> nicolai >> >> >> >> >> >>

Aug. 9, 2015

Re: [Pharo-dev] some questions about bloc

by Aliaksei Syrel

Hi Animation was copied from other project and has nothing to do with Bloc. However, it is still there for a moment. BTW, example on the class side is still morphic. Yes, it does not make any sense to theme CircleView and ImageView, but it makes sense to theme their subclasses, like BrButtonView. Theming mechanism is not integrated in Bloc for now. Cheers, Alex On Aug 9, 2015 7:29 PM, "Nicolai Hess" <nicolaihess(a)web.de> wrote: > BlAlarmQueue > - split into two classes? > Queue : managing the add/remove/sort > Scheduler : process the Alarms > - alarm/alarmqueue both accessing and check the time "Time now" > I would put both checks to, either the alarm OR the queue/scheduler. > And don't use "Time now" explicit, if we put this behind a method call, > we > can easily create alarm queue mocs for unit tests. > - readding periodic alarms: shouldn't this be done by the alarm itself - > the queue should not care, whether a alarm is periodic. > > Some alarm examples put the queue into the morphs property dictionary. I > could find out why > this is necessary. > > > Layout: > Box/Column/Row Layout and corresponding cells define a double linked list, > we already > have a DoubleLinkedList, can we use the DoubleLinkedList instead of > reimplmenting this > on the layout/cells? > > Tablelayout: is this "work in progress" or abandoned? Currently it shares > much code with > the BoxLayout, but it does not look like it is working. > > Theming: > #theme is a property of BlProtoView - isn't this to low level for defining > theming support? > How would you theme a CircleView or an ImageView? > > > Animation: > what are all these "Logics"? > animationLogic > toLogic > stepLogic and steppedLogic(!?) > ifLogic .... > > Is this a software pattern ? I have never seen this before. > (For example we use "sortBlock" but not "sortLogic"). > How about ValueHolder or good old "Block". > > And "ifLogic" sounds like a condition, why don't we name it. ... condition? > And putting all this "logic" into one animation class scares me. > > > About the class comment syntax: > - is this pillar syntax? I think this is difficult to read. Do you use > that syntax, because we > want to use a pillar as comment text and build a renderer for this or is > it to share comments between class comments and the bloc doc book, easily? > > I can help with documenting the classes but I find it difficult to see > which parts of bloc > are just tests/proof of concept or are supposed to be in the final > version. Maybe I miss the big picture? > > > nicolai > > > > > >

Aug. 9, 2015

some questions about bloc

by Nicolai Hess

BlAlarmQueue - split into two classes? Queue : managing the add/remove/sort Scheduler : process the Alarms - alarm/alarmqueue both accessing and check the time "Time now" I would put both checks to, either the alarm OR the queue/scheduler. And don't use "Time now" explicit, if we put this behind a method call, we can easily create alarm queue mocs for unit tests. - readding periodic alarms: shouldn't this be done by the alarm itself - the queue should not care, whether a alarm is periodic. Some alarm examples put the queue into the morphs property dictionary. I could find out why this is necessary. Layout: Box/Column/Row Layout and corresponding cells define a double linked list, we already have a DoubleLinkedList, can we use the DoubleLinkedList instead of reimplmenting this on the layout/cells? Tablelayout: is this "work in progress" or abandoned? Currently it shares much code with the BoxLayout, but it does not look like it is working. Theming: #theme is a property of BlProtoView - isn't this to low level for defining theming support? How would you theme a CircleView or an ImageView? Animation: what are all these "Logics"? animationLogic toLogic stepLogic and steppedLogic(!?) ifLogic .... Is this a software pattern ? I have never seen this before. (For example we use "sortBlock" but not "sortLogic"). How about ValueHolder or good old "Block". And "ifLogic" sounds like a condition, why don't we name it. ... condition? And putting all this "logic" into one animation class scares me. About the class comment syntax: - is this pillar syntax? I think this is difficult to read. Do you use that syntax, because we want to use a pillar as comment text and build a renderer for this or is it to share comments between class comments and the bloc doc book, easily? I can help with documenting the classes but I find it difficult to see which parts of bloc are just tests/proof of concept or are supposed to be in the final version. Maybe I miss the big picture? nicolai

Aug. 9, 2015

Re: [Pharo-dev] [Vm-dev] Re: pharo 4.0 Crashed in the VM thread again

by Nicolai Hess

Pharo or Squeak ? In squeak, this stackframe / large stackframe bug was introduced some months ago by a change for the compiler but it is already fixed. In pharo, we have a simliar bug (in pharos compiler (opal), not related to the change on the squeak compiler). This is a bug that is known but not yet fixed 13854 <https://pharo.fogbugz.com/default.asp?13854> frameSize calculated wrongly for #lineSegmentsDo: ! 2015-08-09 18:39 GMT+02:00 tim Rowledge <tim(a)rowledge.org>: > > Sabine, > As a general rule of thumb, if a method is too long to see at a glance - > in practice this means too long to fit on your screen - then it almost > certainly needs splitting up. I have been forcibly reminded of this a lot > recently due to having to decode insanely long Python routines; seriously - > 1100 lines for a single function? > > tim > -- > tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim > Strange OpCodes: FSRA: Forms Skip and Run-Away > > >

Aug. 9, 2015

StandardFileStream deprecated? DnD from file system

by Stephan Eggermont

Why is StandardFileStream in Files-Deprecated? And how am I supposed to replace it? It has the only sender of <primitive: 'primitiveDropRequestFileHandle' module:'DropPlugin'> Stephan

Aug. 9, 2015

[pharo-project/pharo-core] 7f1136: 50216

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 7f11369599deba3b96f98631602790a86c96b9a8 https://github.com/pharo-project/pharo-core/commit/7f11369599deba3b96f98631… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-08-09 (Sun, 09 Aug 2015) Changed paths: M AST-Core.package/BIConfigurableFormatter.class/class/accessing/traditionalBinaryPrecedence.st M AST-Core.package/BIConfigurableFormatter.class/class/settings/settingsOn_.st R AST-Core.package/BIConfigurableFormatter.class/instance/accessing/traditionalBinaryPrecedence.st A AST-Core.package/BIConfigurableFormatter.class/instance/accessing/traditionalBinaryPrecedenceArray.st M AST-Core.package/BIConfigurableFormatter.class/instance/private/formattedSourceFor_.st M AST-Core.package/BIConfigurableFormatter.class/instance/private/handleLineForSelector_withSeparatorBlock_.st M AST-Core.package/BIConfigurableFormatter.class/instance/private/precedenceOf_greaterThan_.st M AST-Core.package/BIConfigurableFormatter.class/instance/visiting/visitBlockNode_.st R AST-Core.package/BIPrettyPrinterContext.class/instance/accessing/traditionalBinaryPrecedence.st A AST-Core.package/BIPrettyPrinterContext.class/instance/accessing/traditionalBinaryPrecedenceArray.st A AST-Core.package/BISimpleFormatter.class/README.md A AST-Core.package/BISimpleFormatter.class/class/initialization/formatAsYouReadPolicy.st A AST-Core.package/BISimpleFormatter.class/class/initialization/formatAsYouReadPolicy_.st A AST-Core.package/BISimpleFormatter.class/class/initialization/initialize.st A AST-Core.package/BISimpleFormatter.class/class/public/format_.st A AST-Core.package/BISimpleFormatter.class/class/public/format_withIndents_.st A AST-Core.package/BISimpleFormatter.class/definition.st A AST-Core.package/BISimpleFormatter.class/instance/accessing/codeStream.st A AST-Core.package/BISimpleFormatter.class/instance/accessing/codeStream_.st A AST-Core.package/BISimpleFormatter.class/instance/accessing/indent.st A AST-Core.package/BISimpleFormatter.class/instance/accessing/indentString.st A AST-Core.package/BISimpleFormatter.class/instance/accessing/indent_.st A AST-Core.package/BISimpleFormatter.class/instance/accessing/lineStart.st A AST-Core.package/BISimpleFormatter.class/instance/accessing/lineStart_.st A AST-Core.package/BISimpleFormatter.class/instance/accessing/traditionalBinaryPrecedenceArray.st A AST-Core.package/BISimpleFormatter.class/instance/initialization/initialize.st A AST-Core.package/BISimpleFormatter.class/instance/private-formatting/formatArray_.st A AST-Core.package/BISimpleFormatter.class/instance/private-formatting/formatBlockArgumentsFor_.st A AST-Core.package/BISimpleFormatter.class/instance/private-formatting/formatBlock_.st A AST-Core.package/BISimpleFormatter.class/instance/private-formatting/formatCommentsFor_.st A AST-Core.package/BISimpleFormatter.class/instance/private-formatting/formatMethodBodyFor_.st A AST-Core.package/BISimpleFormatter.class/instance/private-formatting/formatMethodCommentFor_.st A AST-Core.package/BISimpleFormatter.class/instance/private-formatting/formatMethodPatternFor_.st A AST-Core.package/BISimpleFormatter.class/instance/private-formatting/formatPragmasFor_.st A AST-Core.package/BISimpleFormatter.class/instance/private-formatting/formatSelectorAndArguments_.st A AST-Core.package/BISimpleFormatter.class/instance/private-formatting/formatSelectorAndArguments_firstSeparator_restSeparator_.st A AST-Core.package/BISimpleFormatter.class/instance/private-formatting/formatSequenceNodeStatementsFor_.st A AST-Core.package/BISimpleFormatter.class/instance/private-formatting/formatStatementCommentsFor_.st A AST-Core.package/BISimpleFormatter.class/instance/private/basicFormatCommentFor_.st A AST-Core.package/BISimpleFormatter.class/instance/private/bracketWith_around_.st A AST-Core.package/BISimpleFormatter.class/instance/private/formatTemporariesFor_.st A AST-Core.package/BISimpleFormatter.class/instance/private/formattedSourceFor_.st A AST-Core.package/BISimpleFormatter.class/instance/private/handleLineForArgument_.st A AST-Core.package/BISimpleFormatter.class/instance/private/indentAround_.st A AST-Core.package/BISimpleFormatter.class/instance/private/indent_around_.st A AST-Core.package/BISimpleFormatter.class/instance/private/needsParenthesisFor_.st A AST-Core.package/BISimpleFormatter.class/instance/private/newLine.st A AST-Core.package/BISimpleFormatter.class/instance/private/newLines_.st A AST-Core.package/BISimpleFormatter.class/instance/private/precedenceOf_greaterThan_.st A AST-Core.package/BISimpleFormatter.class/instance/private/privateFormatMethodPatternMonoLineFor_.st A AST-Core.package/BISimpleFormatter.class/instance/private/space.st A AST-Core.package/BISimpleFormatter.class/instance/private/writeString_.st A AST-Core.package/BISimpleFormatter.class/instance/public interface/containerWidth_.st A AST-Core.package/BISimpleFormatter.class/instance/public interface/format_.st A AST-Core.package/BISimpleFormatter.class/instance/utility/with_and_do_separatedBy_.st A AST-Core.package/BISimpleFormatter.class/instance/visiting/visitArrayNode_.st A AST-Core.package/BISimpleFormatter.class/instance/visiting/visitAssignmentNode_.st A AST-Core.package/BISimpleFormatter.class/instance/visiting/visitBlockNode_.st A AST-Core.package/BISimpleFormatter.class/instance/visiting/visitCascadeNode_.st A AST-Core.package/BISimpleFormatter.class/instance/visiting/visitLiteralArrayNode_.st A AST-Core.package/BISimpleFormatter.class/instance/visiting/visitLiteralNode_.st A AST-Core.package/BISimpleFormatter.class/instance/visiting/visitMessageNode_.st A AST-Core.package/BISimpleFormatter.class/instance/visiting/visitMethodNode_.st A AST-Core.package/BISimpleFormatter.class/instance/visiting/visitNode_.st A AST-Core.package/BISimpleFormatter.class/instance/visiting/visitPatternBlockNode_.st A AST-Core.package/BISimpleFormatter.class/instance/visiting/visitPatternWrapperBlockNode_.st A AST-Core.package/BISimpleFormatter.class/instance/visiting/visitPragmaNode_.st A AST-Core.package/BISimpleFormatter.class/instance/visiting/visitReturnNode_.st A AST-Core.package/BISimpleFormatter.class/instance/visiting/visitSequenceNode_.st A AST-Core.package/BISimpleFormatter.class/instance/visiting/visitVariableNode_.st M AST-Core.package/RBNullFormatter.class/README.md M AST-Core.package/RBNullFormatter.class/definition.st A AST-Tests-Core.package/RBFormatterTest.class/README.md A AST-Tests-Core.package/RBFormatterTest.class/definition.st A AST-Tests-Core.package/RBFormatterTest.class/instance/private/formatClass_.st A AST-Tests-Core.package/RBFormatterTest.class/instance/private/formatClass_selector_.st A AST-Tests-Core.package/RBFormatterTest.class/instance/private/formatterClass.st A AST-Tests-Core.package/RBFormatterTest.class/instance/testing/testCoreSystem.st A BlueInk-Tests.package/BIConfigurableFormatterFormattingTest.class/README.md A BlueInk-Tests.package/BIConfigurableFormatterFormattingTest.class/class/as yet unclassified/shouldInheritSelectors.st A BlueInk-Tests.package/BIConfigurableFormatterFormattingTest.class/definition.st A BlueInk-Tests.package/BIConfigurableFormatterFormattingTest.class/instance/default/formatterClass.st R BlueInk-Tests.package/BIFormatterTests.class/README.md R BlueInk-Tests.package/BIFormatterTests.class/definition.st R BlueInk-Tests.package/BIFormatterTests.class/instance/private/formatClass_.st R BlueInk-Tests.package/BIFormatterTests.class/instance/private/formatClass_selector_.st R BlueInk-Tests.package/BIFormatterTests.class/instance/testing/testCoreSystem.st M Nautilus.package/AbstractNautilusUI.class/instance/accessing/showInstance_.st M Polymorph-Widgets.package/MorphicUIManager.class/instance/ui requests/edit_label_accept_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50215.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50216.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50215.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50216.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Spec-Core.package/LabelModel.class/instance/api/emphasis_.st M Spec-Core.package/LabelModel.class/instance/initialization/initialize.st A Spec-Core.package/LabelModel.class/instance/private/emphasisDepractedFor_.st A Spec-Core.package/LabelModel.class/instance/private/emphasisForCode_.st M Spec-Core.package/TreeModel.class/instance/initialization/registerEvents.st M Spec-MorphicAdapters.package/MorphicLabelAdapter.class/definition.st M Spec-MorphicAdapters.package/MorphicLabelAdapter.class/instance/factory/buildWidget.st A Spec-MorphicAdapters.package/MorphicLabelAdapter.class/instance/spec protocol/emphasisCodeFor_.st A Spec-MorphicAdapters.package/MorphicLabelAdapter.class/instance/spec protocol/emphasisOptions.st M Spec-MorphicAdapters.package/MorphicLabelAdapter.class/instance/spec protocol/emphasis_.st M Spec-MorphicAdapters.package/MorphicTreeAdapter.class/instance/factory/buildWidget.st A Spec-MorphicAdapters.package/MorphicTreeAdapter.class/instance/widget API/evenRowColor_.st M Spec-MorphicAdapters.package/MorphicTreeAdapter.class/instance/widget API/oddRowColor_.st A Spec-Tests.package/MorphicTreeAdapterTest.class/README.md A Spec-Tests.package/MorphicTreeAdapterTest.class/definition.st A Spec-Tests.package/MorphicTreeAdapterTest.class/instance/accessing/modelClass.st A Spec-Tests.package/MorphicTreeAdapterTest.class/instance/running/setUp.st A Spec-Tests.package/MorphicTreeAdapterTest.class/instance/running/testDefaultRowColors.st A Spec-Tests.package/MorphicTreeAdapterTest.class/instance/running/testRowColorsAfterBuild.st A Spec-Tests.package/MorphicTreeAdapterTest.class/instance/running/testRowColorsBeforeBuild.st M UIManager.package/DummyUIManager.class/instance/ui requests/edit_label_accept_.st M UIManager.package/NonInteractiveUIManager.class/instance/ui requests/edit_label_accept_.st M UIManager.package/UIManager.class/instance/ui requests/edit_label_accept_.st Log Message: ----------- 50216 15305 LabelModel emphasis: is bad https://pharo.fogbugz.com/f/cases/15305 15489 Switching to class side with modified class comment https://pharo.fogbugz.com/f/cases/15489 15365 Spec TreeModel support for odd/even row color https://pharo.fogbugz.com/f/cases/15365 16113 SimpleFormatter https://pharo.fogbugz.com/f/cases/16113 16127 Remove PluggableTextMorph from edit:label:action: https://pharo.fogbugz.com/f/cases/16127 http://files.pharo.org/image/50/50216.zip

Aug. 9, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50216 Home: https://github.com/pharo-project/pharo-core

Aug. 9, 2015