- Pharo-dev - lists.pharo.org

Cleaning up Locale, LanguageEnvironment and EncodedCharSet

by Guillermo Polito

Hi guys, I was having a deep look today at Locale, LanguageEnvironment and EncodedCharset with the objective of understanding it and see how we can organize it better. As I saw, in almost all cases, it happened that the locale and language environment are only used to get the current system's encoding. Even, it is not that the system's encoding is obtained from the system's configuration but guessed. Also, I saw that the usage of leadingCharacter is very limited in the image and I'd say that most of the time we would not be using it: we will be using unicode. I proposed in the issue tracker a change in three steps that cleans up this: - Cleaning Locale's API ( https://pharo.fogbugz.com/f/cases/16379/Cleanup-Locale-API) - Fix users to make use of this new API ( https://pharo.fogbugz.com/f/cases/16380/Make-use-of-new-Locale-API) - Remove old unused code ( https://pharo.fogbugz.com/f/cases/16381/Removed-unused-Locale-code) I know that with this change we lose temporarily the ability to use other language environments (like greek or japanese), and thus, change to other system encodings that are not UTF8/16/32. However, I believe that we should not 'guess' the system converter from the system language but to ask the system the encoding it is using. And this should maybe be added as a primitive (as the others already existing in the Locale class for example). If somebody could review these issues or has some comment on something that I should not be aware of, I'd be grateful :). Guille

Aug. 25, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50269 Home: https://github.com/pharo-project/pharo-core

Aug. 25, 2015

[pharo-project/pharo-core] c65815: 50269

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: c65815c1b891362831d8c1c36f08e35f7c6d8e12 https://github.com/pharo-project/pharo-core/commit/c65815c1b891362831d8c1c3… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-08-25 (Tue, 25 Aug 2015) Changed paths: M RecentSubmissions.package/RecentMessageList.class/instance/userinterface/open.st M Refactoring-Critics.package/RBModifiesCollectionRule.class/instance/private/modifiesTree_in_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50268.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50269.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50268.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50269.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Slot.package/TemporaryVariable.class/instance/comparing/hash.st M Slot.package/TemporaryVariable.class/instance/properties/ensureProperties.st M Slot.package/TemporaryVariable.class/instance/properties/removePropertiesIfEmpty.st M Spec-Tools.package/MessageBrowser.class/instance/accessing/selectedMethod.st Log Message: ----------- 50269 16131 RBModifiesCollectionRule breaks methods AST when checking https://pharo.fogbugz.com/f/cases/16131 16363 Context menu in Recent Messages broken when empty https://pharo.fogbugz.com/f/cases/16363 16365 Make properties on TemporaryVariable persistent https://pharo.fogbugz.com/f/cases/16365 16364 Typo in Recent message browser title https://pharo.fogbugz.com/f/cases/16364 http://files.pharo.org/image/50/50269.zip

Aug. 25, 2015

[Issue Tracker] reviews needed

by Marcus Denker

Hi, There are 9 fixed issues that need to be reviewed: https://pharo.fogbugz.com/f/filters/36/Fixed-to-Review Marcus

Aug. 25, 2015

Re: [Pharo-dev] [pharo-project/pharo-core] 0fcec8: 50268

by Sven Van Caekenberghe

> On 25 Aug 2015, at 09:02, GitHub <noreply(a)github.com> wrote: > > Branch: refs/heads/5.0 > Home: https://github.com/pharo-project/pharo-core > Commit: 0fcec817446e17a206d940cb67ae2d138df16bb4 > https://github.com/pharo-project/pharo-core/commit/0fcec817446e17a206d940cb… > Author: Jenkins Build Server <board(a)pharo-project.org> > Date: 2015-08-25 (Tue, 25 Aug 2015) > > Changed paths: > M Ring-Monticello.package/extension/RGMethodDefinition/instance/sameAsMCDefinition_.st YES! Thank you! > R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50267.st > A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50268.st > R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50267.st > A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50268.st > M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st > > Log Message: > ----------- > 50268 > 16358 Can not commit three changed method to class TemporaryVariable > https://pharo.fogbugz.com/f/cases/16358 > > http://files.pharo.org/image/50/50268.zip > >

Aug. 25, 2015

Re: [Pharo-dev] Strange Monticello bug: methods are not saved

by Thierry Goubier

2015-08-25 8:19 GMT+02:00 Nicolai Hess <nicolaihess(a)web.de>: > > > 2015-08-24 18:21 GMT+02:00 stepharo <stepharo(a)free.fr>: > >> This is really nice to have people like you guys around. >> This is a really nice example where the sum is more than its elements >> >> Stef >> >> Le 24/8/15 16:44, Thierry Goubier a Ã©crit : >> >> >> >> 2015-08-24 16:32 GMT+02:00 Marcus Denker <marcus.denker(a)inria.fr>: >> >>> > >>> > solves loading Sven test packages. Marcus, can you try on yours? >>> > >>> >>> Yes! Very good! >>> >>> >> Slice pushed to 16358. We'll see what the tests say. >> >> Why has it started to fail? All the involved code is old. >> >> Thierry >> >> >>> Marcus >>> >>> >>> >> >> > Great, Thierrys solution works. > > But I think there is still a problem with RGMethodDefinition. We call > self compiledMethod > on a RGMethodDefintion, the implementation *always* returns the compiled > method from the system, if > it exists (regardless whether this ring method is active or not). > > I think we should either > - don't call #compiledMethod on ring definitions > - always return nil for not active definitions > - for non active definitions: create a compiled method on demand > > what do you think? > It depends what we want Ring to be. If it is a replacement to MCDefinition and all, then it must handle non-active methods. If it models the live system as well, then it must answers compiledMethod. I would choose return nil or return an exception. Third one could be interesting in some contexts... running packages without loading them. But would be hard to do correctly. Thierry > > > > >

Aug. 25, 2015

Re: [Pharo-dev] Nautilus and Work group

by Yuriy Tymchuk

Would be cool if from Pharo launcher you could specify the configuration that you want to work with and a version of faro, then it would download an image, load there a configuration, and put loaded packages into a work group. Uko > On 25 Aug 2015, at 09:52, Torsten Bergmann <astares(a)gmx.de> wrote: > > Nautilus in Pharo 5 now includes per default a group "Configuration" > and "Work". > > But one has to manually put new work into the "Work" group. Would it > make sense to put newly created packages automagically into this > group as typically one is working on them? > > > >

Aug. 25, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50268 Home: https://github.com/pharo-project/pharo-core

Aug. 25, 2015

[pharo-project/pharo-core] 0fcec8: 50268

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 0fcec817446e17a206d940cb67ae2d138df16bb4 https://github.com/pharo-project/pharo-core/commit/0fcec817446e17a206d940cb… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-08-25 (Tue, 25 Aug 2015) Changed paths: M Ring-Monticello.package/extension/RGMethodDefinition/instance/sameAsMCDefinition_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50267.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50268.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50267.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50268.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50268 16358 Can not commit three changed method to class TemporaryVariable https://pharo.fogbugz.com/f/cases/16358 http://files.pharo.org/image/50/50268.zip

Aug. 25, 2015

Nautilus and Work group

by Torsten Bergmann

Nautilus in Pharo 5 now includes per default a group "Configuration" and "Work". But one has to manually put new work into the "Work" group. Would it make sense to put newly created packages automagically into this group as typically one is working on them?

Aug. 25, 2015