- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] QANautilusPluggin Logic Question

by stepharo

marcus could you log that issue somewhere because I hope that we will get a new Phd working update. Stef Le 30/8/15 18:29, Marcus Denker a Ã©crit : > Hi, > > All methods (and methods of blocks) that are executing already will keep executing the wrong code. > > As only offsets change, one could do on-stack replacement of these methods, but nobody has implemented that > yet. > > It might be good to have a check that warns when changing layout of classes that are active on the stackâ¦. > >> On 30 Aug 2015, at 14:49, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: >> >> Yes, but the situation is weird, because if you look at the variable in the debugger - everything is ok. Is there a way to understand what has not mutated? >> >> Uko >> >> >>> On 30 Aug 2015, at 13:35, stepharo <stepharo(a)free.fr> wrote: >>> >>> may be code executing the check did not get mutated when the system changed shape. >>> >>> Le 30/8/15 11:00, Marcus Denker a Ã©crit : >>>>> On 30 Aug 2015, at 10:57, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: >>>>> >>>>> So the byte symbol comes from the âpositionâ inst var of the superclass. Iâm not completely sure how it works on low level, but I guess that because you a a new variable, the others shift and it accesses the value that is actually mapped to another variable. Is it the issue of my implementation? How can I improve it? >>>>> >>>> The class builder is normally supposed to fix that transparently: You add var, all methods are recompiled and all instances are migrated. There could be bugs there. >>>> >>>>> Uko >>>>> >>>>>> On 28 Aug 2015, at 10:50, stepharo <stepharo(a)free.fr> wrote: >>>>>> >>>>>> When I add an iv to Model I get a ByteSymbol>>entity: >>>>>> >>>>>> QANautilusPluggin>>initialize >>>>>> >>>>>> changeHandler := GLMAsyncTask new >>>>>> priority: Processor activePriority - 1; >>>>>> doInBackground: [ morph entity: self currentEntity ]; >>>>>> yourself >>>>>> >>>>>> And in the debugger morph is a a Morph exactly a QANautilusPluginMorph(493092864) >>>>>> >>>>>> Yuriy do you use thread? >>>>>> >>>>>> Stef >>>>>> >>>>>> >>>>>> >>>> >>> >> > >

Sept. 2, 2015

Re: [Pharo-dev] feedback from J Brant

by stepharo

To have fun I addressed - https://pharo.fogbugz.com/f/cases/16460/I-fileout-a-package-does-not-fileou… but it should be checked. - https://pharo.fogbugz.com/f/cases/16461/ChunkFileParser and introduced hooks. Now back to coding for real. Stef Le 2/9/15 20:28, stepharo a Ã©crit : > Hi guys > > here is some feedback from John. I share it with you. > > > On 02 Sep 2015, at 16:05, John Brant <brant(a)refactoryworkers.com> wrote: > > I've been writing some automated scripts to port SmaCC to Pharo. I > have it where I can file in the Dolphin .pac files directly into a > Pharo 5 image. Most things are working, but I've had to fight some > Pharo issues. Since I wasn't sure who should be notified, I thought > I'd complain to you :) > > > :) if you would see my list of complaints about Pharo you would > laugh a lot because it is huge and diverse. > I put thierry on CC because he is the guy maintaining and using > SmaCC a lot. > So may be you can help each others. > > > *) The BIConfigurableFormatter (aka RBConfigurableFormatter) sends > #asString to nodes. First, it should format the node if it wants them > formatted instead of relying on asString to return a formatted string. > Second, by sending #asString, formatting has become exponential in the > nesting level of blocks. For example, Dolphin Smalltalk runs this in 4 > milliseconds: > > | stream | > stream := WriteStream on: String new. > stream nextPutAll: 'foo ^true and: '. > 40 timesRepeat: [stream nextPutAll: '[true and: ']. > stream nextPutAll: 'false'. > 40 timesRepeat: [stream nextPut: $]]. > (RBParser parseMethod: stream contents) formattedCode > > I'm guessing that Pharo wouldn't finish in a day... It takes over 4 > seconds to format 16 nested blocks. > > Thanks indeed we will fix it. > https://pharo.fogbugz.com/f/cases/16462/BIConfigurableFormatter-should-not-… > > > > *) Also on the formatter, its default doesn't appear to be compliant > with Kent's blocks should look like blocks/rectangles/box rule. The > way I interpret the rule is that if I draw a rectangle around > everything in the block including the brackets, it should not include > any text of anything outside of the block. For example, this would > fail that test: > > surroundedBy: aString > ^ self class > streamContents: [ :s | > s nextPutAll: aString. > s nextPutAll: self. > s nextPutAll: aString ] > > yes > > > Since the block starts at the end of the #streamContents: line, a > rectangle around all the contents in the block contains part of the > #streamContents: selector which isn't part of the block. > > I do not really like all the formattings of kent. Because > sometimes it just does not work. > But this is why we ask franck (an interns to start to have a look). > > For example I do not like > > self xxx > ifTrue: > [ > self bla > self foo. > > in the current default formatter. > and I prefer > > self xxx > ifTrue: [ self bla. > self foo > But here the problem is that the self foo is not tab aligned > because ifTrue: [ > > self xxx > ifTrue: > [ self bla. > self foo > > So may be this one is a nice compromise > I think that we should change some settings. In fact in alpha > things are there to evolve until the release :) > > > > *) If I fileout a package, it doesn't fileout the metaclass extension > methods. The RPackage>>fileOut method needs to be updated with the > metaclassExtensionSelectors. > > Oops this is a bug. > Do you mean what I mean? the extensions done by the package on > metaclass that are not in the package. > > https://pharo.fogbugz.com/f/cases/16460/I-fileout-a-package-does-not-fileou… > > > > *) On windows, it appears that while the menus say Ctrl+..., they > really mean Ctrl+... or Alt+... -- you figure it out. > > Yes it sucks. We are in flux with the key essentially because the > VM often does not even gives us the correct information. > With the new OSWindow architecture we are putting in place we will > have all the events and not just the one the VM does not eat (like > shift pressed) > and we can manage all at the image level not deep into arcane and > old C- code. > > > *) It appears that Pharo is removing subString: in favor of > substring:. The ANSI standard defines subString:. > > I was not aware of it. In fact ANSI is bad and totally incomplete > (for example we studies strings and this is a mess and totally > incomplete). > Now we should probably add it. I will send the mail to the > mailing-list and let people decide. > > > > > *) The ChunkFileFormatParser>>parseNextDeclaration is hard coded to > handle only the Pharo format: > | substrings | > substrings := nextChunk parseLiterals. > (substrings includes: 'methodsFor:') > ifTrue: [ ^self parseMethodDeclarations: substrings ]. > (substrings includes: 'commentStamp:') > ifTrue: [ ^self parseCommentDeclaration: substrings ]. > (substrings includes: 'reorganize') > ifTrue: [ ^self parseClassOrganization: substrings ]. > Due to the hard coded nature of the types of strings accepted, I have > to overwrite this method to be able to file in Dolphin code. In the > other Smalltalk's, I can write an extension method or two that I use > to file in another dialect's code. > > https://pharo.fogbugz.com/f/cases/16461/ChunkFileParser > > If you have a solution please send it. Because we are focusing on > the bootstrap and spur the new object format plus a new FFI. Plus > a lot more. > So this keeps us really busy and many people left the team and we > are restarting to teach :) > > I personally hate this format and the hardcoding of these strings > and selectors everywhere so this is why the ChunkFileFormatParser > is already > a big step forward. > > > > I have several other things that annoy me, > > me too :) > But I tried that every couple of days I fix one. > > > but this is enough for now. :) > > Tx john :) > > > > John Brant > > -------------------------------------------- > StÃ©phane Ducasse > http://stephane.ducasse.free.fr > http://www.synectique.eu / http://www.pharo.org > 03 59 35 87 52 > Assistant: Julie Jonas > 03 59 57 78 50 > 03 59 35 86 16 > > S. Ducasse - Inria > 40, avenue Halley, > Parc Scientifique de la Haute Borne, BÃ¢t.A, Park Plaza > Villeneuve d'Ascq 59650 > France >

Sept. 2, 2015

feedback from J Brant

by stepharo

Hi guys here is some feedback from John. I share it with you. On 02 Sep 2015, at 16:05, John Brant <brant(a)refactoryworkers.com> wrote: I've been writing some automated scripts to port SmaCC to Pharo. I have it where I can file in the Dolphin .pac files directly into a Pharo 5 image. Most things are working, but I've had to fight some Pharo issues. Since I wasn't sure who should be notified, I thought I'd complain to you :) :) if you would see my list of complaints about Pharo you would laugh a lot because it is huge and diverse. I put thierry on CC because he is the guy maintaining and using SmaCC a lot. So may be you can help each others. *) The BIConfigurableFormatter (aka RBConfigurableFormatter) sends #asString to nodes. First, it should format the node if it wants them formatted instead of relying on asString to return a formatted string. Second, by sending #asString, formatting has become exponential in the nesting level of blocks. For example, Dolphin Smalltalk runs this in 4 milliseconds: | stream | stream := WriteStream on: String new. stream nextPutAll: 'foo ^true and: '. 40 timesRepeat: [stream nextPutAll: '[true and: ']. stream nextPutAll: 'false'. 40 timesRepeat: [stream nextPut: $]]. (RBParser parseMethod: stream contents) formattedCode I'm guessing that Pharo wouldn't finish in a day... It takes over 4 seconds to format 16 nested blocks. Thanks indeed we will fix it. https://pharo.fogbugz.com/f/cases/16462/BIConfigurableFormatter-should-not-… *) Also on the formatter, its default doesn't appear to be compliant with Kent's blocks should look like blocks/rectangles/box rule. The way I interpret the rule is that if I draw a rectangle around everything in the block including the brackets, it should not include any text of anything outside of the block. For example, this would fail that test: surroundedBy: aString ^ self class streamContents: [ :s | s nextPutAll: aString. s nextPutAll: self. s nextPutAll: aString ] yes Since the block starts at the end of the #streamContents: line, a rectangle around all the contents in the block contains part of the #streamContents: selector which isn't part of the block. I do not really like all the formattings of kent. Because sometimes it just does not work. But this is why we ask franck (an interns to start to have a look). For example I do not like self xxx ifTrue: [ self bla self foo. in the current default formatter. and I prefer self xxx ifTrue: [ self bla. self foo But here the problem is that the self foo is not tab aligned because ifTrue: [ self xxx ifTrue: [ self bla. self foo So may be this one is a nice compromise I think that we should change some settings. In fact in alpha things are there to evolve until the release :) *) If I fileout a package, it doesn't fileout the metaclass extension methods. The RPackage>>fileOut method needs to be updated with the metaclassExtensionSelectors. Oops this is a bug. Do you mean what I mean? the extensions done by the package on metaclass that are not in the package. https://pharo.fogbugz.com/f/cases/16460/I-fileout-a-package-does-not-fileou… *) On windows, it appears that while the menus say Ctrl+..., they really mean Ctrl+... or Alt+... -- you figure it out. Yes it sucks. We are in flux with the key essentially because the VM often does not even gives us the correct information. With the new OSWindow architecture we are putting in place we will have all the events and not just the one the VM does not eat (like shift pressed) and we can manage all at the image level not deep into arcane and old C- code. *) It appears that Pharo is removing subString: in favor of substring:. The ANSI standard defines subString:. I was not aware of it. In fact ANSI is bad and totally incomplete (for example we studies strings and this is a mess and totally incomplete). Now we should probably add it. I will send the mail to the mailing-list and let people decide. *) The ChunkFileFormatParser>>parseNextDeclaration is hard coded to handle only the Pharo format: | substrings | substrings := nextChunk parseLiterals. (substrings includes: 'methodsFor:') ifTrue: [ ^self parseMethodDeclarations: substrings ]. (substrings includes: 'commentStamp:') ifTrue: [ ^self parseCommentDeclaration: substrings ]. (substrings includes: 'reorganize') ifTrue: [ ^self parseClassOrganization: substrings ]. Due to the hard coded nature of the types of strings accepted, I have to overwrite this method to be able to file in Dolphin code. In the other Smalltalk's, I can write an extension method or two that I use to file in another dialect's code. https://pharo.fogbugz.com/f/cases/16461/ChunkFileParser If you have a solution please send it. Because we are focusing on the bootstrap and spur the new object format plus a new FFI. Plus a lot more. So this keeps us really busy and many people left the team and we are restarting to teach :) I personally hate this format and the hardcoding of these strings and selectors everywhere so this is why the ChunkFileFormatParser is already a big step forward. I have several other things that annoy me, me too :) But I tried that every couple of days I fix one. but this is enough for now. :) Tx john :) John Brant -------------------------------------------- StÃ©phane Ducasse http://stephane.ducasse.free.fr http://www.synectique.eu / http://www.pharo.org 03 59 35 87 52 Assistant: Julie Jonas 03 59 57 78 50 03 59 35 86 16 S. Ducasse - Inria 40, avenue Halley, Parc Scientifique de la Haute Borne, BÃ¢t.A, Park Plaza Villeneuve d'Ascq 59650 France

Sept. 2, 2015

To Detent Or Not To Detentâ¦

by Sean P. DeNigris

Can anyone explain the purpose of sending #detentBy:atMultiplesOf:snap: in the method below? The problem is that, if you resize programatically below a factor of 0.1, you enter a black hole from which many scale attempts become effectively ignored. If the send is removed, everything works for my use case, but I don't understand its purpose and so don't know if it's a bug or feature! TransformationMorph>>#extent: newExtent self adjustAfter: [ | scaleFactor |scaleFactor := (self scale * newExtent r / self fullBounds extent r) max: 0.1. self scale: (scaleFactor detentBy: 0.1 atMultiplesOf: 1.0 snap: false)] ----- Cheers, Sean -- View this message in context: http://forum.world.st/To-Detent-Or-Not-To-Detent-tp4847682.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Sept. 2, 2015

Re: [Pharo-dev] Widget choice list

by Franck Warlouzet

Yes arrows up/down handling in fast table is not perfect. Esteban told me there is a way to have this kind of filtering direclty in the small rectangle but I did not take the time to see how. I like the search field but maybe someone prefers filtering directly in the list items area Franck > To: pharo-dev(a)lists.pharo.org > From: stephan(a)stack.nl > Date: Wed, 2 Sep 2015 16:35:39 +0200 > Subject: Re: [Pharo-dev] Widget choice list > CC: pharo-users(a)lists.pharo.org > > On 02-09-15 14:22, Franck Warlouzet wrote: > > Hi, > > > > Some of you showed interest in a widget as the one which pops up to add protocol in Nautilus, but using FastTable. We started to build such one, it allows to bind specific action on click on a item, to have icon for items, to filter items etc. Examples show how to use it. > > It is still a beginning so there is probably some strange points or improvements to do, but if it appears to be useful to replace some widgets we can enhance it. Or it can simply show you how easy it is to build a fast table with a more complex data source, which would already be a good point. > > > > You can find the code in this repo : > > > > MCHttpRepository > > location: 'http://www.smalltalkhub.com/mc/FranckW/WidgetChoiceList/main' > > user: '' > > password: '' > > > > Feel free to contact me if you have questions. > > Nice. I've fixed example4 > In the interaction between the search field and the table, you'll want > to change the focus behaviour. Starting to type should enter the text in > the search field while filtering the table and selecting the first > element that filters. Arrow up and down should move the selection of the > table. You'll also want a key combination to move up and down to the > next position where the strings start to differ again. > > I took a look at reacting to a keystroke in the text field, but there > is an announcement that is not exposed in the model. > > Stephan > > > >

Sept. 2, 2015

Re: [Pharo-dev] Widget choice list

by Stephan Eggermont

On 02-09-15 14:22, Franck Warlouzet wrote: > Hi, > > Some of you showed interest in a widget as the one which pops up to add protocol in Nautilus, but using FastTable. We started to build such one, it allows to bind specific action on click on a item, to have icon for items, to filter items etc. Examples show how to use it. > It is still a beginning so there is probably some strange points or improvements to do, but if it appears to be useful to replace some widgets we can enhance it. Or it can simply show you how easy it is to build a fast table with a more complex data source, which would already be a good point. > > You can find the code in this repo : > > MCHttpRepository > location: 'http://www.smalltalkhub.com/mc/FranckW/WidgetChoiceList/main' > user: '' > password: '' > > Feel free to contact me if you have questions. Nice. I've fixed example4 In the interaction between the search field and the table, you'll want to change the focus behaviour. Starting to type should enter the text in the search field while filtering the table and selecting the first element that filters. Arrow up and down should move the selection of the table. You'll also want a key combination to move up and down to the next position where the strings start to differ again. I took a look at reacting to a keystroke in the text field, but there is an announcement that is not exposed in the model. Stephan

Sept. 2, 2015

Re: [Pharo-dev] Pharo CI Validation Timeout

by Nicolai Hess

Low memory ? Running the rules fill up the ast cache with nearly one entry per compiled method instance. (this are thousands instances of Array/OrderedCollections/RB and OC classes) My pharo images runs from ~ 50 MB to ~ 350-400 MB after running all rules for all classes! 2015-09-02 13:42 GMT+02:00 Marcus Denker <marcus.denker(a)inria.fr>: > I have the feeling that is is an artefact of the virtualisation somehow. > > On 02 Sep 2015, at 10:24, Guillermo Polito <guillermopolito(a)gmail.com> > wrote: > > I saw also that one of the linux slaves is much much slower than the > others. Just check this: > > https://ci.inria.fr/pharo/job/30-Bootstrap/buildTimeTrend > > In one of the slaves the build takes one hour. In the other it takes 6. > > El miÃ©., 2 de sept. de 2015 a la(s) 9:11 a. m., Marcus Denker < > marcus.denker(a)inria.fr> escribiÃ³: > >> I donât think soâ¦ the job used to run in 15 minutes. But we added more >> tests, >> Rules got slowerâ¦ >> >> On 02 Sep 2015, at 08:34, Nicolai Hess <nicolaihess(a)web.de> wrote: >> >> It is possible to see from the console output which rule or test takes a >> lot time? >> >> 2015-09-02 8:09 GMT+02:00 Marcus Denker <marcus.denker(a)inria.fr>: >> >>> >>> On 01 Sep 2015, at 19:15, Ben Coman <btc(a)openinworld.com> wrote: >>> >>> Do you want to try a post-load... >>> Delay delaySchedulerClass: DelayExperimentalSemaphoreScheduler >>> >>> which fixes the "super fast delay" on virtual machines reported here... >>> http://comments.gmane.org/gmane.comp.lang.smalltalk.pharo.devel/100873 >>> >>> Its named "experimental" only since it was integrated just before >>> Pharo 4 release and did not have wide spread community testing, but >>> its complete and working. There is some further overall streamlining >>> of the DelayScheduler hierarchy I'd like to do later, but it would be >>> good to give this one a run as the default for a while to see how it >>> impacts the issue. (It would be good to get rough "CIAndRule: Timeout" >>> before and after statistics.) >>> >>> btw, is that CI error indicating it times out after one hour? Are >>> there any other timestamps present in the log that indicate if 1 hour >>> really passed? >>> >>> >>> Yes, I think soâ¦ >>> >>> https://ci.inria.fr/pharo/job/Pharo-5.0-Issue-Validator/buildTimeTrend >>> >>> Now looking at it (no idea why it is chinese), it seems that we have some >>> slowdown recently and all runs take 40-50 minutes, a slowdown to 60 can >>> happen >>> just by having less compute power available (or running multiple things >>> in parallel). >>> >>> We should >>> >>> -> do a pass over slow tests >>> -> do a pass over slow rules >>> >>> I will put the limit higher than 60 min for now. >>> >>> Marcus >>> >>> >>> >> >> >

Sept. 2, 2015

Re: [Pharo-dev] Broken GTSpotter in #50298

by Andrei Chis

https://pharo.fogbugz.com/f/cases/16455/Spotter-dying-on-not-understanding-… On Wed, Sep 2, 2015 at 2:41 PM, Juraj Kubelka <juraj.kubelka(a)gmail.com> wrote: > Thanks! > > Juraj > > On Sep 2, 2015, at 09:40, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: > > Making an issue now. > > Cheers, > Andrei > > On Wed, Sep 2, 2015 at 2:04 PM, Juraj Kubelka <juraj.kubelka(a)gmail.com> > wrote: > >> Hi, >> >> I have fixed it yesterday. Maybe some integration is necessary to do. >> >> Cheers, >> Juraj >> >> -- >> Juraj Kubelka >> >> 2. 9. 2015 v 8:50, Peter UhnÃ¡k <i.uhnak(a)gmail.com>: >> >> > Hi, >> > >> > is Spotter working for you in latest Pharo? (#50298) >> > I downloaded fresh image and its dying on not understanding >> #canUnderstand: >> > >> > Peter >> >> > >

Sept. 2, 2015

Re: [Pharo-dev] Broken GTSpotter in #50298

by Juraj Kubelka

Thanks! Juraj > On Sep 2, 2015, at 09:40, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: > > Making an issue now. > > Cheers, > Andrei > > On Wed, Sep 2, 2015 at 2:04 PM, Juraj Kubelka <juraj.kubelka(a)gmail.com <mailto:juraj.kubelka@gmail.com>> wrote: > Hi, > > I have fixed it yesterday. Maybe some integration is necessary to do. > > Cheers, > Juraj > > -- > Juraj Kubelka > > 2. 9. 2015 v 8:50, Peter UhnÃ¡k <i.uhnak(a)gmail.com <mailto:i.uhnak@gmail.com>>: > > > Hi, > > > > is Spotter working for you in latest Pharo? (#50298) > > I downloaded fresh image and its dying on not understanding #canUnderstand: > > > > Peter > >

Sept. 2, 2015

Re: [Pharo-dev] Broken GTSpotter in #50298

by Andrei Chis

Making an issue now. Cheers, Andrei On Wed, Sep 2, 2015 at 2:04 PM, Juraj Kubelka <juraj.kubelka(a)gmail.com> wrote: > Hi, > > I have fixed it yesterday. Maybe some integration is necessary to do. > > Cheers, > Juraj > > -- > Juraj Kubelka > > 2. 9. 2015 v 8:50, Peter UhnÃ¡k <i.uhnak(a)gmail.com>: > > > Hi, > > > > is Spotter working for you in latest Pharo? (#50298) > > I downloaded fresh image and its dying on not understanding > #canUnderstand: > > > > Peter > >

Sept. 2, 2015