- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by stepharo

> Ok, so the deepest Iâve got is that âself classWidget getClassesListâ > (where self is NautilusUI) always returns an empty list, so removed > class is not found in that list, so it is not removed from the model. > I have not changes ClassWidget and never worked with it, so from now > the investigation will go slower. Iâd appreciate help in any Nautilus > people are out there. this morning I started to read the method of AbstractNautilusUI now I still do not get what you did. I hate that I have to download a special image and merge a special slice. We should really have a diff in plain text as it is done in squeak sent to this mailing-list. With that it would take me less than a second to see what you were doing. Stef

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Yuriy Tymchuk

Fix is under monkey validation: https://pharo.fogbugz.com/f/cases/16485/Class-panes-not-refreshed-when-chan… <https://pharo.fogbugz.com/f/cases/16485/Class-panes-not-refreshed-when-chan…> > On 05 Sep 2015, at 14:26, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > >> On 05 Sep 2015, at 13:29, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: >> >> You can see changes for that patch here: >> https://github.com/pharo-project/pharo-core/commit/2536752ecdd88e15b00c6d3e… > > YES, we have that for years now. > > True, it is one click away, but the view is quite nice (not something that can be reproduced in an email). > >>> On 05 Sep 2015, at 13:23, stepharo <stepharo(a)free.fr> wrote: >>> >>> >>>>> On 05 Sep 2015, at 11:40, stepharo <stepharo(a)free.fr> wrote: >>>>> >>>>> How can I see the changes? >>>>> Our process is not good. Most of us do not get any chance understanding what is changing. >>>>> >>>> >>>> -> download the image before it was added >>>> -> merge the slice. >>>> >>>> Yes, our process is not goodâ¦ but from a review perspective, this issue is the best we can do. >>>> *two* reviews, both from people actively contributing to exactly that part of the system. >>>> >>>> If we require more, we will be back at a process where due to Fear we do nothing. >>> >>> I do not want to require more. I want to see all the changes that we are doing without having to download an image >>> and doing merge. >>> I read many squeak changes like that and IT WORKS. >>> >>> Stef >>>> >>>>> >>>>>> Hi, >>>>>> >>>>>> This is a side effect of >>>>>> >>>>>> https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen… >>>>>> >>>>>> (which was reviewed by two people, so not obvious). >>>>>> >>>>>> What happened is that #updatePackageGroupAndClassList calls itself via #selectedClass: leading to a loop. >>>>>> >>>>>> Should be easy to fix for the people involved in case 16475. >>>>>> >>>>>> Marcus >>>>>> >>>>>> >>>>>> On Sat, Sep 5, 2015 at 8:51 AM, stepharo <stepharo(a)free.fr> wrote: >>>>>> Hi >>>>>> >>>>>> I do not know if this is linked to recent changes but we cannot remove classes or move them to another package. >>>>>> >>>>>> Stef >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> -- >>>>>> Marcus Denker -- denker(a)acm.org >>>>>> http://www.marcusdenker.de >>>>> >>>> >>> >> > >

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Sven Van Caekenberghe

> On 05 Sep 2015, at 13:29, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > > You can see changes for that patch here: > https://github.com/pharo-project/pharo-core/commit/2536752ecdd88e15b00c6d3e… YES, we have that for years now. True, it is one click away, but the view is quite nice (not something that can be reproduced in an email). >> On 05 Sep 2015, at 13:23, stepharo <stepharo(a)free.fr> wrote: >> >> >>>> On 05 Sep 2015, at 11:40, stepharo <stepharo(a)free.fr> wrote: >>>> >>>> How can I see the changes? >>>> Our process is not good. Most of us do not get any chance understanding what is changing. >>>> >>> >>> -> download the image before it was added >>> -> merge the slice. >>> >>> Yes, our process is not goodâ¦ but from a review perspective, this issue is the best we can do. >>> *two* reviews, both from people actively contributing to exactly that part of the system. >>> >>> If we require more, we will be back at a process where due to Fear we do nothing. >> >> I do not want to require more. I want to see all the changes that we are doing without having to download an image >> and doing merge. >> I read many squeak changes like that and IT WORKS. >> >> Stef >>> >>>> >>>>> Hi, >>>>> >>>>> This is a side effect of >>>>> >>>>> https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen… >>>>> >>>>> (which was reviewed by two people, so not obvious). >>>>> >>>>> What happened is that #updatePackageGroupAndClassList calls itself via #selectedClass: leading to a loop. >>>>> >>>>> Should be easy to fix for the people involved in case 16475. >>>>> >>>>> Marcus >>>>> >>>>> >>>>> On Sat, Sep 5, 2015 at 8:51 AM, stepharo <stepharo(a)free.fr> wrote: >>>>> Hi >>>>> >>>>> I do not know if this is linked to recent changes but we cannot remove classes or move them to another package. >>>>> >>>>> Stef >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> -- >>>>> Marcus Denker -- denker(a)acm.org >>>>> http://www.marcusdenker.de >>>> >>> >> >

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Stephan Eggermont

On 05-09-15 14:09, Yuriy Tymchuk wrote: > I found the issue. Fix almost ready. Should I reopen the case, or create a new one? 16488 is a different issue Stephan

Sept. 5, 2015

Re: [Pharo-dev] System announcements fixed?

by Stephan Eggermont

On 05-09-15 08:52, stepharo wrote: > Since when? > Where is the bug entry? > Where is a reproducible case? The easy ones: 16485 Class panes not refreshed when changing package (by Marcus) 16486 Nautilus doesn't update the method pane after adding a method (first time) 16487 Dropping methods on empty areas of class/method category pane raises SubscriptOutOfBounds 16488 Dropping a class from one browser to another package in another browser updates selected package+class in both 16489 Monticello browser doesn't update others after adding repo And there is a more difficult case where changing code in the debugger does not get to (all) nautilus browsers. I had two browsers open and changed code that was in the selected class but not visible in the browsers. One browser was correctly updated, the other was not. This has happened for a few weeks now, and I thought this was known and related to the current Nautilus refactorings. Stephan

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Yuriy Tymchuk

I found the issue. Fix almost ready. Should I reopen the case, or create a new one? Uko > On 05 Sep 2015, at 13:59, Stephan Eggermont <stephan(a)stack.nl> wrote: > > On 05-09-15 08:51, stepharo wrote: >> Hi >> >> I do not know if this is linked to recent changes but we cannot remove >> classes or move them to another package > > I can move them to another package using drag-and-drop (issue 16488) > in 50305 > > > Stephan > >

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Stephan Eggermont

On 05-09-15 08:51, stepharo wrote: > Hi > > I do not know if this is linked to recent changes but we cannot remove > classes or move them to another package I can move them to another package using drag-and-drop (issue 16488) in 50305 Stephan

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by Yuriy Tymchuk

You can see changes for that patch here: https://github.com/pharo-project/pharo-core/commit/2536752ecdd88e15b00c6d3e… > On 05 Sep 2015, at 13:23, stepharo <stepharo(a)free.fr> wrote: > > >>> On 05 Sep 2015, at 11:40, stepharo < <mailto:stepharo@free.fr>stepharo(a)free.fr <mailto:stepharo@free.fr>> wrote: >>> >>> How can I see the changes? >>> Our process is not good. Most of us do not get any chance understanding what is changing. >>> >> >> -> download the image before it was added >> -> merge the slice. >> >> Yes, our process is not goodâ¦ but from a review perspective, this issue is the best we can do. >> *two* reviews, both from people actively contributing to exactly that part of the system. >> >> If we require more, we will be back at a process where due to Fear we do nothing. > > I do not want to require more. I want to see all the changes that we are doing without having to download an image > and doing merge. > I read many squeak changes like that and IT WORKS. > > Stef >> >>> >>>> Hi, >>>> >>>> This is a side effect of >>>> >>>> https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen… <https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen…> >>>> >>>> (which was reviewed by two people, so not obvious). >>>> >>>> What happened is that #updatePackageGroupAndClassList calls itself via #selectedClass: leading to a loop. >>>> >>>> Should be easy to fix for the people involved in case 16475. >>>> >>>> Marcus >>>> >>>> >>>> On Sat, Sep 5, 2015 at 8:51 AM, stepharo < <mailto:stepharo@free.fr>stepharo(a)free.fr <mailto:stepharo@free.fr>> wrote: >>>> Hi >>>> >>>> I do not know if this is linked to recent changes but we cannot remove classes or move them to another package. >>>> >>>> Stef >>>> >>>> >>>> >>>> >>>> -- >>>> -- >>>> Marcus Denker -- denker(a)acm.org <mailto:denker@acm.org> >>>> http://www.marcusdenker.de <http://www.marcusdenker.de/> >>> >> >

Sept. 5, 2015

Re: [Pharo-dev] remove MczInstaller?

by stepharo

Hi martin how MCZ are then read? Stef Le 4/9/15 15:18, Martin Dias a Ã©crit : > Hi, > > Does somebody use MczInstaller to load Monticello files? The only > users in the image are it's tests. > > The class comment states: " > An installer for Monticello files with the *.mcz extension. > > MczInstaller installFileNamed: 'MyKillerApp-Core-Author.1.mcz' > " > > MartÃn

Sept. 5, 2015

Re: [Pharo-dev] ***important*** cannot remove a class anymore...

by stepharo

>> On 05 Sep 2015, at 11:40, stepharo <stepharo(a)free.fr >> <mailto:stepharo@free.fr>> wrote: >> >> How can I see the changes? >> Our process is not good. Most of us do not get any chance >> understanding what is changing. >> > > -> download the image before it was added > -> merge the slice. > > Yes, our process is not goodâ¦ but from a review perspective, this > issue is the best we can do. > *two* reviews, both from people actively contributing to exactly that > part of the system. > > If we require more, we will be back at a process where due to Fear we > do nothing. I do not want to require more. I want to see all the changes that we are doing without having to download an image and doing merge. I read many squeak changes like that and IT WORKS. Stef > >> >>> Hi, >>> >>> This is a side effect of >>> >>> https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcemen… >>> >>> (which was reviewed by two people, so not obvious). >>> >>> What happened is that #updatePackageGroupAndClassList calls itself >>> via #selectedClass: leading to a loop. >>> >>> Should be easy to fix for the people involved in case 16475. >>> >>> Marcus >>> >>> >>> On Sat, Sep 5, 2015 at 8:51 AM, stepharo <stepharo(a)free.fr >>> <mailto:stepharo@free.fr>> wrote: >>> >>> Hi >>> >>> I do not know if this is linked to recent changes but we cannot >>> remove classes or move them to another package. >>> >>> Stef >>> >>> >>> >>> >>> -- >>> -- >>> Marcus Denker -- denker(a)acm.org <mailto:denker@acm.org> >>> http://www.marcusdenker.de <http://www.marcusdenker.de/> >> >

Sept. 5, 2015