- Pharo-dev - lists.pharo.org

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50314 Home: https://github.com/pharo-project/pharo-core

Sept. 9, 2015

[pharo-project/pharo-core] 8afa38: 50314

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 8afa388a82651c08ea4af40f346923593f6868ce https://github.com/pharo-project/pharo-core/commit/8afa388a82651c08ea4af40f… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-09-09 (Wed, 09 Sep 2015) Changed paths: M BlueInk-Core.package/BIConfigurableFormatter.class/instance/private-formatting/formatBlock_.st M ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/symbolic versions/stable_.st A ConfigurationOfQualityAssistant.package/ConfigurationOfQualityAssistant.class/instance/versions/v1%5F4%5F2_.st A ContributingToTheCatalogHelp.package/ContributingToTheCatalogHelp.class/README.md A ContributingToTheCatalogHelp.package/ContributingToTheCatalogHelp.class/class/as yet unclassified/bookName.st A ContributingToTheCatalogHelp.package/ContributingToTheCatalogHelp.class/class/as yet unclassified/pages.st A ContributingToTheCatalogHelp.package/ContributingToTheCatalogHelp.class/class/pages/AddingYourProject.st A ContributingToTheCatalogHelp.package/ContributingToTheCatalogHelp.class/class/pages/introduction.st A ContributingToTheCatalogHelp.package/ContributingToTheCatalogHelp.class/definition.st A QualityAssistant.package/QANautilusPlugin.class/instance/accessing/morph.st M QualityAssistant.package/QANautilusPlugin.class/instance/initialization/initialize.st M Refactoring-Critics.package/RBAssignmentInIfTrueRule.class/instance/accessing/rationale.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50313.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50314.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50313.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50314.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50314 16524 Assignment is misspelled in RBAssignmentInIfTrueRule>>#rationale https://pharo.fogbugz.com/f/cases/16524 16515 Adding an instance variable to Model broken by QualityAssistant https://pharo.fogbugz.com/f/cases/16515 16454 BlueInk block formatting https://pharo.fogbugz.com/f/cases/16454 16521 Help topic for contributing to the catalog https://pharo.fogbugz.com/f/cases/16521 http://files.pharo.org/image/50/50314.zip

Sept. 9, 2015

Re: [Pharo-dev] when:send:to: vs. subscribe:send:to:

by Norbert Hartl

> Am 08.09.2015 um 22:49 schrieb stepharo <stepharo(a)free.fr>: > > Me too :) > I do not care that they is a registration mechanism behind. > But you get a subscription back. Und the user should be aware of that there is no magical unsubscribe mechanism. So this no reason for me but I still like when:send:to: better although it feels a bit awkward. Norbert > Stef > > Le 8/9/15 16:30, Ferlicot D. Cyril a Ã©crit : >> Le 08/09/2015 10:13, Stephan Eggermont a Ã©crit : >> >>> When looking at the implementation, it looks as if we should >>> replace all #when:send:to: by #subscribe:when:do:, not the other way >>> around. >>> >>> Where is this all coming from? >>> >>> Stephan >> I think that #when:send:to: is more explicit and more understandable, >> but this is a personal opinion. > >

Sept. 9, 2015

Re: [Pharo-dev] Nautilus strange pattern

by Ben Coman

On Wed, Sep 9, 2015 at 4:41 AM, stepharo <stepharo(a)free.fr> wrote: > just a question that came to my mind while reading your old mail. > > > ">>>" SystemAnnouncer uniqueInstance unsubscribe: mod. "<<<added" > > Are you sure that this is to this one that Nautilus is registered? I'm not sure if its the best approach, but apart from the steps to reproduce in previous link, you can do the following experiment. In a fresh image... "(1)" SystemAnnouncer uniqueInstance inspect. "and review subscriptions tab" "(2)" window := Smalltalk tools openClassBrowser ui window. SystemAnnouncer uniqueInstance inspect. "and review subscriptions tab" "(3)" window delete. Smalltalk garbageCollect. Smalltalk garbageCollect. Smalltalk garbageCollect. SystemAnnouncer uniqueInstance inspect. "and review subscriptions tab" You will find leftover "a PackageTreeNautilusUI" subscriptions. Now repeat starting again with a fresh image, and after evaluating the following... NautilusWindow compile: 'delete | mod | mod := self model. super delete. SystemAnnouncer uniqueInstance unsubscribe: mod. mod ifNotNil: [ mod announce: (WindowClosed new window: self) ] ' "a PackageTreeNautilusUI" is now correctly absent from the SystemAnnouncer subscriptions. A further experiment before and after ammending NautilusWindow>>delete is... 20 timesRepeat: [ window := Smalltalk tools openClassBrowser ui window. window delete. ]. SystemAnnouncer uniqueInstance inspect. I've now logged https://pharo.fogbugz.com/default.asp?16525 cheers -ben

Sept. 9, 2015

Re: [Pharo-dev] garbage on transcript

by stepharo

The idea was to reduce the amount of Parsers (and models of methods) in the systemâ¦ > > I understand that. But parsing for code generation is very different > from the quick and simple parsing for syntax highlighting that Shout > provides, and if one ends up complicating the former to make it > encompass the latter then maybe that's not such a good idea. I'd > rather have a number of smaller simpler parsers than one great big > complex difficult to understand and full of special cases parser > (think... Morphic). Just a thought. Elliot when I start to think about Morphic.... :) > > Marcus > > > _,,,^..^,,,_ > best, Eliot

Sept. 8, 2015

Re: [Pharo-dev] ANSICompatibility package

by stepharo

We should have a SmalltalkCompatibility (not Ansi per se) package were we can add some methods to help migration. Stef Le 8/9/15 06:04, Ben Coman a Ã©crit : > On Tue, Sep 8, 2015 at 9:21 AM, Jan Vrany <jan.vrany(a)fit.cvut.cz> wrote: >> Hi, >> >> is there actually such a thing like ANSICompatibility package? >> (it has been mentioned here lately, but I cannot find it) >> >> Thanks, Jan >> > I made it up for the purpose of discussion to see what interest it generated. > Should we start one ? > cheers -ben > >

Sept. 8, 2015

Re: [Pharo-dev] when:send:to: vs. subscribe:send:to:

by stepharo

Me too :) I do not care that they is a registration mechanism behind. Stef Le 8/9/15 16:30, Ferlicot D. Cyril a Ã©crit : > Le 08/09/2015 10:13, Stephan Eggermont a Ã©crit : > >> When looking at the implementation, it looks as if we should >> replace all #when:send:to: by #subscribe:when:do:, not the other way >> around. >> >> Where is this all coming from? >> >> Stephan >> >> >> > I think that #when:send:to: is more explicit and more understandable, > but this is a personal opinion. >

Sept. 8, 2015

Re: [Pharo-dev] Nautilus strange pattern

by stepharo

just a question that came to my mind while reading your old mail. ">>>" SystemAnnouncer uniqueInstance unsubscribe: mod. "<<<added" Are you sure that this is to this one that Nautilus is registered? Today I discussed with esteban and we agreed that the GroupAnnouncer should be just a class instance var of the Group class. No need to have a subclass of Announcer + a singletong when we can use an announcer. Stef

Sept. 8, 2015

Re: [Pharo-dev] Nautilus strange pattern

by stepharo

Le 8/9/15 01:50, Ben Coman a Ã©crit : > On Tue, Sep 8, 2015 at 5:32 AM, Nicolai Hess <nicolaihess(a)web.de> wrote: >> We should make sure to unregister to all announcement when the window is >> closed. > +1. Nautilus seems to leak announcements. Sorry I forgot to log an > issue already for this... > https://www.mail-archive.com/pharo-dev@lists.pharo.org/msg31953.html > > So should I log a new issue now, sure because we should go slowly with Nautilus. I would like to get the state machine that all the if are trying to rebuild in permanence. > or do you want to pick it up under > existing work? > > cheers -ben > >> (Or is there any reason or situation in which nautilus can properly work >> after the window is closed?) >> >> 2015-09-06 10:41 GMT+02:00 stepharo <stepharo(a)free.fr>: >>> Hi >>> >>> I'm trying to understand what there is a need for this window ifNil: [^ >>> self ] >>> And I wonder is this is not problem due to a global announcer that would >>> keep announcer even when the nautilus widget >>> has been deleted. >>> Any other suggestions? >>> >>> Stef >>> >>> classRemoved: anAnnouncement >>> | class oldPackage | >>> window ifNil: [ ^ self ]. >>> window isDisplayed >>> ifFalse: [ ^ self ]. >>> class := anAnnouncement classRemoved. >>> (self classWidget getClassesList includes: class) >>> ifTrue: >>> [ >>> >>> classRecategorized: anAnnouncement >>> >>> window ifNil: [ ^ self ]. >>> window isDisplayed ifFalse: [ ^ self ]. >>> self selectedPackage ifNotNil:[:selection | >>> ({ anAnnouncement oldCategory. anAnnouncement newCategory } >>> anySatisfy: [ :each | selection includesCategory: each ]) >>> ifTrue: [ self updatePackageGroupAndClassList ]] >>> >>> >>> classRemoved: anAnnouncement >>> | class oldPackage | >>> window ifNil: [ ^ self ]. >>> window isDisplayed >>> ifFalse: [ ^ self ]. >>> class := anAnnouncement classRemoved. >>> (self classWidget getClassesList includes: cla >>> >

Sept. 8, 2015

Re: [Pharo-dev] Nautilus strange pattern

by stepharo

Le 7/9/15 23:32, Nicolai Hess a Ã©crit : > We should make sure to unregister to all announcement when the window > is closed. > (Or is there any reason or situation in which nautilus can properly > work after the window is closed?) Yes I was thinking about this too. I took an image and removed all the window ifNil: [ ^ self ]. window isDisplayed ifFalse: [ ^ self ]. and tried all kind of combination I could imagine. It seemed to work but I should continue to experiment. Stef > > 2015-09-06 10:41 GMT+02:00 stepharo <stepharo(a)free.fr > <mailto:stepharo@free.fr>>: > > Hi > > I'm trying to understand what there is a need for this window > ifNil: [^ self ] > And I wonder is this is not problem due to a global announcer > that would keep announcer even when the nautilus widget > has been deleted. > Any other suggestions? > > Stef > > classRemoved: anAnnouncement > | class oldPackage | > window ifNil: [ ^ self ]. > window isDisplayed > ifFalse: [ ^ self ]. > class := anAnnouncement classRemoved. > (self classWidget getClassesList includes: class) > ifTrue: > [ > > classRecategorized: anAnnouncement > > window ifNil: [ ^ self ]. > window isDisplayed ifFalse: [ ^ self ]. > self selectedPackage ifNotNil:[:selection | > ({ anAnnouncement oldCategory. anAnnouncement newCategory } > anySatisfy: [ :each | selection includesCategory: each ]) > ifTrue: [ self updatePackageGroupAndClassList ]] > > > classRemoved: anAnnouncement > | class oldPackage | > window ifNil: [ ^ self ]. > window isDisplayed > ifFalse: [ ^ self ]. > class := anAnnouncement classRemoved. > (self classWidget getClassesList includes: cla > >

Sept. 8, 2015