- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] About the Unicode class

by Christophe Demarey

Thanks for your answers. I also took a look in Squeak 5.0 but the implementation is also incomplete. I think the best is to remove unused unicode character categories. Le 17 sept. 2015 Ã 18:27, Nicolas Cellier a Ã©crit : > There has been some work on Squeak by Levente in this area, maybe it's time to harvest... > > 2015-09-17 18:22 GMT+02:00 Henrik Johansen <henrik.s.johansen(a)veloxit.no>: > >> On 17 Sep 2015, at 2:58 , Christophe Demarey <christophe.demarey(a)inria.fr> wrote: >> >> Hi, >> >> Does anyone know why there are so many class variables in Unicode and what they are used for? >> Most of them have no sender. >> >> EncodedCharSet subclass: #Unicode >> instanceVariableNames: '' >> classVariableNames: 'Cc Cf Cn Co Cs DecimalProperty GeneralCategory Ll Lm Lo Lt Lu Mc Me Mn Nd Nl No Pc Pd Pe Pf Pi Po Ps Sc Sk Sm So ToCasefold ToLower ToUpper Zl Zp Zs' >> category: 'Multilingual-Encodings' >> >> Thanks, >> Christophe > > A partial / incomplete / broken implementation of querying character properties, I'd guess. > See for instance: > http://en.wikipedia.org/wiki/Unicode_character_property > http://www.fileformat.info/info/unicode/category/index.htm > > Cheers, > Henry >

Sept. 18, 2015

Re: [Pharo-dev] Rubric/Event handling issue?

by Stephan Eggermont

On 17-09-15 23:11, Nicolai Hess wrote: > DragWell > startDrag: evt > WorldState addDeferredUIMessage: [ evt hand grabMorph: self copy ]. > > calls > Morph>>#copy > and this makes a veryDeepCopy. > > I don't know exactly how this affects the other rubric text morphs, but > replacing > self copy > with > self shallowCopy > seems to work. Thanks. So there's something wrong with how I hold onto the Rubric text morph and or model. Something shouldn't be copied there. We don't have many examples of using veryDeepCopy and the fixups needed in image, and I'm not sure I fully understand the class comment of DeepCopier :( The clone menu option for a code card does a duplicate, and that creates the same problem as shown with the color panel. In CodeCard I hold onto both the model and the morph. They are connected using announcements, if I understand it correctly? Shouldn't that connection be rewired when doing a copy? Stephan

Sept. 18, 2015

Re: [Pharo-dev] [review needed] speed up RBClassNotReferencedRule

by Yuriy Tymchuk

> On 18 Sep 2015, at 08:34, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > >> Maybe we can hijack that mechanism with a class side method e.g. >> >> rbNotReferenced >> <lint> >> >> >> Do your modifications test sends of subclassesDo: and friends? >> >> OR >> >> #(#MyClass1 #MyClass2 #MyClass3) collect:[:ea | (Smalltalk at: ea) >> doSomething]. >> >> The reason I ask is I'm planning to do a bunch of cleanup of a package and >> it would be nice to not worry about those cases getting missed >> > > What I did is to implement #isUsed like this in e.g the hierarchy of RBLintRule: > > isUsed > "all my sublasses are used" > ^self name ~= âRBLintRule' > > this way if RBLintRule is not used, it is seen by the Critique, but all subclasses > are used by default. > > I implemented that in TestCase, too, and removed the explicit check for TestCase > subclasses from the rule. This is a nice thing. In the same way we can deal with abstract classes. So if someone develops an abstract class with an intent to use it, he can specify that itâs ok to use the class. Also is there any work on pragmas for classes, at some point Iâve heard something about it but canât recall. I will try to hack a bit this weekend and see if I can add some kind of automation to marking a class as used. I.e. if you see a critic, you should be able to mark the class as being used with 1-2 clicks. If you are developing some king of facade, you should know that you will not reference it from your library. Uko > > Marcus

Sept. 18, 2015

Re: [Pharo-dev] [review needed] speed up RBClassNotReferencedRule

by Marcus Denker

> Maybe we can hijack that mechanism with a class side method e.g. > > rbNotReferenced > <lint> > > > Do your modifications test sends of subclassesDo: and friends? > > OR > > #(#MyClass1 #MyClass2 #MyClass3) collect:[:ea | (Smalltalk at: ea) > doSomething]. > > The reason I ask is I'm planning to do a bunch of cleanup of a package and > it would be nice to not worry about those cases getting missed > What I did is to implement #isUsed like this in e.g the hierarchy of RBLintRule: isUsed "all my sublasses are used" ^self name ~= âRBLintRule' this way if RBLintRule is not used, it is seen by the Critique, but all subclasses are used by default. I implemented that in TestCase, too, and removed the explicit check for TestCase subclasses from the rule. Marcus

Sept. 18, 2015

Re: [Pharo-dev] PID of VM ?

by stepharo

nativeboost is not maintained and we need a solution that can be maintained by multiple people. Normally with the new FFI esteban is doing you will be able to use the NativeBoost syntax. > > Bye > T. > >

Sept. 17, 2015

Re: [Pharo-dev] About the Unicode class

by stepharo

Le 17/9/15 18:27, Nicolas Cellier a Ã©crit : > There has been some work on Squeak by Levente in this area, maybe it's > time to harvest... Thanks nicolas for the information. It is in the Unicode class? > > 2015-09-17 18:22 GMT+02:00 Henrik Johansen > <henrik.s.johansen(a)veloxit.no <mailto:henrik.s.johansen@veloxit.no>>: > > >> On 17 Sep 2015, at 2:58 , Christophe Demarey >> <christophe.demarey(a)inria.fr >> <mailto:christophe.demarey@inria.fr>> wrote: >> >> Hi, >> >> Does anyone know why there are so many class variables in Unicode >> and what they are used for? >> Most of them have no sender. >> >> EncodedCharSet subclass: #Unicode >> instanceVariableNames: '' >> classVariableNames: 'Cc Cf Cn Co Cs DecimalProperty >> GeneralCategory Ll Lm Lo Lt Lu Mc Me Mn Nd Nl No Pc Pd Pe Pf Pi >> Po Ps Sc Sk Sm So ToCasefold ToLower ToUpper Zl Zp Zs' >> category: 'Multilingual-Encodings' >> >> Thanks, >> Christophe > > A partial / incomplete / broken implementation of querying > character properties, I'd guess. > See for instance: > http://en.wikipedia.org/wiki/Unicode_character_property > http://www.fileformat.info/info/unicode/category/index.htm > > Cheers, > Henry > >

Sept. 17, 2015

Re: [Pharo-dev] Rubric/Event handling issue?

by Nicolai Hess

2015-09-17 10:35 GMT+02:00 Stephan Eggermont <stephan(a)stack.nl>: > ping > > > On 15-09-15 17:49, Stephan Eggermont wrote: > >> There is an interesting bad interaction between my drag-and-drop code >> and Rubric. It kills all Rubric editors at the same time, so it looks >> to me like a problem with the Rubric background thread interacting with >> mouseMove or mouseEnter/Leave. >> >> https://vimeo.com/139353992 >> >> To reproduce, >> Load DragPanels from StephanEggermont/DragPanels >> and NewUI from StephanEggermont/Documentation >> >> In a Playground open a panel >> CodePanel new openInWindowLabeled:'Code Panel' >> >> add a few cards (drop them in the panel) >> (CodeCard class: CodeCard selector: #initialize) openInHand >> and expand them by clicking on the arrow >> >> Right click on the empty area in the CodePanel and open the >> colors. A fast drag from the color panel to the rubric area of the >> code card sometimes results in the rubric editors losing their content. >> >> Stephan >> >> >> >> > > > DragWell startDrag: evt WorldState addDeferredUIMessage: [ evt hand grabMorph: self copy ]. calls Morph>>#copy and this makes a veryDeepCopy. I don't know exactly how this affects the other rubric text morphs, but replacing self copy with self shallowCopy seems to work.

Sept. 17, 2015

Re: [Pharo-dev] Contribution scheme confusing ...

by Ben Coman

On Thu, Sep 17, 2015 at 9:40 PM, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>> >>> Also: >>> I did a simple fix on NautilusGroupAutoBuilder package - there is >>> a ConfigurationOfNautilusGroupAutoBuilder. But is it managed internally >>> or externally now? >>> >> Even I can not tell you. >> > > I think the rule we should adopt: if there is a dedicated repository defined in the image for a package, people should commit > there. If there is non (just the inbox), then this should be used (with the Slice mechanism). > > The repositories in the image should be already up to date, I think. > > Marcus > > How would the CI monkey work with Configurations from other repositories? My workflow for reviewing a submitted fix (e.g. for issue 11111) is to open the Pharo5Inbox repository and filter on the issue number, which leaves the SLICE-Issue-11111 as the only item. Having to discover where fixes are scattered makes it harder to review fixes, and they will get less review Now if the Inbox contained ConfigurationofXyz-Issue-11111, it would be simple to identify what needs to be reviewed. This might even help the CI monkey to pick up Configurations for testing. btw, it would be cool if a package loaded by a Configuration becomes dirty, then the Configuration also becomes dirty, or is otherwise flagged somehow. cheers -ben

Sept. 17, 2015

Re: [Pharo-dev] EncodedCharSets

by Sven Van Caekenberghe

> On 17 Sep 2015, at 19:26, Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > > Hi Christophe, > > On Thu, Sep 17, 2015 at 7:09 AM, Christophe Demarey <Christophe.Demarey(a)inria.fr> wrote: > Hi again, > > Does anyone know the rationale behind this? > > declareEncodedCharSet: anEncodedCharSetOrLanguageEnvironmentClass atIndex: aNumber > > EncodedCharSets at: aNumber put: anEncodedCharSetOrLanguageEnvironmentClass > > "this method is used to modularize the old initialize method: > EncodedCharSets at: 0+1 put: Unicode. > EncodedCharSets at: 1+1 put: JISX0208. > EncodedCharSets at: 2+1 put: GB2312. > EncodedCharSets at: 3+1 put: KSX1001. > EncodedCharSets at: 4+1 put: JISX0208. > EncodedCharSets at: 5+1 put: JapaneseEnvironment. > EncodedCharSets at: 6+1 put: SimplifiedChineseEnvironment. > EncodedCharSets at: 7+1 put: KoreanEnvironment. > EncodedCharSets at: 8+1 put: GB2312. > EncodedCharSets at: 12+1 put: KSX1001. > EncodedCharSets at: 13+1 put: GreekEnvironment. > EncodedCharSets at: 14+1 put: Latin2Environment. > EncodedCharSets at: 15+1 put: RussianEnvironment. > EncodedCharSets at: 17+1 put: Latin9Environment. > EncodedCharSets at: 256 put: Unicode. > > " > > what Henrik says is correct. Here's the relevant definition in Character: > > Character>>leadingChar > "Answer the value of the 8 highest bits which is used to identify the language. > This is mostly used for east asian languages CJKV as a workaround against unicode han-unification." > ^ self asInteger bitShift: -22 > > > i.e. the top 8 bytes of the leading character in a string is (was?) used to index EncodedCharSets to determine what language the string is in. Past tense indeed, until someone can explain why we would need this while it cannot be found anywhere else. > _,,,^..^,,,_ > best, Eliot

Sept. 17, 2015

Re: [Pharo-dev] Rubric/Event handling issue?

by Ben Coman

On Thu, Sep 17, 2015 at 8:47 PM, Stephan Eggermont <stephan(a)stack.nl> wrote: > On 17-09-15 13:59, Ben Coman wrote: >> >> On Tue, Sep 15, 2015 at 11:49 PM, Stephan Eggermont <stephan(a)stack.nl> >> wrote: >>> >>> There is an interesting bad interaction between my drag-and-drop code and >>> Rubric. It kills all Rubric editors at the same time, so it looks >>> to me like a problem with the Rubric background thread interacting with >>> mouseMove or mouseEnter/Leave. >>> >>> https://vimeo.com/139353992 >> >> >> It looks like there was meant to be sound, but I didn't hear any >> (could just be me) >> cheers -ben > > > Yes, there is sound, and it is 720p video. I'm probably constructing the > rubric editor incorrectly, and it would be good if that would only interfere > with the ones I created... Problem was at my end. cheers -ben

Sept. 17, 2015