- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Help with RBTransformationRule needed!

by Jan Vrany

Yeah, I remember this is a pain. When I did years ago what you're doing now with QA, I ended up practicing black magic, sacrificing chickens and other things you'd better not to know. IIRC, the trick is to turn rewrite rules in ParseTreeEnvironment into search rules and then run the searches. Now this is tricky as these rules quite often refers to blocks, which then refers to outer contexts and you need these blocks do something different now (report nodes rather then transform stuff). This is the main problem. If you have the guts, you may find the code here: https://bitbucket.org/janvrany/stx-goodies-smallsense and here: http://swing.fit.cvut.cz/hg/stx.goodies.refactoryBrowser/ (alternatively, downlaod https://swing.fit.cvut.cz/projects/stx-jv/ and browse the code in Smalltalk browser). You may want to trace the code starting from ParseTreeEnvironment>>selectionIntervalsForSource:tree:do: RBParseTreeRule>>copyMatchDo: and implementors is also worth mentioning. After doing this, I concluded that SmallLint as it's now is not well designed for this task and it would need a significant refactoring. However, as always, I was never given time to do it. HTH, Jan On Tue, 2015-09-22 at 17:56 +0200, Yuriy Tymchuk wrote: > Hi everyone, > > I need someone who knows how RBParseTreeRewriter & co. work. May of > quality rules are implemented as rewrite rules which is cool. But > they donât report the interval in source code which can be > highlighted to help with understanding of the issue. > > Nowâ¦ the check happens in RBTransformationRule>>#checkMethod:. Is it > possible to obtain the matched string there? Because in that case we > can get highlighting working which will be very useful. > > Cheers! > Uko >

Sept. 22, 2015

Re: [Pharo-dev] Help with RBTransformationRule needed!

by Thierry Goubier

Le 22/09/2015 17:56, Yuriy Tymchuk a Ã©crit : > Hi everyone, > > I need someone who knows how RBParseTreeRewriter & co. work. May of > quality rules are implemented as rewrite rules which is cool. But > they donât report the interval in source code which can be > highlighted to help with understanding of the issue. > > Nowâ¦ the check happens in RBTransformationRule>>#checkMethod:. Is it > possible to obtain the matched string there? Because in that case we > can get highlighting working which will be very useful. Hi Uko, it seems all the information is in the context of the RBParseTreeRewriter instance, but I'm not finding how to get the top-level node (the root of the tree which will be replaced), knowing that you may have multiple matches in a method (i.e. that there is multiple nodes). Thierry

Sept. 22, 2015

Help with RBTransformationRule needed!

by Yuriy Tymchuk

Hi everyone, I need someone who knows how RBParseTreeRewriter & co. work. May of quality rules are implemented as rewrite rules which is cool. But they donât report the interval in source code which can be highlighted to help with understanding of the issue. Nowâ¦ the check happens in RBTransformationRule>>#checkMethod:. Is it possible to obtain the matched string there? Because in that case we can get highlighting working which will be very useful. Cheers! Uko

Sept. 22, 2015

Re: [Pharo-dev] [Reflectivity] Slides ESUG talk

by roberto.minelli＠usi.ch

Hi Marcus, I am finally playing with Reflectivity. In the first place, thanks a lot for this contribution! I am wondering what is the âcorrectâ way to âremoveâ a MetaLink. Is it enough to call #uninstall on the MetaLink or should I also recompile the class/method where the link is installed? I spotted a problem with the control #after. If you try to pass #arguments to the meta, an error is returned. To reproduce: http://ws.stfx.eu/ONC4K9KQRTNQ Is this behavior somewhat desired, or is a bug? Dictionary>>errorKeyNotFound: [ self errorKeyNotFound: key ] in Dictionary>>at: in Block: [ self errorKeyNotFound: key ] Dictionary>>at:ifAbsent: Dictionary>>at: IRPushClosureCopy>>indexForVarNamed: IRTranslatorV2>>visitPushTemp: IRPushTemp>>accept: IRTranslatorV2(IRVisitor)>>visitNode: IRTranslatorV2>>visitInstruction: [ :instr | self visitInstruction: instr ] in IRTranslatorV2(IRVisitor)>>visitSequence: in Block: [ :instr | self visitInstruction: instr ] OrderedCollection>>do: IRSequence>>do: IRTranslatorV2(IRVisitor)>>visitSequence: IRTranslatorV2>>visitSequence: IRSequence>>accept: IRTranslatorV2(IRVisitor)>>visitNode: [ :each | self visitNode: each ] in IRTranslatorV2(IRVisitor)>>visitNodes: in Block: [ :each | self visitNode: each ] SortedCollection(OrderedCollection)>>do: IRTranslatorV2(IRVisitor)>>visitNodes: IRTranslatorV2>>visitSequences: IRTranslatorV2>>visitMethod: IRMethod>>accept: IRTranslatorV2(IRVisitor)>>visitNode: IRMethod>>generate: IRMethod>>compiledMethodWith: RBMethodNode>>generate: ReflectiveMethod>>recompileAST ReflectiveMethod>>compileAndInstallCompiledMethod ReflectiveMethod>>run:with:in: UndefinedObject>>DoIt Cheers, Roberto > On 04 Sep 2015, at 14:16, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > Hi Roberto, > > Very good! I am now working on #after for methods+sequence. *And* primitives... this should all be committed early next week. > > After that, I need to actually use it to find remaining problems, so this is very good that you will start now. > > Marcus > > On Thu, Sep 3, 2015 at 2:50 PM, roberto.minelli(a)usi.ch <roberto.minelli(a)usi.ch> wrote: > Very good talk Marcus. > > In the next weeks I will finally have some time to try Reflectivity out! > > Thanks a lot for all your effort! > > Cheers, > Roberto > > > On 31 Jul 2015, at 13:23, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > > > > >> On 15 Jul 2015, at 10:15, Marcus Denker <marcus.denker(a)inria.fr> wrote: > >> > >> Hi, > >> > >> the slides for my ESUG talk are online: > >> > >> http://www.slideshare.net/MarcusDenker/reflection-in-pharo5 > >> > >> > > > > Video is online, too: > > > > https://www.youtube.com/watch?v=Ik539CtjtTI > > > > > > > > Marcus > > > > > > > -- > -- > Marcus Denker -- denker(a)acm.org > http://www.marcusdenker.de

Sept. 22, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50336 Home: https://github.com/pharo-project/pharo-core

Sept. 22, 2015

[pharo-project/pharo-core] 88ba5f: 50336

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 88ba5fe1e6c51e2b28e1b31811a3b77d5d2922cc https://github.com/pharo-project/pharo-core/commit/88ba5fe1e6c51e2b28e1b318… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-09-22 (Tue, 22 Sep 2015) Changed paths: M Collections-Unordered.package/Dictionary.class/instance/accessing/at_ifPresent_ifAbsent_.st M Collections-Unordered.package/SmallDictionary.class/instance/accessing - values/at_ifPresent_ifAbsent_.st M ContributingToTheCatalogHelp.package/ContributingToTheCatalogHelp.class/README.md M ContributingToTheCatalogHelp.package/ContributingToTheCatalogHelp.class/class/as yet unclassified/pages.st R ContributingToTheCatalogHelp.package/ContributingToTheCatalogHelp.class/class/pages/AddingYourProject.st A ContributingToTheCatalogHelp.package/ContributingToTheCatalogHelp.class/class/pages/addingYourProject.st M ContributingToTheCatalogHelp.package/ContributingToTheCatalogHelp.class/class/pages/introduction.st M Fuel.package/FLLargeIdentityDictionary.class/instance/accessing/at_ifPresent_ifAbsent_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50335.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50336.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50335.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50336.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st A System-Announcements.package/ManifestSystemAnnouncements.class/class/meta-data - dependency analyser/ignoredDependencies.st M System-Hashing.package/SHA1.class/instance/private/initializeTotalsArray.st M System-Hashing.package/SHA1.class/instance/private/processBufferUsingPrimitives_.st M System-Hashing.package/SHA256.class/instance/private/initializeTotalsArray.st M System-OSEnvironments.package/OSEnvironment.class/instance/accessing/at_ifPresent_ifAbsent_.st Log Message: ----------- 50336 16603 System-Hashing should not depend on Graphics Primitives https://pharo.fogbugz.com/f/cases/16603 16615 Improve ContributingToTheCatalogHelp https://pharo.fogbugz.com/f/cases/16615 16614 To use at:ifPresent:ifAbsent:, ifPresent block argument should not be mandatory https://pharo.fogbugz.com/f/cases/16614 http://files.pharo.org/image/50/50336.zip

Sept. 22, 2015

Re: [Pharo-dev] Incorrect invalidation report

by Marcus Denker

Yes, something goes wrongâ¦ can you add an issue? > On 21 Sep 2015, at 14:58, Ben Coman <btc(a)openinworld.com> wrote: > > Before this report timesout, could someone knowing the CI backend > check this validation report... > > https://ci.inria.fr/pharo/job/Pharo-5.0-Issue-Validator/14283//artifact/val… > > The validation seems to have failed yet been reported as a success. > cheers -ben >

Sept. 22, 2015

Re: [Pharo-dev] TextAttributes in source code or class comment?

by phil＠highoctane.be

On Tue, Sep 22, 2015 at 9:13 AM, Tudor Girba <tudor(a)tudorgirba.com> wrote: > Hi, > > I think that having Pillar in comments is definitely the way to go. > > In: > > http://www.humane-assessment.com/blog/writing-pillar-books-with-the-gtinspe… > > I show also an extension that renders comments with PIllar highlighting. > This is working now in an inspector, but the same principle can be applied > to other browsers. > Yes, that's what I tried in the past. The ability to associate graphics explaining structures is really useful there. Phil > > Cheers, > Doru > > > > On Tue, Sep 22, 2015 at 8:47 AM, Christophe Demarey < > Christophe.Demarey(a)inria.fr> wrote: > >> >> Le 22 sept. 2015 Ã 07:49, philippe.back(a)highoctane.be a Ã©crit : >> >> >> Le 22 sept. 2015 07:40, "Sven Van Caekenberghe" <sven(a)stfx.eu> a Ã©crit : >> > >> > >> > > On 21 Sep 2015, at 23:53, stepharo <stepharo(a)free.fr> wrote: >> > > >> > > I think that having metadata (style) language and data (source code) >> mixed together is a bad idea. >> > > I never like the ]lang[ tag because it is a huge hack. It does not >> even exist in the Smalltalk syntax!!! >> > > We save code that the parser cannot parse. What we fun idea. >> > > So people are bashing for backward compatibility and we remove a bad >> way to encode >> > > metadata then suddenly it looks like we were doing something bad. >> > > >> > > Stef >> > >> > I am with Stef, it is a silly idea to mix the two. Nobody uses this in >> Pharo. Cleaning up means simplifying too. >> >> In the code no. But in the comments, that would be good to have back. In >> color form. As we can write pillar class comments, can't we render them ? >> Moose as an editor/viewer for pillar files >> >> >> Yes, it is where we want to go: use Pillar for styled comments. >> Once we have that, we can remove Text styling from source code / comments. >> >> > > > -- > www.tudorgirba.com > > "Every thing has its own flow" >

Sept. 22, 2015

Re: [Pharo-dev] TextAttributes in source code or class comment?

by Thierry Goubier

2015-09-22 9:10 GMT+02:00 Sven Van Caekenberghe <sven(a)stfx.eu>: > > > On 22 Sep 2015, at 08:47, Christophe Demarey < > Christophe.Demarey(a)inria.fr> wrote: > > > > > > Le 22 sept. 2015 Ã 07:49, philippe.back(a)highoctane.be a Ã©crit : > > > >> > >> Le 22 sept. 2015 07:40, "Sven Van Caekenberghe" <sven(a)stfx.eu> a Ã©crit > : > >> > > >> > > >> > > On 21 Sep 2015, at 23:53, stepharo <stepharo(a)free.fr> wrote: > >> > > > >> > > I think that having metadata (style) language and data (source > code) mixed together is a bad idea. > >> > > I never like the ]lang[ tag because it is a huge hack. It does not > even exist in the Smalltalk syntax!!! > >> > > We save code that the parser cannot parse. What we fun idea. > >> > > So people are bashing for backward compatibility and we remove a > bad way to encode > >> > > metadata then suddenly it looks like we were doing something bad. > >> > > > >> > > Stef > >> > > >> > I am with Stef, it is a silly idea to mix the two. Nobody uses this > in Pharo. Cleaning up means simplifying too. > >> > >> In the code no. But in the comments, that would be good to have back. > In color form. As we can write pillar class comments, can't we render them > ? Moose as an editor/viewer for pillar files > >> > >> > > > > Yes, it is where we want to go: use Pillar for styled comments. > > Once we have that, we can remove Text styling from source code / > comments. > > Yes, inside a comment, which should be totally opaque from a language > syntax standpoint, you can do whatever you want: HTML, Markdown, Pillar, > Pier, ... > But, if you want to integrate with IDE support for that extended syntax, then it would be nice to have an idea of the syntax used... Otherwise we're back at the special leading char to determine the format :( Side opinion to come to the point: I think that Pillar would make a better implementation than the ]style[ stuff. Thierry

Sept. 22, 2015

Re: [Pharo-dev] TextAttributes in source code or class comment?

by Tudor Girba

Hi, I think that having Pillar in comments is definitely the way to go. In: http://www.humane-assessment.com/blog/writing-pillar-books-with-the-gtinspe… I show also an extension that renders comments with PIllar highlighting. This is working now in an inspector, but the same principle can be applied to other browsers. Cheers, Doru On Tue, Sep 22, 2015 at 8:47 AM, Christophe Demarey < Christophe.Demarey(a)inria.fr> wrote: > > Le 22 sept. 2015 Ã 07:49, philippe.back(a)highoctane.be a Ã©crit : > > > Le 22 sept. 2015 07:40, "Sven Van Caekenberghe" <sven(a)stfx.eu> a Ã©crit : > > > > > > > On 21 Sep 2015, at 23:53, stepharo <stepharo(a)free.fr> wrote: > > > > > > I think that having metadata (style) language and data (source code) > mixed together is a bad idea. > > > I never like the ]lang[ tag because it is a huge hack. It does not > even exist in the Smalltalk syntax!!! > > > We save code that the parser cannot parse. What we fun idea. > > > So people are bashing for backward compatibility and we remove a bad > way to encode > > > metadata then suddenly it looks like we were doing something bad. > > > > > > Stef > > > > I am with Stef, it is a silly idea to mix the two. Nobody uses this in > Pharo. Cleaning up means simplifying too. > > In the code no. But in the comments, that would be good to have back. In > color form. As we can write pillar class comments, can't we render them ? > Moose as an editor/viewer for pillar files > > > Yes, it is where we want to go: use Pillar for styled comments. > Once we have that, we can remove Text styling from source code / comments. > > -- www.tudorgirba.com "Every thing has its own flow"

Sept. 22, 2015