- Pharo-dev - lists.pharo.org

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50411 Home: https://github.com/pharo-project/pharo-core

Oct. 30, 2015

Re: [Pharo-dev] #50409 regression

by Thierry Goubier

Le 29/10/2015 16:32, stepharo a Ã©crit : > >> >>> >>> 2015-10-28 16:19 GMT+01:00 stepharo >>> <<mailto:stepharo@free.fr>stepharo(a)free.fr>: >>> >>> I see this is annoying that comments are not polymorphic. >>> >>> >>> They could be :) >>> - an empty RBMethodNode with a comment attribute, >>> or >>> - a comment: message send with the comment as a parameter. >> >> Would be nice to have a tree node >> >> ClassComment >> >> >> You have RGCommentDefinition, no? > > And RBComment > So we should probably use them. >> >> >> The static representation of Pharo program can really be improved. >> >> I still want a full package. >> >> >> RGPackage? Or a unified AST-like structure? Even an AST is not that >> cool as a program representation. >> > I'm thorn because on one hand I would like to be able to express a > visitor for the complete compilation unit > and in particular package and extensions but may be we do not need to > have this nodes and just > have an object. I would be favor to have a nice and full AST > representation of the compilation unit. Well, you can unify Ring and RBMethodNode from the point of view of the visitor: you're not in Java where typing could be an issue. Note that I have a structure + visitor for the above AST level implemented in the AltBrowser (covers groups of groups of packages, packages, package tags, classes, extensions, protocols, methods, comments). Thierry

Oct. 29, 2015

Re: [Pharo-dev] #50409 regression

by stepharo

> >> >> 2015-10-28 16:19 GMT+01:00 stepharo <stepharo(a)free.fr >> <mailto:stepharo@free.fr>>: >> >> I see this is annoying that comments are not polymorphic. >> >> >> They could be :) >> - an empty RBMethodNode with a comment attribute, >> or >> - a comment: message send with the comment as a parameter. > > Would be nice to have a tree node > > ClassComment > > > You have RGCommentDefinition, no? And RBComment So we should probably use them. > > > The static representation of Pharo program can really be improved. > > I still want a full package. > > > RGPackage? Or a unified AST-like structure? Even an AST is not that > cool as a program representation. > I'm thorn because on one hand I would like to be able to express a visitor for the complete compilation unit and in particular package and extensions but may be we do not need to have this nodes and just have an object. I would be favor to have a nice and full AST representation of the compilation unit. Stef

Oct. 29, 2015

Re: [Pharo-dev] #50409 regression

by Thierry Goubier

2015-10-29 14:58 GMT+01:00 stepharo <stepharo(a)free.fr>: > > > 2015-10-28 16:19 GMT+01:00 stepharo <stepharo(a)free.fr>: > >> I see this is annoying that comments are not polymorphic. >> > > They could be :) > - an empty RBMethodNode with a comment attribute, > or > - a comment: message send with the comment as a parameter. > > > Would be nice to have a tree node > > ClassComment > You have RGCommentDefinition, no? > > The static representation of Pharo program can really be improved. > I still want a full package. > RGPackage? Or a unified AST-like structure? Even an AST is not that cool as a program representation. Thierry > > Stef > > > > Thierry > > >> >> Stef >> >> Le 28/10/15 11:05, Nicolai Hess a Ã©crit : >> >> >> >> 2015-10-28 15:33 GMT+01:00 stepharo < <stepharo(a)free.fr>stepharo(a)free.fr> >> : >> >>> Hi >>> >>> I typed 'Take' and source code with it. >>> - the progress bar does not update >>> >>> - more important when I click on the message browser I get a DNU ast >>> >>> autoSelect: aSelector >>> textModel readSelectionBlock: [ :text | >>> self selectedMessage >>> ifNotNil: [ :msg | >>> (self sourceIntervalOf: aSelector in: msg ast) >>> ^^^^^^^^^^^^^ >>> ifEmpty:[ self searchedString: aSelector >>> asString in: text ] ]] >>> >>> and RGCommentDefinition does not understand ast. >>> So what do we do? >>> >> >> It is a know bug ( at least, I know of it :) ) >> I changed the way the MessageBrowser selects the search term, >> because it always highlights the search term by "text" and not by "code" >> ,for example, in a "at:put:" senders MessageBrowser >> the first the highlighting started at the first >> at: >> although this is part of a at:ifAbsent: - message. >> >> at: #OneShotArmed ifAbsent: [ true ]) >> ifTrue: [ >> Smalltalk globals at: #OneShotArmed put: >> >> 16673 >> <https://pharo.fogbugz.com/f/cases/16673/Senders-of-highlights-wrong-code-se…> >> Senders of... highlights wrong code segment >> >> But I didn't take the "class-comment"-search results into account. >> >> >> >> >> >> >>> >>> Is it a well know bug? >>> >>> Stef >>> >>> >> >> > >

Oct. 29, 2015

Re: [Pharo-dev] #50409 regression

by stepharo

> > 2015-10-28 16:19 GMT+01:00 stepharo <stepharo(a)free.fr > <mailto:stepharo@free.fr>>: > > I see this is annoying that comments are not polymorphic. > > > They could be :) > - an empty RBMethodNode with a comment attribute, > or > - a comment: message send with the comment as a parameter. Would be nice to have a tree node ClassComment The static representation of Pharo program can really be improved. I still want a full package. Stef > > Thierry > > > Stef > > Le 28/10/15 11:05, Nicolai Hess a Ã©crit : >> >> >> 2015-10-28 15:33 GMT+01:00 stepharo <stepharo(a)free.fr >> <mailto:stepharo@free.fr>>: >> >> Hi >> >> I typed 'Take' and source code with it. >> - the progress bar does not update >> >> - more important when I click on the message browser I >> get a DNU ast >> >> autoSelect: aSelector >> textModel readSelectionBlock: [ :text | >> self selectedMessage >> ifNotNil: [ :msg | >> (self sourceIntervalOf: aSelector in: msg ast) >> ^^^^^^^^^^^^^ >> ifEmpty:[ self searchedString: >> aSelector asString in: text ] ]] >> >> and RGCommentDefinition does not understand ast. >> So what do we do? >> >> >> It is a know bug ( at least, I know of it :) ) >> I changed the way the MessageBrowser selects the search term, >> because it always highlights the search term by "text" and not by >> "code" ,for example, in a "at:put:" senders MessageBrowser >> the first the highlighting started at the first >> at: >> although this is part of a at:ifAbsent: - message. >> >> at: #OneShotArmed ifAbsent: [ true ]) >> ifTrue: [ >> Smalltalk globals at: #OneShotArmed put: >> >> 16673 >> <https://pharo.fogbugz.com/f/cases/16673/Senders-of-highlights-wrong-code-se…> >> Senders of... highlights wrong code segment >> >> But I didn't take the "class-comment"-search results into account. >> >> >> >> >> >> Is it a well know bug? >> >> Stef >> >> > >

Oct. 29, 2015

Re: [Pharo-dev] Nautilus not garbage collected ?

by stepharo

Le 29/10/15 06:30, Yuriy Tymchuk a Ã©crit : > Thanks Cyril. This is already solved in the upcoming version of quality assistant. But maybe we can add a test case like that, so in the future this will not repeat? yes excellent idea and thanks for QA! Thanks you cyril too. It is cool to have you around. Stef > > Uko > >> On 29 Oct 2015, at 10:45, Ferlicot D. Cyril <cyril.ferlicot(a)gmail.com> wrote: >> >> Hi, >> >> Yesterday I needed to browse the instances of >> FTPluggableIconListMorphAdaptor and I saw that I had 117 of these. >> So I browsed the instances of Nautilus and I saw I had a lot with no >> window open. >> >> On a new image I ran: >> >> 10 timesRepeat: [ >> |nautilus| >> nautilus := Object browse. >> nautilus close. >> ]. >> >> Then print: >> >> >> 10 timesRepeat: [ Smalltalk garbageCollect ]. >> Nautilus allInstances size. >> >> I get 10. >> >> If I launch the same in Pharo 4 (just replacing Nautilus by >> PackageTreeNautilus) I get 0. >> >> I checked the class that points Nautilus instances: >> >> (Nautilus allInstances flatCollectAsSet: #pointersTo) collect: #class. >> >> And I saw that QANautilusPlugin points to them. >> If I disable QANautilusPlugin the new instances of Nautilus are garbage >> collected. >> >> I am not sure but I think this comes from the SystemAnnoucement. >> >> Should I open a bug entry ? >> >> -- >> >> Cyril Ferlicot >> >> http://www.synectique.eu >> >> 165 Avenue Bretagne >> Lille 59000 France >> > >

Oct. 29, 2015

Re: [Pharo-dev] Nautilus not garbage collected ?

by Yuriy Tymchuk

Thanks Cyril. This is already solved in the upcoming version of quality assistant. But maybe we can add a test case like that, so in the future this will not repeat? Uko > On 29 Oct 2015, at 10:45, Ferlicot D. Cyril <cyril.ferlicot(a)gmail.com> wrote: > > Hi, > > Yesterday I needed to browse the instances of > FTPluggableIconListMorphAdaptor and I saw that I had 117 of these. > So I browsed the instances of Nautilus and I saw I had a lot with no > window open. > > On a new image I ran: > > 10 timesRepeat: [ > |nautilus| > nautilus := Object browse. > nautilus close. > ]. > > Then print: > > > 10 timesRepeat: [ Smalltalk garbageCollect ]. > Nautilus allInstances size. > > I get 10. > > If I launch the same in Pharo 4 (just replacing Nautilus by > PackageTreeNautilus) I get 0. > > I checked the class that points Nautilus instances: > > (Nautilus allInstances flatCollectAsSet: #pointersTo) collect: #class. > > And I saw that QANautilusPlugin points to them. > If I disable QANautilusPlugin the new instances of Nautilus are garbage > collected. > > I am not sure but I think this comes from the SystemAnnoucement. > > Should I open a bug entry ? > > -- > > Cyril Ferlicot > > http://www.synectique.eu > > 165 Avenue Bretagne > Lille 59000 France >

Oct. 29, 2015

Nautilus not garbage collected ?

by Ferlicot D. Cyril

Hi, Yesterday I needed to browse the instances of FTPluggableIconListMorphAdaptor and I saw that I had 117 of these. So I browsed the instances of Nautilus and I saw I had a lot with no window open. On a new image I ran: 10 timesRepeat: [ |nautilus| nautilus := Object browse. nautilus close. ]. Then print: 10 timesRepeat: [ Smalltalk garbageCollect ]. Nautilus allInstances size. I get 10. If I launch the same in Pharo 4 (just replacing Nautilus by PackageTreeNautilus) I get 0. I checked the class that points Nautilus instances: (Nautilus allInstances flatCollectAsSet: #pointersTo) collect: #class. And I saw that QANautilusPlugin points to them. If I disable QANautilusPlugin the new instances of Nautilus are garbage collected. I am not sure but I think this comes from the SystemAnnoucement. Should I open a bug entry ? -- Cyril Ferlicot http://www.synectique.eu 165 Avenue Bretagne Lille 59000 France

Oct. 29, 2015

[pharo-project/pharo-core] f83e5f: 50410

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: f83e5fe78c68ef6c5db1145682de91b1a0a18830 https://github.com/pharo-project/pharo-core/commit/f83e5fe78c68ef6c5db11456… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2015-10-29 (Thu, 29 Oct 2015) Changed paths: R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50409.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50410.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50409.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50410.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Spec-Tools.package/MessageBrowser.class/instance/announcements-registration/registerToAnnouncements.st A Spec-Tools.package/MessageBrowser.class/instance/announcements/classModified_.st A Spec-Tools.package/MessageBrowser.class/instance/announcements/classRenamed_.st A Spec-Tools.package/MessageBrowser.class/instance/announcements/handleClassRenamed_.st A Spec-Tools.package/MessageBrowser.class/instance/announcements/handleMethodAdded_.st A Spec-Tools.package/MessageBrowser.class/instance/announcements/handleMethodModified_.st A Spec-Tools.package/MessageBrowser.class/instance/announcements/handleMethodRemoved_.st M Spec-Tools.package/MessageBrowser.class/instance/announcements/methodAdded_.st M Spec-Tools.package/MessageBrowser.class/instance/announcements/methodModified_.st M Spec-Tools.package/MessageBrowser.class/instance/announcements/methodRemoved_.st A Spec-Tools.package/MessageBrowser.class/instance/announcements/shouldRefreshItem_fromAnnouncement_.st A Spec-Tools.package/MessageBrowser.class/instance/private/intervalOf_inCode_of_.st A Spec-Tools.package/MessageBrowser.class/instance/private/intervalOf_inCommentText_.st M Spec-Tools.package/MessageBrowser.class/instance/text selection/autoSelect_.st A StartupPreferences.package/StartupPreferencesLoader.class/class/menu/startupGeneralPrefererencesFolderMenuOn_.st M StartupPreferences.package/StartupPreferencesLoader.class/class/menu/startupLoaderMenuOn_.st A StartupPreferences.package/StartupPreferencesLoader.class/class/menu/startupPreferencesVersionFolderMenuOn_.st A StartupPreferences.package/StartupPreferencesLoader.class/class/menu/systemStartupMenuOn_.st Log Message: ----------- 50410 16883 Highlight in Senders of... throws a MNU if the search term was found in a class comment https://pharo.fogbugz.com/f/cases/16883 16818 Renaming a Class triggers debugger https://pharo.fogbugz.com/f/cases/16818 16886 Quick access to startup preferences folder https://pharo.fogbugz.com/f/cases/16886 http://files.pharo.org/image/50/50410.zip

Oct. 29, 2015

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50410 Home: https://github.com/pharo-project/pharo-core

Oct. 29, 2015