- Pharo-dev - lists.pharo.org

Starting to add class comment and test on BlElements

by stepharo

Hi blockers and alek in particular, the code is cool and I like that each method is commented. I'm starting to write a real class comment that we will be able to use in a documentation. But I cannot run the example so this is difficult to write tests. So Alek how do you know that you make progress? Where should I start? I thought BlElement was the starting point. Side note: Now I wonder if we want to have all the assert: May be yes and we should have an opal plugin to turn them off after. allChildrenDo: aBlock "Evaluate aBlock for all my children gathered recursively (excluding the receiver). aBlock must not be nil. aBlock must accept exactly one argument" self assert: aBlock isNotNil. self assert: aBlock argumentCount = 1. self childrenDo: [ :child | aBlock value: child. child allChildrenDo: aBlock ] Stef

Feb. 23, 2016

Re: [Pharo-dev] [pharo-project/pharo-core] a1da99: 50599

by stepharo

The session manager is managed as a configuration? Impressed! Stef Le 22/2/16 18:26, GitHub a Ã©crit : > > Log Message: > ----------- > 50599 > ConfigurationOfSessionManager > > http://files.pharo.org/image/50/50599.zip > >

Feb. 23, 2016

[Bloc] MDLColor and new gradient

by stepharo

Hi Guillaume Larcheveque in Telescope added support for MDLColor http://www.materialui.co/colors and nice gradient building. I asked him if we could extract this functionality and move it into Pharo because it will be usefull for Pharo, Bloc, and Roassal. A first step could be to have MDLColor subclass as it is now but the second step would be to rethink Color and palette. May be we should have some Palette And we could have (brainstorming) (ColorBuilder from: MDLPalette) -> aColorBuilder aColorBuilder red -> .... Stef

Feb. 23, 2016

Re: [Pharo-dev] MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules

by Sven Van Caekenberghe

it is in an extension protocol, like fuel and others > On 23 Feb 2016, at 08:39, stepharo <stepharo(a)free.fr> wrote: > > May be I got wrong what you say. > > But we should not link metaclass or > > TApplyingOnClassSide on Ston. > > > Le 20/2/16 12:34, Henrik Nergaard a Ã©crit : >> Ah, test testMetaclass. Somehow I only read testClass.... >> >> Moving those two methods from Metaclass to TApplyingOnClassSide should make the test happy. >> >> Best regards, >> Henrik >> >> -----Original Message----- >> From: Pharo-dev [mailto:pharo-dev-bounces@lists.pharo.org] On Behalf Of Sven Van Caekenberghe >> Sent: Saturday, February 20, 2016 11:58 AM >> To: Pharo Development List <pharo-dev(a)lists.pharo.org> >> Subject: Re: [Pharo-dev] MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules >> >> If I add (in #50591) my methods to the exception set in the middle, the test is green >> >> self >> assert: >> (Metaclass localSelectors difference: ClassTrait localSelectors) >> = >> {#externalTypeAlias:. >> #baseClass. >> #basicLocalSelectors:. >> #basicLocalSelectors. >> #classClass. >> #isClass. >> #stonName. "<<<" >> #stonOn:. "<<<" >> #environment. >> #fileOutOn:. >> #fileOutOn:initializing:. >> #postCopy. >> #traitComposition. >> #traitComposition:. >> #veryDeepCopyWith:} asSet. >> >> I don't know about the other failures. >> >>> On 20 Feb 2016, at 11:37, Henrik Nergaard <henrik.nergaard(a)uia.no> wrote: >>> >>> The issue should be unrelated: >>> >>> https://pharo.fogbugz.com/f/cases/17616/CI-Server-Failing-tests-related-to-… >>> >>> Best regards, >>> Henrik >>> >>> -----Original Message----- >>> From: Pharo-dev [mailto:pharo-dev-bounces@lists.pharo.org] On Behalf Of Sven Van Caekenberghe >>> Sent: Saturday, February 20, 2016 11:05 AM >>> To: Pharo Development List <pharo-dev(a)lists.pharo.org> >>> Subject: [Pharo-dev] MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules >>> >>> Hi, >>> >>> I am trying to load a new version of STON in Pharo 5 >>> >>> https://pharo.fogbugz.com/f/cases/16893/Update-STON >>> >>> One of the tests that fails is MetaclassTest>>testMetaclassAndTraitClassRespectsPolymorphismRules >>> >>> More specifically, (Metaclass localSelectors difference: ClassTrait localSelectors) is no longer equal to the exceptions defined in the test because #stonName and #stonOn: were added to Metaclass >>> >>> What should I do ? Did I do something wrong ? >>> >>> Should I add to the exceptions defined in the test or should I add them to ClassTrait ? >>> >>> I think the first sounds the most correct. >>> >>> Thx, >>> >>> Sven >>> >>> >> >> >> > >

Feb. 23, 2016

[pharo-project/pharo-core] 10d1e2: 50601

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 10d1e26878c91a8e25242c83e2bf25df490b56cf https://github.com/pharo-project/pharo-core/commit/10d1e26878c91a8e25242c83… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-02-23 (Tue, 23 Feb 2016) Changed paths: M ConfigurationOfCatalog.package/ConfigurationOfCatalog.class/instance/symbolic versions/stable_.st A ConfigurationOfCatalog.package/ConfigurationOfCatalog.class/instance/versions/version%5F0%5F11%5F1_.st M Rubric.package/RubShoutStylerDecorator.class/instance/editing/style_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50600.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50601.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50600.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50601.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Tool-Catalog.package/CatalogProject.class/instance/installing/installVersion_.st Log Message: ----------- 50601 17674 catalog command line installer needs to resume on warning https://pharo.fogbugz.com/f/cases/17674 16020 Syntax Highlighting Rubric: First shows non-highlighted text, then color. Looks slow https://pharo.fogbugz.com/f/cases/16020 http://files.pharo.org/image/50/50601.zip

Feb. 23, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50601 Home: https://github.com/pharo-project/pharo-core

Feb. 23, 2016

Re: [Pharo-dev] double selection in the debugger is confusing

by Nicolai Hess

2016-02-23 8:46 GMT+01:00 stepharo <stepharo(a)free.fr>: > > > Le 22/2/16 09:50, Nicolai Hess a Ã©crit : > > > > 2016-02-21 19:19 GMT+01:00 stepharo <stepharo(a)free.fr>: > >> Here this is terribly confusing because we could think that the execution >> will go inside >> the true block but no in reality it is jumping right after. >> So we must remove this selection of matching terms. >> > > This was always like that, but with rubric, the "second selection" > highlight is much more visible. > In older non-rubric text handling, the second selection was just a pale > light color, without border. > > Maybe we should remove the border for rubrics "second selection" text > highlight. > > > Yes! > Ok, I'll open an issue entry and provide a fix. And you can discuss with Esteban if we want to include this in the code freeze :-) > > > > >> >> Stef >> >> Le 21/2/16 19:04, stepharo a Ã©crit : >> >> Hi guy >>> >>> we should disable the double selection when we click on a stack element >>> because we get selection in frame and in fill and this is confusing >>> because the PC is represented by the filled >>> one. >>> >>> Stef >>> >> >> >> > >

Feb. 23, 2016

Re: [Pharo-dev] How was BoxedFloat64 integrated into the image ?

by Nicolai Hess

2016-02-23 3:55 GMT+01:00 Eliot Miranda <eliot.miranda(a)gmail.com>: > Hi Nicolai, > > there is a hairy script that moves methods around the hierarchy. IIRC > Float is renamed to BoxedFloat64, then a new Float is introduced, then > BoxedFloat64 made to inherit from it. It's likely that the last step of > this script, which replaces the methodClassAssociations in the moved > methods (makes those BoxedFloat64 methods that used to be Float or maybe > vice verse) with the right association, didn't work. > > I don't know how the Pharo 5 image is built. If it is incremental then > just write a script to fix the associations. But if the image is produced > by a bootstrap you'll need to track down the script that creates the > revised Float hierarchy and fix it to work properly in Pharo. > > _,,,^..^,,,_ (phone) > Thanks Eliot, The methods for c lass Float and BoxedFloat are looking fine. Whats wrong is, that some other methods referring to class Float in there source, now having BoxedFloat in its compiled method literal array, #BoxedFloat64->BoxedFloat64 instead of #Float->Float. But it looks like recompiling the whole image fixes this. nicolai > > On Feb 18, 2016, at 2:47 AM, Nicolai Hess <nicolaihess(a)gmail.com> wrote: > > Because we have compiled methods with BoxedFloat64 associations in the > methods literals, but the source code still shows only "Float". > > 17638 > <https://pharo.fogbugz.com/f/cases/17638/Browsing-calls-on-BoxedFloat64-show…> > Browsing calls on BoxedFloat64 shows methods with reference to BoxedFloat64 > in the code > > > >

Feb. 23, 2016

Re: [Pharo-dev] double selection in the debugger is confusing

by stepharo

Le 22/2/16 09:50, Nicolai Hess a Ã©crit : > > > 2016-02-21 19:19 GMT+01:00 stepharo <stepharo(a)free.fr > <mailto:stepharo@free.fr>>: > > Here this is terribly confusing because we could think that the > execution will go inside > the true block but no in reality it is jumping right after. > So we must remove this selection of matching terms. > > > This was always like that, but with rubric, the "second selection" > highlight is much more visible. > In older non-rubric text handling, the second selection was just a > pale light color, without border. > > Maybe we should remove the border for rubrics "second selection" text > highlight. Yes! > > > Stef > > Le 21/2/16 19:04, stepharo a Ã©crit : > > Hi guy > > we should disable the double selection when we click on a > stack element > because we get selection in frame and in fill and this is > confusing because the PC is represented by the filled > one. > > Stef > > > >

Feb. 23, 2016

Re: [Pharo-dev] Why the GTSpotter help does not explain all the categories

by stepharo

Doru is it the title: 'References' that is used to represent #references? I do not get it, I have ot guess. Showing people the implementation does not automatically explain. The help is missing some text (no idea if this is correct). " Each Extensions methods (e.g. spotterCompositionFor:) defines the category tags that you can type in the input field Point #traits? Point #composing traits? For the people loving implementation detail, the title of the listProcessor is used as categories. " Stef Le 22/2/16 10:24, Tudor Girba a Ã©crit : > Hi, > > Indeed, this is a problem: > https://pharo.fogbugz.com/f/cases/17668/Spotter-should-allow-filtering-cate… > > Now, I enhanced the category matching to ignore the whitespace. So, now you can say: > #Classinstancevariables > > Another option would be to change the names of categories to have underscore instead of space. Like this: > #Class_instance_variables > > What do you think? > > Cheers, > Doru > > >> On Feb 21, 2016, at 7:22 PM, stepharo <stepharo(a)free.fr> wrote: >> >> Thanks but it does not really help understanding. At least I do not get it at all. >> >> I have no idea how from >> >> Class instance variables >> >> I should type something meaningfull. >> >> >> I could get it for Examples, Implementors, Senders because there is only one word. >> >> >> >> >> Le 20/2/16 14:34, Tudor Girba a Ã©crit : >>> We added the mechanism and created a kind of an API entry for documenting all entries within the image. This was one of your request: to know what are all the different searches possible :). >>> >>> Doru >>> >>> >>>> On Feb 20, 2016, at 2:26 PM, stepharo <stepharo(a)free.fr> wrote: >>>> >>>> Hi >>>> >>>> So I tried again to understand how spotter works and I looked at the help and I could not understand >>>> how I can find class references. >>>> >>>> I saw that but it does not show me how I can use it and I do not really want to understand how this is implemented. >>>> >>>> spotterReferenceFor: aStep >>>> <spotterOrder: 30> >>>> aStep listProcessor >>>> title: 'References'; >>>> allCandidates: [ (SystemNavigation default allReferencesTo: self binding) collect: #compiledMethod ]; >>>> itemName: [ :method | method gtDisplayString ]; >>>> filter: GTFilterSubstring >>>> >>>> >>>> >>>> To me this help is totally obscure. >>>> >>>> >>>> Spotter allows the developer to define custom search processors in different classes. These custom processors take effect when Spotter reaches an instance of the extended class. You can find below the list of extensions from this image. >>>> >>>> You can also browse this list by inspecting: >>>> >>>> GTSpotter spotterExtendingMethods >>>> >>>> Behavior >>>> - Class instance variables (spotterClassInstanceVariablesFor:) >>>> - Composing traits (spotterCompositionFor:) >>>> - Instance variables (spotterInstanceVariablesFor:) >>>> - QA Critics (spotterQACriticsFor:) >>>> - All subclasses (spotterSubclassesFor:) >>>> - All superclasses (spotterSuperclassesFor:) >>>> - Users (spotterTraitUsersFor:) >>>> - Special Slots (spotterUsedSlotsFor:) >>>> - Uses Traits (spotterUsedTraitsFor:) >>>> >>>> Class >>>> - Examples (gtSpotterGTExamplesFor:) >>>> - Class methods (spotterClassMethodsFor:) >>>> - Instance methods (spotterMethodsFor:) >>>> - References (spotterReferenceFor:) >>>> - Super class methods (spotterSuperClassMethodsFor:) >>>> - Super instance methods (spotterSuperMethodsFor:) >>>> >>>> ClassDescription >>>> - Package (spotterPackageFor:) >>>> >>>> Collection >>>> - spotterItemsFor: (spotterItemsFor:) >>>> >>>> CompiledMethod >>>> - Bytecode (spotterForBytecodesFor:) >>>> - Implementors (spotterForImplementorsFor:) >>>> - Senders (spotterForSendersFor:) >>>> - Class (spotterMethodClassFor:) >>>> - QA Critics (spotterQACriticsFor:) >>>> >>>> Dictionary >>>> - Keys (spotterForKeysFor:) >>>> >>>> FileReference >>>> - Directories (spotterForDirectoriesFor:) >>>> - Files (spotterForFilesFor:) >>>> - Directories (spotterForZipDirectoriesFor:) >>>> - Files (spotterForZipFilesFor:) >>>> >>>> GTExample >>>> - Example Dependencies (gtSpotterDependenciesFor:) >>>> - Example Dependents (gtSpotterDependentsFor:) >>>> - Example Provider (gtSpotterProviderFor:) >>>> - Example Source (gtSpotterSourceFor:) >>>> - Example Subjects (gtSpotterSubjectsFor:) >>>> >>>> GTExampleFinder >>>> - Examples (gtSpotterExamplesFor:) >>>> >>>> GTExampleFinder class >>>> - Examples (gtSpotterExamplesFor:) >>>> >>>> GTExampleOrganizer >>>> - Examples (gtSpotterGTExamplesFor:) >>>> >>>> GTExampleProxy >>>> - Example Dependencies (gtSpotterDependenciesFor:) >>>> - Example Dependents (gtSpotterDependentsFor:) >>>> >>>> GTInspector class >>>> - Extensions (spotterExtensionsFor:) >>>> >>>> GTSelectorImplementors >>>> - Implementors (spotterImplementorsFor:) >>>> - Senders (spotterSendersFor:) >>>> >>>> GTSpotter >>>> - Examples (gtSpotterExamplesFor:) >>>> - Catalog Projects (spotterCatalogProjectsFor:) >>>> - Clipboard History (spotterClipboardFor:) >>>> - Methods (spotterConcreteMethodFor:) >>>> - Dirty Monticello packages (spotterDirtyMonticelloPackagesFor:) >>>> - Playground cached pages (spotterForCachedPlaygroundPagesFor:) >>>> - Classes (spotterForClassesFor:) >>>> - Directories (spotterForDirectoriesFor:) >>>> - Calculator (spotterForExpressionsFor:) >>>> - Files (spotterForFilesFor:) >>>> - Global variables (spotterForGlobalVarsFor:) >>>> - Help topics (spotterForHelpTopicFor:) >>>> - Messages (spotterForMessagesFor:) >>>> - Metacello Configurations (spotterForMetacelloConfigurationsFor:) >>>> - Packages (spotterForPackagesFor:) >>>> - Pragmas (spotterForPragmasFor:) >>>> - References (spotterForReferencesFor:) >>>> - Monticello Repositories (spotterForRepositoriesFor:) >>>> - Senders (spotterForSendersFor:) >>>> - spotterForStashedPlaygroundPagesFor: (spotterForStashedPlaygroundPagesFor:) >>>> - History (spotterHistoryFor:) >>>> - Implementors (spotterImplementorsFor:) >>>> - ws.stfx.eu (spotterStfxFor:) >>>> - Menu (spotterWorldMenuFor:) >>>> >>>> GTSpotter class >>>> - Extensions (spotterExtensionsFor:) >>>> >>>> GTSpotterExceptionMock1 >>>> - mockProcessorFor: (mockProcessorFor:) >>>> >>>> GTSpotterExceptionMock2 >>>> - mockProcessorFor: (mockProcessorFor:) >>>> >>>> GTSpotterExceptionMock3 >>>> - mockProcessorFor: (mockProcessorFor:) >>>> >>>> GTSpotterExceptionMock4 >>>> - mockProcessorFor: (mockProcessorFor:) >>>> >>>> GTSpotterExceptionMock5 >>>> - mockProcessorFor: (mockProcessorFor:) >>>> >>>> GlobalVariable >>>> - Class (spotterClassFor:) >>>> - References (spotterForReferencesFor:) >>>> >>>> HelpTopic >>>> - Help contents (spotterForHelpTopicFor:) >>>> >>>> KMDispatcher >>>> - Keys (spotterForKeysFor:) >>>> >>>> MCPackage >>>> - Packages (spotterForPackageFor:) >>>> - Monticello Working Copy (spotterMonticelloWorkingCopyFor:) >>>> >>>> MCVersionInfo >>>> - Ancestors (spotterAncestorsFor:) >>>> >>>> MCWorkingCopy >>>> - All other repositories (spotterAllRepositoriesFor:) >>>> - Ancestors (spotterAncestorsFor:) >>>> - Monticello Package (spotterMonticelloPackageFor:) >>>> - Packages (spotterPackageFor:) >>>> - Package repositories (spotterPackageRepositoriesFor:) >>>> >>>> MenuItemMorph >>>> - spotterItemsFor: (spotterItemsFor:) >>>> >>>> MenuMorph >>>> - Items (spotterItemsFor:) >>>> >>>> MetacelloAbstractPackageSpec >>>> - Includes (spotterForIncludesFor:) >>>> - Requires (spotterForRequiresFor:) >>>> >>>> MetacelloProject >>>> - Versions (spotterForVersionsFor:) >>>> >>>> MetacelloVersion >>>> - Groups (spotterForGroupsFor:) >>>> - Packages (spotterForPackagesFor:) >>>> >>>> Morph >>>> - spotterForKeysFor: (spotterForKeysFor:) >>>> - Submorphs (spotterForSubmorphsFor:) >>>> >>>> PragmaType >>>> - Pragmas (spotterPragmasFor:) >>>> - Senders (spotterSendersFor:) >>>> >>>> RPackage >>>> - Classes (spotterClassesFor:) >>>> - Extension Methods (spotterExtensionMethodsFor:) >>>> - Monticello Package (spotterMonticelloPackageFor:) >>>> - Monticello Working Copy (spotterMonticelloWorkingCopyFor:) >>>> - Tags (spotterTagsFor:) >>>> >>>> RPackageTag >>>> - Classes (spotterClassesFor:) >>>> >>>> SettingNode >>>> - Children (spotterForSettingsFor:) >>>> >>>> SettingTree >>>> - Settings (spotterForSettingsFor:) >>>> >>>> Slot >>>> - Accesses (spotterAccessesFor:) >>>> >>>> Trait >>>> - Examples (gtSpotterGTExamplesFor:) >>>> - Class methods (spotterClassMethodsFor:) >>>> - Instance methods (spotterMethodsFor:) >>>> - References (spotterReferenceFor:) >>>> - Super class methods (spotterSuperClassMethodsFor:) >>>> - Super instance methods (spotterSuperMethodsFor:) >>>> >>>> TraitBehavior >>>> - Class instance variables (spotterClassInstanceVariablesFor:) >>>> - Composing traits (spotterCompositionFor:) >>>> - Instance variables (spotterInstanceVariablesFor:) >>>> - QA Critics (spotterQACriticsFor:) >>>> - All subclasses (spotterSubclassesFor:) >>>> - All superclasses (spotterSuperclassesFor:) >>>> - Users (spotterTraitUsersFor:) >>>> - Special Slots (spotterUsedSlotsFor:) >>>> - Uses Traits (spotterUsedTraitsFor:) >>>> >>>> TraitDescription >>>> - Package (spotterPackageFor:) >>>> >>>> >>>> >>> -- >>> www.tudorgirba.com >>> www.feenk.com >>> >>> "Reasonable is what we are accustomed with." >>> >>> >>> >> > -- > www.tudorgirba.com > www.feenk.com > > "Quality cannot be an afterthought." > > >

Feb. 23, 2016