- Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Catching Exceptions without any notice

by Richard Sargent

Nicolas Cellier wrote > Isn't catching too wide an anti-pattern? Yes! Just think of all the Exception subclasses which are *not* errors. This kind of thing effectively disables them. > 2016-03-30 13:33 GMT+02:00 Nicolai Hess < > nicolaihess@ > >: > >> Please don't do this: >> >> updateHeight >> "no need to care about height, when it's logic is not customized" >> self layout isHeightCustom ifFalse: [ ^ self ]. >> [ self bounds: (self brickBounds withHeight: self customHeight) ] >> on: Exception >> do: [ "just skip and do nothing" ] >> >> This makes debugging GLM/Brick ui/layout code with "self haltOnce" >> impossible. >> see >> GLMBrickGeometryTrait>>#updateHeight >> GLMBrickGeometryTrait>>#updateWidth >> >> And if you log out the raised exception, you see some calls to >> not initialized fonts and a ZeroDevide and some more errors. >> The above catch, catches and hides wrong / to late initialized objects. >> -- View this message in context: http://forum.world.st/Catching-Exceptions-without-any-notice-tp4887402p4887… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

March 30, 2016

Re: [Pharo-dev] Catching Exceptions without any notice

by Nicolas Cellier

Isn't catching too wide an anti-pattern? 2016-03-30 13:33 GMT+02:00 Nicolai Hess <nicolaihess(a)gmail.com>: > Please don't do this: > > updateHeight > "no need to care about height, when it's logic is not customized" > self layout isHeightCustom ifFalse: [ ^ self ]. > [ self bounds: (self brickBounds withHeight: self customHeight) ] > on: Exception > do: [ "just skip and do nothing" ] > > This makes debugging GLM/Brick ui/layout code with "self haltOnce" > impossible. > see > GLMBrickGeometryTrait>>#updateHeight > GLMBrickGeometryTrait>>#updateWidth > > And if you log out the raised exception, you see some calls to > not initialized fonts and a ZeroDevide and some more errors. > The above catch, catches and hides wrong / to late initialized objects. >

March 30, 2016

Catching Exceptions without any notice

by Nicolai Hess

Please don't do this: updateHeight "no need to care about height, when it's logic is not customized" self layout isHeightCustom ifFalse: [ ^ self ]. [ self bounds: (self brickBounds withHeight: self customHeight) ] on: Exception do: [ "just skip and do nothing" ] This makes debugging GLM/Brick ui/layout code with "self haltOnce" impossible. see GLMBrickGeometryTrait>>#updateHeight GLMBrickGeometryTrait>>#updateWidth And if you log out the raised exception, you see some calls to not initialized fonts and a ZeroDevide and some more errors. The above catch, catches and hides wrong / to late initialized objects.

March 30, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50670 Home: https://github.com/pharo-project/pharo-core

March 30, 2016

[pharo-project/pharo-core] e62014: 50670

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: e6201426356538085bce73dd55c249cbb59e010d https://github.com/pharo-project/pharo-core/commit/e6201426356538085bce73dd… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-03-30 (Wed, 30 Mar 2016) Changed paths: M ConfigurationOfDependencyAnalyser.package/ConfigurationOfDependencyAnalyser.class/instance/symbolic versions/stable_.st A ConfigurationOfDependencyAnalyser.package/ConfigurationOfDependencyAnalyser.class/instance/versions/version116_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50669.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50670.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50669.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50670.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st A Tool-DependencyAnalyser-UI.package/DAReverseDependentPackageNode.class/instance/accessing/rPackage.st A Tool-DependencyAnalyser-UI.package/DAReversePackageNode.class/instance/accessing/rPackage.st M Tool-DependencyAnalyser.package/DAMessageSendAnalyzer.class/instance/accessing/packageStaticDependencies.st M Tool-DependencyAnalyser.package/DAMessageSendAnalyzer.class/instance/computing/implementedMessages.st Log Message: ----------- 50670 17886 dependency analyzer throws DNU on reverse analysis https://pharo.fogbugz.com/f/cases/17886 http://files.pharo.org/image/50/50670.zip

March 30, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50669 Home: https://github.com/pharo-project/pharo-core

March 30, 2016

[pharo-project/pharo-core] 10a766: 50669

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: 10a766404faec99e7ff627ab14c326d29de419df https://github.com/pharo-project/pharo-core/commit/10a766404faec99e7ff627ab… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-03-30 (Wed, 30 Mar 2016) Changed paths: M ConfigurationOfGTDebugger.package/ConfigurationOfGTDebugger.class/instance/symbolic versions/stable_.st A ConfigurationOfGTDebugger.package/ConfigurationOfGTDebugger.class/instance/versions/version25_.st M ConfigurationOfGTEventRecorder.package/ConfigurationOfGTEventRecorder.class/instance/symbolic versions/stable_.st A ConfigurationOfGTEventRecorder.package/ConfigurationOfGTEventRecorder.class/instance/versions/version014_.st M ConfigurationOfGTInspectorCore.package/ConfigurationOfGTInspectorCore.class/instance/symbolic versions/stable_.st A ConfigurationOfGTInspectorCore.package/ConfigurationOfGTInspectorCore.class/instance/versions/version36_.st M ConfigurationOfGTPlaygroundCore.package/ConfigurationOfGTPlaygroundCore.class/instance/symbolic versions/stable_.st A ConfigurationOfGTPlaygroundCore.package/ConfigurationOfGTPlaygroundCore.class/instance/versions/version36_.st M ConfigurationOfGTSpotter.package/ConfigurationOfGTSpotter.class/instance/symbolic versions/stable_.st A ConfigurationOfGTSpotter.package/ConfigurationOfGTSpotter.class/instance/versions/version26_.st M ConfigurationOfGToolkitCore.package/ConfigurationOfGToolkitCore.class/instance/symbolic versions/stable_.st A ConfigurationOfGToolkitCore.package/ConfigurationOfGToolkitCore.class/instance/versions/version317_.st M ConfigurationOfGlamourCore.package/ConfigurationOfGlamourCore.class/instance/symbolic versions/stable_.st A ConfigurationOfGlamourCore.package/ConfigurationOfGlamourCore.class/instance/versions/version49_.st M GT-Debugger.package/GTChangeDebuggerAction.class/definition.st A GT-Debugger.package/GTChangeDebuggerAction.class/instance/accessing/newDebugger.st M GT-Debugger.package/GTChangeDebuggerAction.class/instance/actions/executeAction.st A GT-Debugger.package/GTDebuggerBrowserUpdateRequest.class/README.md A GT-Debugger.package/GTDebuggerBrowserUpdateRequest.class/class/instance-creation/from_.st A GT-Debugger.package/GTDebuggerBrowserUpdateRequest.class/definition.st A GT-Debugger.package/GTDebuggerBrowserUpdateRequest.class/instance/accessing/debugActionExecutedAnnouncement.st A GT-Debugger.package/GTDebuggerBrowserUpdateRequest.class/instance/initialization/from_.st R GT-Debugger.package/GTGenericStackDebugger.class/instance/accessing/window.st M GT-Debugger.package/GTGenericStackDebugger.class/instance/updating/selectionChanged_.st A GT-Debugger.package/GTGenericStackDebuggerSelectionChanged.class/README.md A GT-Debugger.package/GTGenericStackDebuggerSelectionChanged.class/class/instance creation/forDebugger_.st A GT-Debugger.package/GTGenericStackDebuggerSelectionChanged.class/definition.st A GT-Debugger.package/GTGenericStackDebuggerSelectionChanged.class/instance/accessing/debugger.st A GT-Debugger.package/GTGenericStackDebuggerSelectionChanged.class/instance/accessing/newContext.st A GT-Debugger.package/GTGenericStackDebuggerSelectionChanged.class/instance/initialization/forDebugger_.st A GT-Debugger.package/GTGlamourWrapperDebuggingAction.class/instance/initialization/initialize.st M GT-Debugger.package/GTGlamourWrapperDebuggingAction.class/instance/transformation/asGlamourAction.st M GT-Debugger.package/GTMoldableDebugger.class/class/accessing/defaultTitle.st M GT-Debugger.package/GTMoldableDebugger.class/class/accessing/sessionClass.st M GT-Debugger.package/GTMoldableDebugger.class/instance/actions/debug_using_.st M GT-Debugger.package/GTMoldableDebugger.class/instance/building/debuggerStructureIn_.st M GT-Debugger.package/GTMoldableDebugger.class/instance/callbacks/windowIsClosing.st A GT-Debugger.package/GTMoldableDebugger.class/instance/scripting opening/open.st M GT-Debugger.package/GTMoldableDebugger.class/instance/scripting opening/openOn_.st M GT-Debugger.package/GTMoldableDebugger.class/instance/updating/updateBrowserFrom_.st M GT-EventRecorder-Tests.package/GTDummyEvent.class/definition.st M GT-EventRecorder-Tests.package/GTEventBundleTest.class/definition.st M GT-EventRecorder-Tests.package/GTEventCollectorsTest.class/definition.st M GT-EventRecorder-Tests.package/GTEventConsolidateTest.class/definition.st M GT-EventRecorder-Tests.package/GTEventDeliveryTest.class/definition.st M GT-EventRecorder-Tests.package/GTEventMultiBundleFactoryTest.class/definition.st M GT-EventRecorder-Tests.package/GTEventMultiBundleTest.class/definition.st M GT-EventRecorder-Tests.package/GTEventPackingTest.class/definition.st A GT-EventRecorder-Tests.package/GTEventRecorderTest.class/instance/as yet unclassified/testPrivacyChanged.st A GT-EventRecorder-Tests.package/GTEventRecorderTest.class/instance/as yet unclassified/testPrivacyChanged2.st A GT-EventRecorder-Tests.package/GTEventRecorderTest.class/instance/as yet unclassified/testPrivacyChanged3.st A GT-EventRecorder-Tests.package/GTEventRecorderTest.class/instance/as yet unclassified/testPrivacyChanged4.st M GT-EventRecorder-Tests.package/GTEventRegistryTest.class/definition.st M GT-EventRecorder-Tests.package/GTEventUnpackingTest.class/definition.st M GT-EventRecorder-Tests.package/GTFuelPackingTest.class/definition.st M GT-EventRecorder-Tests.package/GTStonPackingTest.class/definition.st M GT-EventRecorder.package/GTEventDelivery.class/instance/activation/activate.st M GT-EventRecorder.package/GTEventRecorder.class/definition.st A GT-EventRecorder.package/GTEventRecorder.class/instance/accessing/announcer.st M GT-EventRecorder.package/GTEventRecorder.class/instance/adding/addCollector_.st A GT-EventRecorder.package/GTEventRecorder.class/instance/delivery/activateDeliveryIfAvailable.st A GT-Inspector.package/GTCurrentExampleContext.class/README.md A GT-Inspector.package/GTCurrentExampleContext.class/class/accessing-defaults/defaultValue.st A GT-Inspector.package/GTCurrentExampleContext.class/class/evaluating/use_during_.st A GT-Inspector.package/GTCurrentExampleContext.class/class/evaluating/value.st A GT-Inspector.package/GTCurrentExampleContext.class/definition.st A GT-Inspector.package/GTCurrentExampleContext.class/instance/accessing-defaults/defaultAction.st A GT-Inspector.package/GTDummyExamplesWithAfter.class/README.md A GT-Inspector.package/GTDummyExamplesWithAfter.class/class/as yet unclassified/a_.st A GT-Inspector.package/GTDummyExamplesWithAfter.class/class/as yet unclassified/afterA.st A GT-Inspector.package/GTDummyExamplesWithAfter.class/class/as yet unclassified/afterB.st A GT-Inspector.package/GTDummyExamplesWithAfter.class/class/as yet unclassified/afterC.st A GT-Inspector.package/GTDummyExamplesWithAfter.class/class/as yet unclassified/b_.st A GT-Inspector.package/GTDummyExamplesWithAfter.class/class/as yet unclassified/c.st A GT-Inspector.package/GTDummyExamplesWithAfter.class/definition.st A GT-Inspector.package/GTDummyExamplesWithContext.class/README.md A GT-Inspector.package/GTDummyExamplesWithContext.class/class/as yet unclassified/a.st A GT-Inspector.package/GTDummyExamplesWithContext.class/class/as yet unclassified/b_c_.st A GT-Inspector.package/GTDummyExamplesWithContext.class/class/as yet unclassified/c.st A GT-Inspector.package/GTDummyExamplesWithContext.class/definition.st M GT-Inspector.package/GTExample.class/definition.st A GT-Inspector.package/GTExample.class/instance/accessing/after.st A GT-Inspector.package/GTExample.class/instance/pragma-selectors/afterClass_selector_.st A GT-Inspector.package/GTExample.class/instance/pragma-selectors/after_.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/dependsAll_.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/dependsClass_selector_.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/depends_.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/description_.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/gtExample.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/iconBase64_.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/iconBytes_.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/iconClass_selector_.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/iconSelectorBase64_.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/iconSelector_.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/iconThemeSelector_.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/icon_.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/label_.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/noCache.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/noTest.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/notTestReport.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/raisesAny_.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/raises_.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/subject_.st M GT-Inspector.package/GTExample.class/instance/pragma-selectors/subjectsAll_.st A GT-Inspector.package/GTExample.class/instance/private/proxyForClass_selector_.st A GT-Inspector.package/GTExample.class/instance/private/proxyForProvider_selector_.st A GT-Inspector.package/GTExample.class/instance/private/proxyForSelector_.st A GT-Inspector.package/GTExampleContext.class/README.md A GT-Inspector.package/GTExampleContext.class/definition.st A GT-Inspector.package/GTExampleEvaluator.class/instance/primitives/primitiveProcessExampleAfter_.st A GT-Inspector.package/GTExampleEvaluator.class/instance/primitives/primitiveProcessExample_withArguments_.st M GT-Inspector.package/GTExampleEvaluator.class/instance/private/process_withArguments_.st M GT-Inspector.package/GTExampleEvaluator.class/instance/public/result.st M GT-Inspector.package/GTExampleProcessor.class/README.md M GT-Inspector.package/GTExampleProcessor.class/definition.st A GT-Inspector.package/GTExampleProcessor.class/instance/accessing/context.st A GT-Inspector.package/GTExampleProcessor.class/instance/accessing/context_.st M GT-Inspector.package/GTExampleProcessor.class/instance/initializing/initialize.st A GT-Inspector.package/GTExampleProcessor.class/instance/private/withContextDo_.st M GT-Inspector.package/GTExampleProcessor.class/instance/public/value.st A GT-Inspector.package/GTExampleProxy.class/instance/public/method.st M GT-Inspector.package/GTExampleResult.class/README.md M GT-Inspector.package/GTExampleResult.class/definition.st A GT-Inspector.package/GTExampleResult.class/instance/accessing/context.st A GT-Inspector.package/GTExampleResult.class/instance/accessing/context_.st M GT-Inspector.package/GTRawObjectVariablesBrowser.class/instance/private building/stringWithoutInitialCommentFrom_.st A GT-Inspector.package/extension/Object/class/gtExampleContext.st A GT-Inspector.package/extension/Object/instance/gtExampleContext.st A GT-InspectorExtensions-Core.package/extension/SharedQueue/instance/gtInspectorItemsIn_.st M GT-Playground.package/GTPlayground.class/instance/building/codeIn_.st M GT-Spotter.package/GTSpotterStep.class/instance/inspecting/gtInspectorProcessorsIn_.st M GT-Tests-Debugger.package/GTDebuggerSmokeTest.class/instance/accessing/debuggerToTest.st M Glamour-Browsers.package/GLMBrowserClosing.class/definition.st A Glamour-Browsers.package/GLMBrowserClosing.class/instance/accessing/presentation.st A Glamour-Browsers.package/GLMBrowserClosing.class/instance/accessing/presentation_.st R Glamour-Core.package/GLMPresentation.class/instance/accessing/addOpenBrowserAction_.st R Glamour-Core.package/GLMPresentation.class/instance/accessing/addSelectionOpenBrowserAction_.st A Glamour-Core.package/GLMPresentation.class/instance/accessing/window.st M Glamour-Core.package/GLMPresentation.class/instance/events/windowIsClosing.st M Glamour-Morphic-Brick.package/GLMFormBrick.class/instance/brick-structure-converting/asFormValue.st M Glamour-Morphic-Brick.package/GLMPhlowListBrick.class/class/examples/example2.st M Glamour-Presentations.package/GLMTablePresentation.class/instance/private/column_valueFor_.st M Glamour-Tests-Rubric.package/GLMRubricTextMorphicTest.class/instance/private/simulateOnlyOneClickOn_.st M Glamour-Tests-Rubric.package/GLMRubricTextMorphicTest.class/instance/tests/testAcceptKeyCanBeOverriden.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50668.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50669.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50668.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50669.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50669 Moose http://files.pharo.org/image/50/50669.zip

March 30, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50668 Home: https://github.com/pharo-project/pharo-core

March 30, 2016

[pharo-project/pharo-core] e7fa5c: 50668

by GitHub

Branch: refs/heads/5.0 Home: https://github.com/pharo-project/pharo-core Commit: e7fa5ccfe9cd72b3aea14a8012549c8cda35f85d https://github.com/pharo-project/pharo-core/commit/e7fa5ccfe9cd72b3aea14a80… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2016-03-30 (Wed, 30 Mar 2016) Changed paths: M ConfigurationOfRubric.package/ConfigurationOfRubric.class/instance/symbolic versions/stable_.st A ConfigurationOfRubric.package/ConfigurationOfRubric.class/instance/versions/version216_.st R Rubric.package/RubFindReplaceService.class/instance/as yet unclassified/hasActiveDialog.st M Rubric.package/RubFindReplaceService.class/instance/events handling/whenTextAreaGotFocus_.st M Rubric.package/RubFindReplaceService.class/instance/events handling/whenTextAreaLostFocus_.st M Rubric.package/RubFindReplaceService.class/instance/events handling/whenTextAreaSelectionChanged_.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50667.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/script50668.st R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50667.st A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/update50668.st M ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 50668 17909 Update Rubric to 2.16 https://pharo.fogbugz.com/f/cases/17909 http://files.pharo.org/image/50/50668.zip

March 30, 2016

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/50667 Home: https://github.com/pharo-project/pharo-core

March 30, 2016